Page MenuHomePhabricator

[mlir] Default for gpu-binary-annotation option.
ClosedPublic

Authored by csigg on Mar 8 2021, 4:19 AM.

Details

Summary

Provide default for gpuBinaryAnnotation so that we don't need to specify it in tests.

The annotation likely only needs to be target specific if we want to lower to e.g. both CUDA and ROCDL.

Diff Detail

Event Timeline

csigg created this revision.Mar 8 2021, 4:19 AM
csigg requested review of this revision.Mar 8 2021, 4:19 AM
csigg updated this revision to Diff 328973.Mar 8 2021, 4:44 AM

Move option to GpuToLLVMConversionPass (from Base) to remove the duplicate forward declaration of getDefaultGpuBinaryAnnotation().

csigg updated this revision to Diff 329324.Mar 9 2021, 7:01 AM

Remove triple, target and feature options.

herhut accepted this revision.Mar 9 2021, 7:45 AM
This revision is now accepted and ready to land.Mar 9 2021, 7:45 AM
bondhugula accepted this revision.Mar 9 2021, 9:26 AM
bondhugula added a subscriber: bondhugula.

A couple of minor comments.

mlir/include/mlir/Conversion/GPUCommon/GPUCommonPass.h
30

Nit: Triple /// comments please consistent with other places below.

53

It'd be good to document gpuBinaryAnnotation here - that a default annotation is used if an empty string is provided?

Remove triple, target and feature options.

Could you include this in the commit summary please?

csigg retitled this revision from [mlir] Add options to GPUKernelToBlobPass. to [mlir] Default for gpu-binary-annotation option..Mar 9 2021, 11:14 AM
csigg edited the summary of this revision. (Show Details)
csigg updated this revision to Diff 329414.Mar 9 2021, 11:19 AM

Address reviewer comments.

csigg marked 2 inline comments as done.Mar 9 2021, 11:22 AM

Remove triple, target and feature options.

Could you include this in the commit summary please?

I reverted part of a previous version. This change does not remove any options.

This revision was landed with ongoing or failed builds.Mar 9 2021, 12:01 PM
This revision was automatically updated to reflect the committed changes.