Page MenuHomePhabricator

csigg (Christian Sigg)
User

Projects

User does not belong to any projects.

User Details

User Since
Nov 25 2019, 10:10 AM (37 w, 4 d)

Recent Activity

Mon, Aug 10

csigg committed rG2c48e3629cfb: [MLIR] Adding gpu.host_register op and lower it to a runtime call. (authored by csigg).
[MLIR] Adding gpu.host_register op and lower it to a runtime call.
Mon, Aug 10, 1:46 PM
csigg closed D85631: [MLIR] Adding gpu.host_register op and lower it to a runtime call..
Mon, Aug 10, 1:46 PM · Restricted Project
csigg added a comment to D85631: [MLIR] Adding gpu.host_register op and lower it to a runtime call..

Thanks a lot for the review, Stephan.

Mon, Aug 10, 12:40 PM · Restricted Project
csigg updated the diff for D85631: [MLIR] Adding gpu.host_register op and lower it to a runtime call..

Apply reviewer comments.

Mon, Aug 10, 12:39 PM · Restricted Project
csigg updated the diff for D85631: [MLIR] Adding gpu.host_register op and lower it to a runtime call..

Rebase.

Mon, Aug 10, 10:46 AM · Restricted Project
csigg committed rG0d4b7adb8220: [MLIR] Make gpu.launch_func rewrite pattern part of the LLVM lowering pass. (authored by csigg).
[MLIR] Make gpu.launch_func rewrite pattern part of the LLVM lowering pass.
Mon, Aug 10, 10:28 AM
csigg closed D85073: [MLIR] Make gpu.launch_func rewrite pattern part of the LLVM lowering pass..
Mon, Aug 10, 10:28 AM · Restricted Project
csigg updated the diff for D85073: [MLIR] Make gpu.launch_func rewrite pattern part of the LLVM lowering pass..

Add isLLVMType function.

Mon, Aug 10, 8:43 AM · Restricted Project
csigg requested review of D85631: [MLIR] Adding gpu.host_register op and lower it to a runtime call..
Mon, Aug 10, 1:14 AM · Restricted Project

Thu, Aug 6

csigg added inline comments to D85073: [MLIR] Make gpu.launch_func rewrite pattern part of the LLVM lowering pass..
Thu, Aug 6, 11:36 AM · Restricted Project
csigg updated the diff for D85073: [MLIR] Make gpu.launch_func rewrite pattern part of the LLVM lowering pass..

Fix.

Thu, Aug 6, 6:14 AM · Restricted Project
csigg updated the diff for D85073: [MLIR] Make gpu.launch_func rewrite pattern part of the LLVM lowering pass..

Fix.

Thu, Aug 6, 5:30 AM · Restricted Project
csigg updated the diff for D85073: [MLIR] Make gpu.launch_func rewrite pattern part of the LLVM lowering pass..

Fix.

Thu, Aug 6, 4:25 AM · Restricted Project
csigg updated the diff for D85073: [MLIR] Make gpu.launch_func rewrite pattern part of the LLVM lowering pass..

Fix.

Thu, Aug 6, 3:30 AM · Restricted Project
csigg updated the diff for D85073: [MLIR] Make gpu.launch_func rewrite pattern part of the LLVM lowering pass..

Rebase, apply reviewer comments.

Thu, Aug 6, 3:25 AM · Restricted Project
csigg committed rG45676a893612: [MLIR] Change GpuLaunchFuncToGpuRuntimeCallsPass to wrap a RewritePattern with… (authored by csigg).
[MLIR] Change GpuLaunchFuncToGpuRuntimeCallsPass to wrap a RewritePattern with…
Thu, Aug 6, 2:56 AM
csigg closed D84946: [MLIR] Change GpuLaunchFuncToGpuRuntimeCallsPass to wrap a RewritePattern with the same functionality..
Thu, Aug 6, 2:56 AM · Restricted Project
csigg updated the diff for D84946: [MLIR] Change GpuLaunchFuncToGpuRuntimeCallsPass to wrap a RewritePattern with the same functionality..

Rebase.

Thu, Aug 6, 2:45 AM · Restricted Project
csigg updated the diff for D84946: [MLIR] Change GpuLaunchFuncToGpuRuntimeCallsPass to wrap a RewritePattern with the same functionality..

Rebase.

Thu, Aug 6, 2:23 AM · Restricted Project
csigg updated the diff for D84946: [MLIR] Change GpuLaunchFuncToGpuRuntimeCallsPass to wrap a RewritePattern with the same functionality..

Rebase.

Thu, Aug 6, 2:09 AM · Restricted Project

Sat, Aug 1

csigg retitled D85073: [MLIR] Make gpu.launch_func rewrite pattern part of the LLVM lowering pass. from Make gpu.launch_func rewrite pattern part of the LLVM lowering pass. to [MLIR] Make gpu.launch_func rewrite pattern part of the LLVM lowering pass..
Sat, Aug 1, 7:41 AM · Restricted Project
csigg requested review of D85073: [MLIR] Make gpu.launch_func rewrite pattern part of the LLVM lowering pass..
Sat, Aug 1, 7:41 AM · Restricted Project
csigg updated the diff for D84946: [MLIR] Change GpuLaunchFuncToGpuRuntimeCallsPass to wrap a RewritePattern with the same functionality..

Apply reviewer comments.

Sat, Aug 1, 6:08 AM · Restricted Project
csigg added inline comments to D84946: [MLIR] Change GpuLaunchFuncToGpuRuntimeCallsPass to wrap a RewritePattern with the same functionality..
Sat, Aug 1, 12:19 AM · Restricted Project

Fri, Jul 31

csigg added a comment to D84946: [MLIR] Change GpuLaunchFuncToGpuRuntimeCallsPass to wrap a RewritePattern with the same functionality..

Thank you very much Stephan for the review.

Fri, Jul 31, 4:32 AM · Restricted Project

Thu, Jul 30

csigg updated the diff for D84946: [MLIR] Change GpuLaunchFuncToGpuRuntimeCallsPass to wrap a RewritePattern with the same functionality..

Remove unnecessary ArrayRefs<>{}.

Thu, Jul 30, 7:43 AM · Restricted Project
csigg added inline comments to D84946: [MLIR] Change GpuLaunchFuncToGpuRuntimeCallsPass to wrap a RewritePattern with the same functionality..
Thu, Jul 30, 7:34 AM · Restricted Project
csigg retitled D84946: [MLIR] Change GpuLaunchFuncToGpuRuntimeCallsPass to wrap a RewritePattern with the same functionality. from Change GpuLaunchFuncToGpuRuntimeCallsPass to wrap a RewritePattern with the same functionality. to [MLIR] Change GpuLaunchFuncToGpuRuntimeCallsPass to wrap a RewritePattern with the same functionality..
Thu, Jul 30, 7:03 AM · Restricted Project
csigg requested review of D84946: [MLIR] Change GpuLaunchFuncToGpuRuntimeCallsPass to wrap a RewritePattern with the same functionality..
Thu, Jul 30, 7:02 AM · Restricted Project
csigg committed rG13a3d88666e2: [MLIR] Don't pass separate LowerToLLVMOptions when we already pass a… (authored by csigg).
[MLIR] Don't pass separate LowerToLLVMOptions when we already pass a…
Thu, Jul 30, 5:55 AM
csigg closed D84915: [MLIR] Don't pass separate LowerToLLVMOptions when we already pass a LLVMTypeConverter which contains those options already..
Thu, Jul 30, 5:55 AM · Restricted Project
csigg updated the diff for D84915: [MLIR] Don't pass separate LowerToLLVMOptions when we already pass a LLVMTypeConverter which contains those options already..

Rebase from master.

Thu, Jul 30, 4:39 AM · Restricted Project
csigg requested review of D84915: [MLIR] Don't pass separate LowerToLLVMOptions when we already pass a LLVMTypeConverter which contains those options already..
Thu, Jul 30, 1:32 AM · Restricted Project

Tue, Jul 28

csigg committed rGc64c04bbaadb: Clean up cuda-runtime-wrappers API. (authored by csigg).
Clean up cuda-runtime-wrappers API.
Tue, Jul 28, 7:34 AM
csigg closed D84660: Clean up cuda-runtime-wrappers API..
Tue, Jul 28, 7:34 AM · Restricted Project
csigg updated the diff for D84660: Clean up cuda-runtime-wrappers API..

Fix.

Tue, Jul 28, 7:33 AM · Restricted Project

Mon, Jul 27

csigg updated the diff for D84660: Clean up cuda-runtime-wrappers API..

Rebase from master, fix clang-tidy errors.

Mon, Jul 27, 11:38 AM · Restricted Project
csigg updated the diff for D84660: Clean up cuda-runtime-wrappers API..

Fix test.

Mon, Jul 27, 8:17 AM · Restricted Project
csigg updated the diff for D84660: Clean up cuda-runtime-wrappers API..

Merge from master.

Mon, Jul 27, 7:34 AM · Restricted Project
Herald added a project to D84660: Clean up cuda-runtime-wrappers API.: Restricted Project.
Mon, Jul 27, 7:26 AM · Restricted Project
csigg committed rG2dd7a9cc2d05: [MLIR] NFC: Rename mcuMemHostRegister* to mgpuMemHostRegister* to make it… (authored by csigg).
[MLIR] NFC: Rename mcuMemHostRegister* to mgpuMemHostRegister* to make it…
Mon, Jul 27, 6:48 AM
csigg closed D84583: [MLIR] NFC: Rename mcuMemHostRegister* to mgpuMemHostRegister* to make it consistent with the other cuda-runner functions and ROCm..
Mon, Jul 27, 6:48 AM · Restricted Project

Sat, Jul 25

csigg retitled D84583: [MLIR] NFC: Rename mcuMemHostRegister* to mgpuMemHostRegister* to make it consistent with the other cuda-runner functions and ROCm. from Rename mcuMemHostRegister* to mgpuMemHostRegister* to make it consistent with the other cuda-runner functions and ROCm. to [MLIR] NFC: Rename mcuMemHostRegister* to mgpuMemHostRegister* to make it consistent with the other cuda-runner functions and ROCm..
Sat, Jul 25, 5:59 AM · Restricted Project
Herald added a project to D84583: [MLIR] NFC: Rename mcuMemHostRegister* to mgpuMemHostRegister* to make it consistent with the other cuda-runner functions and ROCm.: Restricted Project.
Sat, Jul 25, 5:57 AM · Restricted Project

May 26 2020

csigg committed rG222e0e58a876: [MLIR] Helper class referencing MemRefType to unify runner implementations. (authored by csigg).
[MLIR] Helper class referencing MemRefType to unify runner implementations.
May 26 2020, 7:34 AM
csigg closed D80513: [MLIR] Helper class referencing MemRefType to unify runner implementations..
May 26 2020, 7:34 AM · Restricted Project

May 25 2020

csigg retitled D80513: [MLIR] Helper class referencing MemRefType to unify runner implementations. from Add DynamicMemRefType which can reference one of the statically ranked StridedMemRefType or a UnrankedMemRefType so that runner utils only need to be implemented once. to [MLIR] Helper class referencing MemRefType to unify runner implementations..
May 25 2020, 4:46 AM · Restricted Project
csigg created D80513: [MLIR] Helper class referencing MemRefType to unify runner implementations..
May 25 2020, 3:42 AM · Restricted Project

May 19 2020

csigg committed rG62adfed30a12: Unrank mcuMemHostRegister tensor argument. (authored by csigg).
Unrank mcuMemHostRegister tensor argument.
May 19 2020, 5:23 AM
csigg closed D80118: Unrank mcuMemHostRegister tensor argument..
May 19 2020, 5:22 AM · Restricted Project
csigg added inline comments to D80118: Unrank mcuMemHostRegister tensor argument..
May 19 2020, 5:22 AM · Restricted Project

May 18 2020

csigg added a comment to D80118: Unrank mcuMemHostRegister tensor argument..

The presubmit failure is from clang-tidy:

May 18 2020, 11:57 PM · Restricted Project
csigg created D80118: Unrank mcuMemHostRegister tensor argument..
May 18 2020, 5:20 AM · Restricted Project

May 14 2020

csigg committed rG104e38cf761e: Only run pretty-printer tests for builds with debug-info. (authored by csigg).
Only run pretty-printer tests for builds with debug-info.
May 14 2020, 12:30 AM
csigg closed D79897: Only run pretty-printer tests for builds with debug-info..
May 14 2020, 12:29 AM · Restricted Project

May 13 2020

csigg added inline comments to D72321: Add test for GDB pretty printers..
May 13 2020, 1:03 PM · Restricted Project
csigg retitled D79897: Only run pretty-printer tests for builds with debug-info. from Only run pretty-printer tests for debug builds. to Only run pretty-printer tests for builds with debug-info..
May 13 2020, 1:03 PM · Restricted Project
csigg updated the diff for D79897: Only run pretty-printer tests for builds with debug-info..

Really undo formatting.

May 13 2020, 1:03 PM · Restricted Project
csigg updated the diff for D79897: Only run pretty-printer tests for builds with debug-info..

Undo formatting.

May 13 2020, 1:03 PM · Restricted Project
csigg updated the diff for D79897: Only run pretty-printer tests for builds with debug-info..

Adding 'debug-info' feature config because assert does not necessarily imply debug info.

May 13 2020, 1:03 PM · Restricted Project
csigg created D79897: Only run pretty-printer tests for builds with debug-info..
May 13 2020, 11:57 AM · Restricted Project

Apr 22 2020

csigg retitled D78640: [MLIR][Prototype] async gpu ops from For demonstration/discussion purposes only, not meant to be reviewed/submitted. to [MLIR][Prototype] async gpu ops.
Apr 22 2020, 8:06 AM · Restricted Project
csigg created D78640: [MLIR][Prototype] async gpu ops.
Apr 22 2020, 8:06 AM · Restricted Project

Apr 15 2020

csigg accepted D78207: [MLIR] Allow for multiple gpu modules during translation..
Apr 15 2020, 8:11 AM · Restricted Project

Apr 8 2020

csigg committed rG06ddb7946bb1: [MLIR] Add missing colon after CHECKs. (authored by csigg).
[MLIR] Add missing colon after CHECKs.
Apr 8 2020, 2:40 AM
csigg closed D77709: [MLIR] Add missing colon after CHECKs..
Apr 8 2020, 2:40 AM · Restricted Project
csigg retitled D77709: [MLIR] Add missing colon after CHECKs. from Add missing colon after CHECKs. to [MLIR] Add missing colon after CHECKs..
Apr 8 2020, 2:39 AM · Restricted Project
csigg created D77709: [MLIR] Add missing colon after CHECKs..
Apr 8 2020, 12:29 AM · Restricted Project

Mar 23 2020

csigg committed rGb43ae21e6082: Fix all-reduce int tests by host-registering memrefs. (authored by csigg).
Fix all-reduce int tests by host-registering memrefs.
Mar 23 2020, 3:48 AM
csigg closed D76563: Fix all-reduce int tests by host-registering memrefs. Reduce amount of boiler plate to register host memory..
Mar 23 2020, 3:48 AM · Restricted Project

Mar 22 2020

csigg added inline comments to D76563: Fix all-reduce int tests by host-registering memrefs. Reduce amount of boiler plate to register host memory..
Mar 22 2020, 12:51 PM · Restricted Project
csigg updated the diff for D76563: Fix all-reduce int tests by host-registering memrefs. Reduce amount of boiler plate to register host memory..

Fix variable name (dense_strides > denseStrides)

Mar 22 2020, 12:51 PM · Restricted Project
csigg created D76563: Fix all-reduce int tests by host-registering memrefs. Reduce amount of boiler plate to register host memory..
Mar 22 2020, 2:06 AM · Restricted Project

Mar 14 2020

csigg added a comment to D75811: [CUDA] Choose default architecture based on CUDA installation.

I've gone with the approach of trying the architectures in the most recent non-deprecated order – sm_52, sm_30.

Mar 14 2020, 11:06 PM · Restricted Project
csigg added a comment to D75811: [CUDA] Choose default architecture based on CUDA installation.

I'll be adding a CUDA_ROOT option to CMake that will be passed to clang as --cuda-path.

Mar 14 2020, 11:06 PM · Restricted Project

Mar 11 2020

csigg committed rGfc421d7ca3ec: [MLIR] Remove all-reduce lowering from GPU to NVVM. Use in-dialect lowering… (authored by csigg).
[MLIR] Remove all-reduce lowering from GPU to NVVM. Use in-dialect lowering…
Mar 11 2020, 7:26 AM
csigg committed rGf3ad6eb5d3d0: Change to individual pretty printer classes, remove generic `make_printer`. (authored by csigg).
Change to individual pretty printer classes, remove generic `make_printer`.
Mar 11 2020, 7:26 AM
csigg closed D73794: [MLIR] Remove all-reduce lowering from GPU to NVVM. Use in-dialect lowering instead..
Mar 11 2020, 7:25 AM · Restricted Project
csigg closed D73609: Change to individual pretty printer classes, remove generic `make_printer`..
Mar 11 2020, 7:25 AM · Restricted Project

Mar 10 2020

csigg added a comment to D73609: Change to individual pretty printer classes, remove generic `make_printer`..

Hi David, I finally had time to get back to this and spend a few hours to root cause why some PointerUnions can't be pretty printed.
It was unrelated to std::__u::pair. The issue is that the PointerUnionUIntTraits may be invisible to the current GDB block if it's only been instanced in a different translation unit.
I've added a test case to show the issue.

Mar 10 2020, 4:29 AM · Restricted Project
csigg updated the diff for D73609: Change to individual pretty printer classes, remove generic `make_printer`..

Add test case for PointerUnion that cannot be pretty-printed.

Mar 10 2020, 4:29 AM · Restricted Project

Mar 9 2020

csigg updated the diff for D73794: [MLIR] Remove all-reduce lowering from GPU to NVVM. Use in-dialect lowering instead..

Remove --dump-input-on-failure.

Mar 9 2020, 6:57 AM · Restricted Project
csigg updated the diff for D73794: [MLIR] Remove all-reduce lowering from GPU to NVVM. Use in-dialect lowering instead..

Avoid DCE in tests by returning values from functions.

Mar 9 2020, 6:57 AM · Restricted Project

Mar 7 2020

csigg added a comment to D75766: [MLIR] Add `and`, `or`, `xor`, `min`, `max` too gpu.all_reduce and the nvvm lowering.

Thanks Valentin, the change looks good, with one caveat: the all_reduce lowering in LowerGpuOpsToNVVMOps.cpp is on the chopping block.
Would you mind replicating your changes in mlir/lib/Dialect/GPU/Transforms/AllReduceLowering.cpp as well?
I hope I will get to the clean up next week, it's overdue but I've been busy with other stuff.

Mar 7 2020, 10:16 AM · Restricted Project

Feb 9 2020

csigg added inline comments to D73609: Change to individual pretty printer classes, remove generic `make_printer`..
Feb 9 2020, 11:38 AM · Restricted Project

Feb 7 2020

csigg updated the diff for D73609: Change to individual pretty printer classes, remove generic `make_printer`..

Rebase from master.

Feb 7 2020, 5:18 AM · Restricted Project
csigg committed rG5a21d2bbb982: Rename prettyprinters test to llvm-support. (authored by csigg).
Rename prettyprinters test to llvm-support.
Feb 7 2020, 5:10 AM
csigg closed D73726: Rename prettyprinters test to llvm-support..
Feb 7 2020, 5:09 AM · Restricted Project

Feb 4 2020

csigg added inline comments to D73609: Change to individual pretty printer classes, remove generic `make_printer`..
Feb 4 2020, 1:09 PM · Restricted Project

Feb 3 2020

csigg added a comment to D73546: Add a few GDB pretty printers for MLIR..

@nicolasvasilache, it's currently blocked on D73609 and D73726. Then I will add tests and send it to @dblaikie for review.

Feb 3 2020, 5:13 AM · Restricted Project
csigg retitled D73726: Rename prettyprinters test to llvm-support. from Rename llvm-prettyprinters to visualizer-tests. to Rename prettyprinters test to llvm-support..
Feb 3 2020, 5:03 AM · Restricted Project
csigg updated the diff for D73726: Rename prettyprinters test to llvm-support..

Revert back to llvm-prettyprinters directory.

Feb 3 2020, 5:03 AM · Restricted Project

Jan 31 2020

csigg created D73794: [MLIR] Remove all-reduce lowering from GPU to NVVM. Use in-dialect lowering instead..
Jan 31 2020, 10:45 AM · Restricted Project

Jan 30 2020

csigg added a comment to D73726: Rename prettyprinters test to llvm-support..

Maybe I should just leave the directory as is and only rename the files?

Jan 30 2020, 11:20 PM · Restricted Project
csigg created D73726: Rename prettyprinters test to llvm-support..
Jan 30 2020, 10:30 AM · Restricted Project
csigg updated the diff for D73609: Change to individual pretty printer classes, remove generic `make_printer`..

Rebase from master.

Jan 30 2020, 12:45 AM · Restricted Project
csigg committed rGa03ec58da60c: Add GDB pretty printers for llvm::ilist, llvm::simple_ilist, and llvm… (authored by csigg).
Add GDB pretty printers for llvm::ilist, llvm::simple_ilist, and llvm…
Jan 30 2020, 12:36 AM
csigg closed D72589: Add GDB pretty printers for llvm::ilist, llvm::simple_ilist, and llvm::ilist_node..
Jan 30 2020, 12:36 AM · Restricted Project

Jan 29 2020

csigg created D73609: Change to individual pretty printer classes, remove generic `make_printer`..
Jan 29 2020, 1:01 AM · Restricted Project

Jan 28 2020

csigg added a comment to D72589: Add GDB pretty printers for llvm::ilist, llvm::simple_ilist, and llvm::ilist_node..

Thanks for the details! I'd be /OK/ with this, but it doesn't seem ideal to be printing the next/prev when printing the container? Do you think it's worth/there's any nice way to avoid that significant redundancy/verbosity in the printing & just print the payload?

Jan 28 2020, 11:46 PM · Restricted Project