Page MenuHomePhabricator

csigg (Christian Sigg)
User

Projects

User does not belong to any projects.

User Details

User Since
Nov 25 2019, 10:10 AM (59 w, 5 d)

Recent Activity

Thu, Jan 14

csigg added a comment to D94421: [mlir] Add gpu async integration test..

Just curious, are these tests candidates for mlir/integration_test rather than mlir/test?

Thu, Jan 14, 12:06 PM · Restricted Project

Tue, Jan 12

csigg added a comment to D94399: [mlir] Link mlir_runner_utils statically into cuda/rocm-runtime-wrappers..

I don't really understand how this works, but my guess is that the JITDylib loaded into the ExecutionEngine's module do not share any symbols with the main process.

Tue, Jan 12, 11:56 PM · Restricted Project
csigg abandoned D94540: [mlir] Please ignore, testing stacked changes in Phabricator..
Tue, Jan 12, 11:43 PM · Restricted Project
csigg abandoned D94539: [mlir] Please ignore, testing stacked changes in Phabricator..
Tue, Jan 12, 11:43 PM · Restricted Project
csigg requested review of D94540: [mlir] Please ignore, testing stacked changes in Phabricator..
Tue, Jan 12, 11:47 AM · Restricted Project
csigg requested review of D94539: [mlir] Please ignore, testing stacked changes in Phabricator..
Tue, Jan 12, 11:46 AM · Restricted Project
csigg retitled D94495: [mlir] Set CUDA/ROCm context before creating resources. from Set CUDA/ROCm context before creating resources. to [mlir] Set CUDA/ROCm context before creating resources..
Tue, Jan 12, 10:21 AM · Restricted Project
csigg updated the diff for D94421: [mlir] Add gpu async integration test..

Trying to upload again with D94399 as base.

Tue, Jan 12, 10:18 AM · Restricted Project
csigg requested review of D94495: [mlir] Set CUDA/ROCm context before creating resources..
Tue, Jan 12, 7:11 AM · Restricted Project
csigg committed rGace516fb33d1: Change the LLVM_ATTRIBUTE_DEPRECATED macro to use C++14 attribute. (authored by csigg).
Change the LLVM_ATTRIBUTE_DEPRECATED macro to use C++14 attribute.
Tue, Jan 12, 3:41 AM
csigg closed D94219: Change the LLVM_ATTRIBUTE_DEPRECATED macro to use C++14 attribute..
Tue, Jan 12, 3:41 AM · Restricted Project
csigg updated the summary of D94399: [mlir] Link mlir_runner_utils statically into cuda/rocm-runtime-wrappers..
Tue, Jan 12, 1:48 AM · Restricted Project

Mon, Jan 11

csigg updated the diff for D94421: [mlir] Add gpu async integration test..

Rebase.

Mon, Jan 11, 2:07 PM · Restricted Project
csigg updated the summary of D94399: [mlir] Link mlir_runner_utils statically into cuda/rocm-runtime-wrappers..
Mon, Jan 11, 12:24 PM · Restricted Project
csigg accepted D94431: Avoid fragile type lookups in GDB pretty printer.

Yes, that does look safer.

Mon, Jan 11, 12:09 PM · Restricted Project
csigg committed rG195728c75aa4: [mlir] Add structural conversion to async dialect lowering. (authored by csigg).
[mlir] Add structural conversion to async dialect lowering.
Mon, Jan 11, 11:37 AM
csigg closed D94404: [mlir] Add structural conversion to async dialect lowering..
Mon, Jan 11, 11:37 AM · Restricted Project
csigg added inline comments to D94404: [mlir] Add structural conversion to async dialect lowering..
Mon, Jan 11, 11:36 AM · Restricted Project
csigg updated the diff for D94404: [mlir] Add structural conversion to async dialect lowering..

Remove commented code left-over.

Mon, Jan 11, 11:35 AM · Restricted Project
csigg requested review of D94421: [mlir] Add gpu async integration test..
Mon, Jan 11, 8:18 AM · Restricted Project
csigg committed rGd59ddba77725: [mlir] Fix gpu-to-llvm lowering for gpu.alloc with dynamic sizes. (authored by csigg).
[mlir] Fix gpu-to-llvm lowering for gpu.alloc with dynamic sizes.
Mon, Jan 11, 6:56 AM
csigg closed D94402: [mlir] Fix gpu-to-llvm lowering for gpu.alloc with dynamic sizes..
Mon, Jan 11, 6:56 AM · Restricted Project
csigg updated the diff for D94402: [mlir] Fix gpu-to-llvm lowering for gpu.alloc with dynamic sizes..

Fix SPIRV lowering.

Mon, Jan 11, 5:46 AM · Restricted Project
csigg committed rG4c372a35cd89: [mlir] Make GpuAsyncRegion pass depend on async dialect. (authored by csigg).
[mlir] Make GpuAsyncRegion pass depend on async dialect.
Mon, Jan 11, 5:43 AM
csigg closed D94397: [mlir] Make GpuAsyncRegion pass depend on async dialect..
Mon, Jan 11, 5:43 AM · Restricted Project
csigg committed rG4fe7b16ae3f4: [mlir] Remove unnecessary llvm.mlir.cast in AsyncToLLVM lowering. (authored by csigg).
[mlir] Remove unnecessary llvm.mlir.cast in AsyncToLLVM lowering.
Mon, Jan 11, 5:41 AM
csigg closed D94400: [mlir] Remove unnecessary llvm.mlir.cast in AsyncToLLVM lowering..
Mon, Jan 11, 5:41 AM · Restricted Project
csigg added a reviewer for D94404: [mlir] Add structural conversion to async dialect lowering.: ezhulenev.
Mon, Jan 11, 5:14 AM · Restricted Project
csigg requested review of D94404: [mlir] Add structural conversion to async dialect lowering..
Mon, Jan 11, 5:13 AM · Restricted Project
csigg updated the diff for D94397: [mlir] Make GpuAsyncRegion pass depend on async dialect..

Fix.

Mon, Jan 11, 4:56 AM · Restricted Project
csigg retitled D94397: [mlir] Make GpuAsyncRegion pass depend on async dialect. from Make GpuAsyncRegion pass depend on async dialect. to [mlir] Make GpuAsyncRegion pass depend on async dialect..
Mon, Jan 11, 4:55 AM · Restricted Project
csigg retitled D94399: [mlir] Link mlir_runner_utils statically into cuda/rocm-runtime-wrappers. from Link mlir_runner_utils statically into cuda/rocm-runtime-wrappers. to [mlir] Link mlir_runner_utils statically into cuda/rocm-runtime-wrappers..
Mon, Jan 11, 4:54 AM · Restricted Project
csigg added a comment to D94400: [mlir] Remove unnecessary llvm.mlir.cast in AsyncToLLVM lowering..

Is it always unnecessary or is there a possibility that it still might be (e.g., async pointer)?

Mon, Jan 11, 4:53 AM · Restricted Project
csigg retitled D94400: [mlir] Remove unnecessary llvm.mlir.cast in AsyncToLLVM lowering. from Remove unnecessary llvm.mlir.cast in AsyncToLLVM lowering. to [mlir] Remove unnecessary llvm.mlir.cast in AsyncToLLVM lowering..
Mon, Jan 11, 4:44 AM · Restricted Project
csigg requested review of D94402: [mlir] Fix gpu-to-llvm lowering for gpu.alloc with dynamic sizes..
Mon, Jan 11, 4:43 AM · Restricted Project
csigg requested review of D94400: [mlir] Remove unnecessary llvm.mlir.cast in AsyncToLLVM lowering..
Mon, Jan 11, 4:25 AM · Restricted Project
csigg requested review of D94399: [mlir] Link mlir_runner_utils statically into cuda/rocm-runtime-wrappers..
Mon, Jan 11, 4:04 AM · Restricted Project
csigg requested review of D94397: [mlir] Make GpuAsyncRegion pass depend on async dialect..
Mon, Jan 11, 3:20 AM · Restricted Project

Fri, Jan 8

csigg updated the summary of D94219: Change the LLVM_ATTRIBUTE_DEPRECATED macro to use C++14 attribute..
Fri, Jan 8, 2:47 AM · Restricted Project
csigg updated the summary of D94219: Change the LLVM_ATTRIBUTE_DEPRECATED macro to use C++14 attribute..
Fri, Jan 8, 2:47 AM · Restricted Project
csigg committed rG2fe625e9abd0: Fix two pessimizing moves. (authored by csigg).
Fix two pessimizing moves.
Fri, Jan 8, 2:45 AM
csigg closed D94218: Fix two pessimizing moves..
Fri, Jan 8, 2:44 AM · Restricted Project, Restricted Project

Thu, Jan 7

csigg added a reviewer for D94219: Change the LLVM_ATTRIBUTE_DEPRECATED macro to use C++14 attribute.: rriddle.
Thu, Jan 7, 1:01 AM · Restricted Project
csigg added a reviewer for D94218: Fix two pessimizing moves.: rriddle.
Thu, Jan 7, 1:00 AM · Restricted Project, Restricted Project
csigg requested review of D94219: Change the LLVM_ATTRIBUTE_DEPRECATED macro to use C++14 attribute..
Thu, Jan 7, 12:59 AM · Restricted Project
csigg requested review of D94218: Fix two pessimizing moves..
Thu, Jan 7, 12:41 AM · Restricted Project, Restricted Project
csigg committed rGc3529a5b0806: [mlir] Mark methods from mlir::OpState that just forward to mlir::Operation as… (authored by csigg).
[mlir] Mark methods from mlir::OpState that just forward to mlir::Operation as…
Thu, Jan 7, 12:09 AM
csigg closed D94191: [mlir] Mark methods from mlir::OpState that just forward to mlir::Operation as deprecated..
Thu, Jan 7, 12:08 AM · Restricted Project

Wed, Jan 6

csigg updated the diff for D94191: [mlir] Mark methods from mlir::OpState that just forward to mlir::Operation as deprecated..

Separate definition because gcc 10 doesn't allow attributes on function definition.

Wed, Jan 6, 10:56 PM · Restricted Project
csigg added a comment to D94191: [mlir] Mark methods from mlir::OpState that just forward to mlir::Operation as deprecated..

Hmm, I need to separate the definition for this to work. Will do so tomorrow, it's getting late.

Wed, Jan 6, 1:28 PM · Restricted Project
csigg updated the diff for D94191: [mlir] Mark methods from mlir::OpState that just forward to mlir::Operation as deprecated..

Use LLVM_ATTRIBUTE_DEPRECATED.

Wed, Jan 6, 1:23 PM · Restricted Project
csigg requested review of D94191: [mlir] Mark methods from mlir::OpState that just forward to mlir::Operation as deprecated..
Wed, Jan 6, 1:02 PM · Restricted Project
csigg committed rGbadc7606b0f6: [mlir] Remove a number of methods from mlir::OpState that just forward to mlir… (authored by csigg).
[mlir] Remove a number of methods from mlir::OpState that just forward to mlir…
Wed, Jan 6, 12:39 PM

Wed, Dec 23

csigg committed rG19a0d0a40ce9: [mlir] Rename ConvertToLLVMPattern::isSupportedMemRefType() to… (authored by csigg).
[mlir] Rename ConvertToLLVMPattern::isSupportedMemRefType() to…
Wed, Dec 23, 3:24 AM
csigg closed D93752: [mlir] Rename ConvertToLLVMPattern::isSupportedMemRefType() to isConvertibleAndHasIdentityMaps()..
Wed, Dec 23, 3:23 AM · Restricted Project
csigg updated the diff for D93752: [mlir] Rename ConvertToLLVMPattern::isSupportedMemRefType() to isConvertibleAndHasIdentityMaps()..

Rebase, update comment.

Wed, Dec 23, 2:42 AM · Restricted Project
csigg committed rG8451d4872ed7: [mlir] NFC: Remove ConvertToLLVMPattern::getDataPtr(). All call sites use… (authored by csigg).
[mlir] NFC: Remove ConvertToLLVMPattern::getDataPtr(). All call sites use…
Wed, Dec 23, 2:35 AM
csigg closed D93751: [mlir] NFC: Remove ConvertToLLVMPattern::getDataPtr(). All call sites use getStridedElementPtr() now..
Wed, Dec 23, 2:35 AM · Restricted Project
csigg requested review of D93752: [mlir] Rename ConvertToLLVMPattern::isSupportedMemRefType() to isConvertibleAndHasIdentityMaps()..
Wed, Dec 23, 2:21 AM · Restricted Project
csigg requested review of D93751: [mlir] NFC: Remove ConvertToLLVMPattern::getDataPtr(). All call sites use getStridedElementPtr() now..
Wed, Dec 23, 2:07 AM · Restricted Project

Tue, Dec 22

csigg committed rGdf6cbd37f57f: [mlir] Lower gpu.memcpy to GPU runtime calls. (authored by csigg).
[mlir] Lower gpu.memcpy to GPU runtime calls.
Tue, Dec 22, 1:49 PM
csigg closed D93204: [mlir] Lower gpu.memcpy to GPU runtime calls..
Tue, Dec 22, 1:49 PM · Restricted Project
csigg updated the diff for D93204: [mlir] Lower gpu.memcpy to GPU runtime calls..

Rebase.

Tue, Dec 22, 11:46 AM · Restricted Project
csigg added inline comments to D93204: [mlir] Lower gpu.memcpy to GPU runtime calls..
Tue, Dec 22, 8:44 AM · Restricted Project
csigg updated the diff for D93204: [mlir] Lower gpu.memcpy to GPU runtime calls..

Add comment.

Tue, Dec 22, 8:43 AM · Restricted Project
csigg committed rG0955d8df0635: [mlir] Add gpu.memcpy op. (authored by csigg).
[mlir] Add gpu.memcpy op.
Tue, Dec 22, 8:40 AM
csigg closed D93197: [mlir] Add gpu.memcpy op..
Tue, Dec 22, 8:40 AM · Restricted Project
csigg updated the diff for D93197: [mlir] Add gpu.memcpy op..

Remove space.

Tue, Dec 22, 8:39 AM · Restricted Project

Mon, Dec 21

csigg added inline comments to D93204: [mlir] Lower gpu.memcpy to GPU runtime calls..
Mon, Dec 21, 11:11 PM · Restricted Project
csigg added inline comments to D93197: [mlir] Add gpu.memcpy op..
Mon, Dec 21, 12:31 PM · Restricted Project
csigg updated the diff for D93197: [mlir] Add gpu.memcpy op..

Change assembly syntax.
Improve verifier.

Mon, Dec 21, 12:29 PM · Restricted Project
csigg accepted D93598: [mlir] Async: add support for lowering async value operands to LLVM.
Mon, Dec 21, 1:36 AM · Restricted Project
csigg accepted D93592: [mlir] Async: lowering async.value to LLVM.
Mon, Dec 21, 1:34 AM · Restricted Project

Dec 17 2020

csigg abandoned D93484: Fix DDGPrinter build on MSVC..

Already fixed at HEAD.

Dec 17 2020, 12:18 PM · Restricted Project
csigg requested review of D93484: Fix DDGPrinter build on MSVC..
Dec 17 2020, 12:17 PM · Restricted Project
csigg added a comment to D93480: Fix NDEBUG build after https://reviews.llvm.org/D93005..

Feel free to push build fixes without going through review: getting the build green is the priority :)

Dec 17 2020, 11:48 AM · Restricted Project
csigg committed rG58f2b765ebec: Fix NDEBUG build after https://reviews.llvm.org/D93005. (authored by csigg).
Fix NDEBUG build after https://reviews.llvm.org/D93005.
Dec 17 2020, 11:38 AM
csigg closed D93480: Fix NDEBUG build after https://reviews.llvm.org/D93005..
Dec 17 2020, 11:38 AM · Restricted Project
csigg requested review of D93480: Fix NDEBUG build after https://reviews.llvm.org/D93005..
Dec 17 2020, 11:35 AM · Restricted Project

Dec 16 2020

csigg committed rGa79b26db0e96: [mlir] Fix for gpu-async-region pass. (authored by csigg).
[mlir] Fix for gpu-async-region pass.
Dec 16 2020, 10:08 AM
csigg closed D93156: [mlir] Fix for gpu-async-region pass..
Dec 16 2020, 10:08 AM · Restricted Project
csigg updated the diff for D93156: [mlir] Fix for gpu-async-region pass..

Trigger pre-merge checks.

Dec 16 2020, 12:08 AM · Restricted Project

Dec 15 2020

csigg updated the diff for D93156: [mlir] Fix for gpu-async-region pass..

Rebase.

Dec 15 2020, 10:21 PM · Restricted Project
csigg updated the diff for D93156: [mlir] Fix for gpu-async-region pass..

Rebase.

Dec 15 2020, 12:53 PM · Restricted Project
csigg updated the diff for D93156: [mlir] Fix for gpu-async-region pass..

Add test.

Dec 15 2020, 12:15 PM · Restricted Project

Dec 14 2020

csigg added a reverting change for rG6f271e921ba4: [mlir] Remove methods from mlir::OpState that just forward to mlir::Operation.: rG0cf7e4b252fe: Revert "[mlir] Remove methods from mlir::OpState that just forward to mlir….
Dec 14 2020, 1:47 PM
csigg committed rG0cf7e4b252fe: Revert "[mlir] Remove methods from mlir::OpState that just forward to mlir… (authored by csigg).
Revert "[mlir] Remove methods from mlir::OpState that just forward to mlir…
Dec 14 2020, 1:47 PM
csigg added a reverting change for D93176: [mlir] Remove methods from mlir::OpState that just forward to mlir::Operation.: rG0cf7e4b252fe: Revert "[mlir] Remove methods from mlir::OpState that just forward to mlir….
Dec 14 2020, 1:47 PM · Restricted Project
csigg closed D93242: Revert "[mlir] Remove methods from mlir::OpState that just forward to mlir::Operation.".
Dec 14 2020, 1:47 PM · Restricted Project
csigg added a reverting change for rG6f271e921ba4: [mlir] Remove methods from mlir::OpState that just forward to mlir::Operation.: D93242: Revert "[mlir] Remove methods from mlir::OpState that just forward to mlir::Operation.".
Dec 14 2020, 1:46 PM
csigg requested review of D93242: Revert "[mlir] Remove methods from mlir::OpState that just forward to mlir::Operation.".
Dec 14 2020, 1:46 PM · Restricted Project
csigg added a reverting change for D93176: [mlir] Remove methods from mlir::OpState that just forward to mlir::Operation.: D93242: Revert "[mlir] Remove methods from mlir::OpState that just forward to mlir::Operation.".
Dec 14 2020, 1:46 PM · Restricted Project
csigg committed rG6f271e921ba4: [mlir] Remove methods from mlir::OpState that just forward to mlir::Operation. (authored by csigg).
[mlir] Remove methods from mlir::OpState that just forward to mlir::Operation.
Dec 14 2020, 12:26 PM
csigg closed D93176: [mlir] Remove methods from mlir::OpState that just forward to mlir::Operation..
Dec 14 2020, 12:26 PM · Restricted Project
csigg updated the diff for D93176: [mlir] Remove methods from mlir::OpState that just forward to mlir::Operation..

Rebase.

Dec 14 2020, 11:30 AM · Restricted Project
csigg committed rGa1eb154421a0: [flang] Use mlir::OpState::operator->() to get to methods of mlir::Operation. (authored by csigg).
[flang] Use mlir::OpState::operator->() to get to methods of mlir::Operation.
Dec 14 2020, 11:05 AM
csigg closed D93194: [flang] Use mlir::OpState::operator->() to get to methods of mlir::Operation..
Dec 14 2020, 11:05 AM · Restricted Project
csigg updated the diff for D93156: [mlir] Fix for gpu-async-region pass..

Thanks for the review!

Dec 14 2020, 5:56 AM · Restricted Project
csigg added a comment to D93156: [mlir] Fix for gpu-async-region pass..

There should be some test that captures this.

Dec 14 2020, 5:55 AM · Restricted Project
csigg requested review of D93204: [mlir] Lower gpu.memcpy to GPU runtime calls..
Dec 14 2020, 4:12 AM · Restricted Project