[analyzer][CTU][NFC] Add an extra regression test

[steakhal]

Summary

Before bc713f6a004723d1325bc16e1efc32d0ac82f939 landed, the analyzer crashed on this reduced example.
It seems important to have bot ctu and -analyzer-opt-analyze-headers enabled in the example.

This test file ensures that no regression happens in the future in this regard.

[steakhal]

ping

[NoQ]

-analyzer-opt-analyze-headers

I'm actually shocked that we provide such option at all. And that it's the first option in the list in scan-build --help. And that I haven't noticed it until now despite that. How did you discover the crash? Are people actually using it?

The test is obviously nice to have.

[steakhal]

In D96586#2601856, @NoQ wrote:

-analyzer-opt-analyze-headers

I'm actually shocked that we provide such option at all. And that it's the first option in the list in scan-build --help. And that I haven't noticed it until now despite that.

I didn't know about this option either xD

How did you discover the crash? Are people actually using it?

If I remember correctly, one of our test runs, analyzing the clang's source code with shallow and deep CTU configuration crashed.
The CodeChecker was driving the analysis, but if a configuration can crash the analyzer that is a problem for sure.
We always provide this flag here.

Luckily, Richard's commit fixed this without any direct intent :D That is why I want to pin this via this regression test.

The funny thing is that no headers are involved, yet the crash depends on the -analyzer-opt-analyze-headers flag.

"Force the static analyzer to analyze functions defined in header files"

I'm not sure how can this flag influence that, as no header files are involved in this reproducer.
I didn't feel like the time not worth investigating this more thoroughly.

[martong]

Thanks for the test!

[thakis]

The test doesn't pass: http://45.33.8.238/linux/41341/step_7.txt

I think you just need to say rm -rf instead of rm -r on line 3 (?)

[steakhal]

In D96586#2616292, @thakis wrote:

The test doesn't pass: http://45.33.8.238/linux/41341/step_7.txt

I think you just need to say rm -rf instead of rm -r on line 3 (?)

I hope a94ac467c2974d9afe68f3fe6cff27bd19bcfad0 fixes this.
Thanks for the heads up.

Uh, I missed mentioning this revision in the commit message. I hope it's not gonna bite back :|

clang/test/Analysis/Inputs/ctu-inherited-default-ctor-other.cpp

+namespace llvm {
+template <int, typename...>
+class impl;
+// basecase
+template <int n>
+class impl<n> {};
+// recursion
+template <int n, typename T, typename... TS>
+class impl<n, T, TS...> : impl<n + 1, TS...> {
+  using child = impl<n + 1, TS...>;
+  using child::child; // no-crash
+  impl(T);
+};
+template <typename... TS>
+class container : impl<0, TS...> {};
+} // namespace llvm
+namespace clang {
+class fun {
+  llvm::container<int, float> k;
+  fun() {}
+};
+class DeclContextLookupResult {
+  static int *const SingleElementDummyList;
+};
+} // namespace clang
+using namespace clang;
+int *const DeclContextLookupResult::SingleElementDummyList = nullptr;

clang/test/Analysis/ctu-inherited-default-ctor.cpp

+// Should not crash with '-analyzer-opt-analyze-headers' option during CTU analysis.
+//
+// RUN: rm -r %t && mkdir -p %t/ctudir
+// RUN: %clang_cc1 -std=c++14 -triple x86_64-pc-linux-gnu \
+// RUN:   -emit-pch -o %t/ctudir/ctu-inherited-default-ctor-other.cpp.ast \
+// RUN:    %S/Inputs/ctu-inherited-default-ctor-other.cpp
+// RUN: echo "c:@N@clang@S@DeclContextLookupResult@SingleElementDummyList ctu-inherited-default-ctor-other.cpp.ast" \
+// RUN:   > %t/ctudir/externalDefMap.txt
+//
+// RUN: %clang_analyze_cc1 -std=c++14 -triple x86_64-pc-linux-gnu \
+// RUN:   -analyzer-opt-analyze-headers \
+// RUN:   -analyzer-checker=core \
+// RUN:   -analyzer-config experimental-enable-naive-ctu-analysis=true \
+// RUN:   -analyzer-config ctu-dir=%t/ctudir \
+// RUN:   -analyzer-config display-ctu-progress=true \
+// RUN:   -verify %s 2>&1 | FileCheck %s
+//
+// expected-no-diagnostics
+//
+// CHECK: CTU loaded AST file: ctu-inherited-default-ctor-other.cpp.ast
+
+namespace clang {}
+namespace llvm {}
+namespace clang {
+class DeclContextLookupResult {
+  static int *const SingleElementDummyList;
+};
+} // namespace clang