Page MenuHomePhabricator
Differential D95000

[mlir:async] Use ODS to define async types
ClosedPublic
Actions

Authored by ezhulenev on Jan 19 2021, 1:38 PM.

Details

Reviewers
ftynse
rriddle
Commits
rG2f7baffdc134: [mlir:async] Use ODS to define async types
Summary

Depends On D94923

Migrate Async dialect to ODS TypeDef

Diff Detail

Event Timeline

ezhulenev created this revision.Jan 19 2021, 1:38 PM
Herald added subscribers: teijeong, rdzhabarov, tatianashp and 14 others. · View Herald TranscriptJan 19 2021, 1:38 PM
ezhulenev requested review of this revision.Jan 19 2021, 1:38 PM
Herald added a project: Restricted Project. · View Herald TranscriptJan 19 2021, 1:38 PM
Herald added subscribers: stephenneuendorffer, nicolasvasilache. · View Herald Transcript
ezhulenev retitled this revision from [mlir:async] Use tablegen to define async types to [mlir:async] Use ODS to define async types.Jan 19 2021, 1:39 PM
ezhulenev edited the summary of this revision. (Show Details)
ezhulenev added a reviewer: ftynse.
rriddle accepted this revision.Jan 19 2021, 1:42 PM
rriddle added inline comments.
mlir/lib/Dialect/Async/IR/Async.cpp
21–22

Remove commented out code.

This revision is now accepted and ready to land.Jan 19 2021, 1:42 PM
rriddle added a comment.Jan 19 2021, 1:42 PM

Nice cleanup!

ezhulenev updated this revision to Diff 317681.Jan 19 2021, 1:43 PM

Omit empty ins and outs

ezhulenev mentioned this in D94923: [mlir:Async] Add intermediate async.coro and async.runtime operations to simplify Async to LLVM lowering.Jan 19 2021, 1:43 PM
rriddle added inline comments.Jan 19 2021, 1:44 PM
mlir/lib/Dialect/Async/IR/Async.cpp
21–22

You should be able to generate most of the parser/printer as well if you set the mnemonic on the TypeDef.

Harbormaster completed remote builds in B85767: Diff 317676.Jan 19 2021, 1:44 PM
Harbormaster completed remote builds in B85770: Diff 317681.Jan 19 2021, 3:06 PM
ezhulenev updated this revision to Diff 317721.Jan 19 2021, 4:06 PM
ezhulenev marked 2 inline comments as done.

Use ODS generated parser and printer

Harbormaster completed remote builds in B85791: Diff 317721.Jan 19 2021, 5:33 PM
ftynse accepted this revision.Jan 20 2021, 2:15 AM

nice!

ezhulenev added a child revision: D95311: [mlir] Async: add a separate pass to lower from async to async.coro and async.runtime.Jan 24 2021, 9:41 AM
Closed by commit rG2f7baffdc134: [mlir:async] Use ODS to define async types (authored by ezhulenev). · Explain WhyJan 26 2021, 2:38 AM
This revision was automatically updated to reflect the committed changes.
ezhulenev added a commit: rG2f7baffdc134: [mlir:async] Use ODS to define async types.

Revision Contents
Changeset List

PathSize
mlir/
include/
mlir/
Dialect/
Async/
IR/
67 lines
33 lines
9 lines
25 lines
AsyncTypes.td
AsyncBase.td
81 lines
lib/
Dialect/
Async/
IR/
134 lines
test/
Dialect/
Async/
2 lines

Diff 319253

View Options

mlir/include/mlir/Dialect/Async/IR/Async.h

Loading...
View Options

mlir/include/mlir/Dialect/Async/IR/AsyncBase.td

Loading...
View Options

mlir/include/mlir/Dialect/Async/IR/AsyncDialect.td

Loading...
View Options

mlir/include/mlir/Dialect/Async/IR/AsyncOps.td

Loading...
View Options

mlir/include/mlir/Dialect/Async/IR/AsyncTypes.h

Loading...
View Options

mlir/include/mlir/Dialect/Async/IR/AsyncTypes.td

Loading...
View Options

mlir/lib/Dialect/Async/IR/Async.cpp

Loading...
View Options

mlir/test/Dialect/Async/verify.mlir

Loading...