Page MenuHomePhabricator

[mlir:async] Use ODS to define async types
ClosedPublic

Authored by ezhulenev on Jan 19 2021, 1:38 PM.

Details

Summary

Depends On D94923

Migrate Async dialect to ODS TypeDef

Diff Detail

Event Timeline

ezhulenev created this revision.Jan 19 2021, 1:38 PM
ezhulenev requested review of this revision.Jan 19 2021, 1:38 PM
ezhulenev retitled this revision from [mlir:async] Use tablegen to define async types to [mlir:async] Use ODS to define async types.Jan 19 2021, 1:39 PM
ezhulenev edited the summary of this revision. (Show Details)
ezhulenev added a reviewer: ftynse.
rriddle accepted this revision.Jan 19 2021, 1:42 PM
rriddle added inline comments.
mlir/lib/Dialect/Async/IR/Async.cpp
21–22

Remove commented out code.

This revision is now accepted and ready to land.Jan 19 2021, 1:42 PM

Nice cleanup!

ezhulenev updated this revision to Diff 317681.Jan 19 2021, 1:43 PM

Omit empty ins and outs

rriddle added inline comments.Jan 19 2021, 1:44 PM
mlir/lib/Dialect/Async/IR/Async.cpp
21–22

You should be able to generate most of the parser/printer as well if you set the mnemonic on the TypeDef.

ezhulenev updated this revision to Diff 317721.Jan 19 2021, 4:06 PM
ezhulenev marked 2 inline comments as done.

Use ODS generated parser and printer

ftynse accepted this revision.Jan 20 2021, 2:15 AM

nice!

This revision was automatically updated to reflect the committed changes.