Page MenuHomePhabricator

ezhulenev (Eugene Zhulenev)
User

Projects

User does not belong to any projects.

User Details

User Since
Mar 6 2020, 7:42 PM (45 w, 6 d)

Recent Activity

Yesterday

ezhulenev updated the diff for D95143: [mlir] Add coro intrinsics operations to LLVM dialect.

remove dump input

Thu, Jan 21, 8:58 AM · Restricted Project
ezhulenev updated the summary of D95143: [mlir] Add coro intrinsics operations to LLVM dialect.
Thu, Jan 21, 8:57 AM · Restricted Project
ezhulenev requested review of D95143: [mlir] Add coro intrinsics operations to LLVM dialect.
Thu, Jan 21, 8:56 AM · Restricted Project

Wed, Jan 20

ezhulenev committed rGa2223b09b10a: [mlir:async] Fix data races in AsyncRuntime (authored by ezhulenev).
[mlir:async] Fix data races in AsyncRuntime
Wed, Jan 20, 1:24 PM
ezhulenev closed D95037: [mlir:async] Fix data races in AsyncRuntime.
Wed, Jan 20, 1:23 PM · Restricted Project
ezhulenev updated the summary of D95037: [mlir:async] Fix data races in AsyncRuntime.
Wed, Jan 20, 5:22 AM · Restricted Project
ezhulenev requested review of D95037: [mlir:async] Fix data races in AsyncRuntime.
Wed, Jan 20, 5:17 AM · Restricted Project

Tue, Jan 19

ezhulenev updated the diff for D95000: [mlir:async] Use ODS to define async types.

Use ODS generated parser and printer

Tue, Jan 19, 4:06 PM · Restricted Project
ezhulenev added a comment to D94923: [mlir:Async] Add intermediate async.coro and async.runtime operations to simplify Async to LLVM lowering.

Will do LLVM intrinsics in a separate change, this one is already pretty large.

Tue, Jan 19, 1:44 PM · Restricted Project
ezhulenev added inline comments to D94923: [mlir:Async] Add intermediate async.coro and async.runtime operations to simplify Async to LLVM lowering.
Tue, Jan 19, 1:43 PM · Restricted Project
ezhulenev updated the diff for D95000: [mlir:async] Use ODS to define async types.

Omit empty ins and outs

Tue, Jan 19, 1:43 PM · Restricted Project
ezhulenev updated the diff for D94923: [mlir:Async] Add intermediate async.coro and async.runtime operations to simplify Async to LLVM lowering.

Omit empty ins and outs

Tue, Jan 19, 1:43 PM · Restricted Project
ezhulenev retitled D95000: [mlir:async] Use ODS to define async types from [mlir:async] Use tablegen to define async types to [mlir:async] Use ODS to define async types.
Tue, Jan 19, 1:39 PM · Restricted Project
ezhulenev requested review of D95000: [mlir:async] Use ODS to define async types.
Tue, Jan 19, 1:38 PM · Restricted Project
ezhulenev added a comment to D94923: [mlir:Async] Add intermediate async.coro and async.runtime operations to simplify Async to LLVM lowering.

Do you have code pointers to intrinsic op definitions in the LLVM dialect? I like this idea, however I still would keep 2 levels of IR lowering, async specific async.coro (that omit a lot of irrelevant coro details) that are lowered to LLVM intrinsic ops.

Tue, Jan 19, 4:39 AM · Restricted Project

Mon, Jan 18

ezhulenev abandoned D83531: [MLIR] Add F32ElementsAttr to OpBase.td.
Mon, Jan 18, 3:03 PM · Restricted Project
ezhulenev abandoned D92022: Revert "[mlir] Temporarily disable flaky mlir-cpu-runner async tests".
Mon, Jan 18, 3:03 PM · Restricted Project
ezhulenev retitled D94923: [mlir:Async] Add intermediate async.coro and async.runtime operations to simplify Async to LLVM lowering from [mlir:Async] Add intermediate async.coro and async.runtime to simplify Async to LLVM lowering to [mlir:Async] Add intermediate async.coro and async.runtime operations to simplify Async to LLVM lowering.
Mon, Jan 18, 11:06 AM · Restricted Project
ezhulenev updated the summary of D94923: [mlir:Async] Add intermediate async.coro and async.runtime operations to simplify Async to LLVM lowering.
Mon, Jan 18, 11:04 AM · Restricted Project
ezhulenev requested review of D94923: [mlir:Async] Add intermediate async.coro and async.runtime operations to simplify Async to LLVM lowering.
Mon, Jan 18, 10:58 AM · Restricted Project

Mon, Jan 11

ezhulenev accepted D94404: [mlir] Add structural conversion to async dialect lowering..
Mon, Jan 11, 8:30 AM · Restricted Project

Sat, Jan 9

ezhulenev committed rGbb0e621387f8: [mlir] AsyncRuntime: use LLVM ThreadPool to run async tasks (authored by ezhulenev).
[mlir] AsyncRuntime: use LLVM ThreadPool to run async tasks
Sat, Jan 9, 2:40 AM
ezhulenev closed D94346: [mlir] AsyncRuntime: use LLVM ThreadPool to run async tasks.
Sat, Jan 9, 2:40 AM · Restricted Project
ezhulenev updated the diff for D94346: [mlir] AsyncRuntime: use LLVM ThreadPool to run async tasks.

Rebased

Sat, Jan 9, 2:09 AM · Restricted Project

Fri, Jan 8

ezhulenev updated the summary of D94346: [mlir] AsyncRuntime: use LLVM ThreadPool to run async tasks.
Fri, Jan 8, 3:24 PM · Restricted Project
ezhulenev requested review of D94346: [mlir] AsyncRuntime: use LLVM ThreadPool to run async tasks.
Fri, Jan 8, 3:24 PM · Restricted Project
ezhulenev committed rG78b3bce23b11: [mlir] AsyncRuntime: disable mlir-runner init/disable for WIN32 (authored by ezhulenev).
[mlir] AsyncRuntime: disable mlir-runner init/disable for WIN32
Fri, Jan 8, 2:03 PM
ezhulenev closed D94339: [mlir] AsyncRuntime: disable mlir-runner init/disable for WIN32.
Fri, Jan 8, 2:03 PM · Restricted Project
ezhulenev requested review of D94339: [mlir] AsyncRuntime: disable mlir-runner init/disable for WIN32.
Fri, Jan 8, 2:02 PM · Restricted Project
ezhulenev committed rG1fc986427ba3: [mlir:JitRunner] Use custom shared library init/destroy functions if available (authored by ezhulenev).
[mlir:JitRunner] Use custom shared library init/destroy functions if available
Fri, Jan 8, 1:16 PM
ezhulenev closed D94312: [mlir:JitRunner] Use custom shared library init/destroy functions if available.
Fri, Jan 8, 1:16 PM · Restricted Project
ezhulenev updated the summary of D94312: [mlir:JitRunner] Use custom shared library init/destroy functions if available.
Fri, Jan 8, 8:57 AM · Restricted Project
ezhulenev updated the summary of D94312: [mlir:JitRunner] Use custom shared library init/destroy functions if available.
Fri, Jan 8, 8:55 AM · Restricted Project
ezhulenev updated the summary of D94312: [mlir:JitRunner] Use custom shared library init/destroy functions if available.
Fri, Jan 8, 8:20 AM · Restricted Project
ezhulenev requested review of D94312: [mlir:JitRunner] Use custom shared library init/destroy functions if available.
Fri, Jan 8, 8:18 AM · Restricted Project
ezhulenev added a reverting change for D94270: [mlir:JitRunner] Use custom shared library init/destroy functions if available: rG740950cf1cda: Revert "[mlir:JitRunner] Use custom shared library init/destroy functions if….
Fri, Jan 8, 7:47 AM · Restricted Project
ezhulenev committed rG740950cf1cda: Revert "[mlir:JitRunner] Use custom shared library init/destroy functions if… (authored by ezhulenev).
Revert "[mlir:JitRunner] Use custom shared library init/destroy functions if…
Fri, Jan 8, 7:47 AM
ezhulenev added a reverting change for rG84dc9b451bfd: [mlir:JitRunner] Use custom shared library init/destroy functions if available: rG740950cf1cda: Revert "[mlir:JitRunner] Use custom shared library init/destroy functions if….
Fri, Jan 8, 7:47 AM
ezhulenev closed D94309: Revert "[mlir:JitRunner] Use custom shared library init/destroy functions if available".
Fri, Jan 8, 7:46 AM · Restricted Project
ezhulenev updated the summary of D94309: Revert "[mlir:JitRunner] Use custom shared library init/destroy functions if available".
Fri, Jan 8, 7:45 AM · Restricted Project
ezhulenev added a reverting change for rG84dc9b451bfd: [mlir:JitRunner] Use custom shared library init/destroy functions if available: D94309: Revert "[mlir:JitRunner] Use custom shared library init/destroy functions if available".
Fri, Jan 8, 7:44 AM
ezhulenev added a reverting change for D94270: [mlir:JitRunner] Use custom shared library init/destroy functions if available: D94309: Revert "[mlir:JitRunner] Use custom shared library init/destroy functions if available".
Fri, Jan 8, 7:44 AM · Restricted Project
ezhulenev requested review of D94309: Revert "[mlir:JitRunner] Use custom shared library init/destroy functions if available".
Fri, Jan 8, 7:44 AM · Restricted Project
ezhulenev committed rG84dc9b451bfd: [mlir:JitRunner] Use custom shared library init/destroy functions if available (authored by ezhulenev).
[mlir:JitRunner] Use custom shared library init/destroy functions if available
Fri, Jan 8, 7:14 AM
ezhulenev closed D94270: [mlir:JitRunner] Use custom shared library init/destroy functions if available.
Fri, Jan 8, 7:14 AM · Restricted Project
ezhulenev added inline comments to D94270: [mlir:JitRunner] Use custom shared library init/destroy functions if available.
Fri, Jan 8, 7:12 AM · Restricted Project
ezhulenev updated the diff for D94270: [mlir:JitRunner] Use custom shared library init/destroy functions if available.

Export only mlir runner API symbols

Fri, Jan 8, 3:14 AM · Restricted Project

Thu, Jan 7

ezhulenev updated the summary of D94270: [mlir:JitRunner] Use custom shared library init/destroy functions if available.
Thu, Jan 7, 3:33 PM · Restricted Project
ezhulenev requested review of D94270: [mlir:JitRunner] Use custom shared library init/destroy functions if available.
Thu, Jan 7, 3:31 PM · Restricted Project
ezhulenev abandoned D94253: [mlir] mlir-cpu-runner: Register shutdown callbacks with the runner.

Yeah, makes sense, also weak linking does not seem to work with MSVC, will try to the dlsym approach.

Thu, Jan 7, 12:53 PM · Restricted Project
ezhulenev updated the diff for D94253: [mlir] mlir-cpu-runner: Register shutdown callbacks with the runner.

Fix CMakeLists

Thu, Jan 7, 12:27 PM · Restricted Project
ezhulenev updated the summary of D94255: [mlir] AsyncRuntime: use LLVM ThreadPool to run async tasks.
Thu, Jan 7, 12:24 PM · Restricted Project
ezhulenev requested review of D94255: [mlir] AsyncRuntime: use LLVM ThreadPool to run async tasks.
Thu, Jan 7, 12:22 PM · Restricted Project
ezhulenev updated the diff for D94253: [mlir] mlir-cpu-runner: Register shutdown callbacks with the runner.

Remove extra space

Thu, Jan 7, 11:58 AM · Restricted Project
ezhulenev updated the summary of D94253: [mlir] mlir-cpu-runner: Register shutdown callbacks with the runner.
Thu, Jan 7, 11:57 AM · Restricted Project
ezhulenev requested review of D94253: [mlir] mlir-cpu-runner: Register shutdown callbacks with the runner.
Thu, Jan 7, 11:56 AM · Restricted Project

Wed, Jan 6

ezhulenev abandoned D93905: [mlir] AsyncRuntime: use LLVM ThreadPool to run async tasks.

Judging by the build failures this still does not work. Will work on a "mlir-cpu-runner dylib unloading" in a separate PR.

Wed, Jan 6, 1:55 AM · Restricted Project

Tue, Dec 29

ezhulenev updated the summary of D93905: [mlir] AsyncRuntime: use LLVM ThreadPool to run async tasks.
Tue, Dec 29, 10:23 AM · Restricted Project
ezhulenev requested review of D93905: [mlir] AsyncRuntime: use LLVM ThreadPool to run async tasks.
Tue, Dec 29, 10:20 AM · Restricted Project
ezhulenev added a comment to D92368: [mlir] AsyncRuntime: disable threading until test flakiness is fixed.

Since it surfaced on our radar again, any updated on the global destructors removal?

Tue, Dec 29, 8:54 AM · Restricted Project

Fri, Dec 25

ezhulenev committed rG61422c8b661c: [mlir] Async: add support for lowering async value operands to LLVM (authored by ezhulenev).
[mlir] Async: add support for lowering async value operands to LLVM
Fri, Dec 25, 2:25 AM
ezhulenev closed D93598: [mlir] Async: add support for lowering async value operands to LLVM.
Fri, Dec 25, 2:25 AM · Restricted Project
ezhulenev committed rG621ad468d99d: [mlir] Async: lowering async.value to LLVM (authored by ezhulenev).
[mlir] Async: lowering async.value to LLVM
Fri, Dec 25, 2:24 AM
ezhulenev closed D93592: [mlir] Async: lowering async.value to LLVM.
Fri, Dec 25, 2:24 AM · Restricted Project
ezhulenev accepted D93808: [mlir] Fix mlir_async_runtime.lib creation for MSVC..
Fri, Dec 25, 2:19 AM · Restricted Project

Thu, Dec 24

ezhulenev updated the diff for D93592: [mlir] Async: lowering async.value to LLVM.

Add missing targets to CMakeLists

Thu, Dec 24, 5:08 AM · Restricted Project
ezhulenev updated the diff for D93598: [mlir] Async: add support for lowering async value operands to LLVM.

Rebase

Thu, Dec 24, 4:22 AM · Restricted Project
ezhulenev updated the diff for D93592: [mlir] Async: lowering async.value to LLVM.

Rebase

Thu, Dec 24, 4:21 AM · Restricted Project

Dec 21 2020

ezhulenev updated the diff for D93598: [mlir] Async: add support for lowering async value operands to LLVM.

Fix style warnings

Dec 21 2020, 2:08 AM · Restricted Project
ezhulenev updated the diff for D93592: [mlir] Async: lowering async.value to LLVM.

Fix style warnings

Dec 21 2020, 2:08 AM · Restricted Project
ezhulenev updated the diff for D93592: [mlir] Async: lowering async.value to LLVM.

Add documentation

Dec 21 2020, 2:06 AM · Restricted Project

Dec 20 2020

ezhulenev updated the summary of D93598: [mlir] Async: add support for lowering async value operands to LLVM.
Dec 20 2020, 8:52 AM · Restricted Project
ezhulenev requested review of D93598: [mlir] Async: add support for lowering async value operands to LLVM.
Dec 20 2020, 8:50 AM · Restricted Project
ezhulenev added a reviewer for D93592: [mlir] Async: lowering async.value to LLVM: csigg.
Dec 20 2020, 3:41 AM · Restricted Project
ezhulenev updated the summary of D93592: [mlir] Async: lowering async.value to LLVM.
Dec 20 2020, 3:41 AM · Restricted Project
ezhulenev requested review of D93592: [mlir] Async: lowering async.value to LLVM.
Dec 20 2020, 3:38 AM · Restricted Project

Dec 16 2020

ezhulenev committed rG900d71a851db: [mlir] Async: re-enable tests after fixing fkakines (authored by ezhulenev).
[mlir] Async: re-enable tests after fixing fkakines
Dec 16 2020, 11:07 AM
ezhulenev closed D93384: [mlir] Async: re-enable tests after fixing fkakines.
Dec 16 2020, 11:07 AM · Restricted Project
ezhulenev committed rG11f1027b4d8d: [mlir] AsyncRuntime: mode runtime declarations to mlir::runtime namespace (authored by ezhulenev).
[mlir] AsyncRuntime: mode runtime declarations to mlir::runtime namespace
Dec 16 2020, 11:05 AM
ezhulenev closed D93391: [mlir] AsyncRuntime: mode runtime declarations to mlir::runtime namespace.
Dec 16 2020, 11:05 AM · Restricted Project
ezhulenev accepted D93405: [mlir] Support index and memref types in llvm.mlir.cast.

Thanks!

Dec 16 2020, 9:58 AM · Restricted Project
ezhulenev updated the diff for D93391: [mlir] AsyncRuntime: mode runtime declarations to mlir::runtime namespace.

Keep extern "C" in API function definition

Dec 16 2020, 5:14 AM · Restricted Project
ezhulenev updated the summary of D93391: [mlir] AsyncRuntime: mode runtime declarations to mlir::runtime namespace.
Dec 16 2020, 4:30 AM · Restricted Project
ezhulenev updated the diff for D93391: [mlir] AsyncRuntime: mode runtime declarations to mlir::runtime namespace.

Rebase

Dec 16 2020, 4:29 AM · Restricted Project
ezhulenev requested review of D93391: [mlir] AsyncRuntime: mode runtime declarations to mlir::runtime namespace.
Dec 16 2020, 4:27 AM · Restricted Project
ezhulenev updated the summary of D93384: [mlir] Async: re-enable tests after fixing fkakines.
Dec 16 2020, 2:19 AM · Restricted Project
ezhulenev requested review of D93384: [mlir] Async: re-enable tests after fixing fkakines.
Dec 16 2020, 2:18 AM · Restricted Project

Dec 14 2020

ezhulenev committed rG0b510e79ce34: [mlir] Fix opaque struct typedef in AsyncRuntime header (authored by ezhulenev).
[mlir] Fix opaque struct typedef in AsyncRuntime header
Dec 14 2020, 3:05 PM
ezhulenev closed D93250: [mlir] Fix opaque struct typedef in AsyncRuntime header.
Dec 14 2020, 3:05 PM · Restricted Project
ezhulenev requested review of D93250: [mlir] Fix opaque struct typedef in AsyncRuntime header.
Dec 14 2020, 2:55 PM · Restricted Project

Dec 8 2020

ezhulenev committed rG94e645f9cce8: [mlir] Async: Add numWorkerThreads argument to createAsyncParallelForPass (authored by ezhulenev).
[mlir] Async: Add numWorkerThreads argument to createAsyncParallelForPass
Dec 8 2020, 10:30 AM
ezhulenev closed D92835: [mlir] Async: Add numWorkerThreads argument to createAsyncParallelForPass.
Dec 8 2020, 10:30 AM · Restricted Project
ezhulenev updated the summary of D92835: [mlir] Async: Add numWorkerThreads argument to createAsyncParallelForPass.
Dec 8 2020, 4:40 AM · Restricted Project
ezhulenev added a reviewer for D92835: [mlir] Async: Add numWorkerThreads argument to createAsyncParallelForPass: mehdi_amini.
Dec 8 2020, 4:36 AM · Restricted Project
ezhulenev requested review of D92835: [mlir] Async: Add numWorkerThreads argument to createAsyncParallelForPass.
Dec 8 2020, 4:35 AM · Restricted Project
ezhulenev accepted D92685: [mlir] Use rewriting infrastructure in AsyncToLLVM.
Dec 8 2020, 2:09 AM · Restricted Project

Dec 4 2020

ezhulenev added inline comments to D92685: [mlir] Use rewriting infrastructure in AsyncToLLVM.
Dec 4 2020, 1:53 PM · Restricted Project
ezhulenev requested changes to D92685: [mlir] Use rewriting infrastructure in AsyncToLLVM.
Dec 4 2020, 1:52 PM · Restricted Project

Dec 1 2020

ezhulenev committed rG9edcedf7f222: [mlir] AsyncRuntime: disable threading until test flakiness is fixed (authored by ezhulenev).
[mlir] AsyncRuntime: disable threading until test flakiness is fixed
Dec 1 2020, 1:12 AM
ezhulenev closed D92368: [mlir] AsyncRuntime: disable threading until test flakiness is fixed.
Dec 1 2020, 1:12 AM · Restricted Project