Page MenuHomePhabricator

[mlir] Add structural conversion to async dialect lowering.
ClosedPublic

Authored by csigg on Jan 11 2021, 5:13 AM.

Details

Summary

Lowering of async dialect uses a fixed type converter and therefore does not support lowering non-standard types.

This revision adds a structural conversion so that non-standard types in !async.values can be lowered to LLVM before lowering the async dialect itself.

Diff Detail

Event Timeline

csigg created this revision.Jan 11 2021, 5:13 AM
csigg requested review of this revision.Jan 11 2021, 5:13 AM
ezhulenev accepted this revision.Jan 11 2021, 8:30 AM
ezhulenev added inline comments.
mlir/lib/Conversion/AsyncToLLVM/AsyncToLLVM.cpp
1167

Not needed?

This revision is now accepted and ready to land.Jan 11 2021, 8:30 AM
csigg updated this revision to Diff 315887.Jan 11 2021, 11:35 AM

Remove commented code left-over.

csigg marked an inline comment as done.Jan 11 2021, 11:36 AM
csigg added inline comments.
mlir/lib/Conversion/AsyncToLLVM/AsyncToLLVM.cpp
1167

Yeah, that's just left-over from experimenting. Removed.

This revision was landed with ongoing or failed builds.Jan 11 2021, 11:37 AM
This revision was automatically updated to reflect the committed changes.
csigg marked an inline comment as done.