This is an archive of the discontinued LLVM Phabricator instance.

[clangd] Add go-to-def metric.
ClosedPublic

Authored by hokein on Jan 8 2021, 12:58 AM.

Details

Summary

to track the number of different "special" go-to-def request.

Diff Detail

Event Timeline

hokein created this revision.Jan 8 2021, 12:58 AM
hokein requested review of this revision.Jan 8 2021, 12:58 AM
Herald added a project: Restricted Project. · View Herald TranscriptJan 8 2021, 12:58 AM
sammccall accepted this revision.Jan 8 2021, 6:23 AM
sammccall added inline comments.
clang-tools-extra/clangd/XRefs.cpp
375

name could be a bit more explicit, particularly I'd confuse it with go-to on the override keyword.

Maybe method-to-override and method-to-base?

407

template-specialization-to-primary?

426

objc-category-to-class?

This revision is now accepted and ready to land.Jan 8 2021, 6:23 AM
hokein updated this revision to Diff 315480.Jan 8 2021, 12:11 PM
hokein marked 3 inline comments as done.

address comments.

This revision was landed with ongoing or failed builds.Jan 8 2021, 12:12 PM
This revision was automatically updated to reflect the committed changes.