Page MenuHomePhabricator

hokein (Haojian Wu)
User

Projects

User does not belong to any projects.

User Details

User Since
Aug 19 2015, 3:38 AM (274 w, 5 d)

Recent Activity

Today

hokein accepted D91951: [clangd] Get rid of clangToolingRefactoring dependency.
Mon, Nov 23, 2:48 AM · Restricted Project
hokein added inline comments to D71880: [clangd] Implement Decl canonicalization rules for rename.
Mon, Nov 23, 2:28 AM · Restricted Project
hokein accepted D71880: [clangd] Implement Decl canonicalization rules for rename.

Thanks, this looks great now.

Mon, Nov 23, 2:27 AM · Restricted Project
hokein abandoned D84970: Adjust all existing tests..
Mon, Nov 23, 2:11 AM · Restricted Project
hokein committed rGb1444edbf41c: [AST] Build recovery expression by default for all language. (authored by hokein).
[AST] Build recovery expression by default for all language.
Mon, Nov 23, 2:09 AM
hokein closed D89046: [AST] Build recovery expression by default for all language..
Mon, Nov 23, 2:08 AM · Restricted Project
hokein accepted D91947: [clangd] testPath's final result agrees with the passed in Style.
Mon, Nov 23, 1:56 AM · Restricted Project
hokein updated the summary of D89046: [AST] Build recovery expression by default for all language..
Mon, Nov 23, 1:51 AM · Restricted Project
hokein updated the diff for D89046: [AST] Build recovery expression by default for all language..

rebase and update

Mon, Nov 23, 1:49 AM · Restricted Project
hokein committed rG66ace4dc0275: [clang-tidy] Fix a nullptr-access crash in unused-raii-check. (authored by hokein).
[clang-tidy] Fix a nullptr-access crash in unused-raii-check.
Mon, Nov 23, 12:44 AM
hokein closed D91614: [clang-tidy] Fix a nullptr-access crash in unused-raii-check..
Mon, Nov 23, 12:44 AM · Restricted Project
hokein accepted D91721: [clangd] textDocument/implementation (LSP layer).

thanks, looks good.

Mon, Nov 23, 12:39 AM · Restricted Project
hokein added a comment to D71880: [clangd] Implement Decl canonicalization rules for rename.

Thanks, this looks nicer now.

Mon, Nov 23, 12:30 AM · Restricted Project

Yesterday

hokein added a comment to D91721: [clangd] textDocument/implementation (LSP layer).

just nits.

Sun, Nov 22, 11:53 PM · Restricted Project

Fri, Nov 20

hokein added a comment to D89046: [AST] Build recovery expression by default for all language..

should be ready to go -- from our internal experiment, we don't see any super crashes.

Fri, Nov 20, 6:49 AM · Restricted Project
hokein updated the diff for D89046: [AST] Build recovery expression by default for all language..

rebase

Fri, Nov 20, 6:46 AM · Restricted Project

Thu, Nov 19

hokein committed rG734d2f98f649: [clangd] No crash on "-verify" mode. (authored by hokein).
[clangd] No crash on "-verify" mode.
Thu, Nov 19, 6:52 AM
hokein closed D91777: [clangd] No crash on "-verify" mode..
Thu, Nov 19, 6:52 AM · Restricted Project
hokein requested review of D91777: [clangd] No crash on "-verify" mode..
Thu, Nov 19, 2:14 AM · Restricted Project

Wed, Nov 18

hokein added inline comments to D71880: [clangd] Implement Decl canonicalization rules for rename.
Wed, Nov 18, 12:39 PM · Restricted Project
hokein accepted D91625: [clang] Do not crash on pointer wchar_t pointer assignment..

Thanks!

Wed, Nov 18, 11:40 AM · Restricted Project
hokein committed rGbd4662cd3f37: [AST] Enhance the const expression evaluator to support error-dependent exprs. (authored by hokein).
[AST] Enhance the const expression evaluator to support error-dependent exprs.
Wed, Nov 18, 6:49 AM
hokein closed D84637: [AST] Enhance the const expression evaluator to support error-dependent exprs..
Wed, Nov 18, 6:48 AM · Restricted Project
hokein accepted D91626: [clangd] Implement textDocument/implementation (Xref layer).

The patch description is a bit stale now.

Wed, Nov 18, 6:35 AM · Restricted Project
hokein committed rGaad3ea8983a8: [clangd] Remove the trailing "." in add-using message. (authored by hokein).
[clangd] Remove the trailing "." in add-using message.
Wed, Nov 18, 5:47 AM
hokein closed D91694: [clangd] Remove the trailing "." in add-using message..
Wed, Nov 18, 5:46 AM · Restricted Project
hokein added a comment to D91694: [clangd] Remove the trailing "." in add-using message..

If you are doing this may as well cover DefineOutline and RemoveUsingNamespace - that one can do away with formatv too.

Wed, Nov 18, 4:19 AM · Restricted Project
hokein updated the diff for D91694: [clangd] Remove the trailing "." in add-using message..

Fix other code actions as well.

Wed, Nov 18, 4:19 AM · Restricted Project
hokein requested review of D91694: [clangd] Remove the trailing "." in add-using message..
Wed, Nov 18, 2:45 AM · Restricted Project
hokein added a comment to D91162: Give up on evaluating value-dependent potential constexpr before hitting the assertion..

oops, this reminds me of the patch https://reviews.llvm.org/D84637 (I should have landed it, sorry), that patch should fix a general recovery-expr crash inside constexpr function body. I think the crash test should be fixed by that (let me check tomorrow).

Wed, Nov 18, 2:28 AM · Restricted Project
hokein added a comment to D84637: [AST] Enhance the const expression evaluator to support error-dependent exprs..

There are a couple of cases where you're returning EvalStmtResult from a function with a bool return type, that I'd like to see fixed before this lands.

All the other comments are directed towards producing more precise behavior when evaluating a function containing errors / value-dependent constructs. I don't think there's any need to block fixing the crasher here on improving the diagnostics, so I'm happy if you ignore these and commit as-is (other than fixing the return type issue), but I think we'll want to look at these diagnostic improvements at some point.

Wed, Nov 18, 2:25 AM · Restricted Project
hokein updated the diff for D84637: [AST] Enhance the const expression evaluator to support error-dependent exprs..

rebase and address review comments.

Wed, Nov 18, 2:23 AM · Restricted Project
hokein added a comment to D91626: [clangd] Implement textDocument/implementation (Xref layer).

thanks, just reviewed at the xrefs code. I think we can narrow the scope of the patch by splitting it into two patches

Wed, Nov 18, 12:30 AM · Restricted Project

Tue, Nov 17

hokein abandoned D69094: [WIP] Add override relationship..

closing it in favor of https://reviews.llvm.org/D91610.

Tue, Nov 17, 11:40 PM · Restricted Project
hokein accepted D91610: [clangd] Add OverriddenBy Relation to index..
Tue, Nov 17, 12:48 PM · Restricted Project
hokein added a comment to D91162: Give up on evaluating value-dependent potential constexpr before hitting the assertion..

oops, this reminds me of the patch https://reviews.llvm.org/D84637 (I should have landed it, sorry), that patch should fix a general recovery-expr crash inside constexpr function body. I think the crash test should be fixed by that (let me check tomorrow).

Tue, Nov 17, 12:29 PM · Restricted Project
hokein added inline comments to D91625: [clang] Do not crash on pointer wchar_t pointer assignment..
Tue, Nov 17, 12:13 PM · Restricted Project
hokein added a comment to D91610: [clangd] Add OverriddenBy Relation to index..

Thanks! I think we need to bump the index version number (in index/Serialization.cpp) in order to let the index pick up this change.

Tue, Nov 17, 6:07 AM · Restricted Project
hokein requested review of D91614: [clang-tidy] Fix a nullptr-access crash in unused-raii-check..
Tue, Nov 17, 4:33 AM · Restricted Project
hokein committed rGaf0d607e7275: [clang-tidy] Fix an abseil-redundant-strcat-calls crash on 0-parameter StrCat(). (authored by hokein).
[clang-tidy] Fix an abseil-redundant-strcat-calls crash on 0-parameter StrCat().
Tue, Nov 17, 2:12 AM
hokein closed D91601: [clang-tidy] Fix an abseil-redundant-strcat-calls crash on 0-parameter StrCat()..
Tue, Nov 17, 2:12 AM · Restricted Project
hokein accepted D91602: [clang-tidy] Make clang-format and include-order-check coherent.
Tue, Nov 17, 1:56 AM · Restricted Project
hokein requested review of D91601: [clang-tidy] Fix an abseil-redundant-strcat-calls crash on 0-parameter StrCat()..
Tue, Nov 17, 1:29 AM · Restricted Project
hokein committed rG218500d823c8: [clang-tidy] Verify the fixes in abseil-redundant-strcat-calls test, NFC (authored by hokein).
[clang-tidy] Verify the fixes in abseil-redundant-strcat-calls test, NFC
Tue, Nov 17, 1:19 AM

Mon, Nov 16

hokein added a comment to D71880: [clangd] Implement Decl canonicalization rules for rename.

didn't finish all parts (looked at the FunctionDecl and RecordDecl), I think we need more documentation/comments in the code to specify the canonical behavior (templates are tricky).

Mon, Nov 16, 12:39 AM · Restricted Project

Fri, Nov 13

hokein committed rG7ad6c8414ce2: [clang] Fix an assertion crash in delayed access check. (authored by hokein).
[clang] Fix an assertion crash in delayed access check.
Fri, Nov 13, 5:03 AM
hokein closed D91380: [clang] Fix an assertion crash in delayed access check..
Fri, Nov 13, 5:03 AM · Restricted Project
hokein accepted D91337: [clangd] Add missing tests to rename feature.
Fri, Nov 13, 3:00 AM · Restricted Project

Thu, Nov 12

hokein added inline comments to D91337: [clangd] Add missing tests to rename feature.
Thu, Nov 12, 12:53 PM · Restricted Project
hokein requested review of D91380: [clang] Fix an assertion crash in delayed access check..
Thu, Nov 12, 12:38 PM · Restricted Project
hokein added a comment to D71880: [clangd] Implement Decl canonicalization rules for rename.

don't dig into details, first round of comments.

Thu, Nov 12, 12:13 AM · Restricted Project

Wed, Nov 11

hokein added a comment to D83025: [clang] Include type specifiers in typo correction when checking isCXXDeclarationSpecifiers..

We're seeing the same issue mentionned in PR45498, but with the repro below. git bisect points to this patch. Could anyone please possibly confirm? Simply build clang with -DLLVM_ENABLE_ASSERTIONS=ON.

// compile with: clang-cl /c a.cpp
template < a > struct b;
template < bool a, class > using c = b< a >;
template < class > using d = void ;
template < class, class, class = void >
bool e template < class f, class g >
bool e< f, g, d< decltype(h(g())) > > template < class f, class g >
void i(f, g ) {
  e< f, g >
}
template < class _BidIt2, c< e< _BidIt, _BidIt2 >, int > = 0 >
void h(_BidIt2) short do_tolower__Last {
  i(do_tolower__First, do_tolower__Last)
}
Wed, Nov 11, 11:41 AM · Restricted Project
hokein accepted D91134: [clangd] Abort rename when given the same name.
Wed, Nov 11, 1:11 AM · Restricted Project

Tue, Nov 10

hokein committed rG7d85f732b13a: Fix the DeclContextLookupResult::iterator non-copyable. (authored by hokein).
Fix the DeclContextLookupResult::iterator non-copyable.
Tue, Nov 10, 11:24 AM
hokein closed D91158: Fix the DeclContextLookupResult::iterator non-copyable..
Tue, Nov 10, 11:24 AM · Restricted Project
hokein added inline comments to D91134: [clangd] Abort rename when given the same name.
Tue, Nov 10, 10:57 AM · Restricted Project
hokein added inline comments to D91134: [clangd] Abort rename when given the same name.
Tue, Nov 10, 6:36 AM · Restricted Project
hokein requested review of D91158: Fix the DeclContextLookupResult::iterator non-copyable..
Tue, Nov 10, 6:31 AM · Restricted Project
hokein committed rGa97d7b9159a0: Fix the buildbot failure. (authored by hokein).
Fix the buildbot failure.
Tue, Nov 10, 4:12 AM
hokein added a comment to D89790: [clangd] Add basic conflict detection for the rename..

This breaks compillation on windows when using clang as compiler: http://45.33.8.238/win/27605/step_4.txt

Tue, Nov 10, 3:56 AM · Restricted Project
hokein committed rG71064b02701d: [clangd] Bump index version number. (authored by hokein).
[clangd] Bump index version number.
Tue, Nov 10, 1:32 AM
hokein closed D91131: [clangd] Bump index version number..
Tue, Nov 10, 1:32 AM · Restricted Project
hokein accepted D91102: [clangd] Enhance Clangd rename testing coverage.

Thanks. Please update the patch description when landing it (the description is stale now).

Tue, Nov 10, 12:53 AM · Restricted Project
hokein requested review of D91131: [clangd] Bump index version number..
Tue, Nov 10, 12:17 AM · Restricted Project
hokein added a comment to D91102: [clangd] Enhance Clangd rename testing coverage.

thanks for doing this!

Tue, Nov 10, 12:07 AM · Restricted Project

Mon, Nov 9

hokein committed rGdaa736da10fd: [clangd] Add basic conflict detection for the rename. (authored by hokein).
[clangd] Add basic conflict detection for the rename.
Mon, Nov 9, 11:53 PM
hokein closed D89790: [clangd] Add basic conflict detection for the rename..
Mon, Nov 9, 11:52 PM · Restricted Project
hokein added inline comments to D91051: [clangd] Improve clangd-indexer performance.
Mon, Nov 9, 4:05 AM · Restricted Project
hokein updated the diff for D89790: [clangd] Add basic conflict detection for the rename..

address review comments.

Mon, Nov 9, 12:51 AM · Restricted Project

Wed, Nov 4

hokein accepted D90540: [Syntax] Add minimal TableGen for syntax nodes. NFC.
Wed, Nov 4, 12:08 PM · Restricted Project
hokein added inline comments to D89790: [clangd] Add basic conflict detection for the rename..
Wed, Nov 4, 11:56 AM · Restricted Project
hokein updated the diff for D89790: [clangd] Add basic conflict detection for the rename..

address comments.

Wed, Nov 4, 11:56 AM · Restricted Project

Sun, Nov 1

hokein committed rG6d15a28a853d: [clangd] Fix ParsedASTTest.TopLevelDecls test. (authored by ilya-golovenko).
[clangd] Fix ParsedASTTest.TopLevelDecls test.
Sun, Nov 1, 11:37 PM
hokein closed D90384: [clangd] Fix ParsedASTTest.TopLevelDecls test..
Sun, Nov 1, 11:37 PM · Restricted Project

Fri, Oct 30

hokein requested review of D90459: [WIP][clang] Use RecoveryExpr to suppress secondary diagnostics for typo correction..
Fri, Oct 30, 6:44 AM · Restricted Project

Thu, Oct 29

hokein accepted D90384: [clangd] Fix ParsedASTTest.TopLevelDecls test..

Great! Thanks for doing this!

Thu, Oct 29, 6:17 AM · Restricted Project

Tue, Oct 27

hokein updated subscribers of D89046: [AST] Build recovery expression by default for all language..

@hubert.reinterpretcast, similar to D78350, could you help to test this patch with your downstream clang? this patch is based on 2c2dc7c392a3f28d4dbec3018e3137d5d4f8c6c8. Thanks!

Tue, Oct 27, 4:37 AM · Restricted Project
hokein added inline comments to D89046: [AST] Build recovery expression by default for all language..
Tue, Oct 27, 3:10 AM · Restricted Project
hokein updated the diff for D89046: [AST] Build recovery expression by default for all language..

rebase and address comments.

Tue, Oct 27, 3:09 AM · Restricted Project
hokein committed rG2c2dc7c392a3: [clang][RecoveryExpr] Add tests for ObjectiveC. (authored by hokein).
[clang][RecoveryExpr] Add tests for ObjectiveC.
Tue, Oct 27, 1:43 AM
hokein closed D90140: [clang][RecoveryExpr] Add tests for ObjectiveC..
Tue, Oct 27, 1:43 AM · Restricted Project
hokein added inline comments to D90140: [clang][RecoveryExpr] Add tests for ObjectiveC..
Tue, Oct 27, 1:43 AM · Restricted Project

Mon, Oct 26

hokein committed rGefa9aaad703e: [clang] Suppress "follow-up" diagnostics on recovery call expressions. (authored by hokein).
[clang] Suppress "follow-up" diagnostics on recovery call expressions.
Mon, Oct 26, 4:46 AM
hokein closed D89946: [clang] Suppress "follow-up" diagnostics on recovery call expressions..
Mon, Oct 26, 4:45 AM · Restricted Project
hokein requested review of D90140: [clang][RecoveryExpr] Add tests for ObjectiveC..
Mon, Oct 26, 2:54 AM · Restricted Project
hokein added inline comments to D89946: [clang] Suppress "follow-up" diagnostics on recovery call expressions..
Mon, Oct 26, 2:24 AM · Restricted Project
hokein updated the diff for D89946: [clang] Suppress "follow-up" diagnostics on recovery call expressions..

address comments.

Mon, Oct 26, 2:24 AM · Restricted Project
hokein added inline comments to D89946: [clang] Suppress "follow-up" diagnostics on recovery call expressions..
Mon, Oct 26, 1:06 AM · Restricted Project
hokein updated the diff for D89946: [clang] Suppress "follow-up" diagnostics on recovery call expressions..

address comment.

Mon, Oct 26, 1:06 AM · Restricted Project

Oct 23 2020

hokein accepted D89785: [clangd] Add basic support for attributes (selection, hover).
Oct 23 2020, 1:04 AM · Restricted Project
hokein added inline comments to D89946: [clang] Suppress "follow-up" diagnostics on recovery call expressions..
Oct 23 2020, 1:00 AM · Restricted Project
hokein updated the diff for D89946: [clang] Suppress "follow-up" diagnostics on recovery call expressions..

address comments and add AST tests.

Oct 23 2020, 1:00 AM · Restricted Project
hokein added inline comments to D89785: [clangd] Add basic support for attributes (selection, hover).
Oct 23 2020, 12:02 AM · Restricted Project

Oct 22 2020

hokein added inline comments to D89946: [clang] Suppress "follow-up" diagnostics on recovery call expressions..
Oct 22 2020, 3:46 AM · Restricted Project
hokein requested review of D89946: [clang] Suppress "follow-up" diagnostics on recovery call expressions..
Oct 22 2020, 3:40 AM · Restricted Project

Oct 21 2020

hokein added a comment to D87349: [clang] adapt c++17 behavior for dependent decltype-specifiers.

friendly ping @rsmith :)

Oct 21 2020, 10:51 AM · Restricted Project
hokein added a comment to D84637: [AST] Enhance the const expression evaluator to support error-dependent exprs..

friendly ping @rsmith :)

Oct 21 2020, 10:51 AM · Restricted Project

Oct 20 2020

hokein accepted D89743: Support Attr in DynTypedNode and ASTMatchers..
Oct 20 2020, 7:09 AM · Restricted Project
hokein requested review of D89790: [clangd] Add basic conflict detection for the rename..
Oct 20 2020, 7:02 AM · Restricted Project
hokein committed rG84048e234f8f: [format] foo.<name>.h should be the main-header for foo.<name>.cc (authored by hokein).
[format] foo.<name>.h should be the main-header for foo.<name>.cc
Oct 20 2020, 4:34 AM