Page MenuHomePhabricator

hokein (Haojian Wu)
User

Projects

User does not belong to any projects.

User Details

User Since
Aug 19 2015, 3:38 AM (294 w, 6 d)

Recent Activity

Fri, Apr 9

hokein accepted D95244: [clang][AST] Handle overload callee type in CallExpr::getCallReturnType..

thanks, looks good!

Fri, Apr 9, 3:49 AM · Restricted Project

Wed, Apr 7

hokein added inline comments to D95244: [clang][AST] Handle overload callee type in CallExpr::getCallReturnType..
Wed, Apr 7, 3:57 AM · Restricted Project

Wed, Mar 24

hokein committed rGcfc36bf01794: [clang] Treat variable-length array of incomplete element type as (authored by hokein).
[clang] Treat variable-length array of incomplete element type as
Wed, Mar 24, 6:23 AM
hokein closed D99165: [clang] Treat variable-length array of incomplete element type as incomplete type..
Wed, Mar 24, 6:22 AM · Restricted Project
hokein added inline comments to D99165: [clang] Treat variable-length array of incomplete element type as incomplete type..
Wed, Mar 24, 6:15 AM · Restricted Project
hokein retitled D99165: [clang] Treat variable-length array of incomplete element type as incomplete type. from [clang] Fix a crash on checkDestructorReference. to [clang] Treat variable-length array of incomplete element type as incomplete type..
Wed, Mar 24, 6:10 AM · Restricted Project
hokein added a comment to D99165: [clang] Treat variable-length array of incomplete element type as incomplete type..

The fix doesn't look obviously correct: the side effect of marking the destructor reference seems important if we actually generate code. It's not obvious to me why the type can only be incomplete if there are errors.

This was introduced between clang 8 and clang 9, I would guess by f8ccf052935adaf405e581fd31e8bc634cc5bbc7.
@erik.pilkington
Looking at that patch, mostly this function was just a rename, but there's a new callsite for array-types that seems to be what we're hitting here.
Maybe a slightly less-invasive version would be to guard that callsite with "and if the element type is complete"?

Wed, Mar 24, 3:38 AM · Restricted Project
hokein updated the diff for D99165: [clang] Treat variable-length array of incomplete element type as incomplete type..
  • jrefine the fix of the crash: if the element type of an variable-length array

is incomplete, the array type is incomplete;

  • simplify the testcase
Wed, Mar 24, 3:31 AM · Restricted Project

Tue, Mar 23

hokein requested review of D99165: [clang] Treat variable-length array of incomplete element type as incomplete type..
Tue, Mar 23, 3:27 AM · Restricted Project
hokein accepted D99145: [clang] Fix a crash when CTAD fails.

Thanks!

Tue, Mar 23, 1:32 AM · Restricted Project

Mon, Mar 22

hokein accepted D99065: [clangd] Replace usages of dummy with more descriptive words.
Mon, Mar 22, 3:29 AM · Restricted Project

Wed, Mar 17

hokein added inline comments to D98738: [clang-tidy] performance-* checks: Match AllowedTypes against qualified type names when they contain "::"..
Wed, Mar 17, 1:31 PM · Restricted Project

Mar 12 2021

hokein updated subscribers of D93300: [PowerPC] Exploit paddi instruction on Power 10 for constant materialization.

hi @stefanp, this patch caused an asan error when running on ninja check-llvm-codegen-powerpc.

llvm-project/llvm/lib/Target/PowerPC/PPCISelDAGToDAG.cpp:1046:48: runtime error: shift exponent 64 is too large for 64-bit type 'uint64_t' (aka 'unsigned long')

Mar 12 2021, 5:53 AM · Restricted Project
hokein added a comment to D93300: [PowerPC] Exploit paddi instruction on Power 10 for constant materialization.

hi @stefanp, this patch caused an asan error when running on ninja check-llvm-codegen-powerpc.

Mar 12 2021, 4:55 AM · Restricted Project
hokein added a comment to D95244: [clang][AST] Handle overload callee type in CallExpr::getCallReturnType..

This looks like a reasonable solution to me -- if we don't know the function call result type (e.g. dependent-type callExpr in template context), modeling it as a dependent type.

Mar 12 2021, 4:30 AM · Restricted Project

Mar 8 2021

hokein committed rGc9ff39a3f984: Add "assert require" for the test added in… (authored by hokein).
Add "assert require" for the test added in…
Mar 8 2021, 5:18 AM
hokein added a comment to D97935: [clangd] Add config support for ResourceDir.

The code looks good, but I don't have a very strong opinion of making the resource-dir as a config option. Do we have a motivation (e.g. user request?) now?

Mar 8 2021, 12:04 AM · Restricted Project

Mar 7 2021

hokein accepted D97965: [clang] Fix crash when creating deduction guide..

Thanks!

Mar 7 2021, 11:55 PM · Restricted Project

Mar 1 2021

hokein accepted D97577: [clang-tidy] performance-for-range-copy: Don't trigger on implicit type conversions..
In D97577#2592827, @flx wrote:

It is best not to change existing tests, but add new ones.

Could elaborate on this, Roman?

In this case the tests use special auto convertible types with the intention to test that the check doesn't trigger because the loop variable needs to be constructed. But the reason they don't trigger is that the loop variable erroneously is already a reference type.

If we keep the tests as is we should rename the test functions and use different types or document that the real reason they don't trigger is that they already are const reference types, but we already have a test for that as well.

Mar 1 2021, 11:15 PM · Restricted Project, Restricted Project

Feb 28 2021

hokein accepted D97351: [clangd] Use flags from open files when opening headers they include.

thanks, this looks great.

Feb 28 2021, 1:48 PM · Restricted Project

Feb 25 2021

hokein committed rGb218f7c4baad: [clangd] NFC, remove an extra "class" keyword. (authored by hokein).
[clangd] NFC, remove an extra "class" keyword.
Feb 25 2021, 12:33 AM

Feb 24 2021

hokein committed rG77a8589e5d2f: [clang][RecoveryAST] Add design doc to clang internal manual. (authored by hokein).
[clang][RecoveryAST] Add design doc to clang internal manual.
Feb 24 2021, 11:23 PM
hokein closed D96944: [RecoveryAST] Add design doc to clang internal manual..
Feb 24 2021, 11:23 PM · Restricted Project

Feb 18 2021

hokein added inline comments to D96944: [RecoveryAST] Add design doc to clang internal manual..
Feb 18 2021, 6:32 AM · Restricted Project
hokein updated the diff for D96944: [RecoveryAST] Add design doc to clang internal manual..

address review comments

Feb 18 2021, 6:30 AM · Restricted Project
hokein committed rG780ead41e075: [Syntax] No crash on OpaqueValueExpr. (authored by hokein).
[Syntax] No crash on OpaqueValueExpr.
Feb 18 2021, 1:32 AM
hokein closed D96112: [Syntax] No crash on OpaqueValueExpr..
Feb 18 2021, 1:32 AM · Restricted Project
hokein requested review of D96944: [RecoveryAST] Add design doc to clang internal manual..
Feb 18 2021, 12:50 AM · Restricted Project

Feb 17 2021

hokein committed rG7048cb5371f9: [clangd] IndexedFiles should include Fils from RefSlab and RelationSlab. (authored by hokein).
[clangd] IndexedFiles should include Fils from RefSlab and RelationSlab.
Feb 17 2021, 6:44 AM
hokein closed D96845: [clangd] IndexedFiles should include Fils from RefSlab and RelationSlab..
Feb 17 2021, 6:44 AM · Restricted Project
hokein committed rGe030de7e5a28: [clangd] Pass file when possible to resolve URI. (authored by hokein).
[clangd] Pass file when possible to resolve URI.
Feb 17 2021, 6:39 AM
hokein closed D96844: [clangd] Pass file when possible to resolve URI..
Feb 17 2021, 6:39 AM · Restricted Project

Feb 16 2021

hokein requested review of D96845: [clangd] IndexedFiles should include Fils from RefSlab and RelationSlab..
Feb 16 2021, 11:48 PM · Restricted Project
hokein requested review of D96844: [clangd] Pass file when possible to resolve URI..
Feb 16 2021, 11:43 PM · Restricted Project

Feb 15 2021

hokein updated the diff for D96693: [Syntax] Model FunctionDefinition..

Fix and simplify the test.

Feb 15 2021, 1:46 AM · Restricted Project
hokein requested review of D96693: [Syntax] Model FunctionDefinition..
Feb 15 2021, 1:27 AM · Restricted Project

Feb 12 2021

hokein committed rGee4dd0f87698: [clangd] Remove the cross-file-rename option. (authored by hokein).
[clangd] Remove the cross-file-rename option.
Feb 12 2021, 6:39 AM
hokein closed D96578: [clangd] Remove the cross-file-rename option..
Feb 12 2021, 6:39 AM · Restricted Project
hokein accepted D96542: [clang-tidy] Fix `TransformerClangTidyCheck`'s handling of include insertions..

Thanks, the fix looks good.

Feb 12 2021, 4:17 AM · Restricted Project, Restricted Project
hokein added inline comments to D96578: [clangd] Remove the cross-file-rename option..
Feb 12 2021, 1:41 AM · Restricted Project
hokein updated the diff for D96578: [clangd] Remove the cross-file-rename option..

address review comment.

Feb 12 2021, 1:40 AM · Restricted Project
hokein requested review of D96578: [clangd] Remove the cross-file-rename option..
Feb 12 2021, 12:32 AM · Restricted Project

Feb 11 2021

hokein committed rG573348ab9b28: [clangd] Retire the cross-file-rename command-line flag. (authored by hokein).
[clangd] Retire the cross-file-rename command-line flag.
Feb 11 2021, 11:29 AM
hokein closed D96495: [clangd] Retire the cross-file-rename command-line flag..
Feb 11 2021, 11:29 AM · Restricted Project
hokein updated the diff for D96495: [clangd] Retire the cross-file-rename command-line flag..

fix failure tests.

Feb 11 2021, 11:10 AM · Restricted Project
hokein added a comment to D96495: [clangd] Retire the cross-file-rename command-line flag..

Those test failures look related.

Feb 11 2021, 11:10 AM · Restricted Project
hokein requested review of D96495: [clangd] Retire the cross-file-rename command-line flag..
Feb 11 2021, 6:00 AM · Restricted Project
hokein committed rG6c47eafb3973: [clang][index] report references from unreslovedLookupExpr. (authored by hokein).
[clang][index] report references from unreslovedLookupExpr.
Feb 11 2021, 2:08 AM
hokein closed D96262: [clang][index] report references from unreslovedLookupExpr..
Feb 11 2021, 2:08 AM · Restricted Project
hokein updated the diff for D96262: [clang][index] report references from unreslovedLookupExpr..

address comment, add more tests.

Feb 11 2021, 2:07 AM · Restricted Project
hokein accepted D96353: [clangd] Use ML Code completion ranking as default..

maybe add some data (improvement DecisionForest vs heuristic) in the patch description.

Feb 11 2021, 1:49 AM · Restricted Project
hokein committed rGe159a3ced4c5: [Syntax] Remove a strict valid source location assertion for TypeLoc. (authored by hokein).
[Syntax] Remove a strict valid source location assertion for TypeLoc.
Feb 11 2021, 12:59 AM
hokein closed D96261: [Syntax] Remove a strict valid source location assertion for TypeLoc..
Feb 11 2021, 12:58 AM · Restricted Project
hokein committed rG35a5e883906f: [Syntax] NFC, Simplify a test with annotations (authored by hokein).
[Syntax] NFC, Simplify a test with annotations
Feb 11 2021, 12:49 AM
hokein committed rGdf1a17c219c0: [clang-check] Add tokens-dump in clang-check. (authored by hokein).
[clang-check] Add tokens-dump in clang-check.
Feb 11 2021, 12:41 AM
hokein closed D96017: [clang-check] Add tokens-dump in clang-check..
Feb 11 2021, 12:41 AM · Restricted Project

Feb 10 2021

hokein added inline comments to D96353: [clangd] Use ML Code completion ranking as default..
Feb 10 2021, 11:51 PM · Restricted Project
hokein accepted D96376: [CodeComplete] Member completion: heuristically resolve some dependent base exprs.

thanks! this looks like a nice improvement!

Feb 10 2021, 11:44 PM · Restricted Project

Feb 8 2021

hokein accepted D96247: [clangd] Fix false positive in local rename collision detetction.

Thanks for the quick fix.

Feb 8 2021, 6:40 AM · Restricted Project
hokein requested review of D96262: [clang][index] report references from unreslovedLookupExpr..
Feb 8 2021, 6:24 AM · Restricted Project
hokein requested review of D96261: [Syntax] Remove a strict valid source location assertion for TypeLoc..
Feb 8 2021, 6:15 AM · Restricted Project

Feb 5 2021

hokein accepted D95935: [clang][CodeComplete] Fix crash on ParenListExprs.
Feb 5 2021, 5:59 AM · Restricted Project
hokein requested review of D96112: [Syntax] No crash on OpaqueValueExpr..
Feb 5 2021, 2:25 AM · Restricted Project

Feb 4 2021

hokein requested review of D96017: [clang-check] Add tokens-dump in clang-check..
Feb 4 2021, 4:46 AM · Restricted Project
hokein accepted D96009: [clangd] Improve name conflict detection.

Thanks!

Feb 4 2021, 4:32 AM · Restricted Project
hokein added inline comments to D95925: [clangd] Detect rename conflicits within enclosing scope.
Feb 4 2021, 12:42 AM · Restricted Project
hokein accepted D95925: [clangd] Detect rename conflicits within enclosing scope.

Looks good, thanks!

Feb 4 2021, 12:40 AM · Restricted Project
hokein committed rG6c1a23303de9: [Syntax] Support condition for IfStmt. (authored by hokein).
[Syntax] Support condition for IfStmt.
Feb 4 2021, 12:30 AM
hokein closed D95782: [Syntax] Support condition for IfStmt..
Feb 4 2021, 12:30 AM · Restricted Project
hokein added inline comments to D95782: [Syntax] Support condition for IfStmt..
Feb 4 2021, 12:29 AM · Restricted Project

Feb 3 2021

hokein added inline comments to D95925: [clangd] Detect rename conflicits within enclosing scope.
Feb 3 2021, 11:55 PM · Restricted Project
hokein added a comment to D95925: [clangd] Detect rename conflicits within enclosing scope.

thanks, looks better now, just some nits to improve the code readability.

Feb 3 2021, 4:54 AM · Restricted Project
hokein accepted D95852: [clangd] Report xref for base methods..

Thanks!

Feb 3 2021, 2:38 AM · Restricted Project
hokein added a comment to D95925: [clangd] Detect rename conflicits within enclosing scope.

Thanks, this looks right to me.

Feb 3 2021, 12:48 AM · Restricted Project

Feb 2 2021

hokein requested review of D95871: [clang] Store the location for invalid type of a declarator..
Feb 2 2021, 7:26 AM · Restricted Project
hokein added inline comments to D95852: [clangd] Report xref for base methods..
Feb 2 2021, 1:34 AM · Restricted Project

Feb 1 2021

hokein accepted D95812: [clangd] Report only decl of overridding method in xref..

Thanks, this looks great.

Feb 1 2021, 11:43 PM · Restricted Project
hokein committed rG78c22fbce991: [clangd] Don't rely on builtin headers for document-link.test. (authored by hokein).
[clangd] Don't rely on builtin headers for document-link.test.
Feb 1 2021, 6:45 AM
hokein closed D95670: [clangd] Don't rely on builtin headers for document-link.test..
Feb 1 2021, 6:45 AM · Restricted Project
hokein updated the diff for D95670: [clangd] Don't rely on builtin headers for document-link.test..

address comments.

Feb 1 2021, 6:42 AM · Restricted Project
hokein requested review of D95782: [Syntax] Support condition for IfStmt..
Feb 1 2021, 6:26 AM · Restricted Project

Jan 31 2021

hokein accepted D95759: [clangd] Rename: merge index/AST refs path-insensitively where needed.

Thanks for fixing this!

Jan 31 2021, 11:29 PM · Restricted Project

Jan 29 2021

hokein committed rGe90e455d2a0c: [Syntax] Add syntax-tree-dump in clang-check. (authored by hokein).
[Syntax] Add syntax-tree-dump in clang-check.
Jan 29 2021, 5:20 AM
hokein closed D95526: [Syntax] Add syntax-tree-dump in clang-check..
Jan 29 2021, 5:20 AM · Restricted Project
hokein updated the diff for D95526: [Syntax] Add syntax-tree-dump in clang-check..

address comment.

Jan 29 2021, 5:19 AM · Restricted Project

Jan 28 2021

hokein committed rGf25a57e248a0: [clangd] Add include-fixer fixit for field_incomplete_or_sizeless diagnostic. (authored by hokein).
[clangd] Add include-fixer fixit for field_incomplete_or_sizeless diagnostic.
Jan 28 2021, 11:57 PM
hokein closed D95439: [clangd] Add include-fixer fixit for field_incomplete_or_sizeless diagnostic..
Jan 28 2021, 11:56 PM · Restricted Project
hokein requested review of D95670: [clangd] Don't rely on builtin headers for document-link.test..
Jan 28 2021, 11:55 PM · Restricted Project

Jan 27 2021

hokein accepted D95571: [clangd] Remove some obsolete options that are now always on.

I assume you'll handle the internal integration part ;)

Jan 27 2021, 11:25 PM · Restricted Project
hokein requested review of D95526: [Syntax] Add syntax-tree-dump in clang-check..
Jan 27 2021, 7:17 AM · Restricted Project
hokein added a comment to rGd972d4c74904: Revert "[clang] Suppress "follow-up" diagnostics on recovery call expressions.".

Hello,

The test case Clang/CodeGenCXX/ms-lookup-template-base-classes.cpp is missing a REQUIRES statement and is failing on Linux validations downstream for us. It needs a:

// REQUIRES: x86-registered-target

Thoughts?

Thank you,
Gaurav

Jan 27 2021, 1:52 AM
hokein added inline comments to D95439: [clangd] Add include-fixer fixit for field_incomplete_or_sizeless diagnostic..
Jan 27 2021, 1:15 AM · Restricted Project
hokein updated the diff for D95439: [clangd] Add include-fixer fixit for field_incomplete_or_sizeless diagnostic..

address comments.

Jan 27 2021, 1:14 AM · Restricted Project

Jan 26 2021

hokein requested review of D95439: [clangd] Add include-fixer fixit for field_incomplete_or_sizeless diagnostic..
Jan 26 2021, 4:33 AM · Restricted Project
hokein committed rG68dbd1aefe5a: [clangd] Add include-fixer fixit for no_member_template diagnostic. (authored by hokein).
[clangd] Add include-fixer fixit for no_member_template diagnostic.
Jan 26 2021, 1:11 AM
hokein closed D95365: [clangd] Add include-fixer fixit for no_member_template diagnostic..
Jan 26 2021, 1:11 AM · Restricted Project

Jan 25 2021

hokein accepted D95362: [clangd] Parse Diagnostics block, and nest ClangTidy block under it..
Jan 25 2021, 11:47 AM · Restricted Project
hokein requested review of D95365: [clangd] Add include-fixer fixit for no_member_template diagnostic..
Jan 25 2021, 7:29 AM · Restricted Project
hokein accepted D95349: [clangd] Allow diagnostics to be suppressed with configuration.
Jan 25 2021, 6:34 AM · Restricted Project
hokein accepted D95145: [clang] Fix a nullptr dereference bug on invalid code.

Thanks.

Jan 25 2021, 5:55 AM · Restricted Project