Page MenuHomePhabricator

[mlir:JitRunner] Use custom shared library init/destroy functions if available
ClosedPublic

Authored by ezhulenev on Jan 7 2021, 3:31 PM.

Details

Summary

Use custom mlir runner init/destroy functions to safely init and destroy shared libraries loaded by the JitRunner.

Diff Detail

Event Timeline

ezhulenev created this revision.Jan 7 2021, 3:31 PM
ezhulenev requested review of this revision.Jan 7 2021, 3:31 PM
ezhulenev edited the summary of this revision. (Show Details)Jan 7 2021, 3:33 PM
ezhulenev added a reviewer: mehdi_amini.
mehdi_amini accepted this revision.Jan 7 2021, 4:27 PM
mehdi_amini added inline comments.
mlir/lib/ExecutionEngine/AsyncRuntime.cpp
361

Please check that a symbol isn't already defined and error out if it is.

387

All the symbols could get visiliby hidden right?

This revision is now accepted and ready to land.Jan 7 2021, 4:27 PM
ezhulenev updated this revision to Diff 315332.Jan 8 2021, 3:14 AM
ezhulenev marked an inline comment as done.

Export only mlir runner API symbols

ezhulenev marked an inline comment as done.Jan 8 2021, 7:12 AM
ezhulenev added inline comments.
mlir/lib/ExecutionEngine/AsyncRuntime.cpp
387

Yes, updated the target property in CMakeLists and explicitly exported mlir init and destroy.

This revision was landed with ongoing or failed builds.Jan 8 2021, 7:14 AM
This revision was automatically updated to reflect the committed changes.
ezhulenev marked an inline comment as done.