Page MenuHomePhabricator

[mlir:JitRunner] Use custom shared library init/destroy functions if available
ClosedPublic

Authored by ezhulenev on Jan 8 2021, 8:18 AM.

Details

Summary

Use custom mlir runner init/destroy functions to safely init and destroy shared libraries loaded by the JitRunner.

This mechanism is ignored for Windows builds (for now) because init/destroy functions are not exported, and library unloading relies on static destructors.

Re-submit https://reviews.llvm.org/D94270 with a temporary workaround for windows

Diff Detail

Event Timeline

ezhulenev created this revision.Jan 8 2021, 8:18 AM
ezhulenev requested review of this revision.Jan 8 2021, 8:18 AM
ezhulenev edited the summary of this revision. (Show Details)Jan 8 2021, 8:20 AM
ezhulenev edited the summary of this revision. (Show Details)Jan 8 2021, 8:55 AM
ezhulenev added a reviewer: mehdi_amini.
ezhulenev edited the summary of this revision. (Show Details)Jan 8 2021, 8:57 AM
This revision was not accepted when it landed; it landed in state Needs Review.Jan 8 2021, 1:16 PM
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.