Page MenuHomePhabricator

[clang][Sema] Compare SourceLocations directly [NFCI]
ClosedPublic

Authored by miyuki on Jan 7 2021, 5:38 AM.

Details

Summary

The ordered comparison operators are defined for the SourceLocation
class, so SourceLocation objects can be compared directly. There is no
need to extract the internal representation for comparison.

Diff Detail

Event Timeline

miyuki requested review of this revision.Jan 7 2021, 5:38 AM
miyuki created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptJan 7 2021, 5:38 AM
Herald added a subscriber: cfe-commits. · View Herald Transcript
aprantl accepted this revision.Jan 8 2021, 4:11 PM

Based on your explanation, this seems good. Thanks!

This revision is now accepted and ready to land.Jan 8 2021, 4:11 PM
This revision was automatically updated to reflect the committed changes.