Page MenuHomePhabricator

aprantl (Adrian Prantl)
User

Projects

User Details

User Since
Mar 2 2013, 8:12 AM (457 w, 4 d)

Recent Activity

Mon, Dec 6

aprantl added a comment to D115007: Dump swift5 reflection section data into dsym bundle generated binary with dsymutil.

Thanks, this is looking pretty good!

Mon, Dec 6, 2:14 PM · Restricted Project, debug-info

Tue, Nov 30

aprantl accepted D114742: [lldb] Search PrivateFrameworks when using an internal SDK.
Tue, Nov 30, 10:48 AM · Restricted Project

Mon, Nov 29

aprantl committed rG4f215bfa6ee5: Update unit test API usage (NFC) (authored by aprantl).
Update unit test API usage (NFC)
Mon, Nov 29, 1:14 PM

Fri, Nov 19

aprantl committed rG587a397917b2: Skip tests when compiler with older versions of clang (authored by aprantl).
Skip tests when compiler with older versions of clang
Fri, Nov 19, 9:06 AM

Thu, Nov 18

aprantl added a reverting change for rG6424dc21bf6b: Increase gdbremote timeout.: rGcbb8b200a656: Revert "Increase gdbremote timeout.".
Thu, Nov 18, 3:07 PM
aprantl committed rGcbb8b200a656: Revert "Increase gdbremote timeout." (authored by aprantl).
Revert "Increase gdbremote timeout."
Thu, Nov 18, 3:07 PM
aprantl committed rG721bb7367647: make testcase more robust (authored by aprantl).
make testcase more robust
Thu, Nov 18, 2:01 PM
aprantl committed rG5cf23ecc23af: fix syntax error (authored by aprantl).
fix syntax error
Thu, Nov 18, 10:50 AM
aprantl added a comment to D111899: LLDB tests modification for hardware breakpoints.

FYI, this broke all the TestObjCNewSyntax* tests. I *think* I've fixed them.

Thu, Nov 18, 8:52 AM · Restricted Project
aprantl committed rG08c0a45ab89c: Unbreak test after D111899 (authored by aprantl).
Unbreak test after D111899
Thu, Nov 18, 8:52 AM

Wed, Nov 17

aprantl committed rZORG3d65006e6aea: Revert "Revert "Put a temporary workaround in place for codesigning on the… (authored by aprantl).
Revert "Revert "Put a temporary workaround in place for codesigning on the…
Wed, Nov 17, 11:19 AM
aprantl added a reverting change for rZORGff44ecde6325: Revert "Put a temporary workaround in place for codesigning on the green-dragon…: rZORG3d65006e6aea: Revert "Revert "Put a temporary workaround in place for codesigning on the….
Wed, Nov 17, 11:19 AM
aprantl added a reverting change for rZORG66f091ff8a67: Put a temporary workaround in place for codesigning on the green-dragon-04…: rZORGff44ecde6325: Revert "Put a temporary workaround in place for codesigning on the green-dragon….
Wed, Nov 17, 9:42 AM
aprantl committed rZORGff44ecde6325: Revert "Put a temporary workaround in place for codesigning on the green-dragon… (authored by aprantl).
Revert "Put a temporary workaround in place for codesigning on the green-dragon…
Wed, Nov 17, 9:42 AM

Tue, Nov 16

aprantl added a comment to D113650: [lldb] fix -print-script-interpreter-info on windows.

This seems to have broken the green dragon incremental bot: https://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake/38387/

Tue, Nov 16, 5:48 PM · Restricted Project
aprantl accepted D113864: Don't add irrelevant items to queue in DwarfCompileUnit::createScopeChildrenDIE (NFC).

Seems reasonable.

Tue, Nov 16, 12:03 PM · Restricted Project
aprantl committed rGdb5b960e2dd5: fix decorator (authored by aprantl).
fix decorator
Tue, Nov 16, 9:18 AM
aprantl committed rZORG063a5585c616: Add clang 11 and 13 to the LLDB matrix bot (authored by aprantl).
Add clang 11 and 13 to the LLDB matrix bot
Tue, Nov 16, 9:16 AM
aprantl committed rG948b36d2582c: Skip tests on older versions of clang (authored by aprantl).
Skip tests on older versions of clang
Tue, Nov 16, 9:10 AM
aprantl committed rG6424dc21bf6b: Increase gdbremote timeout. (authored by aprantl).
Increase gdbremote timeout.
Tue, Nov 16, 9:10 AM
aprantl committed rG6e78cfb28ab5: typo (authored by aprantl).
typo
Tue, Nov 16, 9:10 AM

Mon, Nov 15

aprantl committed rZORG5d20a0c7d833: fix job name (authored by aprantl).
fix job name
Mon, Nov 15, 3:01 PM
aprantl committed rZORGfe8cc6b007f9: Rename GIT_REVISION to GIT_SHA (authored by aprantl).
Rename GIT_REVISION to GIT_SHA
Mon, Nov 15, 2:01 PM
aprantl committed rZORG49c4bebcaa42: Make sure stage2 LLDB builder download the correct compiler artifacts (authored by aprantl).
Make sure stage2 LLDB builder download the correct compiler artifacts
Mon, Nov 15, 1:55 PM
aprantl committed rZORG47c9baf4dfcb: Revert "move relay job to green-dragon-23" (authored by aprantl).
Revert "move relay job to green-dragon-23"
Mon, Nov 15, 1:41 PM
aprantl added a reverting change for rZORG084a5ac3f39e: move relay job to green-dragon-23: rZORG47c9baf4dfcb: Revert "move relay job to green-dragon-23".
Mon, Nov 15, 1:41 PM
aprantl committed rZORG4b72e88596a1: Build fewer targets on the LLDB bot (authored by aprantl).
Build fewer targets on the LLDB bot
Mon, Nov 15, 1:31 PM
aprantl committed rZORG084a5ac3f39e: move relay job to green-dragon-23 (authored by aprantl).
move relay job to green-dragon-23
Mon, Nov 15, 1:24 PM
aprantl added a comment to D113743: [RFC][clang][DebugInfo] Allow function-local statics and types to be scoped within a lexical block.

This looks reasonable to me. Thanks!

Mon, Nov 15, 1:06 PM · debug-info, Restricted Project
aprantl committed rZORG57f6909bb1c3: register option properties (authored by aprantl).
register option properties
Mon, Nov 15, 11:44 AM
aprantl committed rZORG3352ecf15664: Add a relay-lldb job to trigger stage2 LLDB bots for builds that passed stage1. (authored by aprantl).
Add a relay-lldb job to trigger stage2 LLDB bots for builds that passed stage1.
Mon, Nov 15, 10:02 AM

Fri, Nov 12

aprantl abandoned D113716: sys::path: Detect posix paths starting with ~ as absolute.

Thanks for the feedback!

Fri, Nov 12, 3:47 PM · Restricted Project, debug-info
aprantl added a comment to D113734: [llvm-objcopy][MachO] Add llvm-strip support for newer load commands.

I'm not sure how this should be tested since there aren't cases where we actually link binaries before being able to run this

Fri, Nov 12, 12:59 PM · Restricted Project
aprantl added a comment to D113586: [DebugInfo][NFC] Add instr-ref documentation, migration guide.

Nice! Should we link to this document from other documents?

Fri, Nov 12, 12:55 PM · Restricted Project

Thu, Nov 11

aprantl requested review of D113725: Validate chained fixup image formats.
Thu, Nov 11, 5:53 PM · Restricted Project
aprantl requested review of D113718: Don't append the working directory to absolute paths.
Thu, Nov 11, 2:35 PM · debug-info
aprantl requested review of D113716: sys::path: Detect posix paths starting with ~ as absolute.
Thu, Nov 11, 2:31 PM · Restricted Project, debug-info
aprantl updated the diff for D113630: Add support for chained fixup load commands to MachOObjectFile.

Rebased & fixed typo

Thu, Nov 11, 9:53 AM · Restricted Project
aprantl updated the diff for D113573: Add a (nonfunctional) -dyld_info flag to llvm-objdump..

Address review feedback.

Thu, Nov 11, 9:39 AM · Restricted Project
aprantl added a comment to D113573: Add a (nonfunctional) -dyld_info flag to llvm-objdump..

What's the motivation for adding the option without implementation at this point?

Thu, Nov 11, 9:18 AM · Restricted Project

Wed, Nov 10

aprantl requested review of D113630: Add support for chained fixup load commands to MachOObjectFile.
Wed, Nov 10, 4:51 PM · Restricted Project
aprantl accepted D113562: [lldb][NFC] Add an ImporterBackedASTSource that serves as base class for LLDB ExternalASTSources that use the ASTImporter.

LGTM

Wed, Nov 10, 11:13 AM · Restricted Project
aprantl accepted D113524: [lldb] Make TypeSystemClang work with redeclarations.
Wed, Nov 10, 11:12 AM · Restricted Project
aprantl requested review of D113573: Add a (nonfunctional) -dyld_info flag to llvm-objdump..
Wed, Nov 10, 9:02 AM · Restricted Project

Tue, Nov 9

aprantl committed rG68a4d179c2ac: Use yaml2obj instead of relying on invoking the Darwin system assembler. (authored by aprantl).
Use yaml2obj instead of relying on invoking the Darwin system assembler.
Tue, Nov 9, 10:48 AM
aprantl committed rG56f7da6e0d29: Add a requires line to test. (authored by aprantl).
Add a requires line to test.
Tue, Nov 9, 10:16 AM
aprantl committed rGc9881c7d99c6: Support looking up absolute symbols (authored by aprantl).
Support looking up absolute symbols
Tue, Nov 9, 9:45 AM
aprantl closed D113445: Support looking up absolute symbols.
Tue, Nov 9, 9:45 AM · Restricted Project

Mon, Nov 8

aprantl requested review of D113445: Support looking up absolute symbols.
Mon, Nov 8, 5:32 PM · Restricted Project

Nov 8 2021

aprantl committed rGfae440974a69: Attempt to work around type checking error on older compilers (authored by aprantl).
Attempt to work around type checking error on older compilers
Nov 8 2021, 12:42 PM
aprantl committed rG8bd8dd16e22b: Extend obj2yaml to optionally preserve raw __LINKEDIT/__DATA segments. (authored by aprantl).
Extend obj2yaml to optionally preserve raw __LINKEDIT/__DATA segments.
Nov 8 2021, 11:30 AM
aprantl closed D113234: Extend obj2yaml to optionally preserve raw __LINKEDIT/__DATA segments..
Nov 8 2021, 11:30 AM · Restricted Project

Nov 5 2021

aprantl added inline comments to D113234: Extend obj2yaml to optionally preserve raw __LINKEDIT/__DATA segments..
Nov 5 2021, 2:25 PM · Restricted Project
aprantl updated the diff for D113234: Extend obj2yaml to optionally preserve raw __LINKEDIT/__DATA segments..

Indeed. I forgot to git-add the file!

Nov 5 2021, 1:58 PM · Restricted Project
aprantl updated the diff for D113234: Extend obj2yaml to optionally preserve raw __LINKEDIT/__DATA segments..

Generalize command line options to use a bitvector to list all raw segments.

Nov 5 2021, 1:45 PM · Restricted Project
aprantl updated subscribers of D113234: Extend obj2yaml to optionally preserve raw __LINKEDIT/__DATA segments..
Nov 5 2021, 12:03 PM · Restricted Project
aprantl added a comment to D106585: Fix clang debug info irgen of i128 enums.

This broke determinism when building Firefox.

Nov 5 2021, 11:04 AM · Restricted Project, Restricted Project
aprantl added inline comments to D113234: Extend obj2yaml to optionally preserve raw __LINKEDIT/__DATA segments..
Nov 5 2021, 8:36 AM · Restricted Project
aprantl updated the diff for D113234: Extend obj2yaml to optionally preserve raw __LINKEDIT/__DATA segments..

Put function into inline namespace.

Nov 5 2021, 8:35 AM · Restricted Project
aprantl added a reviewer for D113234: Extend obj2yaml to optionally preserve raw __LINKEDIT/__DATA segments.: alexander-shaposhnikov.
Nov 5 2021, 8:23 AM · Restricted Project

Nov 4 2021

aprantl requested review of D113234: Extend obj2yaml to optionally preserve raw __LINKEDIT/__DATA segments..
Nov 4 2021, 6:38 PM · Restricted Project

Nov 2 2021

aprantl accepted D112945: [lldb] Improve error reporting in `lang objc tagged-pointer info`.

Excellent, thanks!

Nov 2 2021, 1:16 PM · Restricted Project
aprantl accepted D113011: [lldb] make the code prettier in FindFileTest.cpp.
Nov 2 2021, 10:30 AM · Restricted Project

Nov 1 2021

aprantl accepted D112439: normalize file path when searching the source map.

Hi, @aprantl

I've submitted a NFC patch here:
https://reviews.llvm.org/D112863

Seems that patch can't build by CI because it is based on this patch. In my understanding we need to merge this patch firstly and rebase that NFC patch to let CI work, right?

Nov 1 2021, 3:59 PM · Restricted Project
aprantl accepted D112863: [lldb][NFC] avoid unnecessary roundtrips between different string types.

Thank you!

Nov 1 2021, 3:58 PM · Restricted Project
aprantl added inline comments to D112945: [lldb] Improve error reporting in `lang objc tagged-pointer info`.
Nov 1 2021, 2:11 PM · Restricted Project
aprantl added a comment to D112945: [lldb] Improve error reporting in `lang objc tagged-pointer info`.

This is great, thanks! (one question inline)

Nov 1 2021, 2:09 PM · Restricted Project

Oct 29 2021

aprantl added inline comments to D112439: normalize file path when searching the source map.
Oct 29 2021, 11:32 AM · Restricted Project
aprantl accepted D112615: [lldb] Make SBType::IsTypeComplete more consistent by forcing the loading of definitions.
Oct 29 2021, 11:24 AM · Restricted Project
aprantl accepted D112250: Support: Reduce stats in fs::copy_file on Darwin.

Nice!

Oct 29 2021, 11:04 AM · Restricted Project
aprantl accepted D111477: DO NOT SUBMIT: workaround for context-sensitive use of non-type-template-parameter integer suffixes.

I think this is fine.

Oct 29 2021, 11:01 AM · Restricted Project, Restricted Project
aprantl added a reviewer for D111477: DO NOT SUBMIT: workaround for context-sensitive use of non-type-template-parameter integer suffixes: shafik.
Oct 29 2021, 11:01 AM · Restricted Project, Restricted Project
aprantl accepted D112165: Cleanup a few more PR36048 skips.

Nice!

Oct 29 2021, 10:53 AM · Restricted Project

Oct 27 2021

aprantl added a comment to D112676: [lldb] The os and version are not separate components in the triple.

thanks!

Oct 27 2021, 4:39 PM · Restricted Project
aprantl accepted D112676: [lldb] The os and version are not separate components in the triple.

Yup that's wrong. Personally I would only append env to the list if non-empty. Thanks!

Oct 27 2021, 4:18 PM · Restricted Project
aprantl accepted D112662: [lldb] Fixup code addresses in the Objective-C language runtime.

This is all good of course, but I wonder if we should lift this into the type system and have functions returned a UnstrippedAddress type that you can only turn into an addr_t by calling FixCodeAddress.

Oct 27 2021, 1:51 PM · Restricted Project

Oct 22 2021

aprantl accepted D111770: [DebugInfo] Skip ODRUniquing for mismatched tags.

From a pragmatic point of view this seems to make sense to me.

Oct 22 2021, 11:04 AM · Restricted Project

Oct 18 2021

aprantl accepted D111920: Test untested variants of BreakpointCreateBySourceRegex.
Oct 18 2021, 8:46 AM · Restricted Project

Oct 15 2021

aprantl accepted D111809: [DebugInfo] Correctly handle arrays with 0-width elements in GEP salvaging.
Oct 15 2021, 11:22 AM · Restricted Project, debug-info
aprantl accepted D111632: [lldb] Split ParseSingleMember into Obj-C property and normal member/ivar parsing code..
Oct 15 2021, 11:20 AM · Restricted Project
aprantl accepted D111404: [DebugInfo][ARM] Fix incorrect debug information for RWPI accessed globals.

Looks reasonable.

Oct 15 2021, 11:18 AM · Restricted Project

Oct 14 2021

aprantl added a comment to D111816: [lldb] Remove logging from Platform::~Platform.

Thanks!

Oct 14 2021, 9:50 AM · Restricted Project

Oct 11 2021

aprantl accepted D109217: [llvm-dwarfdump] Fix unsigned overflow when calculating stats.

Ok. Works for me.

Oct 11 2021, 10:01 AM · Restricted Project, debug-info

Oct 8 2021

aprantl committed rZORG66f091ff8a67: Put a temporary workaround in place for codesigning on the green-dragon-04… (authored by aprantl).
Put a temporary workaround in place for codesigning on the green-dragon-04…
Oct 8 2021, 3:48 PM

Oct 7 2021

aprantl added a comment to D109217: [llvm-dwarfdump] Fix unsigned overflow when calculating stats.

I think this is reasonable, out of curiosity, would there be a benefit to using APInt? Probably not because 64 bits is already huge...

Oct 7 2021, 2:13 PM · Restricted Project, debug-info
aprantl committed rG9f93f2bfbd3f: Do not emit prologue_end for line 0 locs if there is a non-zero loc present (authored by aprantl).
Do not emit prologue_end for line 0 locs if there is a non-zero loc present
Oct 7 2021, 1:55 PM
aprantl committed rG4651576edd09: Recognize the Swift compiler in DW_AT_producer (authored by aprantl).
Recognize the Swift compiler in DW_AT_producer
Oct 7 2021, 1:55 PM
aprantl closed D110740: Do not emit prologue_end for line 0 locs if there is a non-zero loc present.
Oct 7 2021, 1:54 PM · Restricted Project, debug-info
aprantl closed D111278: Recognize the Swift compiler in DW_AT_producer.
Oct 7 2021, 1:54 PM · Restricted Project
aprantl accepted D111339: [lldb] Parse and display reporting errors from JSON crashlogs.

sgtm

Oct 7 2021, 12:57 PM · Restricted Project
aprantl accepted D111341: [lldb] Support missing threadState in JSON crashlogs.
Oct 7 2021, 12:54 PM · Restricted Project
aprantl updated the diff for D111278: Recognize the Swift compiler in DW_AT_producer.

Const.

Oct 7 2021, 12:52 PM · Restricted Project
aprantl added inline comments to D111278: Recognize the Swift compiler in DW_AT_producer.
Oct 7 2021, 12:51 PM · Restricted Project
aprantl added inline comments to D111278: Recognize the Swift compiler in DW_AT_producer.
Oct 7 2021, 12:49 PM · Restricted Project

Oct 6 2021

aprantl updated the diff for D111278: Recognize the Swift compiler in DW_AT_producer.

Sort variables in a more logical order.

Oct 6 2021, 3:01 PM · Restricted Project
aprantl requested review of D111278: Recognize the Swift compiler in DW_AT_producer.
Oct 6 2021, 2:59 PM · Restricted Project
aprantl committed rG8c5f3348af38: Add a unit test for llvm-gcc producer strings and cleanup code. (NFC) (authored by aprantl).
Add a unit test for llvm-gcc producer strings and cleanup code. (NFC)
Oct 6 2021, 2:57 PM
aprantl committed rG2edb9058ea63: Simplify control flow (NFC) (authored by aprantl).
Simplify control flow (NFC)
Oct 6 2021, 2:57 PM
aprantl committed rG14aa3f3703b5: Use llvm::VersionTuple to store DWARF producer info (NFC) (authored by aprantl).
Use llvm::VersionTuple to store DWARF producer info (NFC)
Oct 6 2021, 2:56 PM
aprantl closed D111200: Use llvm::VersionTuple to store DWARF producer info (NFC).
Oct 6 2021, 2:56 PM · Restricted Project