[clang][Sema] Compare SourceLocations directly [NFCI]

[miyuki]

Summary

The ordered comparison operators are defined for the SourceLocation
class, so SourceLocation objects can be compared directly. There is no
need to extract the internal representation for comparison.

[aprantl]

Based on your explanation, this seems good. Thanks!

clang/lib/Sema/SemaDecl.cpp

if (Result.getAmbiguityKind() == LookupResult::AmbiguousTagHiding) {
       return nullptr;
     }
 
     // Look to see if we have a type anywhere in the list of results.
     for (LookupResult::iterator Res = Result.begin(), ResEnd = Result.end();
          Res != ResEnd; ++Res) {
       if (isa<TypeDecl>(*Res) || isa<ObjCInterfaceDecl>(*Res) ||
           (AllowDeducedTemplate && getAsTypeTemplateDecl(*Res))) {
-        if (!IIDecl ||
-            (*Res)->getLocation().getRawEncoding() <
-              IIDecl->getLocation().getRawEncoding())
+        if (!IIDecl || (*Res)->getLocation() < IIDecl->getLocation())
           IIDecl = *Res;
       }
     }
 
     if (!IIDecl) {
       // None of the entities we found is a type, so there is no way
       // to even assume that the result is a type. In this case, don't
       // complain about the ambiguity. The parser will either try to

clang/lib/Sema/SemaStmt.cpp

 /// CmpCaseVals - Comparison predicate for sorting case values.
 ///
 static bool CmpCaseVals(const std::pair<llvm::APSInt, CaseStmt*>& lhs,
                         const std::pair<llvm::APSInt, CaseStmt*>& rhs) {
   if (lhs.first < rhs.first)
     return true;
 
   if (lhs.first == rhs.first &&
-      lhs.second->getCaseLoc().getRawEncoding()
-       < rhs.second->getCaseLoc().getRawEncoding())
+      lhs.second->getCaseLoc() < rhs.second->getCaseLoc())
     return true;
   return false;
 }
 
 /// CmpEnumVals - Comparison predicate for sorting enumeration values.
 ///
 static bool CmpEnumVals(const std::pair<llvm::APSInt, EnumConstantDecl*>& lhs,
                         const std::pair<llvm::APSInt, EnumConstantDecl*>& rhs)