Page MenuHomePhabricator

miyuki (Mikhail Maltsev)
User

Projects

User does not belong to any projects.

User Details

User Since
Nov 6 2017, 10:05 AM (167 w, 4 d)

Recent Activity

Today

miyuki committed rGa0e30914f8c8: [clang][Tooling] Get rid of a hack in SymbolOccurrences, NFCI (authored by miyuki).
[clang][Tooling] Get rid of a hack in SymbolOccurrences, NFCI
Fri, Jan 22, 5:02 AM
miyuki closed D94599: [clang][Tooling] Get rid of a hack in SymbolOccurrences, NFCI.
Fri, Jan 22, 5:02 AM · Restricted Project

Wed, Jan 20

miyuki added a comment to D94596: [clang][AST] Encapsulate DeclarationNameLoc, NFCI.

ping

Wed, Jan 20, 1:43 AM · Restricted Project

Tue, Jan 19

miyuki updated the diff for D94599: [clang][Tooling] Get rid of a hack in SymbolOccurrences, NFCI.

Added static_asserts that check that SourceRange and SourceLocation are trivially destructible.

Tue, Jan 19, 10:52 AM · Restricted Project
miyuki added a comment to D94599: [clang][Tooling] Get rid of a hack in SymbolOccurrences, NFCI.

I will wait until the end of this week to see if anyone has objections.

Tue, Jan 19, 3:20 AM · Restricted Project

Thu, Jan 14

miyuki committed rG176f5e95e1af: [clang-tidy] Use DenseSet<SourceLocation> in UpgradeDurationConversionsCheck… (authored by miyuki).
[clang-tidy] Use DenseSet<SourceLocation> in UpgradeDurationConversionsCheck…
Thu, Jan 14, 5:50 AM
miyuki closed D94601: [clang-tidy] Use DenseSet<SourceLocation> in UpgradeDurationConversionsCheck, NFCI.
Thu, Jan 14, 5:50 AM · Restricted Project, Restricted Project
miyuki added a comment to D94237: [clang] Use SourceLocations in unions [NFCI].

This revision was landed with ongoing or failed builds.

Thu, Jan 14, 2:59 AM · Restricted Project
miyuki committed rG17f8c458de63: [clang] Use SourceLocations in unions [NFCI] (authored by miyuki).
[clang] Use SourceLocations in unions [NFCI]
Thu, Jan 14, 2:57 AM
miyuki closed D94237: [clang] Use SourceLocations in unions [NFCI].
Thu, Jan 14, 2:57 AM · Restricted Project

Wed, Jan 13

miyuki updated the diff for D94237: [clang] Use SourceLocations in unions [NFCI].

Refactored SLocEntry in a similar way.

Wed, Jan 13, 8:38 AM · Restricted Project
miyuki requested review of D94601: [clang-tidy] Use DenseSet<SourceLocation> in UpgradeDurationConversionsCheck, NFCI.
Wed, Jan 13, 7:20 AM · Restricted Project, Restricted Project
miyuki requested review of D94599: [clang][Tooling] Get rid of a hack in SymbolOccurrences, NFCI.
Wed, Jan 13, 7:03 AM · Restricted Project
miyuki abandoned D69903: [Basic] Introduce PODSourceLocation, NFCI.

Abandoning in favor of D94237 and D94596.

Wed, Jan 13, 6:09 AM · Restricted Project
miyuki requested review of D94596: [clang][AST] Encapsulate DeclarationNameLoc, NFCI.
Wed, Jan 13, 6:04 AM · Restricted Project
miyuki added a reviewer for D94237: [clang] Use SourceLocations in unions [NFCI]: faisalv.
Wed, Jan 13, 4:48 AM · Restricted Project
miyuki added a comment to D94237: [clang] Use SourceLocations in unions [NFCI].

Do you need to run the destructor before placement new in these situations?

Wed, Jan 13, 2:46 AM · Restricted Project

Tue, Jan 12

miyuki committed rGc1e08f0073e3: [clang][AST] Get rid of an alignment hack in DeclObjC.h [NFCI] (authored by miyuki).
[clang][AST] Get rid of an alignment hack in DeclObjC.h [NFCI]
Tue, Jan 12, 2:23 AM
miyuki closed D94224: [clang][AST] Get rid of an alignment hack in DeclObjC.h [NFCI].
Tue, Jan 12, 2:22 AM · Restricted Project

Mon, Jan 11

miyuki updated the diff for D94237: [clang] Use SourceLocations in unions [NFCI].

Fixed a typo in the word "implicit"

Mon, Jan 11, 4:39 AM · Restricted Project
miyuki added inline comments to D94224: [clang][AST] Get rid of an alignment hack in DeclObjC.h [NFCI].
Mon, Jan 11, 2:31 AM · Restricted Project

Sat, Jan 9

miyuki updated the diff for D94224: [clang][AST] Get rid of an alignment hack in DeclObjC.h [NFCI].

Removed alignas

Sat, Jan 9, 7:52 AM · Restricted Project
miyuki committed rG9f76788b0930: [clang][Sema] Compare SourceLocations directly [NFCI] (authored by miyuki).
[clang][Sema] Compare SourceLocations directly [NFCI]
Sat, Jan 9, 6:13 AM
miyuki closed D94231: [clang][Sema] Compare SourceLocations directly [NFCI].
Sat, Jan 9, 6:13 AM · Restricted Project

Thu, Jan 7

miyuki retitled D94237: [clang] Use SourceLocations in unions [NFCI] from [clang] Use SourceLocations in unions to [clang] Use SourceLocations in unions [NFCI].
Thu, Jan 7, 8:49 AM · Restricted Project
miyuki requested review of D94237: [clang] Use SourceLocations in unions [NFCI].
Thu, Jan 7, 8:48 AM · Restricted Project
miyuki updated the diff for D94224: [clang][AST] Get rid of an alignment hack in DeclObjC.h [NFCI].

Fixed formatting.

Thu, Jan 7, 5:44 AM · Restricted Project
miyuki requested review of D94231: [clang][Sema] Compare SourceLocations directly [NFCI].
Thu, Jan 7, 5:38 AM · Restricted Project
miyuki committed rG7da3e3a8983a: [libcxx] Mark a test as unsupported for C++03 (authored by miyuki).
[libcxx] Mark a test as unsupported for C++03
Thu, Jan 7, 4:06 AM
miyuki closed D93941: [libcxx] Mark a test as unsupported for C++03.
Thu, Jan 7, 4:06 AM · Restricted Project
miyuki requested review of D94224: [clang][AST] Get rid of an alignment hack in DeclObjC.h [NFCI].
Thu, Jan 7, 4:00 AM · Restricted Project

Mon, Jan 4

miyuki added a reviewer for D93941: [libcxx] Mark a test as unsupported for C++03: EricWF.
Mon, Jan 4, 2:33 AM · Restricted Project

Wed, Dec 30

miyuki requested review of D93941: [libcxx] Mark a test as unsupported for C++03.
Wed, Dec 30, 4:25 AM · Restricted Project

Dec 10 2020

miyuki added inline comments to D93022: [ARM][AArch64] Add Cortex-A78C Support for Clang and LLVM.
Dec 10 2020, 4:27 AM · Restricted Project, Restricted Project

Dec 3 2020

miyuki added a comment to D92543: Switch to std::is_trivially_move_constructible and std::is_trivially_copy_constructible.

Hi @MaskRay, this commit broke our builds which use GCC 7.3. I've posted some comments in D92591, but have just realized that it probably was not the right place. Could you please fix the breakage?

Dec 3 2020, 11:44 AM · Restricted Project

Nov 2 2020

miyuki abandoned D90615: [libunwind] Add missing #include <alloca.h>.
Nov 2 2020, 8:29 AM · Restricted Project, Restricted Project
miyuki added a comment to D90615: [libunwind] Add missing #include <alloca.h>.

I guess I'll leave it in our downstream version then.

Nov 2 2020, 8:28 AM · Restricted Project, Restricted Project
miyuki updated the summary of D90615: [libunwind] Add missing #include <alloca.h>.
Nov 2 2020, 7:52 AM · Restricted Project, Restricted Project
miyuki requested review of D90615: [libunwind] Add missing #include <alloca.h>.
Nov 2 2020, 7:52 AM · Restricted Project, Restricted Project

Oct 27 2020

miyuki committed rG443ab4d2e012: [clang][Basic] Integrate SourceLocation with FoldingSet, NFCI (authored by miyuki).
[clang][Basic] Integrate SourceLocation with FoldingSet, NFCI
Oct 27 2020, 3:44 AM
miyuki closed D69844: [clang][Basic] Integrate SourceLocation with FoldingSet, NFCI.
Oct 27 2020, 3:44 AM · Restricted Project

Oct 26 2020

miyuki added inline comments to D69844: [clang][Basic] Integrate SourceLocation with FoldingSet, NFCI.
Oct 26 2020, 6:57 AM · Restricted Project

Oct 23 2020

miyuki updated the diff for D69844: [clang][Basic] Integrate SourceLocation with FoldingSet, NFCI.

Fixed linter errors.

Oct 23 2020, 3:44 AM · Restricted Project

Oct 22 2020

miyuki updated the diff for D69844: [clang][Basic] Integrate SourceLocation with FoldingSet, NFCI.

Reverted the accidentally removed chunk.

Oct 22 2020, 11:10 AM · Restricted Project
miyuki updated the diff for D69844: [clang][Basic] Integrate SourceLocation with FoldingSet, NFCI.

Addressed review comments

Oct 22 2020, 11:02 AM · Restricted Project

Oct 20 2020

miyuki added a comment to D69903: [Basic] Introduce PODSourceLocation, NFCI.

An alternative would be to update the unions to an AlignedCharArrayUnion and use SourceLocation directly. WDYT?

Oct 20 2020, 9:13 AM · Restricted Project
miyuki committed rG781941183700: [clang] Use SourceLocation as key in hash maps, NFCI (authored by miyuki).
[clang] Use SourceLocation as key in hash maps, NFCI
Oct 20 2020, 8:25 AM
miyuki closed D69840: [clang] Use SourceLocation as key in hash maps, NFCI.
Oct 20 2020, 8:24 AM · Restricted Project
miyuki committed rG234c47ae2a8e: [clang][Basic] Make SourceLocation usable as key in hash maps, NFCI (authored by miyuki).
[clang][Basic] Make SourceLocation usable as key in hash maps, NFCI
Oct 20 2020, 7:53 AM
miyuki closed D89719: [clang][Basic] Make SourceLocation usable as key in hash maps, NFCI.
Oct 20 2020, 7:53 AM · Restricted Project
miyuki added a comment to D89719: [clang][Basic] Make SourceLocation usable as key in hash maps, NFCI.

The test failure is unrelated (see D89463)

Oct 20 2020, 7:52 AM · Restricted Project
miyuki updated the diff for D89719: [clang][Basic] Make SourceLocation usable as key in hash maps, NFCI.

Added an example of usage.

Oct 20 2020, 5:11 AM · Restricted Project

Oct 19 2020

miyuki updated the diff for D69840: [clang] Use SourceLocation as key in hash maps, NFCI.

Split out the refactoring part.

Oct 19 2020, 12:19 PM · Restricted Project
miyuki retitled D69840: [clang] Use SourceLocation as key in hash maps, NFCI from [Basic] Make SourceLocation usable as key in hash maps, NFCI to [clang] Use SourceLocation as key in hash maps, NFCI.
Oct 19 2020, 11:42 AM · Restricted Project
miyuki requested review of D89719: [clang][Basic] Make SourceLocation usable as key in hash maps, NFCI.
Oct 19 2020, 11:31 AM · Restricted Project
miyuki committed rGa3c16039b3f1: [clang] Use SourceLocation as key in std::map, NFCI (authored by miyuki).
[clang] Use SourceLocation as key in std::map, NFCI
Oct 19 2020, 10:31 AM
miyuki closed D89705: [clang] Use SourceLocation as key in std::map, NFCI.
Oct 19 2020, 10:31 AM · Restricted Project
miyuki added a comment to D69840: [clang] Use SourceLocation as key in hash maps, NFCI.

Yes, I am still interested in working on this. For now, I've split out some changes that don't require any modifications in SourceLocation into https://reviews.llvm.org/D89705.

A general comment is that there are a couple of functional changes in this patch, where hash values are changing and data structures are being changed, but they're buried in the noise of the refactoring that's going on at the same time. I suggest splitting this up at least into two

Will do.

Oct 19 2020, 8:40 AM · Restricted Project
miyuki requested review of D89705: [clang] Use SourceLocation as key in std::map, NFCI.
Oct 19 2020, 8:36 AM · Restricted Project

Oct 1 2020

miyuki added a comment to D86704: [libcxx] Add testing infrastructure for EXTERNAL_THREAD_API mode.

Customization allows storing data of OS structures such as mutexes and threads in-place, thus avoiding the need for additional dynamic memory allocations, this is important in embedded environments.

Oct 1 2020, 5:50 AM · Restricted Project

Sep 30 2020

miyuki added a comment to D86704: [libcxx] Add testing infrastructure for EXTERNAL_THREAD_API mode.

Given this new setup where build bots are checked into the repo, I think adding a bot that test this configuration would be a good way of making sure this doesn't regress. What do you think?

Yes, setting up a build bot is part of my original plan. I will be on holiday for the next two weeks, but I do plan to continue working on this after returning.

Is there a reason why your platform can't simply provide the pthread or the C11 threading APIs, and libc++ has to provide this bridge instead?

The original intent of the external threading API was to make it usable with bare-metal real-time OS-es which tend not to have POSIX or POSIX-like APIs. For example, __libcpp_mutex_t can include the OS structure representing a mutex, instead of allocating it elsewhere.

Sep 30 2020, 9:10 AM · Restricted Project

Sep 29 2020

miyuki added a comment to D86704: [libcxx] Add testing infrastructure for EXTERNAL_THREAD_API mode.

@ldionne, do you have any thoughts on how we might progress this forward?

Sep 29 2020, 10:58 AM · Restricted Project
miyuki commandeered D86704: [libcxx] Add testing infrastructure for EXTERNAL_THREAD_API mode.
Sep 29 2020, 10:57 AM · Restricted Project

Sep 28 2020

miyuki committed rG07b7a24e3fe8: [unittests] Preserve LD_LIBRARY_PATH in crash recovery test (authored by miyuki).
[unittests] Preserve LD_LIBRARY_PATH in crash recovery test
Sep 28 2020, 9:46 AM
miyuki closed D88308: [unittests] Preserve LD_LIBRARY_PATH in crash recovery test.
Sep 28 2020, 9:46 AM · Restricted Project
miyuki added inline comments to D88308: [unittests] Preserve LD_LIBRARY_PATH in crash recovery test.
Sep 28 2020, 9:37 AM · Restricted Project
miyuki updated the diff for D88308: [unittests] Preserve LD_LIBRARY_PATH in crash recovery test.

Use setenv in the parent process

Sep 28 2020, 9:37 AM · Restricted Project

Sep 25 2020

miyuki added a comment to D88308: [unittests] Preserve LD_LIBRARY_PATH in crash recovery test.

In our case, the child process fails to find the correct version of libstdc++ and exits with return code 1, ASSERT_EQ(-2, RetCode) fails.

Sep 25 2020, 8:28 AM · Restricted Project
miyuki requested review of D88308: [unittests] Preserve LD_LIBRARY_PATH in crash recovery test.
Sep 25 2020, 8:07 AM · Restricted Project

Sep 24 2020

miyuki committed rG8cc842a95072: [clang][Sema] Use enumerator instead of hard-coded constant (authored by miyuki).
[clang][Sema] Use enumerator instead of hard-coded constant
Sep 24 2020, 2:24 AM
miyuki closed D88164: [clang][Sema] Use enumerator instead of hard-coded constant.
Sep 24 2020, 2:24 AM · Restricted Project

Sep 23 2020

miyuki requested review of D88164: [clang][Sema] Use enumerator instead of hard-coded constant.
Sep 23 2020, 9:51 AM · Restricted Project

Sep 11 2020

miyuki added a comment to rGfc4bff0cd37f: Update atomic feature macros, synopsis, signatures to match C++20. Improve test….

Thanks!

Sep 11 2020, 10:17 AM
miyuki closed D87508: [libcxx] Handle target triples with dashes in platform name.
Sep 11 2020, 7:41 AM · Restricted Project
miyuki added a comment to rGfc4bff0cd37f: Update atomic feature macros, synopsis, signatures to match C++20. Improve test….

Hi Olivier,
Prior versions of the C++ standard (11, 14, 17) required more specialized templates for atomic_fetch_{add,sub}[_explicit] for pointers. E.g.:

template <class T>
T atomic_fetch_add(atomic<T>*, T) noexcept;
template <class T>
T* atomic_fetch_add(atomic<T*>*, ptrdiff_t) noexcept;

Implementing them as a single template breaks the following code (when compiled as C++17):

#include <atomic>
Sep 11 2020, 7:24 AM
miyuki requested review of D87508: [libcxx] Handle target triples with dashes in platform name.
Sep 11 2020, 4:47 AM · Restricted Project

Sep 1 2020

miyuki added a comment to D86598: [libcxx] Fix compile for BUILD_EXTERNAL_THREAD_LIBRARY.

I've just committed D86773

Sep 1 2020, 4:48 AM · Restricted Project
miyuki committed rG722db5c0b4e8: [libcxx] Link target `cxx_external_threads` to `cxx-headers` for… (authored by Nicu).
[libcxx] Link target `cxx_external_threads` to `cxx-headers` for…
Sep 1 2020, 4:44 AM
miyuki closed D86773: [libcxx] Link target `cxx_external_threads` to `cxx-headers` for BUILD_EXTERNAL_THREAD_LIBRARY.
Sep 1 2020, 4:44 AM · Restricted Project

Aug 28 2020

miyuki added a comment to D86598: [libcxx] Fix compile for BUILD_EXTERNAL_THREAD_LIBRARY.

Thanks!

Aug 28 2020, 3:20 AM · Restricted Project

Aug 27 2020

miyuki committed rG433f2680c979: [ARM][BFloat16] Change types of some Arm and AArch64 bf16 intrinsics (authored by miyuki).
[ARM][BFloat16] Change types of some Arm and AArch64 bf16 intrinsics
Aug 27 2020, 10:55 AM
miyuki committed rGae1396c7d4d8: [ARM][BFloat16] Change types of some Arm and AArch64 bf16 intrinsics (authored by miyuki).
[ARM][BFloat16] Change types of some Arm and AArch64 bf16 intrinsics
Aug 27 2020, 10:44 AM
miyuki closed D86146: [ARM][BFloat16] Change types of some Arm and AArch64 bf16 intrinsics.
Aug 27 2020, 10:44 AM · Restricted Project, Restricted Project
miyuki updated the diff for D86146: [ARM][BFloat16] Change types of some Arm and AArch64 bf16 intrinsics.

Small refactoring of bitcode updater tests (use some-name.ll.bc names for bitcode files in order to be able to refer to them as %s.bc from some-name.ll)

Aug 27 2020, 9:50 AM · Restricted Project, Restricted Project
miyuki added inline comments to D86146: [ARM][BFloat16] Change types of some Arm and AArch64 bf16 intrinsics.
Aug 27 2020, 9:09 AM · Restricted Project, Restricted Project
miyuki added a comment to D86598: [libcxx] Fix compile for BUILD_EXTERNAL_THREAD_LIBRARY.

Sorry about that. I've reverted the change and will investigate.

Aug 27 2020, 8:49 AM · Restricted Project
miyuki added a reverting change for rG3b71f91558ff: [libcxx] Fix compile for BUILD_EXTERNAL_THREAD_LIBRARY: rGa19fd1aab519: Revert "[libcxx] Fix compile for BUILD_EXTERNAL_THREAD_LIBRARY".
Aug 27 2020, 8:49 AM
miyuki committed rGa19fd1aab519: Revert "[libcxx] Fix compile for BUILD_EXTERNAL_THREAD_LIBRARY" (authored by miyuki).
Revert "[libcxx] Fix compile for BUILD_EXTERNAL_THREAD_LIBRARY"
Aug 27 2020, 8:48 AM
miyuki added a reverting change for D86598: [libcxx] Fix compile for BUILD_EXTERNAL_THREAD_LIBRARY: rGa19fd1aab519: Revert "[libcxx] Fix compile for BUILD_EXTERNAL_THREAD_LIBRARY".
Aug 27 2020, 8:48 AM · Restricted Project
miyuki committed rG3b71f91558ff: [libcxx] Fix compile for BUILD_EXTERNAL_THREAD_LIBRARY (authored by Nicu).
[libcxx] Fix compile for BUILD_EXTERNAL_THREAD_LIBRARY
Aug 27 2020, 8:25 AM
miyuki closed D86598: [libcxx] Fix compile for BUILD_EXTERNAL_THREAD_LIBRARY.
Aug 27 2020, 8:25 AM · Restricted Project
miyuki added inline comments to D86704: [libcxx] Add testing infrastructure for EXTERNAL_THREAD_API mode.
Aug 27 2020, 8:20 AM · Restricted Project
miyuki committed rG23d5e93f342e: [AArch64] Optimize instruction selection for certain vector shuffles (authored by miyuki).
[AArch64] Optimize instruction selection for certain vector shuffles
Aug 27 2020, 3:07 AM
miyuki closed D86225: [AArch64] Optimize instruction selection for certain vector shuffles.
Aug 27 2020, 3:07 AM · Restricted Project

Aug 26 2020

miyuki updated the diff for D86146: [ARM][BFloat16] Change types of some Arm and AArch64 bf16 intrinsics.
  1. Also update bfdot
  2. Add auto-upgrade for old intrinsics
Aug 26 2020, 12:11 PM · Restricted Project, Restricted Project
miyuki updated the diff for D86225: [AArch64] Optimize instruction selection for certain vector shuffles.

Cast to the correct type

Aug 26 2020, 11:13 AM · Restricted Project
miyuki added a reviewer for D86599: [libcxx] Add cmake cache file for BUILD_EXTERNAL_THREAD_LIBRARY: miyuki.
Aug 26 2020, 5:56 AM · Restricted Project
miyuki added a reviewer for D86599: [libcxx] Add cmake cache file for BUILD_EXTERNAL_THREAD_LIBRARY: ldionne.
Aug 26 2020, 5:55 AM · Restricted Project
miyuki added inline comments to D86598: [libcxx] Fix compile for BUILD_EXTERNAL_THREAD_LIBRARY.
Aug 26 2020, 5:54 AM · Restricted Project
miyuki added reviewers for D86598: [libcxx] Fix compile for BUILD_EXTERNAL_THREAD_LIBRARY: ldionne, miyuki.
Aug 26 2020, 5:51 AM · Restricted Project