Page MenuHomePhabricator
Differential D92447

[flang][openacc] Add clause validity tests for the update directive
ClosedPublic
Actions

Authored by clementval on Dec 1 2020, 7:03 PM.

Details

Reviewers
sscalpone
kiranktp
SouraVX
kiranchandramohan
sameeranjoshi
Commits
rG1dd24e6ab7a7: [flang][openacc] Add clause validity tests for the update directive
rGe46065433466: [flang][openacc] Add clause validity tests for the update directive
Summary

Add couple of clause validity tests for the update directive and check for
the restriction where at least self, host or device clause must appear on the directive.

Diff Detail

Event Timeline

clementval created this revision.Dec 1 2020, 7:03 PM
Herald added a project: Restricted Project. · View Herald TranscriptDec 1 2020, 7:03 PM
Herald added a subscriber: llvm-commits. · View Herald Transcript
clementval requested review of this revision.Dec 1 2020, 7:03 PM
clementval added a project: Restricted Project.Dec 1 2020, 7:04 PM
Herald added a subscriber: jdoerfert. · View Herald TranscriptDec 1 2020, 7:04 PM
Harbormaster completed remote builds in B80754: Diff 308840.Dec 1 2020, 7:21 PM
sameeranjoshi accepted this revision.Dec 4 2020, 8:40 AM

Looks Good Thanks.

This revision is now accepted and ready to land.Dec 4 2020, 8:40 AM
This revision was landed with ongoing or failed builds.Dec 4 2020, 11:39 AM
Closed by commit rGe46065433466: [flang][openacc] Add clause validity tests for the update directive (authored by clementval). · Explain Why
This revision was automatically updated to reflect the committed changes.
clementval added a commit: rGe46065433466: [flang][openacc] Add clause validity tests for the update directive.
clementval added a reverting change: rGf99e90f2c38b: Revert "[flang][openacc] Add clause validity tests for the update directive".Dec 4 2020, 12:06 PM
clementval reopened this revision.Dec 4 2020, 12:19 PM
This revision is now accepted and ready to land.Dec 4 2020, 12:19 PM
clementval updated this revision to Diff 309612.Dec 4 2020, 12:24 PM

Rebase

Harbormaster completed remote builds in B81142: Diff 309612.Dec 4 2020, 2:10 PM
clementval updated this revision to Diff 310071.Dec 7 2020, 6:39 PM

Revert to previous version after a bad rebase/update

Herald added a subscriber: mehdi_amini. · View Herald TranscriptDec 7 2020, 6:39 PM
Harbormaster completed remote builds in B81384: Diff 310071.Dec 7 2020, 7:18 PM
This revision was landed with ongoing or failed builds.Dec 8 2020, 7:47 AM
Closed by commit rG1dd24e6ab7a7: [flang][openacc] Add clause validity tests for the update directive (authored by clementval). · Explain Why
This revision was automatically updated to reflect the committed changes.
clementval added a commit: rG1dd24e6ab7a7: [flang][openacc] Add clause validity tests for the update directive.

Revision Contents
Changeset List

PathSize
flang/
include/
flang/
Parser/
1 line
6 lines
lib/
Lower/
19 lines
Parser/
15 lines
Semantics/
25 lines
test/
Semantics/
39 lines
llvm/
include/
llvm/
Frontend/
OpenACC/
3 lines

Diff 310213

View Options

flang/include/flang/Parser/dump-parse-tree.h

Loading...
View Options

flang/include/flang/Parser/parse-tree.h

Loading...
View Options

flang/lib/Lower/OpenACC.cpp

Loading...
View Options

flang/lib/Parser/openacc-parsers.cpp

Loading...
View Options

flang/lib/Semantics/check-acc-structure.cpp

Loading...
View Options

flang/test/Semantics/acc-clause-validity.f90

Loading...
View Options

llvm/include/llvm/Frontend/OpenACC/ACC.td

Loading...