Page MenuHomePhabricator

[libcxx] remove checks for __STDCPP_THREADS__ as it is defined by compiler
ClosedPublic

Authored by zequanwu on Nov 30 2020, 2:09 PM.

Diff Detail

Event Timeline

zequanwu created this revision.Nov 30 2020, 2:09 PM
Herald added a project: Restricted Project. · View Herald TranscriptNov 30 2020, 2:09 PM
Herald added a reviewer: Restricted Project. · View Herald Transcript
zequanwu requested review of this revision.Nov 30 2020, 2:09 PM
rnk added inline comments.Nov 30 2020, 2:42 PM
libcxx/include/__config
1159

Let's continue defining __STDCPP_THREADS__ if it's not defined. It's safe. It makes new libc++ work with old clang.

zequanwu updated this revision to Diff 308484.Nov 30 2020, 2:45 PM
zequanwu marked an inline comment as done.

address comment.

rnk accepted this revision.Nov 30 2020, 4:19 PM

Looks good, but change the commit message: you are changing libc++, not libc++abi.

This revision was not accepted when it landed; it landed in state Needs Review.Nov 30 2020, 4:37 PM
This revision was automatically updated to reflect the committed changes.
zequanwu retitled this revision from [libcxxabi] remove checks for __STDCPP_THREADS__ as it is defined by compiler to [libcxx] remove checks for __STDCPP_THREADS__ as it is defined by compiler.Nov 30 2020, 4:37 PM
ldionne added a subscriber: ldionne.Dec 1 2020, 8:31 AM

@zequanwu In the future, please refrain from committing to libc++ or libc++abi unless you have approval of the libcxx or libcxxabi review group. There's a reason why that group is added as a "blocking reviewer", it's because you should wait for it to be green before proceeding.

@zequanwu In the future, please refrain from committing to libc++ or libc++abi unless you have approval of the libcxx or libcxxabi review group. There's a reason why that group is added as a "blocking reviewer", it's because you should wait for it to be green before proceeding.

Okay.