Page MenuHomePhabricator

Mordante (Mark de Wever)
User

Projects

User does not belong to any projects.

User Details

User Since
May 10 2019, 9:08 AM (88 w, 2 d)

Recent Activity

Mon, Jan 11

Mordante added inline comments to D94409: [libc++] [C++2b] [P1048] Add is_scoped_enum and is_scoped_enum_v..
Mon, Jan 11, 11:37 AM · Restricted Project
Mordante added inline comments to D94409: [libc++] [C++2b] [P1048] Add is_scoped_enum and is_scoped_enum_v..
Mon, Jan 11, 10:46 AM · Restricted Project

Tue, Jan 5

Mordante added a comment to D93912: [libc++][P1679] add string contains.

The macro should be added to libcxx/utils/generate_feature_test_macro_components.py, then run the script to generate the proper macros and tests.

Thanks!
Should I check in the (changed) generated files?

Tue, Jan 5, 10:31 AM · Restricted Project
Mordante added a comment to D93912: [libc++][P1679] add string contains.

Where are the feature test macros defined?
__cpp_lib_string_contains should be added

Tue, Jan 5, 8:47 AM · Restricted Project

Tue, Dec 22

Mordante accepted D93582: [libc++] [libc++abi] Correctly quote source and target names in tests. NFC..

Thanks, LGTM.

Tue, Dec 22, 11:50 AM · Restricted Project, Restricted Project

Sun, Dec 20

Mordante added a comment to D93582: [libc++] [libc++abi] Correctly quote source and target names in tests. NFC..

One minor question, otherwise LGTM.

Sun, Dec 20, 4:59 AM · Restricted Project, Restricted Project
Mordante added a comment to D93593: [libc++][format] Add __format_arg_store..

It seems the CI build fails since it can't process the dependencies properly. I'll rebase and trigger an CI build once the dependencies have landed.

Sun, Dec 20, 4:44 AM · Restricted Project
Mordante requested review of D93593: [libc++][format] Add __format_arg_store..
Sun, Dec 20, 4:36 AM · Restricted Project
Mordante updated the diff for D93166: [libc++][format] Add basic_format_parse_context..

Replace a std:: with _VSTD::

Sun, Dec 20, 4:17 AM · Restricted Project

Sat, Dec 19

Mordante committed rG5740f96d8eed: [NFC][libc++] Fixes swapped comments. (authored by Mordante).
[NFC][libc++] Fixes swapped comments.
Sat, Dec 19, 7:17 AM

Dec 17 2020

Mordante requested review of D93461: [libc++] Implements concept default_initializable..
Dec 17 2020, 8:16 AM · Restricted Project
Mordante updated the diff for D93414: [libc++] Adds a make_string test helper function..

Improve the formatting as requested by @mclow.lists.
Disabled the automatic formatting to make sure the formatting won't be updated
automatically.

Dec 17 2020, 8:04 AM · Restricted Project
Mordante added a comment to D93414: [libc++] Adds a make_string test helper function..

Thanks for the review!

Dec 17 2020, 7:52 AM · Restricted Project

Dec 16 2020

Mordante updated the diff for D93414: [libc++] Adds a make_string test helper function..

Disable unit test when localization is disabled.

Dec 16 2020, 11:56 AM · Restricted Project
Mordante requested review of D93414: [libc++] Adds a make_string test helper function..
Dec 16 2020, 11:12 AM · Restricted Project

Dec 15 2020

Mordante added inline comments to D67086: Implement syncstream (p0053).
Dec 15 2020, 10:14 AM · Restricted Project
Mordante added a comment to D93283: [libcxx] Remove ifdefs in the message to static_assert. NFC..

LGTM, once it passes CI.

Dec 15 2020, 9:34 AM · Restricted Project
Mordante added inline comments to D93166: [libc++][format] Add basic_format_parse_context..
Dec 15 2020, 9:22 AM · Restricted Project
Mordante added inline comments to D92229: [libc++] Update clang-format configuration.
Dec 15 2020, 8:58 AM · Restricted Project

Dec 14 2020

Mordante added a comment to D92229: [libc++] Update clang-format configuration.

Do we need to discuss the wanted formatting in this patch or on Slack/dev-ml?

Dec 14 2020, 8:56 AM · Restricted Project
Mordante updated the diff for D93166: [libc++][format] Add basic_format_parse_context..

Addresses review comments.

Dec 14 2020, 7:32 AM · Restricted Project
Mordante added a comment to D93166: [libc++][format] Add basic_format_parse_context..

Thanks for the review!

Dec 14 2020, 7:09 AM · Restricted Project

Dec 12 2020

Mordante updated the diff for D93166: [libc++][format] Add basic_format_parse_context..

Fixes a GCC shadow warning.

Dec 12 2020, 12:06 PM · Restricted Project
Mordante requested review of D93166: [libc++][format] Add basic_format_parse_context..
Dec 12 2020, 11:04 AM · Restricted Project
Mordante updated the diff for D91004: [libc++] Implements concept destructible.

Rebased.

Dec 12 2020, 5:18 AM · Restricted Project
Mordante updated the diff for D90999: [libc++] Implements ranges::enable_borrowed_range.

Rebased.

Dec 12 2020, 5:11 AM · Restricted Project
Mordante updated the diff for D92214: [libc++] Implement format_error..

Rebased.

Dec 12 2020, 5:03 AM · Restricted Project

Dec 10 2020

Mordante added a comment to D92214: [libc++] Implement format_error..

@ldionne Can you have a look?

Dec 10 2020, 7:49 AM · Restricted Project

Dec 7 2020

Mordante added inline comments to D92730: [libc++] [LWG3221] Add tests for wrapping operator+(year_month, months)..
Dec 7 2020, 9:45 AM · Restricted Project

Dec 6 2020

Mordante added a comment to D92730: [libc++] [LWG3221] Add tests for wrapping operator+(year_month, months)..

A few minor nits, but otherwise LGTM.

Dec 6 2020, 11:58 AM · Restricted Project
Mordante added inline comments to D92725: [libc++] [LWG2993] reference_wrapper<T> conversion from U&&.
Dec 6 2020, 9:36 AM · Restricted Project
Mordante added inline comments to D92725: [libc++] [LWG2993] reference_wrapper<T> conversion from U&&.
Dec 6 2020, 7:58 AM · Restricted Project

Dec 5 2020

Mordante committed rGce6269f9ba6c: [NFC][libc++] Update C++20 issues status. (authored by Mordante).
[NFC][libc++] Update C++20 issues status.
Dec 5 2020, 7:38 AM
Mordante committed rGf687b4ac84a3: [NFC][clang-tidy] Fixes comment typos. (authored by Mordante).
[NFC][clang-tidy] Fixes comment typos.
Dec 5 2020, 7:32 AM

Dec 3 2020

Mordante updated the diff for D91004: [libc++] Implements concept destructible.

Implement all new header tests as suggested by @curdeius in D92214.

Dec 3 2020, 9:39 AM · Restricted Project
Mordante updated the diff for D90999: [libc++] Implements ranges::enable_borrowed_range.

Implement all new header tests as suggested by @curdeius in D92214.

Dec 3 2020, 9:37 AM · Restricted Project
Mordante updated the diff for D92214: [libc++] Implement format_error..

Implement all new header tests as suggested by @curdeius.

Dec 3 2020, 9:34 AM · Restricted Project
Mordante added inline comments to D92214: [libc++] Implement format_error..
Dec 3 2020, 9:31 AM · Restricted Project

Dec 2 2020

Mordante updated the diff for D92214: [libc++] Implement format_error..

Updated the Apple ABI list and synopsis.

Dec 2 2020, 10:55 AM · Restricted Project
Mordante added a comment to D92214: [libc++] Implement format_error..

Thanks for the review.

Dec 2 2020, 10:48 AM · Restricted Project
Mordante added a comment to D92306: [libc++] [docs] Add C++2b (to be C++23) status page..

Thanks for the patch.
One minor nit, other than that LGTM.

Dec 2 2020, 9:39 AM · Restricted Project
Mordante planned changes to D92214: [libc++] Implement format_error..
Dec 2 2020, 9:12 AM · Restricted Project
Mordante updated the diff for D92214: [libc++] Implement format_error..

Rebase to trigger CI to generate the Apple ABI list.

Dec 2 2020, 9:11 AM · Restricted Project

Nov 28 2020

Mordante committed rGae5f792002d8: [libc++] Disable some tests using gcc 9. (authored by Mordante).
[libc++] Disable some tests using gcc 9.
Nov 28 2020, 11:10 AM
Mordante committed rG67c88e47bdba: [libc++] P1645 constexpr for <numeric> (authored by Mordante).
[libc++] P1645 constexpr for <numeric>
Nov 28 2020, 8:04 AM
Mordante closed D90569: [libc++] P1645 constexpr for <numeric>.
Nov 28 2020, 8:04 AM · Restricted Project
Mordante updated the diff for D90569: [libc++] P1645 constexpr for <numeric>.

Disable the unit tests on clang-8, they fail and we don't support these old compilers for libc++.
Switch to the new status page
Adjusted the unit tests modified in D61170 to work in constexpr evaluation. Since constexpr string isn't supported yet the std::string tests are disabled in constant evaluation context.

Nov 28 2020, 6:48 AM · Restricted Project
Mordante updated the diff for D92214: [libc++] Implement format_error..

Disable the Apple unit tests as suggested by @curdeius.
Formatted the manually written code with the .clang-format settings as proposed in D92229.

Nov 28 2020, 5:04 AM · Restricted Project
Mordante added a comment to D92229: [libc++] Update clang-format configuration.

Thanks @curdeius for looking into this! The lack of proper clang-format rules for libc++ also bothered me a bit. Ut didn't bother me enough to look into it yet.

Nov 28 2020, 4:57 AM · Restricted Project
Mordante added a comment to D92214: [libc++] Implement format_error..

To fix Apple back-deployment build, you'll need to mark your test with sth like:

Nov 28 2020, 4:40 AM · Restricted Project

Nov 27 2020

Mordante updated the diff for D92214: [libc++] Implement format_error..

Properly guard the code in format.cpp to only be used in C++20 mode.
Update the x86_64 ABI list.
Note the Apple ABI list is still out of date.

Nov 27 2020, 3:35 AM · Restricted Project
Mordante planned changes to D92214: [libc++] Implement format_error..

Thanks for the review!

Nov 27 2020, 3:11 AM · Restricted Project
Mordante requested review of D92214: [libc++] Implement format_error..
Nov 27 2020, 1:10 AM · Restricted Project

Nov 26 2020

Mordante committed rG83d26603e040: [NFC][libc++] Mark LWG3296 as complete. (authored by Mordante).
[NFC][libc++] Mark LWG3296 as complete.
Nov 26 2020, 1:41 AM

Nov 25 2020

Mordante added a comment to D91004: [libc++] Implements concept destructible.

@ldionne the patch passes the CI build and I addressed all previous review comments. When you have time can you have a look?

Nov 25 2020, 5:30 AM · Restricted Project
Mordante reopened D90569: [libc++] P1645 constexpr for <numeric>.

Reopened since I reverted to commit. It fails on several build bots using LLVM 8.

Nov 25 2020, 4:48 AM · Restricted Project
Mordante added a reverting change for rGeb9b063539c3: [libc++] P1645 constexpr for <numeric>: rGecabb39ca11c: Revert "[libc++] P1645 constexpr for <numeric>".
Nov 25 2020, 4:46 AM
Mordante committed rGecabb39ca11c: Revert "[libc++] P1645 constexpr for <numeric>" (authored by Mordante).
Revert "[libc++] P1645 constexpr for <numeric>"
Nov 25 2020, 4:46 AM
Mordante added a reverting change for D90569: [libc++] P1645 constexpr for <numeric>: rGecabb39ca11c: Revert "[libc++] P1645 constexpr for <numeric>".
Nov 25 2020, 4:46 AM · Restricted Project
Mordante committed rGeb9b063539c3: [libc++] P1645 constexpr for <numeric> (authored by Mordante).
[libc++] P1645 constexpr for <numeric>
Nov 25 2020, 4:19 AM
Mordante closed D90569: [libc++] P1645 constexpr for <numeric>.
Nov 25 2020, 4:19 AM · Restricted Project
Mordante updated the diff for D90999: [libc++] Implements ranges::enable_borrowed_range.

Move the enable_borrowed_range to a helper header to avoid including <ranges> in <span> and <string_view> as suggested by @miscco.

Nov 25 2020, 2:48 AM · Restricted Project
Mordante updated the diff for D90569: [libc++] P1645 constexpr for <numeric>.

Rebase to trigger CI.

Nov 25 2020, 2:31 AM · Restricted Project

Nov 24 2020

Mordante updated the diff for D91004: [libc++] Implements concept destructible.

Rebase to trigger CI build.

Nov 24 2020, 9:25 AM · Restricted Project
Mordante added a comment to D91986: [libc++] Implements concept constructible_from.

@CaseyCarter had this to say back in D74291.

There's tons of coverage here for class types and reference types. What about void, function types, pointers, arrays, pointers-to-members? (I don't know about clang/libc++, but the MSVC STL tests for type traits tend to _be_ the tests for compiler intrinsics used to implement those traits, so we consequently cover everything under the sun.)

I'd suggest we apply this here as well.

Nov 24 2020, 9:19 AM · Restricted Project
Mordante updated the diff for D91004: [libc++] Implements concept destructible.

Rebase to trigger CI.

Nov 24 2020, 8:53 AM · Restricted Project
Mordante updated the diff for D90569: [libc++] P1645 constexpr for <numeric>.

Rebase to trigger CI.

Nov 24 2020, 8:45 AM · Restricted Project
Mordante committed rG1a036e9cc82a: [libcxx] Implement P1956 rename low-level bit functions (authored by Mordante).
[libcxx] Implement P1956 rename low-level bit functions
Nov 24 2020, 8:37 AM
Mordante closed D90551: [libcxx] Implement P1956 rename low-level bit functions.
Nov 24 2020, 8:37 AM · Restricted Project
Mordante added a comment to D90569: [libc++] P1645 constexpr for <numeric>.

Thanks for the review.
I've switched to arc, so that should solve the CI issues.

Nov 24 2020, 8:35 AM · Restricted Project
Mordante updated the diff for D90551: [libcxx] Implement P1956 rename low-level bit functions.

Rebase to trigger the bildkite.

Nov 24 2020, 6:00 AM · Restricted Project

Nov 23 2020

Mordante requested review of D91986: [libc++] Implements concept constructible_from.
Nov 23 2020, 11:37 AM · Restricted Project
Mordante updated the diff for D90569: [libc++] P1645 constexpr for <numeric>.

This should complete the implementation of P1645
Additional changes

  • Since constexpr vector isn't available some test have a workaround to be tested without this feature. The changes are marked with a fixme to be removed once the support is available.
  • Enables additional unit tests in libcxx/test/std/numerics/numeric.ops/inclusive.scan/inclusive_scan_op.pass.cpp. These were disabled when added, but that seems an oversight.
  • Changes the changed numeric functions to all use _LIBCPP_INLINE_VISIBILITY and removed the unneeded inline.
Nov 23 2020, 9:51 AM · Restricted Project

Nov 18 2020

Mordante added a comment to D90569: [libc++] P1645 constexpr for <numeric>.

Is there a reason why their signatures differ or is it an oversight?
Shall I fix them in this patch?

I believe those are oversights, and the blame seems to confirm this. Good catch, and please fix them in this patch. You don't need inline though, just _LIBCPP_INLINE_VISIBILITY. These functions are already inline (i.e. linkonce-ODR) because they are templates.

Nov 18 2020, 10:25 AM · Restricted Project
Mordante updated the diff for D90569: [libc++] P1645 constexpr for <numeric>.

Added an updated test for libcxx/test/std/numerics/numeric.ops/exclusive.scan/exclusive_scan.pass.cpp.

Nov 18 2020, 10:24 AM · Restricted Project
Mordante added a comment to D90551: [libcxx] Implement P1956 rename low-level bit functions.

Thanks for the review.

Nov 18 2020, 9:33 AM · Restricted Project
Mordante committed rG3abaf6cde7a9: [libc++] Implements multiline regex support. (authored by Mordante).
[libc++] Implements multiline regex support.
Nov 18 2020, 9:18 AM
Mordante added a comment to D63059: Implements multiline regex support.

Thanks for the review!

Nov 18 2020, 9:14 AM · Restricted Project

Nov 17 2020

Mordante added inline comments to D91586: Mark trivial_abi unique_ptr tests as unsupported in clang-11..
Nov 17 2020, 11:25 AM · Restricted Project
Mordante added a comment to D91630: [Parse] Add parsing support for C++ attributes on using-declarations.

Thanks for the patch!
No further comments regarding the patch, except the items Aaron already mentioned.

Nov 17 2020, 11:12 AM
Mordante updated the diff for D90551: [libcxx] Implement P1956 rename low-level bit functions.

Addresses the review comments:

  • Adds the change to the release notes.
  • Remove instead of deprecate the old functions.
Nov 17 2020, 10:48 AM · Restricted Project
Mordante added inline comments to D63059: Implements multiline regex support.
Nov 17 2020, 10:20 AM · Restricted Project
Mordante updated the diff for D63059: Implements multiline regex support.
  • Removed __[rl]_anchor
  • Changed __is_eol to use _LIBCPP_INLINE_VISIBILITY
Nov 17 2020, 10:19 AM · Restricted Project

Nov 10 2020

Mordante updated the diff for D91004: [libc++] Implements concept destructible.

Undo the last revision since I accidentally attached a patch to the wrong review.

Nov 10 2020, 10:33 AM · Restricted Project
Mordante updated the diff for D90999: [libc++] Implements ranges::enable_borrowed_range.

Change the unit tests to compile time test, based on the review comment in D91004.

Nov 10 2020, 10:31 AM · Restricted Project
Mordante added a comment to D87171: Implement P0919R3.

I just noticed two small nits.

Nov 10 2020, 10:21 AM · Restricted Project
Mordante added a comment to D90551: [libcxx] Implement P1956 rename low-level bit functions.

Thanks for the review.

Nov 10 2020, 10:03 AM · Restricted Project
Mordante updated the diff for D91004: [libc++] Implements concept destructible.

Change the unit tests to compile time test, based on the review comment in D91004.

Nov 10 2020, 9:46 AM · Restricted Project
Mordante updated the diff for D91004: [libc++] Implements concept destructible.

Added a main() to the compile time test as requested by @miscco .

Nov 10 2020, 9:31 AM · Restricted Project

Nov 9 2020

Mordante added a comment to D91004: [libc++] Implements concept destructible.

One last ask for @ldionne, currently MSVC`s internal test runner seems to require int main() even in compile only tests, as it not yet understands compileonly tests. For the sake ofcompatibility could we for now include int main() {} to enable cross vendor compatibility.

I would be happy to clean that up once it MSVC fixes their side

Nov 9 2020, 11:09 AM · Restricted Project
Mordante updated the diff for D91004: [libc++] Implements concept destructible.

Addresses the review comments:

  • @miscco and @ldionne their suggestion to make the unit test a compile-time test
  • @ldionne's suggestion to explicitly test the compatibility with is_nothrow_destructible_v
Nov 9 2020, 9:59 AM · Restricted Project
Mordante added inline comments to D91004: [libc++] Implements concept destructible.
Nov 9 2020, 9:54 AM · Restricted Project
Mordante added a comment to D91004: [libc++] Implements concept destructible.

I'd like to address the issue of reviews, because it has been on my mind for some time.

<snip>

I really want to create a sane and efficient contribution culture around libc++, and I think it's necessary for the project to be successful. How does that sound?

Nov 9 2020, 8:11 AM · Restricted Project

Nov 8 2020

Mordante added inline comments to D91004: [libc++] Implements concept destructible.
Nov 8 2020, 11:54 AM · Restricted Project
Mordante added a comment to D91004: [libc++] Implements concept destructible.

I'd actually been hoping to merge my ranges library since ~March, but reviews are a major blocker and so I've put it on hold for now. Once @ldionne has the time to review, I'll resume contributing.

Nov 8 2020, 9:43 AM · Restricted Project
Mordante updated the diff for D91004: [libc++] Implements concept destructible.

Addresses @miscco's review comments assert -> static_assert and some minor nits.

Nov 8 2020, 6:52 AM · Restricted Project
Mordante added a comment to D91004: [libc++] Implements concept destructible.

LGTM

Nov 8 2020, 6:43 AM · Restricted Project
Mordante updated the diff for D90999: [libc++] Implements ranges::enable_borrowed_range.

Adds the additional unit tests as requested by @miscco.
Found some accidental tabs in the patch replaced them with spaces.

Nov 8 2020, 6:23 AM · Restricted Project
Mordante added a comment to D90999: [libc++] Implements ranges::enable_borrowed_range.

I am wondering whether we should split the ranges header up into a smaller part that we use to include in other headers adn the rest.

Including all of ranges just for one trait seems a bit of an overkill.

Nov 8 2020, 5:59 AM · Restricted Project

Nov 7 2020

Mordante requested review of D91004: [libc++] Implements concept destructible.
Nov 7 2020, 8:26 AM · Restricted Project