- User Since
- May 10 2019, 9:08 AM (64 w, 5 d)
Sun, Aug 2
Rebased the patch and updated the unit tests.
Apr 7 2020
Take all \params and function parameters in account when looking for a solution and find the best total solution.
Currently all unmapped parameters are taken into account.
I cannot imagine a use case where taking the mapped ones into account could influence the outcome.
Also I personally don't like breaking any existing correct documentation.
Do you have some example?
Mar 21 2020
Sorry it took a while.
Mar 17 2020
Implements the multiline using a derived class.
Mar 12 2020
Thanks for the confirmation it's an ABI break. I like your suggestion to use a derived class, so I'll try that solution first.
Seems it requires CMake 3.8 to use CXX_STANDARD 17, so reverted the commit for now.
CXX_STANDARD_REQUIRED is already set by the main LLVM CMake script.
Good catch, I'll update the patch.
Addresses @EricWF's comment.
Mar 10 2020
Noticed I didn't stage my last hunk. Don't use BENCHMARK_DIALECT_FLAG which no longer is set.
It builds for me, but I had CMAKE_CXX_STANDARD set to 17 for this build. It seems the method used to use C++17 for the benchmarks didn't work. I feel fixing this issue should not be part of this commit. So I created D75955 to fix the issue. With that patch applied it also works for me when CMAKE_CXX_STANDARD set to 14. This is the default value.
Mar 8 2020
Added unit tests as requested and rebased against master.
Thanks for looking into these patches!
Rebased against master.
Mar 4 2020
Thanks for the patch! I've some minor nits, but other then that it looks fine.
@gribozavr2 what's your opinion of this patch?
Feb 22 2020
Added some C++ tests for similar c-style casts.
Feb 20 2020
Thanks for your patch. I also would like to get better fixits for the arguments.
Rebased as requested.
Thanks for the review and committing! (BTW I have commit access.)
Feb 19 2020
Feb 18 2020
Feb 16 2020
Thanks for the quick review!
This revision caused issue for the MSVC build bot. I created a followup patch D74694.
Thanks for the review.
Phab registered the commit, but didn't close this review.
Feb 4 2020
- Enabled the warning by default
- Added an Microsoft extension, the unit tests already expected this behaviour
Feb 1 2020
Created D73834 to cherry-pick the changes to the release branch and updates the release notes.
Jan 26 2020
So if I understand correctly:
- getParamNameAsWritten will become getArgText
- The getParamName will do the translation from the name in the documentation to the name in the current function declaration. If the parameter index is invalid the function will fail (with an assertion error) and not fallback to call getArgText.
Jan 21 2020
Would it make sense to also allow wmain with wchar_t? https://docs.microsoft.com/en-us/cpp/cpp/main-function-command-line-args?view=vs-2019
Jan 19 2020
I proposed D73007 as fix.
Jan 18 2020
Thanks for your report. I think it's similar to https://bugs.llvm.org/show_bug.cgi?id=44556. I'll look for a fix.
Thanks for the review!
Jan 12 2020
Jan 11 2020
Thanks for the review!
I only have some naming nits
- incriment -> increment
- decriment -> decrement
Friendly ping, it would be nice to get this in the next release.
Adding Depends on D72284 would add the patches to the stack.
I like the patch!
Jan 7 2020
While looking at the test failures I noticed the tests pointer_to_integral_type_conv in clang/test/Sema/MicrosoftExtensions.c were not tested. Will look into it later.
You're welcome. It would be nice if we can get this one in the release.
Jan 6 2020
Thanks for the feedback!
Jan 5 2020
Made some improvements based on feedback of @craig.topper:
- Adds a not
- Implements an example of the maximum string length when using -Wpedantic
Nice to see this patch! I intended to look at a similar patch, but that's no longer required.
Rebased on master. This adds one new fix and removes the ones done by others.
Jan 4 2020
@eugene Please don't use auto when type is spelled in same statement or iterator. do you mean type is not spelled ?