Page MenuHomePhabricator

Mordante (Mark de Wever)
User

Projects

User does not belong to any projects.

User Details

User Since
May 10 2019, 9:08 AM (64 w, 5 d)

Recent Activity

Sun, Aug 2

Mordante updated the diff for D72103: [Sema] Avoid using an invalid InsertPos.

Rebased the patch and updated the unit tests.

Sun, Aug 2, 10:21 AM · Restricted Project
Mordante requested review of D85091: [Sema, CodeGen] Implement [[likely]] and [[unlikely]] in IfStmt.
Sun, Aug 2, 4:42 AM · Restricted Project, Restricted Project

Apr 7 2020

Mordante planned changes to D71142: [Sema] Validate large bitfields.

Any comments?

@rsmith @aaron.ballman

There are outstanding review comments, so I'm waiting for the patch author to address those, unless I've missed a question somewhere?

Apr 7 2020, 11:55 AM · Restricted Project
Mordante added a comment to D74877: [clang] fix incorrect Wdocumentation fix-its.

Take all \params and function parameters in account when looking for a solution and find the best total solution.

Currently all unmapped parameters are taken into account.
I cannot imagine a use case where taking the mapped ones into account could influence the outcome.
Also I personally don't like breaking any existing correct documentation.
Do you have some example?

Apr 7 2020, 11:55 AM · Restricted Project

Mar 21 2020

Mordante added a comment to D74877: [clang] fix incorrect Wdocumentation fix-its.

Sorry it took a while.

Mar 21 2020, 11:13 AM · Restricted Project
Mordante added inline comments to D63059: Implements multiline regex support.
Mar 21 2020, 9:37 AM · Restricted Project

Mar 17 2020

Mordante updated the diff for D63059: Implements multiline regex support.

Implements the multiline using a derived class.

Mar 17 2020, 12:23 PM · Restricted Project
Mordante added a comment to D63059: Implements multiline regex support.

Thanks for the confirmation it's an ABI break. I like your suggestion to use a derived class, so I'll try that solution first.

I'm not 100% sure that solution addresses the ABI break problem, though. I'd have to think about it harder and run it through at least another person to be confident.

Mar 17 2020, 12:23 PM · Restricted Project
Mordante added a comment to D72103: [Sema] Avoid using an invalid InsertPos.

Friendly ping.

Mar 17 2020, 11:49 AM · Restricted Project

Mar 12 2020

Mordante committed rG56926a9146fc: Revert "[libcxx] Enable C++17 for the benchmarks." (authored by Mordante).
Revert "[libcxx] Enable C++17 for the benchmarks."
Mar 12 2020, 2:39 PM
Mordante added a reverting change for rGd184d0226301: [libcxx] Enable C++17 for the benchmarks.: rG56926a9146fc: Revert "[libcxx] Enable C++17 for the benchmarks.".
Mar 12 2020, 2:39 PM
Herald added a reviewer for D63059: Implements multiline regex support: Restricted Project.

Thanks for the confirmation it's an ABI break. I like your suggestion to use a derived class, so I'll try that solution first.

Mar 12 2020, 2:39 PM · Restricted Project
Mordante added a comment to D75955: [libcxx] Enable C++17 for the benchmarks.

Seems it requires CMake 3.8 to use CXX_STANDARD 17, so reverted the commit for now.

Mar 12 2020, 2:39 PM · Restricted Project
Mordante added a comment to D75955: [libcxx] Enable C++17 for the benchmarks.

CXX_STANDARD_REQUIRED is already set by the main LLVM CMake script.

Mar 12 2020, 2:39 PM · Restricted Project
Mordante added a comment to D62778: [1/2] Add a benchmark for map operations..

Good catch, I'll update the patch.

Mar 12 2020, 2:07 PM · Restricted Project
Mordante updated the diff for D62778: [1/2] Add a benchmark for map operations..

Addresses @EricWF's comment.

Mar 12 2020, 2:07 PM · Restricted Project
Mordante committed rGd184d0226301: [libcxx] Enable C++17 for the benchmarks. (authored by Mordante).
[libcxx] Enable C++17 for the benchmarks.
Mar 12 2020, 1:37 PM
Mordante closed D75955: [libcxx] Enable C++17 for the benchmarks.
Mar 12 2020, 1:36 PM · Restricted Project

Mar 10 2020

Mordante updated subscribers of D63059: Implements multiline regex support.

@mclow.lists, @ldionne is the change of the size of __l_anchor an ABI break?

Mar 10 2020, 1:39 PM · Restricted Project
Mordante updated the diff for D75955: [libcxx] Enable C++17 for the benchmarks.

Noticed I didn't stage my last hunk. Don't use BENCHMARK_DIALECT_FLAG which no longer is set.

Mar 10 2020, 1:39 PM · Restricted Project
Mordante requested review of D62778: [1/2] Add a benchmark for map operations..

It builds for me, but I had CMAKE_CXX_STANDARD set to 17 for this build. It seems the method used to use C++17 for the benchmarks didn't work. I feel fixing this issue should not be part of this commit. So I created D75955 to fix the issue. With that patch applied it also works for me when CMAKE_CXX_STANDARD set to 14. This is the default value.

Mar 10 2020, 1:06 PM · Restricted Project
Mordante created D75955: [libcxx] Enable C++17 for the benchmarks.
Mar 10 2020, 1:06 PM · Restricted Project

Mar 8 2020

Mordante updated the diff for D62779: [2/2] Fix complexity of map insert_or_assign with a hint..

Added unit tests as requested and rebased against master.

Mar 8 2020, 11:44 AM · Restricted Project
Mordante added a comment to D62779: [2/2] Fix complexity of map insert_or_assign with a hint..

Thanks for looking into these patches!

Mar 8 2020, 11:44 AM · Restricted Project
Mordante updated the diff for D62778: [1/2] Add a benchmark for map operations..

Rebased against master.

Mar 8 2020, 11:44 AM · Restricted Project

Mar 4 2020

Mordante added a comment to D75613: [Sema] Reword -Wrange-loop-analysis warning messages.

Thanks for the patch! I've some minor nits, but other then that it looks fine.

Mar 4 2020, 12:21 PM · Restricted Project
Mordante added a comment to D74877: [clang] fix incorrect Wdocumentation fix-its.

@gribozavr2 what's your opinion of this patch?

Mar 4 2020, 11:47 AM · Restricted Project

Feb 22 2020

Mordante added a comment to D72103: [Sema] Avoid using an invalid InsertPos.

Friendly ping.

Feb 22 2020, 10:58 AM · Restricted Project
Mordante committed rG56eb15a1c710: [Sema] Fix pointer-to-int-cast diagnostic for _Bool (authored by Mordante).
[Sema] Fix pointer-to-int-cast diagnostic for _Bool
Feb 22 2020, 10:41 AM
Mordante closed D74860: [Sema] Fix pointer-to-int-cast diagnostic for _Bool.
Feb 22 2020, 10:40 AM · Restricted Project
Mordante added inline comments to D74877: [clang] fix incorrect Wdocumentation fix-its.
Feb 22 2020, 10:40 AM · Restricted Project
Mordante updated the diff for D74860: [Sema] Fix pointer-to-int-cast diagnostic for _Bool.

Added some C++ tests for similar c-style casts.

Feb 22 2020, 10:05 AM · Restricted Project
Mordante added a comment to D74860: [Sema] Fix pointer-to-int-cast diagnostic for _Bool.

Can we test the same thing in C++?

Feb 22 2020, 10:05 AM · Restricted Project

Feb 20 2020

Mordante added a reviewer for D74877: [clang] fix incorrect Wdocumentation fix-its: gribozavr2.

Thanks for your patch. I also would like to get better fixits for the arguments.

Feb 20 2020, 1:25 PM · Restricted Project
Mordante updated the diff for D62453: Regex backreference [3/3] Validate backreferences in the constructor..

Rebased as requested.

Feb 20 2020, 12:19 PM · Restricted Project
Mordante added a comment to D62451: Regex backreference [1/3] Fixes backreferences for extended grammar..

Thanks for the review and committing! (BTW I have commit access.)

Feb 20 2020, 12:10 PM · Restricted Project

Feb 19 2020

Mordante created D74860: [Sema] Fix pointer-to-int-cast diagnostic for _Bool.
Feb 19 2020, 12:52 PM · Restricted Project
Mordante added a comment to D62451: Regex backreference [1/3] Fixes backreferences for extended grammar..

Friendly ping.

Feb 19 2020, 12:24 PM · Restricted Project
Mordante added a comment to D72231: [Sema] Adds the pointer-to-int-cast diagnostic.

Okay. Can we raise this with the kernel folks instead of just assuming they'll be opposed? An obvious patch to fix a few dozen places where they're hit by a warning they intentionally enabled really doesn't seem like a burden. If they push back, fine, we can enable the warning without covering enums.

Feb 19 2020, 11:55 AM · Restricted Project

Feb 18 2020

Mordante added a comment to D72231: [Sema] Adds the pointer-to-int-cast diagnostic.

There appear to a be semantic difference between GCC and clang with the current version of this patch which results in a lot of additional warnings in the Linux kernel: https://godbolt.org/z/eHFJd8

Warning about casting to an enum seems clearly correct and in scope for this warning. Warning about casting to _Bool seems clearly incorrect and should not be warned about at all.

Feb 18 2020, 1:03 PM · Restricted Project

Feb 16 2020

Mordante committed rGaf202119443b: [Sema] Fix pointer-to-int-cast for MSVC build bot (authored by Mordante).
[Sema] Fix pointer-to-int-cast for MSVC build bot
Feb 16 2020, 10:11 AM
Mordante closed D74694: [Sema] Fix pointer-to-int-cast for MSVC build bot.
Feb 16 2020, 10:11 AM · Restricted Project
Mordante added a comment to D74694: [Sema] Fix pointer-to-int-cast for MSVC build bot.

Thanks for the quick review!

Feb 16 2020, 10:09 AM · Restricted Project
Mordante created D74694: [Sema] Fix pointer-to-int-cast for MSVC build bot.
Feb 16 2020, 9:42 AM · Restricted Project
Mordante added a comment to D72231: [Sema] Adds the pointer-to-int-cast diagnostic.

This revision caused issue for the MSVC build bot. I created a followup patch D74694.

Feb 16 2020, 9:42 AM · Restricted Project
Mordante planned changes to D71966: [Wdocumentation][RFC] Improve identifier's of \param.
Feb 16 2020, 9:06 AM · Restricted Project
Mordante committed rG9658d895c81a: [Sema] Adds the pointer-to-int-cast diagnostic (authored by Mordante).
[Sema] Adds the pointer-to-int-cast diagnostic
Feb 16 2020, 6:43 AM
Mordante closed D72231: [Sema] Adds the pointer-to-int-cast diagnostic.
Feb 16 2020, 6:42 AM · Restricted Project
Mordante added a comment to D72231: [Sema] Adds the pointer-to-int-cast diagnostic.

Thanks for the review.

Feb 16 2020, 6:42 AM · Restricted Project
Mordante closed D73834: Update for Clang 10 release notes.

Phab registered the commit, but didn't close this review.

Feb 16 2020, 5:54 AM · Restricted Project

Feb 4 2020

Mordante updated the diff for D72231: [Sema] Adds the pointer-to-int-cast diagnostic.
  • Enabled the warning by default
  • Added an Microsoft extension, the unit tests already expected this behaviour
Feb 4 2020, 11:53 AM · Restricted Project
Mordante committed rG2d9954dd8244: Add -Wrange-loop-analysis changes to ReleaseNotes (authored by Mordante).
Add -Wrange-loop-analysis changes to ReleaseNotes
Feb 4 2020, 11:26 AM

Feb 1 2020

Mordante added a comment to D73434: [Sema] Remove a -Wrange warning from -Wall.

Created D73834 to cherry-pick the changes to the release branch and updates the release notes.

Feb 1 2020, 10:09 AM · Restricted Project
Mordante created D73834: Update for Clang 10 release notes.
Feb 1 2020, 10:09 AM · Restricted Project
Mordante committed rGc03349e40f21: [Sema] Remove a -Wrange warning from -Wall (authored by Mordante).
[Sema] Remove a -Wrange warning from -Wall
Feb 1 2020, 9:51 AM
Mordante closed D73434: [Sema] Remove a -Wrange warning from -Wall.
Feb 1 2020, 9:51 AM · Restricted Project

Jan 26 2020

Mordante added a comment to D73007: [Sema] Avoid Wrange-loop-analysis false positives.

Created D73434.

Jan 26 2020, 10:18 AM · Restricted Project
Mordante created D73434: [Sema] Remove a -Wrange warning from -Wall.
Jan 26 2020, 10:17 AM · Restricted Project
Mordante added a comment to D71966: [Wdocumentation][RFC] Improve identifier's of \param.

So if I understand correctly:

  • getParamNameAsWritten will become getArgText
  • The getParamName will do the translation from the name in the documentation to the name in the current function declaration. If the parameter index is invalid the function will fail (with an assertion error) and not fallback to call getArgText.
Jan 26 2020, 8:40 AM · Restricted Project
Mordante added a comment to D73007: [Sema] Avoid Wrange-loop-analysis false positives.

@aaronpuchert, @aaron.ballman I agree with the proposal, I'll work on a patch.

Jan 26 2020, 7:55 AM · Restricted Project

Jan 21 2020

Mordante added a comment to D73098: [clang-tidy] readability-identifier-naming disregards parameters restrictions on main like functions.

Would it make sense to also allow wmain with wchar_t? https://docs.microsoft.com/en-us/cpp/cpp/main-function-command-line-args?view=vs-2019

Jan 21 2020, 12:23 PM · Restricted Project, Restricted Project
Mordante committed rG41fcd17250fa: [Sema] Avoid Wrange-loop-analysis false positives (authored by Mordante).
[Sema] Avoid Wrange-loop-analysis false positives
Jan 21 2020, 12:14 PM
Mordante closed D73007: [Sema] Avoid Wrange-loop-analysis false positives.
Jan 21 2020, 12:14 PM · Restricted Project
Mordante added inline comments to D73007: [Sema] Avoid Wrange-loop-analysis false positives.
Jan 21 2020, 11:55 AM · Restricted Project
Mordante added a comment to D73007: [Sema] Avoid Wrange-loop-analysis false positives.

LGTM! Do you think this should also be pushed onto the release branch?

Jan 21 2020, 11:46 AM · Restricted Project
Mordante added a comment to D73007: [Sema] Avoid Wrange-loop-analysis false positives.

Yes, but minimal fix is better for release branch, so @hans should merge it.

Handling your case probably needs more work and patches..

Jan 21 2020, 11:46 AM · Restricted Project

Jan 19 2020

Mordante added a comment to D68912: Adds -Wrange-loop-analysis to -Wall.

I proposed D73007 as fix.

Jan 19 2020, 10:12 AM · Restricted Project
Mordante created D73007: [Sema] Avoid Wrange-loop-analysis false positives.
Jan 19 2020, 10:03 AM · Restricted Project

Jan 18 2020

Mordante added a comment to D68912: Adds -Wrange-loop-analysis to -Wall.

Thanks for your report. I think it's similar to https://bugs.llvm.org/show_bug.cgi?id=44556. I'll look for a fix.

Jan 18 2020, 12:06 PM · Restricted Project
Mordante added a comment to D71966: [Wdocumentation][RFC] Improve identifier's of \param.

Thanks for the review!

Jan 18 2020, 11:56 AM · Restricted Project

Jan 12 2020

Mordante closed D72560: Add -Wrange-loop-analysis changes to ReleaseNotes.

Committed as https://reviews.llvm.org/rGdc422e968e73790178e500f506e8fb7cfa1e62ea

Jan 12 2020, 11:06 AM · Restricted Project

Jan 11 2020

Mordante committed rGdc422e968e73: Add -Wrange-loop-analysis changes to ReleaseNotes (authored by Mordante).
Add -Wrange-loop-analysis changes to ReleaseNotes
Jan 11 2020, 11:03 AM
Mordante added a comment to D72560: Add -Wrange-loop-analysis changes to ReleaseNotes.

Thanks for the review!

Jan 11 2020, 11:03 AM · Restricted Project
Mordante created D72560: Add -Wrange-loop-analysis changes to ReleaseNotes.
Jan 11 2020, 10:10 AM · Restricted Project
Mordante added inline comments to D72052: [UserManual] Update the C++ standard support.
Jan 11 2020, 8:46 AM · Restricted Project
Mordante added a comment to D72553: [clang-tidy] Add performance-prefer-preincrement check.
  • 99% sure I have all incriments renamed now
Jan 11 2020, 8:46 AM · Restricted Project, Restricted Project
Mordante added a comment to D72553: [clang-tidy] Add performance-prefer-preincrement check.

I only have some naming nits

  • incriment -> increment
  • decriment -> decrement
Jan 11 2020, 7:24 AM · Restricted Project, Restricted Project
Mordante added a comment to D72052: [UserManual] Update the C++ standard support.

Friendly ping, it would be nice to get this in the next release.

Jan 11 2020, 7:06 AM · Restricted Project
Mordante added a comment to D72378: [clang-tidy] Add `bugprone-reserved-identifier`.

Adding Depends on D72284 would add the patches to the stack.
I like the patch!

Jan 11 2020, 6:58 AM · Restricted Project, Restricted Project
Mordante committed rG9c74fb402e1b: [Sema] Improve -Wrange-loop-analysis warnings. (authored by Mordante).
[Sema] Improve -Wrange-loop-analysis warnings.
Jan 11 2020, 6:38 AM
Mordante closed D72212: [Sema] Improve -Wrange-loop-analysis warnings.
Jan 11 2020, 6:38 AM · Restricted Project
Mordante added inline comments to D72212: [Sema] Improve -Wrange-loop-analysis warnings.
Jan 11 2020, 6:38 AM · Restricted Project

Jan 7 2020

Mordante planned changes to D72231: [Sema] Adds the pointer-to-int-cast diagnostic.

While looking at the test failures I noticed the tests pointer_to_integral_type_conv in clang/test/Sema/MicrosoftExtensions.c were not tested. Will look into it later.

Jan 7 2020, 1:08 PM · Restricted Project
Mordante added a comment to D72212: [Sema] Improve -Wrange-loop-analysis warnings.

You're welcome. It would be nice if we can get this one in the release.

Jan 7 2020, 11:31 AM · Restricted Project

Jan 6 2020

Mordante committed rG5e0e0e3ff05f: [NFC] Fixes -Wrange-loop-analysis warnings (authored by Mordante).
[NFC] Fixes -Wrange-loop-analysis warnings
Jan 6 2020, 3:52 PM
Mordante added a comment to D72053: [RFC] Handling implementation limits.

Thanks for the feedback!

Jan 6 2020, 2:44 PM · Restricted Project
Mordante added inline comments to D72053: [RFC] Handling implementation limits.
Jan 6 2020, 8:48 AM · Restricted Project
Mordante committed rGeec0240f9718: Adds -Wrange-loop-analysis to -Wall (authored by Mordante).
Adds -Wrange-loop-analysis to -Wall
Jan 6 2020, 8:39 AM
Mordante committed rG1d549cff48cd: [NFC] Fixes -Wrange-loop-analysis warnings (authored by Mordante).
[NFC] Fixes -Wrange-loop-analysis warnings
Jan 6 2020, 8:38 AM
Mordante closed D72210: [NFC] Fixes -Wrange-loop-analysis warnings.
Jan 6 2020, 8:38 AM · Restricted Project, lld

Jan 5 2020

Mordante added a comment to D72231: [Sema] Adds the pointer-to-int-cast diagnostic.

The diagnostic is not enabled by default

But GCC enables it for C even without "-Wall or -Wextra". Clang should follow it..

Jan 5 2020, 12:16 PM · Restricted Project
Mordante created D72231: [Sema] Adds the pointer-to-int-cast diagnostic.
Jan 5 2020, 11:43 AM · Restricted Project
Mordante updated the diff for D72053: [RFC] Handling implementation limits.

Made some improvements based on feedback of @craig.topper:

  • Adds a not
  • Implements an example of the maximum string length when using -Wpedantic
Jan 5 2020, 7:35 AM · Restricted Project
Mordante added a comment to D72217: [clang-tidy] Added readability-qualified-auto check.

Nice to see this patch! I intended to look at a similar patch, but that's no longer required.

Jan 5 2020, 6:03 AM · Restricted Project, Restricted Project
Mordante updated the diff for D72210: [NFC] Fixes -Wrange-loop-analysis warnings.

Rebased on master. This adds one new fix and removes the ones done by others.

Jan 5 2020, 5:43 AM · Restricted Project, lld
Mordante added inline comments to D72213: [clang-tidy] Add `bugprone-reserved-identifier` to flag usages of reserved C++ names.
Jan 5 2020, 5:25 AM · Restricted Project, Restricted Project
Mordante added inline comments to D72212: [Sema] Improve -Wrange-loop-analysis warnings.
Jan 5 2020, 5:15 AM · Restricted Project

Jan 4 2020

Mordante updated subscribers of D72213: [clang-tidy] Add `bugprone-reserved-identifier` to flag usages of reserved C++ names.

@eugene Please don't use auto when type is spelled in same statement or iterator. do you mean type is not spelled ?

Jan 4 2020, 2:05 PM · Restricted Project, Restricted Project
Mordante added inline comments to D72053: [RFC] Handling implementation limits.
Jan 4 2020, 1:55 PM · Restricted Project
Mordante added inline comments to D72212: [Sema] Improve -Wrange-loop-analysis warnings.
Jan 4 2020, 1:46 PM · Restricted Project