Page MenuHomePhabricator

dmajor (dmajor)
User

Projects

User does not belong to any projects.

User Details

User Since
Nov 10 2017, 10:09 AM (153 w, 6 d)

Recent Activity

Today

dmajor added a comment to D89088: [MBP] Add whole chain to BlockFilterSet instead of individual BB.

In case it helps, I turned on debug logging for this pass on our repro: https://paste.mozilla.org/HBDkeGXO (starts at line 60)

Thu, Oct 22, 7:10 PM · Restricted Project

Yesterday

dmajor added a comment to D89088: [MBP] Add whole chain to BlockFilterSet instead of individual BB.

Could you help to check when block bb.0 is moved below bb.2?

Wed, Oct 21, 3:25 PM · Restricted Project

Tue, Oct 20

dmajor updated subscribers of D89088: [MBP] Add whole chain to BlockFilterSet instead of individual BB.

Adding @jmorse in case D83046 is related.

Tue, Oct 20, 2:26 PM · Restricted Project
dmajor added a comment to rGe372a5f86f64: [InstCombine] Add or((icmp ult/ule (A + C1), C3), (icmp ult/ule (A + C2), C3))….

Unfortunately I don't have my git account handy either. I'm fine if this waits until tomorrow.

Tue, Oct 20, 1:32 PM
dmajor added a comment to rGe372a5f86f64: [InstCombine] Add or((icmp ult/ule (A + C1), C3), (icmp ult/ule (A + C2), C3))….

This is causing an assertion failure in our stage2 builds, could you please take a look? https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=319157722&repo=ash&lineNumber=9931 The reproducer artifacts can be obtained by clicking "Show Job Info" in the top bar.

Tue, Oct 20, 11:38 AM

Mon, Oct 19

dmajor added inline comments to D89640: [Sanitizers] Remove OpenBSD support.
Mon, Oct 19, 12:57 PM · Restricted Project
dmajor added a comment to D81682: [PGO] Extend the value profile buckets for mem op sizes..

Just a quick status update, I don't reproduce the issue with your script. I'm attempting to adjust the script to match our CI, but I'm distracted by other work.

Mon, Oct 19, 12:41 PM · Restricted Project, Restricted Project
dmajor added a comment to D87544: [CFGuard] Add address-taken IAT tables and delay-load support.

This caused a regression when calling through function pointers in a certain way as seen in sqlite3: https://bugs.llvm.org/show_bug.cgi?id=47905

Mon, Oct 19, 10:28 AM · Restricted Project

Thu, Oct 15

dmajor added a comment to D89088: [MBP] Add whole chain to BlockFilterSet instead of individual BB.

Hi, this commit caused an assertion in one of our builds:

/builds/worker/fetches/llvm-project/llvm/lib/CodeGen/LiveDebugValues/VarLocBasedImpl.cpp:1669: bool (anonymous namespace)::VarLocBasedLDV::join(llvm::MachineBasicBlock &, (anonymous namespace)::VarLocBasedLDV::VarLocInMBB &, (anonymous namespace)::VarLocBasedLDV::VarLocInMBB &, const (anonymous namespace)::VarLocBasedLDV::VarLocMap &, SmallPtrSet<const llvm::MachineBasicBlock *, 16> &, SmallPtrSetImpl<const llvm::MachineBasicBlock *> &): Assertion `(NumVisited || MBB.pred_empty()) && "Should have processed at least one predecessor"' failed.

It's an LTO+PGO build of Firefox so reproducing it is very time-consuming. I will try to get more info but it may take time and I wanted to give you an advance notice. In the meantime is there anything you can guess by inspection about what went wrong?

Thu, Oct 15, 8:28 PM · Restricted Project

Wed, Oct 14

dmajor added a comment to D81682: [PGO] Extend the value profile buckets for mem op sizes..

It may actually be that -vp-counters-per-site needs adjusting. How do you reproduce?

Wed, Oct 14, 8:40 AM · Restricted Project, Restricted Project

Tue, Oct 13

dmajor added a comment to D81682: [PGO] Extend the value profile buckets for mem op sizes..

The re-landing of this patch in 4a539faf74b9b4c25ee3b880e4007564bd5139b0 causes our PGO build of clang to have thousands of

LLVM Profile Warning: Unable to track new values: Running out of static counters.  Consider using option -mllvm -vp-counters-per-site=<n> to allocate more value profile counters at compile time.

Is that expected? Should the cmake set a higher value of -vp-counters-per-site in self-hosted PGO builds?

This has been reverted for now. There was a related issue.

Tue, Oct 13, 11:14 AM · Restricted Project, Restricted Project
dmajor added a comment to D89251: Reland [lsan] Enable LSAN for Android.

The build bot is happy with Diff 6! \o/

Tue, Oct 13, 8:40 AM · Restricted Project

Mon, Oct 12

dmajor added a comment to D89251: Reland [lsan] Enable LSAN for Android.

Looks like it's having trouble with the thread-local machinery:

Mon, Oct 12, 9:02 PM · Restricted Project
dmajor added a comment to D89251: Reland [lsan] Enable LSAN for Android.

More errors: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=318436438&repo=ash&lineNumber=15974
(Please note that there are two different files mentioned -- sanitizer_linux.cpp and sanitizer_linux_libcdep.cpp)

Mon, Oct 12, 5:50 PM · Restricted Project
dmajor added a comment to D89251: Reland [lsan] Enable LSAN for Android.

Latest errors: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=318424891&repo=ash&lineNumber=23010

Mon, Oct 12, 2:47 PM · Restricted Project
dmajor added a comment to D89251: Reland [lsan] Enable LSAN for Android.

The v2 patch still fails with

Mon, Oct 12, 12:36 PM · Restricted Project
dmajor added a comment to D85927: Enable LSAN for Android.

Thanks for the report!

This caused a build break in our compiler-rt build for Android: use of undeclared identifier '__interceptor_memalign'

Are you also building with API 16? (From your second comment)

Mon, Oct 12, 10:41 AM · Restricted Project
dmajor added a comment to D85927: Enable LSAN for Android.

And later we also get use of undeclared identifier 'dl_iterate_phdr' in sanitizer_linux.cpp. We compile for API 16, which doesn't implement that.

Mon, Oct 12, 9:04 AM · Restricted Project
dmajor added a comment to D85927: Enable LSAN for Android.

This caused a build break in our compiler-rt build for Android: use of undeclared identifier '__interceptor_memalign'

Mon, Oct 12, 8:16 AM · Restricted Project

Wed, Oct 7

dmajor created P8239 After loop-vectorize.
Wed, Oct 7, 1:39 PM
dmajor created P8238 Before loop-vectorize.
Wed, Oct 7, 1:38 PM

Mon, Oct 5

dmajor added a comment to D87836: [ARM] Fold select_cc(vecreduce_[u|s][min|max], x) into VMINV or VMAXV.

This caused a failure on the bots: http://lab.llvm.org:8011/builders/clang-x86_64-debian-fast/builds/38144

Mon, Oct 5, 10:49 AM · Restricted Project

Fri, Oct 2

dmajor added a comment to rG3e5f9dacb092: [libc++] Fix tests on GCC 10.

The bots are happy, thanks.

Fri, Oct 2, 4:37 PM
dmajor added a comment to rG3e5f9dacb092: [libc++] Fix tests on GCC 10.

Thanks. I get the impression that libc++ has generally been more aggressive about raising requirements than LLVM overall. My org's crusty and underowned build has been getting caught up in that, so anything that you could codify as an upfront enforcement would be appreciated and probably lead to me bugging you less. =)

Fri, Oct 2, 2:25 PM
dmajor added a comment to rG3e5f9dacb092: [libc++] Fix tests on GCC 10.

Can you move to the runtimes build, which builds libc++ with the just-built Clang instead of with whatever compiler happens to be on your system?

Fri, Oct 2, 2:16 PM
dmajor added a comment to rG3e5f9dacb092: [libc++] Fix tests on GCC 10.

This appears to have broken our stage1 build which uses gcc 7:

Fri, Oct 2, 1:48 PM

Fri, Sep 25

dmajor added a comment to D88005: [clang] [MinGW] Add an implicit .exe suffix even when crosscompiling.

This change broke the configure step of Firefox mingw builds.

Fri, Sep 25, 8:31 PM · Restricted Project

Sep 22 2020

dmajor added a comment to D83004: [UpdateCCTestChecks] Include generated functions if asked.

The expensive-checks bots have been red for several days. Could you please take a look or revert?

Sep 22 2020, 7:56 AM · Restricted Project, Restricted Project

Sep 21 2020

dmajor added a comment to D87163: [DSE] Switch to MemorySSA-backed DSE by default..

I threw as many tests as I could find at 9d172c8e9c84, and I don't see any regressions compared to its parent revision.

Sep 21 2020, 12:32 PM · Restricted Project, Restricted Project

Sep 18 2020

dmajor added a comment to D87917: [Sema] Handle objc_super special lookup when checking builtin compatibility.

Thanks, this fixes the specific translation unit I was looking at today. It's going to take some time before I have full build results but I don't expect any problems.

Sep 18 2020, 11:05 AM · Restricted Project
dmajor added a comment to D77491: [Sema] Introduce BuiltinAttr, per-declaration builtin-ness.

This commit broke Firefox builds on Mac with an error in the SDK headers. Could you please revert if a fix is not readily available?

Sep 18 2020, 9:40 AM · Restricted Project
dmajor added a comment to D87163: [DSE] Switch to MemorySSA-backed DSE by default..

Thanks for the heads up. I'll schedule a more intensive test run over the weekend while there's less demand for machines.

Sep 18 2020, 5:05 AM · Restricted Project, Restricted Project

Sep 17 2020

dmajor added a comment to D87701: Do not apply calling conventions to MSVC entry points.

This broke Firefox builds too, in one of our helper binaries that uses a wWinMain, although I'm having trouble writing a minimal reproducer for it. Simply making a barebones wWinMain program doesn't hit the error.

Sep 17 2020, 1:41 PM · Restricted Project

Sep 16 2020

dmajor added a comment to D87163: [DSE] Switch to MemorySSA-backed DSE by default..

I checked in a fix in https://reviews.llvm.org/rGfc8200633122, but I haven't yet verified it addresses all the failures reported.

Sep 16 2020, 8:42 AM · Restricted Project, Restricted Project

Sep 15 2020

dmajor added a comment to D87163: [DSE] Switch to MemorySSA-backed DSE by default..

Reduced a bit more: https://godbolt.org/z/j59evK (C++) and https://godbolt.org/z/8xG688 (IR) -- the store at line 43 of while.end has been removed.

Sep 15 2020, 9:21 AM · Restricted Project, Restricted Project
dmajor added a comment to D87163: [DSE] Switch to MemorySSA-backed DSE by default..

Here is a reduced-ish repro, I can keep poking at it but maybe this is sufficient for you to notice something: https://godbolt.org/z/endf6d.

Sep 15 2020, 8:50 AM · Restricted Project, Restricted Project

Sep 14 2020

dmajor added a comment to D87163: [DSE] Switch to MemorySSA-backed DSE by default..

I also pushed a fix for a MemorySSA issue that was exposed through DSE + MemorySSA in c4f1b3144184. This might also fix (some) of the failures you are seeing.

Sep 14 2020, 2:22 PM · Restricted Project, Restricted Project
dmajor added a comment to D87163: [DSE] Switch to MemorySSA-backed DSE by default..

Heads-up: We're seeing fairly widespread test failures with this in Chromium that go away when we force this flag off. It's possible that it's due to only a small number of issues and they might be previously-benign UB (no idea), but I figured I'd give an early note. We'll send an update once we've reduced a failing test.

Thanks for the heads-up. I just pushed another fix for the issue @uabelho. I'd guess at least some of the failures you are seeing should be related. If not, I think it makes sense to revert this once we have the reproducers and can work in ironing out the remaining issues.

Sep 14 2020, 1:27 PM · Restricted Project, Restricted Project

Aug 28 2020

dmajor added a comment to D84803: [ThinLTO][Legacy] Compute PreservedGUID based on IRName in Symtab.

Our builds are back to green with that change. I agree that the root cause is likely elsewhere, but getting to the bottom of it would unfortunately take more time than I am able to commit.

Aug 28 2020, 6:09 PM · Restricted Project
dmajor added a comment to D84803: [ThinLTO][Legacy] Compute PreservedGUID based on IRName in Symtab.

Yeah, I wish I could give a nice test case, but it's a huge build and the affected configuration needs a lot of setup so I can't even replicate it locally at the moment.

Aug 28 2020, 1:26 PM · Restricted Project
dmajor added a comment to D84803: [ThinLTO][Legacy] Compute PreservedGUID based on IRName in Symtab.

Hi, we're seeing an assertion failure in one of the Firefox LTO bots:

char llvm::StringRef::operator[](size_t) const: Assertion `Index < Length && "Invalid index!"' failed.

I'm still working on finishing the bisection but I have a hunch that it may be this change. Unfortunately I can't seem to get a backtrace out of this particular bot.

Aug 28 2020, 11:40 AM · Restricted Project

Aug 24 2020

dmajor added a comment to D77152: [SelectionDAG] Better legalization for FSHL and FSHR.

We're seeing a break in the Firefox build after this change:

WidenVectorResult #0: t29: v2i32 = rotl t25, t28, /builds/worker/checkouts/gecko/gfx/angle/checkout/src/image_util/loadimage.cpp:640
Aug 24 2020, 8:59 AM · Restricted Project

Aug 17 2020

dmajor added a comment to D86103: [TSan][libdispatch] Ensure TSan dylib works on old systems.
In D86103#2222585, @yln wrote:

I just discovered that this is still not enough; linking still fails with SDK < 10.14.

Aug 17 2020, 2:38 PM · Restricted Project
dmajor added a comment to D86103: [TSan][libdispatch] Ensure TSan dylib works on old systems.
In D86103#2222302, @yln wrote:

@dmajor: do you have a quick way to check if this unbreaks your builds?
Another follow-up might be required to make the test work: https://reviews.llvm.org/D85995

Aug 17 2020, 1:23 PM · Restricted Project
dmajor added a comment to D85854: [TSan][libdispatch] Add interceptors for dispatch_async_and_wait().

Our automation builds are broken after this change, with undefined symbols for _dispatch_async_and_wait{,_f}. We build using the 10.12 SDK with a deployment target of 10.11. Should this code have a version check?

Aug 17 2020, 8:23 AM · Restricted Project

Aug 10 2020

dmajor added a comment to D85545: [Diagnostics] Diagnose missing comma in string array initialization.

In the Firefox repo this warning is firing on a number of strings that were broken up by clang-format (or humans) for line length, for example https://searchfox.org/mozilla-central/rev/ab81b8552f4aa9696a2524f97fdfeb59d4dc31c1/security/certverifier/ExtendedValidation.cpp#176-178 or https://searchfox.org/mozilla-central/rev/ab81b8552f4aa9696a2524f97fdfeb59d4dc31c1/xpcom/tests/gtest/TestEscape.cpp#103-104 or https://searchfox.org/mozilla-central/rev/ab81b8552f4aa9696a2524f97fdfeb59d4dc31c1/js/src/jsapi-tests/testXDR.cpp#115.

Aug 10 2020, 2:21 PM · Restricted Project

Aug 6 2020

dmajor added a comment to D76885: [lld][COFF][ELF][WebAssembly] Replace --[no-]threads /threads[:no] with --threads={1,2,...} /threads:{1,2,...}.

I've now opened https://github.com/WebAssembly/wasi-sdk/pull/151/ to remove the --no-threads from wasi-sdk, which was a workaround for an old bug that has long been fixed.

Aug 6 2020, 9:52 AM · Restricted Project

Aug 4 2020

dmajor added a comment to D76885: [lld][COFF][ELF][WebAssembly] Replace --[no-]threads /threads[:no] with --threads={1,2,...} /threads:{1,2,...}.

--no-threads is used rarely. So just delete --no-threads instead of keeping it for compatibility for a while.

Aug 4 2020, 12:30 PM · Restricted Project

Aug 3 2020

dmajor added a comment to D82562: Implement AVX ABI Warning/error.

@erichkeane, could you help me understand what is the action item of these warnings?

Aug 3 2020, 12:24 PM · Restricted Project

Jul 23 2020

dmajor added a comment to D84474: [libFuzzer] Add a missing include_directories..

I've confirmed that this fixes our builds, thank you.

Jul 23 2020, 6:15 PM · Restricted Project
dmajor added a comment to D83494: [libFuzzer] Link libFuzzer's own interceptors when other compiler runtimes are not linked..

After this commit, several of our builds are failing with FuzzerInterceptors.cpp:30:10: fatal error: 'sanitizer/common_interface_defs.h' file not found. This is odd because the file certainly seems like it exists. Is there a missing include path somewhere, perhaps?

Jul 23 2020, 3:19 PM · Restricted Project, Restricted Project
dmajor accepted D84418: [libc++] Build the dylib with -faligned-allocation.

Our mac builds are back to green, and no complaints from the other platforms. Thank you!

Jul 23 2020, 10:05 AM · Restricted Project
dmajor added a comment to D83375: [NFC] Separate bitcode reading for FUNC_CODE_INST_CMPXCHG(_OLD).

To connect the dots for anyone following along: this was reverted in cc28058c13e89ecc85dac7e1bd5d13a2ce1bb620.

Jul 23 2020, 8:48 AM · Restricted Project
dmajor added a comment to D84418: [libc++] Build the dylib with -faligned-allocation.

Kicked off a run.

Jul 23 2020, 8:27 AM · Restricted Project
dmajor added a comment to D75243: [libc++] Build the dylib with C++17 to allow aligned new/delete.

Hmmm. There's a few interesting things here. First, I'd like to understand why you're building the dylib with a deployment target of 10.11 -- we usually make the assumption that people building libc++ are vendors, and we take for granted that they're building for new-ish platforms. For example, at Apple, we only build the dylib for the latest OS because that's what the dylib is going into, so using an older deployment target just doesn't make sense. If you have another use case, it might be useful to know about it for the future.

Jul 23 2020, 7:00 AM · Restricted Project

Jul 22 2020

dmajor added a comment to D83219: [ARM] Add MVE_TwoOpPattern. NFC.

We just noticed this in Firefox as well, and I confirmed that 411eb87c7962ec817ab6bf7aa3c737a3159d2d4e fixes the issue for us. Thanks for the fast response!

Jul 22 2020, 4:35 PM · Restricted Project
dmajor added a comment to D81682: [PGO] Extend the value profile buckets for mem op sizes..

The re-landing of this patch in 4a539faf74b9b4c25ee3b880e4007564bd5139b0 causes our PGO build of clang to have thousands of

LLVM Profile Warning: Unable to track new values: Running out of static counters.  Consider using option -mllvm -vp-counters-per-site=<n> to allocate more value profile counters at compile time.

Is that expected? Should the cmake set a higher value of -vp-counters-per-site in self-hosted PGO builds?

Jul 22 2020, 3:11 PM · Restricted Project, Restricted Project
dmajor added a comment to D75243: [libc++] Build the dylib with C++17 to allow aligned new/delete.

In our builds with the 10.12 SDK and MACOSX_DEPLOYMENT_TARGET of 10.11, this is producing

Jul 22 2020, 3:00 PM · Restricted Project

Jul 15 2020

dmajor added a comment to D82148: [compiler-rt][Android] Stop using detect_target_arch.

The revert fixes our build too. Just in time for the 11.0.0 branch, thanks @aeubanks!

Jul 15 2020, 9:37 AM · Restricted Project

Jul 14 2020

dmajor added a comment to D82148: [compiler-rt][Android] Stop using detect_target_arch.

Hi, this commit seems to have caused a problem in Firefox. We're no longer getting a libclang_rt.profile-arm-android.a in our clang package when we request armv7-linux-android. Does arm need special translation similar to the i686->i386 special case?

Jul 14 2020, 12:37 PM · Restricted Project

Jul 8 2020

dmajor added a comment to D76885: [lld][COFF][ELF][WebAssembly] Replace --[no-]threads /threads[:no] with --threads={1,2,...} /threads:{1,2,...}.

I filed https://bugs.llvm.org/show_bug.cgi?id=46641 to make sure it doesn't get lost.

Jul 8 2020, 9:33 AM · Restricted Project
dmajor added a comment to D82717: [InstSimplify] Fold icmp with dominating assume.

After this commit, Firefox builds crash inside the isValidAssumeForContext. I filed https://bugs.llvm.org/show_bug.cgi?id=46638.

Jul 8 2020, 7:56 AM · Restricted Project

Jul 2 2020

dmajor added a comment to D76885: [lld][COFF][ELF][WebAssembly] Replace --[no-]threads /threads[:no] with --threads={1,2,...} /threads:{1,2,...}.

This commit breaks the build when -DLLVM_ENABLE_THREADS=OFF is used. Could you please take a look?

Jul 2 2020, 9:10 AM · Restricted Project

Jun 30 2020

dmajor added a comment to D65543: [Windows] Autolink with basenames and add libdir to libpath.

In that case, more specifically, the problem I'm seeing is that these flags are not making it through to a small handful of files: LLVMHello.dll, PrintFunctionNames.dll, AnnotateFunctions.dll, Attribute.dll. Let me dig in a little deeper...

Jun 30 2020, 9:44 AM · Restricted Project, Restricted Project
dmajor created D82888: [cmake][Windows] Add libpath to CMAKE_MODULE_LINKER_FLAGS too.
Jun 30 2020, 9:44 AM · Restricted Project
dmajor added a comment to D65543: [Windows] Autolink with basenames and add libdir to libpath.

After this change, PGO builds of clang on Windows can no longer find clang_rt.profile-x86_64.lib. Is there some cmake magic that could potentially make this seamless? Or is it expected that the burden is on the user to set up the paths manually during the LLVM_BUILD_INSTRUMENTED phase?

Jun 30 2020, 9:44 AM · Restricted Project, Restricted Project
dmajor added a comment to D65543: [Windows] Autolink with basenames and add libdir to libpath.

After this change, PGO builds of clang on Windows can no longer find clang_rt.profile-x86_64.lib. Is there some cmake magic that could potentially make this seamless? Or is it expected that the burden is on the user to set up the paths manually during the LLVM_BUILD_INSTRUMENTED phase?

Jun 30 2020, 8:39 AM · Restricted Project, Restricted Project

Jun 15 2020

dmajor added a comment to D71786: [Support] On Windows, add optional support for {rpmalloc|snmalloc|mimalloc}.

That was on our c5.4xlarge AWS builders, which have 16 vCPUs according to the docs. I'm not sure offhand whether there is HT involved, but anyway I was testing with this patch applied to LLVM 10 which doesn't have the lldltojobs=all patch.

Jun 15 2020, 9:46 AM · Restricted Project
dmajor added a comment to D71786: [Support] On Windows, add optional support for {rpmalloc|snmalloc|mimalloc}.

Very nice! This reduces the link time of Firefox's xul.dll from 13 minutes to 7 minutes.

Jun 15 2020, 9:13 AM · Restricted Project

May 12 2020

dmajor accepted D79787: [IndVarSimplify][LoopUtils] Avoid TOCTOU/ordering issues (PR45835).

Thanks a lot for taking this over! Looks good from my side but you may wish to wait for a more expert review.

May 12 2020, 9:39 AM · Restricted Project
dmajor added a comment to D79787: [IndVarSimplify][LoopUtils] Avoid TOCTOU/ordering issues (PR45835).

Is it a problem that the test case doesn't fail on trunk before the patch, since SCEVMinMaxExpr is no longer automatically high cost? I noted this in D79720 but wasn't sure how to nudge the code around it.

May 12 2020, 8:01 AM · Restricted Project
dmajor abandoned D79720: [IndVarSimplify][LoopUtils] Track rewrite cost per unique BB (PR45835).

Abandoning in favor of D79787. Thanks!

May 12 2020, 8:01 AM · Restricted Project

May 11 2020

dmajor added a comment to D79720: [IndVarSimplify][LoopUtils] Track rewrite cost per unique BB (PR45835).

Yes, but it is still not obvious to me as to why that happens?
It's the same PHI node, we are asking about the same value, for the same basic block.
Why do we not find expansion first time but do find it second time?
Did we perform some expansion inbetween?

May 11 2020, 11:50 AM · Restricted Project
dmajor added a comment to D79720: [IndVarSimplify][LoopUtils] Track rewrite cost per unique BB (PR45835).

Note: the test case does not currently fail on trunk before this change (although it does fail on the 10.0 release branch, where I would eventually like to get this merged) because after D73744 it is no longer blanket assumed that SCEVMinMaxExpr is high cost. Any pointers on how I could modify the test to get around that? (I'm not familiar with why this IR is considered to have a SCEVMinMaxExpr or what it would take to make it high cost.)

May 11 2020, 9:39 AM · Restricted Project
dmajor created D79720: [IndVarSimplify][LoopUtils] Track rewrite cost per unique BB (PR45835).
May 11 2020, 9:39 AM · Restricted Project

May 5 2020

dmajor accepted D79451: [libclang] Remove duplicate dependency on LLVMSupport.

Thanks for the fast response! lgtm

May 5 2020, 5:17 PM · Restricted Project

Apr 24 2020

dmajor added a comment to D54370: [codeview] Expose -gcodeview-ghash for global type hashing.

Should the directions in http://blog.llvm.org/2018/01/improving-link-time-on-windows-with.html be updated with the new flags?

Apr 24 2020, 8:04 AM

Feb 26 2020

dmajor added a comment to D74784: [driver][darwin] Don't use -platform_version flag by default.

Thanks! I'm still working on getting commit access, would one of you be able to submit for me?

Feb 26 2020, 2:47 PM · Restricted Project, Restricted Project
dmajor updated the diff for D74784: [driver][darwin] Don't use -platform_version flag by default.

Updated the tests: three cases for {default, old, new} linkers in the platform-version tests; left alone the tests not specifically targeting this path.

Feb 26 2020, 9:50 AM · Restricted Project, Restricted Project

Feb 25 2020

dmajor added a comment to D74784: [driver][darwin] Don't use -platform_version flag by default.

@steven_wu, ping, could you clarify about the tests please?

Feb 25 2020, 10:00 AM · Restricted Project, Restricted Project

Feb 19 2020

dmajor added a comment to D74784: [driver][darwin] Don't use -platform_version flag by default.

I forgot if there is reason to use the option by default at all time (I did ask that in the previous review but Alex might have given more context offline).

Feb 19 2020, 9:52 AM · Restricted Project, Restricted Project

Feb 18 2020

dmajor created D74784: [driver][darwin] Don't use -platform_version flag by default.
Feb 18 2020, 12:08 PM · Restricted Project, Restricted Project

Feb 17 2020

dmajor accepted D74501: [TSan] Add CMake check for minimal SDK requirements on Darwin.
In D74501#1879277, @yln wrote:

@dmajor: are you okay with this?

Feb 17 2020, 1:25 PM · Restricted Project, Restricted Project

Feb 12 2020

dmajor added inline comments to D71579: [driver][darwin] Pass -platform_version flag to the linker instead of the -<platform>_version_min flag.
Feb 12 2020, 8:33 AM · Restricted Project, Restricted Project

Feb 10 2020

dmajor added a comment to D71060: [LLD][ELF] Add time-trace to ELF LLD (2/2).

Should this go into the docs / man page / release notes / etc.?

Feb 10 2020, 7:02 AM · Restricted Project

Feb 5 2020

dmajor added a comment to D74059: [TSan] Ensure we can compile the runtime with older SDKs.

Thanks @yln! For posterity, the commit was rGc32d809e9cae8da7d3016b6cb30e2a2a9c9e2762 / https://github.com/llvm/llvm-project/commit/c32d809e9cae8da7d3016b6cb30e2a2a9c9e2762.

Feb 5 2020, 11:52 AM · Restricted Project, Restricted Project
dmajor accepted D74059: [TSan] Ensure we can compile the runtime with older SDKs.

The build was successful, thank you!

Feb 5 2020, 10:43 AM · Restricted Project, Restricted Project

Feb 4 2020

dmajor added a comment to D73973: Revert "[TSan] #include header instead of forward declaring interceptees".

Incidentally I wrote up this same patch and applied it locally earlier today, and our build still fails with the error below. Any ideas?

Feb 4 2020, 9:35 AM · Restricted Project, Restricted Project

Jan 22 2020

dmajor added a comment to D67678: PR17164: Change clang's default behavior from -flax-vector-conversions=all to -flax-vector-conversions=integer..

I noticed that this was merged to the 10.0 release branch. Should the merge be reverted while the dust settles on the trunk implementation?

Jan 22 2020, 12:42 PM · Restricted Project

Jan 8 2020

dmajor added a comment to D72167: Add support for __declspec(guard(nocf)).

I've confirmed that the current patch fixes our CFG failures. Thanks again!

Jan 8 2020, 1:27 PM · Restricted Project, Restricted Project

Jan 7 2020

dmajor added a comment to D72167: Add support for __declspec(guard(nocf)).

Is the current patch an interdiff? It would be helpful to have the diff against the master repo; Phabricator can take care of showing interdiffs if necessary.

Jan 7 2020, 3:24 PM · Restricted Project, Restricted Project

Jan 3 2020

dmajor added a comment to D72167: Add support for __declspec(guard(nocf)).

Thanks for doing this!

Jan 3 2020, 10:53 AM · Restricted Project, Restricted Project

Dec 5 2019

dmajor added a comment to D65761: Add Windows Control Flow Guard checks (/guard:cf)..
In D65761#1772031, @rnk wrote:

I think -fcf-protection and __attribute__((nocf_check)) have to do with CET and Intel's endbranch instruction or what have you. Similar goals, different implementation. I think at this point it's "patches welcome". =S

Dec 5 2019, 6:26 PM · Restricted Project, Restricted Project

Dec 3 2019

dmajor added a comment to D65761: Add Windows Control Flow Guard checks (/guard:cf)..

Are there any plans to implement __declspec(guard(nocf)) or an equivalent mechanism? __attribute__((nocf_check)) doesn't do anything without the -fcf-protection flag. (https://bugs.llvm.org/show_bug.cgi?id=44096)

Dec 3 2019, 6:13 AM · Restricted Project, Restricted Project
dmajor accepted D70910: [compiler-rt] Add a critical section when flushing gcov counters.

This lgtm from the Windows side but I'd feel better if you got an additional review from someone who knows gcov better than me.

Dec 3 2019, 6:04 AM · Restricted Project, Restricted Project

Dec 2 2019

dmajor updated subscribers of D70910: [compiler-rt] Add a critical section when flushing gcov counters.

The extra setup/teardown work for Windows relative to Linux is unfortunate. How would you feel about using an SRWLock instead?

Are there minimum Windows version requirements for compiler-rt? SRWLock is only available on Win7 forward, I think.

Dec 2 2019, 12:27 PM · Restricted Project, Restricted Project
dmajor added a comment to D70910: [compiler-rt] Add a critical section when flushing gcov counters.

The extra setup/teardown work for Windows relative to Linux is unfortunate. How would you feel about using an SRWLock instead? They accept a static initializer. (https://docs.microsoft.com/en-us/windows/win32/sync/slim-reader-writer--srw--locks)

Dec 2 2019, 10:43 AM · Restricted Project, Restricted Project

Nov 19 2019

dmajor added inline comments to D68351: [profile] Add a mode to continuously sync counter updates to a file.
Nov 19 2019, 12:24 PM · Restricted Project, Restricted Project, Restricted Project

Nov 18 2019

dmajor added a comment to D65761: Add Windows Control Flow Guard checks (/guard:cf)..

Hi, I filed https://bugs.llvm.org/show_bug.cgi?id=44049 for some strange crashes that we're seeing because the CFG code overwrites the lower byte of function pointers before jumping to them. (Commenting separately here because I was unable to CC @ajpaverd in Bugzilla)

Nov 18 2019, 12:48 PM · Restricted Project, Restricted Project

Oct 1 2019

dmajor added a comment to D55056: [CMake] Default options for faster executables on MSVC.

For posterity: this was reverted in r361837.

Oct 1 2019, 6:25 AM · Restricted Project