Page MenuHomePhabricator

ldionne (Louis Dionne)
UserAdministrator

Projects

User does not belong to any projects.

User Details

User Since
Feb 11 2015, 3:26 PM (311 w, 10 h)
Roles
Administrator

Recent Activity

Yesterday

ldionne added inline comments to D94807: [libc++] Rationalize our treatment of contiguous iterators and __unwrap_iter()..
Wed, Jan 27, 3:03 PM · Unknown Object (Project)
ldionne added a comment to D90968: Fix for the Bug 41784.

In addition to the comments I made, can you please add tests using the type traits like static_assert(!std::is_copy_constructible_v<std::atomic<int>>);?

Sure, will do it in the next update. I guess I should check both copy constructible and copy assignable there. Anything else?

Wed, Jan 27, 10:59 AM · Unknown Object (Project)
ldionne added a comment to D94807: [libc++] Rationalize our treatment of contiguous iterators and __unwrap_iter()..
In D94807#2520593, @rnk wrote:

In the discussion on the bug with the author of these checked iterators, they seemed OK with relying on implementation details, including re-opening the std::__1 namespaces with the necessary macros to make the __unwrap_iter overload work. I think the optimization only has to work with bundled libc++ version. If that is not in use, the optimization is disabled. I think we might be OK without a properly supported way to do this until we make it to C++20. NaCl is supposed to go away in 2021, so at that point we could probably spring forward and use the officially supported mechanism.

Wed, Jan 27, 10:44 AM · Unknown Object (Project)
ldionne added a comment to D94718: [libc++] Unbreak the debug mode.

Hi @ldionne,

[...]

A possible fix is linking the test within local folder and pass a short library path into the linker such as ./t.tmp.lib. I.e. replace the second RUN line with something like

RUN: cd %T && %{cxx} %{flags} %{compile_flags} %s ./t.tmp.lib %{link_flags} -fPIC -DTU2 -D_LIBCPP_DEBUG=1 -fvisibility=hidden -o %t.exe

I have tested these changes on my local build system and it works, but I'm not sure how it will work on the other systems.

Wed, Jan 27, 10:09 AM · Unknown Object (Project)
ldionne committed rG90407b16b1d3: [libc++] Fix extern template test failing on Windows (authored by ldionne).
[libc++] Fix extern template test failing on Windows
Wed, Jan 27, 10:09 AM
ldionne accepted D93512: [libc++] [P0879] constexpr heap and partial_sort algorithms.

@ldionne: I don't think buildkite is ever going to finish a build here. I propose that you approve this revision and I just go again and land it, and we'll see what happens with the buildbots after that. (If it somehow does break buildbots, we can revert it.) Thoughts?

Wed, Jan 27, 6:17 AM · Unknown Object (Project)

Tue, Jan 26

ldionne committed rG4210b87020b9: [libc++] Fix oss-fuzz build (authored by ldionne).
[libc++] Fix oss-fuzz build
Tue, Jan 26, 12:31 PM

Mon, Jan 25

ldionne added inline comments to D93512: [libc++] [P0879] constexpr heap and partial_sort algorithms.
Mon, Jan 25, 12:47 PM · Unknown Object (Project)
ldionne added a comment to D92044: Implement P0655R1 visit<R>: Explicit Return Type for visit.

Thanks a lot Nico. The back story is that CI didn't run for that revision due to a misconfigured repository on the Phab revision. This is a great reminder that we should never skip pre-commit CI for non-trivial changes. This is my fault, I should have requested that the author updates the patch with a proper repository set so CI would trigger.

Mon, Jan 25, 12:16 PM · Unknown Object (Project)
ldionne committed rG9d5095875754: [libc++] Fix build after 51faba35fd81fbd3af407a29c136895a718ccd96 (authored by rarutyun).
[libc++] Fix build after 51faba35fd81fbd3af407a29c136895a718ccd96
Mon, Jan 25, 10:41 AM
ldionne closed D95372: Follow up build fix for P0655R1 visit<R>: Explicit Return Type for visit.
Mon, Jan 25, 10:41 AM · Unknown Object (Project)
ldionne added a comment to D95372: Follow up build fix for P0655R1 visit<R>: Explicit Return Type for visit.

Ah, now I understand. This change is necessary to fix the build after https://reviews.llvm.org/D92044. The problem is that CI didn't run for that revision, so we didn't catch the failure. When you submit a patch, please make sure to follow the arc diff instructions here: https://llvm.org/docs/Phabricator.html#requesting-a-review-via-the-command-line.

Mon, Jan 25, 10:37 AM · Unknown Object (Project)
ldionne accepted D95372: Follow up build fix for P0655R1 visit<R>: Explicit Return Type for visit.

Will commit once CI passes.

Mon, Jan 25, 9:32 AM · Unknown Object (Project)
ldionne requested changes to D93557: [libc++] [P0879] constexpr std::nth_element, and rewrite its tests..

Can you please ping me once CI passes?

Mon, Jan 25, 9:14 AM · Unknown Object (Project)
ldionne accepted D95248: [libc++][doc] Update the release notes.

Thanks a lot! This looks good.

Mon, Jan 25, 9:13 AM · Unknown Object (Project)
ldionne requested changes to D93661: [libc++] [P0879] constexpr std::sort, and add new tests for it.

What's the status of this? Can you please rebase so CI runs (there were some CI issues during the holidays, I remember patch application failing). Ping me when this is ready for review, until then I'm marking as "changes requested".

Mon, Jan 25, 9:10 AM · Unknown Object (Project)
ldionne requested changes to D93512: [libc++] [P0879] constexpr heap and partial_sort algorithms.

Generally looks good, I'm just asking for a bit more manual testing. Thanks a lot for working on this, I love that we're removing dependencies on <random>.

Mon, Jan 25, 9:08 AM · Unknown Object (Project)
ldionne accepted D93443: [libc++] [P0879] constexpr reverse, partition, *_permutation.
Mon, Jan 25, 9:00 AM · Unknown Object (Project)
ldionne requested changes to D94807: [libc++] Rationalize our treatment of contiguous iterators and __unwrap_iter()..

I like this - I find it cleaner than a "private contract" with some specific users that they are allowed to overload __unwrap_iter. But I'd like to know why can't we leave that only enabled in C++20 mode. @rnk Would it be acceptable for Chrome to compile with C++20? It seems like an optimization that would justify the work to upgrade?

Mon, Jan 25, 8:56 AM · Unknown Object (Project)
ldionne added a comment to D92776: [libc++] ADL-proof <algorithm> by adding _VSTD:: qualification on calls..

We definitely want to unqualify __unwrap_iter to unbreak chromium. That's somewhat intended to be a customization point (until the proper contiguous iterator stuff lands).

Mon, Jan 25, 8:42 AM · Unknown Object (Project)
ldionne accepted D93819: [libc++] Implement [P0769] "Add shift to algorithm" (shift_left, shift_right).

The P-numbered paper doesn't match what was actually landed in http://eel.is/c++draft/alg.shift .

Mon, Jan 25, 8:18 AM · Unknown Object (Project)
ldionne committed rG51faba35fd81: [libc++] Implement P0655R1 visit<R>: Explicit Return Type for visit (authored by rarutyun).
[libc++] Implement P0655R1 visit<R>: Explicit Return Type for visit
Mon, Jan 25, 8:15 AM
ldionne closed D92044: Implement P0655R1 visit<R>: Explicit Return Type for visit.
Mon, Jan 25, 8:15 AM · Unknown Object (Project)
ldionne accepted D94571: [libcxx] random_device, for OpenBSD specify optimal entropy properties.
Mon, Jan 25, 7:40 AM · Unknown Object (Project)
ldionne requested changes to D93971: Add freestanding parameter to libcxx lit.
Mon, Jan 25, 7:39 AM · Unknown Object (Project)
ldionne accepted D94452: [libc++] Support immovable return types in std::function..

LGTM once CI passes (after you silence the GCC warning). Ship it once it does!

Mon, Jan 25, 7:32 AM · Unknown Object (Project)

Fri, Jan 22

ldionne accepted D94908: [libc++] Introduce __bits.
Fri, Jan 22, 12:06 PM · Unknown Object (Project)
ldionne committed rGfaa440786ccf: [libc++] Bring back mach_absolute_time implementation of steady_clock (authored by ldionne).
[libc++] Bring back mach_absolute_time implementation of steady_clock
Fri, Jan 22, 11:54 AM
ldionne closed D95177: [libc++] Bring back mach_absolute_time implementation of steady_clock.
Fri, Jan 22, 11:54 AM · Unknown Object (Project)
ldionne accepted D95177: [libc++] Bring back mach_absolute_time implementation of steady_clock.
In D95177#2516251, @rnk wrote:

I patched this in and confirmed that it fixes our build issue, thanks!

I see that you didn't change the documentation back to claim support for Mac 10.9. That's fine with me, I consider this to be a temporary state of affairs.

Fri, Jan 22, 11:53 AM · Unknown Object (Project)
ldionne added a comment to D95248: [libc++][doc] Update the release notes.

Thanks a lot for doing this! This is great - historically we haven't been very good at communicating what we've done in libc++ from one release to another, but this is much better.

Fri, Jan 22, 10:33 AM · Unknown Object (Project)
ldionne committed rG03b6dc300531: [libc++] Fix broken build when merging libc++abi into libc++ on Apple (authored by ldionne).
[libc++] Fix broken build when merging libc++abi into libc++ on Apple
Fri, Jan 22, 9:40 AM
ldionne added a comment to D94924: [libc++] first steps of a private modulemap.

I would rather expect that we have to split some headers into smaller/modular ones.

Fri, Jan 22, 7:03 AM · Unknown Object (Project)

Thu, Jan 21

ldionne added a comment to D95177: [libc++] Bring back mach_absolute_time implementation of steady_clock.

Please try this out and let me know if that solves your problems.

Thu, Jan 21, 2:56 PM · Unknown Object (Project)
ldionne added a comment to D74489: [libc++] Remove workarounds for the lack of clock_gettime on older macOS platforms.

See tentative fix in https://reviews.llvm.org/D95177

Thu, Jan 21, 2:55 PM · Unknown Object (Project)
ldionne requested review of D95177: [libc++] Bring back mach_absolute_time implementation of steady_clock.
Thu, Jan 21, 2:54 PM · Unknown Object (Project)
ldionne added a comment to D94924: [libc++] first steps of a private modulemap.
  1. You don't have to do anything.
  2. If you use -fcxx-modules, it reduces the size of the surface of the std module. The std_private module is hidden from users. There is a " // FIXME: These should be private." in the module.modulemap. These headers should not be visible to users of the std module. The private module is exactly trying to do that.
Thu, Jan 21, 1:55 PM · Unknown Object (Project)
ldionne added a comment to D93190: [libc++abi] Simplify scan_eh_tab.

This really isn't in my area, so I'm deferring to @compnerd . Please feel free to go ahead. :-)

Thu, Jan 21, 1:52 PM · Unknown Object (Project)
ldionne added a comment to D88189: [libc++abi] Add an option to avoid demangling in terminate..

Sorry this got through the cracks.

Thu, Jan 21, 1:40 PM · Unknown Object (Project)
ldionne added inline comments to D94452: [libc++] Support immovable return types in std::function..
Thu, Jan 21, 12:40 PM · Unknown Object (Project)
ldionne requested changes to D94452: [libc++] Support immovable return types in std::function..
Thu, Jan 21, 11:52 AM · Unknown Object (Project)
ldionne added a comment to D94924: [libc++] first steps of a private modulemap.

Generally speaking, I have no objection with doing this if it's an improvement. But I don't understand the benefits / tradeoffs here cause I don't have much experience with Clang modules (so far the libc++ Clang modules are kind of a side thing maintained by people who care about it, but we still use the non-modular build by default). Can you explain what introducing private modules is going to buy us, and what sort of changes are going to be required? Will this have any visible change for people building with -fcxx-modules or -fmodules today?

Thu, Jan 21, 7:55 AM · Unknown Object (Project)
ldionne accepted D94564: [libcxx] Check return value for asprintf().

LGTM, thanks!

Thu, Jan 21, 7:45 AM · Unknown Object (Project)
ldionne accepted D94953: [libc++] Use ioctl when available to get random_device entropy..

LGTM, thanks!

Thu, Jan 21, 7:42 AM · Unknown Object (Project)
ldionne added a comment to D93922: Itanium Mangling: Mangle `__alignof__` differently than `alignof`..

Was the "group" libc++abi accept intended to be an accept for the whole revision? Or should still ping for review from rsmith or someone else?

Thu, Jan 21, 7:11 AM · Restricted Project, Unknown Object (Project), Restricted Project

Wed, Jan 20

ldionne accepted D94452: [libc++] Support immovable return types in std::function..

Per the discussion on the LWG reflector, this LGTM.

Wed, Jan 20, 10:27 AM · Unknown Object (Project)
ldionne added a comment to D95055: [clang] Don't look into <sysroot> for C++ headers if they are found alongside the toolchain.

I would like to cherry-pick this change onto LLVM 11.1.0, if there is still time to do so. It is breaking Clang when the sysroot contains headers for libc++. Is it too late?

Wed, Jan 20, 9:30 AM · Restricted Project
ldionne requested review of D95055: [clang] Don't look into <sysroot> for C++ headers if they are found alongside the toolchain.
Wed, Jan 20, 9:18 AM · Restricted Project
ldionne committed rG6c1bc0d24cea: [docs] Fix overly specific link to uploading patches on Phabricator (authored by ldionne).
[docs] Fix overly specific link to uploading patches on Phabricator
Wed, Jan 20, 8:14 AM
ldionne closed D94929: [docs] Fix overly specific link to uploading patches on Phabricator.
Wed, Jan 20, 8:14 AM · Restricted Project
ldionne updated the diff for D94929: [docs] Fix overly specific link to uploading patches on Phabricator.

Fix broken link (I generated the documentation to test, this time).

Wed, Jan 20, 8:14 AM · Restricted Project

Tue, Jan 19

ldionne requested changes to D94924: [libc++] first steps of a private modulemap.

Is this ready for review? If not, please ping me when it is. In the meantime, I'll "request changes" so it shows up correctly in the queue.

Tue, Jan 19, 12:00 PM · Unknown Object (Project)
ldionne added a comment to D94571: [libcxx] random_device, for OpenBSD specify optimal entropy properties.

@ldionne I don't understand how a Linux specific diff would help with another operating system. I could update this after D94953 goes in and eliminate the first chunk.

Tue, Jan 19, 11:48 AM · Unknown Object (Project)
ldionne added inline comments to D94953: [libc++] Use ioctl when available to get random_device entropy..
Tue, Jan 19, 11:48 AM · Unknown Object (Project)
ldionne added a comment to D93912: [libc++][P1679] add string contains.

Thanks for your contribution!

Tue, Jan 19, 11:35 AM · Unknown Object (Project)
ldionne committed rG6ac9cb2a7c6c: [libc++][P1679] add string contains (authored by WimLeflere).
[libc++][P1679] add string contains
Tue, Jan 19, 11:35 AM
ldionne closed D93912: [libc++][P1679] add string contains.
Tue, Jan 19, 11:35 AM · Unknown Object (Project)
ldionne accepted D93912: [libc++][P1679] add string contains.

It's unclear to me if I should add noexcept to the const char* overloads.

I think @mclow.lists is right. We shouldn't have noexcept here, and we also need to remove it from some of the __str_find overloads (as a separate patch, which I'm happy to make).

Tue, Jan 19, 11:33 AM · Unknown Object (Project)
ldionne requested changes to D90968: Fix for the Bug 41784.

In addition to the comments I made, can you please add tests using the type traits like static_assert(!std::is_copy_constructible_v<std::atomic<int>>);?

Tue, Jan 19, 11:24 AM · Unknown Object (Project)
ldionne committed rG933518fff82c: [libc++] Make LIBCXX_ENABLE_FILESYSTEM fully consistent (authored by ldionne).
[libc++] Make LIBCXX_ENABLE_FILESYSTEM fully consistent
Tue, Jan 19, 11:16 AM
ldionne closed D94921: [libc++] Make LIBCXX_ENABLE_FILESYSTEM fully consistent.
Tue, Jan 19, 11:16 AM · Unknown Object (Project)
ldionne committed rG68dba7eae1df: [libc++] Unbreak the debug mode (authored by ldionne).
[libc++] Unbreak the debug mode
Tue, Jan 19, 11:15 AM
ldionne closed D94718: [libc++] Unbreak the debug mode.
Tue, Jan 19, 11:15 AM · Unknown Object (Project)
ldionne accepted D94921: [libc++] Make LIBCXX_ENABLE_FILESYSTEM fully consistent.
Tue, Jan 19, 11:12 AM · Unknown Object (Project)
ldionne added inline comments to D92229: [libc++] Update clang-format configuration.
Tue, Jan 19, 10:45 AM · Unknown Object (Project)
ldionne updated the diff for D94983: [libc++] Make feature-test macros consistent with availability macros.

Re-generate feature-test macros after fixing the typo.

Tue, Jan 19, 10:26 AM · Unknown Object (Project)
ldionne added a comment to D94983: [libc++] Make feature-test macros consistent with availability macros.

Note that I expect to have to make changes to the tests. I'm submitting a patch mainly to run the CI.

Tue, Jan 19, 10:25 AM · Unknown Object (Project)
ldionne updated the diff for D94983: [libc++] Make feature-test macros consistent with availability macros.

Fix typo.

Tue, Jan 19, 10:25 AM · Unknown Object (Project)
ldionne requested review of D94983: [libc++] Make feature-test macros consistent with availability macros.
Tue, Jan 19, 10:24 AM · Unknown Object (Project)
ldionne added a comment to D91630: [Parse] Add parsing support for C++ attributes on using-declarations.

Gentle ping! Can we merge this? I'd love to move forward with https://reviews.llvm.org/D90257.

Tue, Jan 19, 8:59 AM
ldionne accepted D91004: [libc++] Implements concept destructible.

LGTM. Feel free to commit after fixing the minor comments.

Tue, Jan 19, 8:31 AM · Unknown Object (Project)
ldionne requested changes to D92214: [libc++] Implement format_error..
Tue, Jan 19, 8:09 AM · Unknown Object (Project)
ldionne updated the diff for D94921: [libc++] Make LIBCXX_ENABLE_FILESYSTEM fully consistent.

Fix modules tests.

Tue, Jan 19, 7:33 AM · Unknown Object (Project)
ldionne added a comment to D94571: [libcxx] random_device, for OpenBSD specify optimal entropy properties.

@brad I suggest we abandon this in favour of D94953. Does it solve your problem?

Tue, Jan 19, 7:28 AM · Unknown Object (Project)
ldionne requested changes to D94953: [libc++] Use ioctl when available to get random_device entropy..

@tcanens You may want to consider updating cppreference in light of this patch when it gets in.

Tue, Jan 19, 7:22 AM · Unknown Object (Project)
ldionne accepted D94969: [libc++] Split re.alg tests into locale-dependent and independent tests.

LGTM once CI passes!

Tue, Jan 19, 7:17 AM · Unknown Object (Project)

Mon, Jan 18

ldionne requested changes to D94452: [libc++] Support immovable return types in std::function..

I think allowing a non-copyable type to be returned makes more sense, however I think this needs a LWG issue so we can clear any doubts on the standardese. Are you willing to file it?

Mon, Jan 18, 2:50 PM · Unknown Object (Project)
ldionne added inline comments to D93912: [libc++][P1679] add string contains.
Mon, Jan 18, 2:49 PM · Unknown Object (Project)
ldionne requested changes to D93912: [libc++][P1679] add string contains.

Thanks Arthur. Indeed, this doesn't apply cleanly on top of main. Please rebase and address Arthur's comments. Requesting changes just so it shows up in the review queue, but this LGTM except for what I just said.

Mon, Jan 18, 2:41 PM · Unknown Object (Project)
ldionne committed rG2cb4a96a99e8: [libc++] NFCI: Refactor allocator_traits (authored by ldionne).
[libc++] NFCI: Refactor allocator_traits
Mon, Jan 18, 2:38 PM
ldionne closed D94544: [libc++] NFCI: Refactor allocator_traits.
Mon, Jan 18, 2:37 PM · Unknown Object (Project)
ldionne accepted D94544: [libc++] NFCI: Refactor allocator_traits.

Thanks for the review Zoe!

Mon, Jan 18, 2:36 PM · Unknown Object (Project)
ldionne added a comment to D92044: Implement P0655R1 visit<R>: Explicit Return Type for visit.

Do you need help committing this?

I think so.

I would prefer to go through this path myself, to make commits directly (if it's possible and if I have enough permissions to do that). It's just may save the time of other people and your time in particular:) Currently, I just don't know what to do. So if you (or somebody else) can teach me it would be great.

But I don't mind if you merge it yourself. Please choose the way that works better for you.

Mon, Jan 18, 2:35 PM · Unknown Object (Project)
ldionne requested changes to D93819: [libc++] Implement [P0769] "Add shift to algorithm" (shift_left, shift_right).

I'm not done with the review, but I figured I might as well give you the feedback I have right away.

Mon, Jan 18, 2:29 PM · Unknown Object (Project)
ldionne requested changes to D94569: [libcxx] Wipe some more macros that do not belong in C++ forwarding headers.

These symbols are usually macros + libc calls.

Mon, Jan 18, 1:01 PM · Unknown Object (Project)
ldionne added a comment to D93912: [libc++][P1679] add string contains.

@Quuxplusone Arthur, did you still have objections? If not, please accept and I'll commit this.

Mon, Jan 18, 12:40 PM · Unknown Object (Project)
ldionne accepted D93912: [libc++][P1679] add string contains.
Mon, Jan 18, 12:39 PM · Unknown Object (Project)
ldionne committed rG2776be43f0c2: [libc++] improve feature test macro script (authored by WimLeflere).
[libc++] improve feature test macro script
Mon, Jan 18, 12:19 PM
ldionne closed D94530: [libc++] improve feature test macro script.
Mon, Jan 18, 12:19 PM · Unknown Object (Project)
ldionne added a comment to D94530: [libc++] improve feature test macro script.

Do you need help committing this? If so, please provide Author Name <email@domain>. Thanks!

Is it an action I can take in the web interface?
Do I need certain access rights?

Info: Wim Leflere wim.leflere@gmail.com

Mon, Jan 18, 12:16 PM · Unknown Object (Project)
ldionne requested review of D94929: [docs] Fix overly specific link to uploading patches on Phabricator.
Mon, Jan 18, 12:15 PM · Restricted Project
ldionne accepted D91292: [libc++] [P0935] [C++20] Eradicating unnecessarily explicit default constructors from the standard library..

I didn't look again in detail, but I remember I was OK with the patch except for the question of whether to implement it as a DR. This has been settled now, so this LGTM. Thanks!

Mon, Jan 18, 12:01 PM · Unknown Object (Project)
ldionne accepted D94530: [libc++] improve feature test macro script.

Do you need help committing this? If so, please provide Author Name <email@domain>. Thanks!

Mon, Jan 18, 11:58 AM · Unknown Object (Project)
ldionne accepted D92044: Implement P0655R1 visit<R>: Explicit Return Type for visit.

Do you need help committing this?

Mon, Jan 18, 11:48 AM · Unknown Object (Project)
ldionne set the repository for D92044: Implement P0655R1 visit<R>: Explicit Return Type for visit to rG LLVM Github Monorepo.
Mon, Jan 18, 11:46 AM · Unknown Object (Project)
ldionne committed rG01a13f127a8b: [libc++] Rename check-cxx-deps to cxx-test-depends for consistency (authored by ldionne).
[libc++] Rename check-cxx-deps to cxx-test-depends for consistency
Mon, Jan 18, 11:42 AM
ldionne closed D94499: [libc++] Rename check-cxx-deps to cxx-test-depends for consistency.
Mon, Jan 18, 11:42 AM · Unknown Object (Project)
ldionne accepted D94499: [libc++] Rename check-cxx-deps to cxx-test-depends for consistency.
Mon, Jan 18, 11:41 AM · Restricted Project
ldionne added a comment to D94499: [libc++] Rename check-cxx-deps to cxx-test-depends for consistency.

LGTM!

Can / should this be added to the catch-all test-depends as well? (I thought llvm-test-depends and clang-test-depends were both added there somewhere, although I admit I just the code and I don't see it...) Regardless, this could be done separately / later if it makes sense to do.

Mon, Jan 18, 11:41 AM · Restricted Project
ldionne added inline comments to D94544: [libc++] NFCI: Refactor allocator_traits.
Mon, Jan 18, 11:38 AM · Restricted Project