This is an archive of the discontinued LLVM Phabricator instance.

[mlir] Split BufferUtils.h out of Bufferize.h
ClosedPublic

Authored by silvas on Nov 16 2020, 1:13 PM.

Details

Summary

These utilities are more closely associated with the buffer
optimizations and buffer deallocation than with the dialect conversion
stuff in Bufferize.h. So move them out.

This makes Bufferize.h very easy to understand and completely focused on
dialect conversion.

Diff Detail

Event Timeline

silvas created this revision.Nov 16 2020, 1:13 PM
silvas requested review of this revision.Nov 16 2020, 1:13 PM
dfki-jugr added inline comments.Nov 17 2020, 1:32 AM
mlir/lib/Transforms/BufferUtils.cpp
28

Is it useful to have a copy here and in BufferDeallocation since it introduces code duplication?

47

missing third /
withing -> within

silvas updated this revision to Diff 305880.Nov 17 2020, 12:22 PM

Address comments.

mlir/lib/Transforms/BufferUtils.cpp
28

Actually, the helper is redundant. I replaced it with regionInterface.getSuccessorRegions(index, successors)

dfki-jugr accepted this revision.Nov 18 2020, 12:02 AM
This revision is now accepted and ready to land.Nov 18 2020, 12:02 AM
This revision was automatically updated to reflect the committed changes.