Page MenuHomePhabricator

dfki-jugr (Julian Gross)
User

Projects

User does not belong to any projects.

User Details

User Since
Jan 9 2020, 1:31 AM (53 w, 2 d)

Recent Activity

Wed, Jan 13

dfki-jugr added reviewers for D94586: Added check if there are regions that do not implement the RegionBranchOpInterface.: herhut, bondhugula.
Wed, Jan 13, 2:56 AM · Restricted Project
dfki-jugr requested review of D94586: Added check if there are regions that do not implement the RegionBranchOpInterface..
Wed, Jan 13, 2:54 AM · Restricted Project

Mon, Jan 11

dfki-jugr accepted D94351: [mlir][docs] Bring bufferization docs up to date..
Mon, Jan 11, 1:08 AM · Restricted Project

Dec 3 2020

dfki-jugr committed rG8aeca73702d8: [MLIR] Added support for dynamic shaped allocas to promote-buffers-to-stack… (authored by dfki-jugr).
[MLIR] Added support for dynamic shaped allocas to promote-buffers-to-stack…
Dec 3 2020, 2:49 AM
dfki-jugr closed D91969: [MLIR] Added support for dynamic shaped allocas to promote-buffers-to-stack pass..
Dec 3 2020, 2:48 AM · Restricted Project

Dec 1 2020

dfki-jugr updated the diff for D91969: [MLIR] Added support for dynamic shaped allocas to promote-buffers-to-stack pass..

Addressed comments.

Dec 1 2020, 4:31 AM · Restricted Project

Nov 25 2020

dfki-jugr added inline comments to D91969: [MLIR] Added support for dynamic shaped allocas to promote-buffers-to-stack pass..
Nov 25 2020, 7:18 AM · Restricted Project
dfki-jugr updated the diff for D91969: [MLIR] Added support for dynamic shaped allocas to promote-buffers-to-stack pass..

Addressed comments.
Changed default max rank to 1 instead of 2 and changed condition to less or equal.
This way is more intuitive.

Nov 25 2020, 7:17 AM · Restricted Project

Nov 24 2020

dfki-jugr updated the diff for D91969: [MLIR] Added support for dynamic shaped allocas to promote-buffers-to-stack pass..

Addressed comments.
Introduce transformation if the alloc operands are RankOps.

Nov 24 2020, 7:39 AM · Restricted Project

Nov 23 2020

dfki-jugr added reviewers for D91969: [MLIR] Added support for dynamic shaped allocas to promote-buffers-to-stack pass.: herhut, pifon2a.
Nov 23 2020, 7:43 AM · Restricted Project
dfki-jugr requested review of D91969: [MLIR] Added support for dynamic shaped allocas to promote-buffers-to-stack pass..
Nov 23 2020, 7:42 AM · Restricted Project

Nov 18 2020

dfki-jugr accepted D91563: [mlir] Split BufferUtils.h out of Bufferize.h.
Nov 18 2020, 12:02 AM · Restricted Project

Nov 17 2020

dfki-jugr added inline comments to D91563: [mlir] Split BufferUtils.h out of Bufferize.h.
Nov 17 2020, 1:32 AM · Restricted Project

Nov 13 2020

dfki-jugr abandoned D73713: Fixed non-deterministic GPU intrinsic lowering..
Nov 13 2020, 1:31 AM · Restricted Project, Restricted Project
dfki-jugr added a comment to D90675: [MLIR] Added documentation and manual to use bufferization features..

Hello! It looks like this documentation is a bit outdated. For example, setResultConversionKind method was removed and replaced with separate pass (see https://github.com/llvm/llvm-project/commit/f7bc56826616814a656866fd50e90a35a8e461eb). Is there any plans to update this documentation?

Nov 13 2020, 12:50 AM · Restricted Project
dfki-jugr accepted D91360: [mlir][bufferize] Fix buffer promotion to stack for index types.
Nov 13 2020, 12:29 AM · Restricted Project

Nov 12 2020

dfki-jugr committed rG0313e3bfe6e2: [MLIR] Added documentation and manual to use bufferization features. (authored by dfki-jugr).
[MLIR] Added documentation and manual to use bufferization features.
Nov 12 2020, 1:43 AM
dfki-jugr closed D90675: [MLIR] Added documentation and manual to use bufferization features..
Nov 12 2020, 1:43 AM · Restricted Project

Nov 5 2020

dfki-jugr updated the diff for D90675: [MLIR] Added documentation and manual to use bufferization features..

Addressed comments

Nov 5 2020, 1:20 AM · Restricted Project
dfki-jugr added inline comments to D90675: [MLIR] Added documentation and manual to use bufferization features..
Nov 5 2020, 1:17 AM · Restricted Project

Nov 3 2020

dfki-jugr added reviewers for D90675: [MLIR] Added documentation and manual to use bufferization features.: herhut, pifon2a, dfki-heme, dfki-albo, dfki-mako.
Nov 3 2020, 3:42 AM · Restricted Project
dfki-jugr requested review of D90675: [MLIR] Added documentation and manual to use bufferization features..
Nov 3 2020, 3:41 AM · Restricted Project

Oct 23 2020

dfki-jugr committed rG0d1d363c51c9: [MLIR] Added PromoteBuffersToStackPass to convert heap- to stack-based… (authored by dfki-jugr).
[MLIR] Added PromoteBuffersToStackPass to convert heap- to stack-based…
Oct 23 2020, 3:12 AM
dfki-jugr closed D89688: [MLIR] Added PromoteBuffersToStackPass to convert heap-based allocations to stack-based allocations..
Oct 23 2020, 3:11 AM · Restricted Project

Oct 22 2020

dfki-jugr updated the diff for D89688: [MLIR] Added PromoteBuffersToStackPass to convert heap-based allocations to stack-based allocations..

Addressed comments.

Oct 22 2020, 7:23 AM · Restricted Project

Oct 21 2020

dfki-jugr updated the diff for D89688: [MLIR] Added PromoteBuffersToStackPass to convert heap-based allocations to stack-based allocations..

Addressed comments.

Oct 21 2020, 2:46 AM · Restricted Project

Oct 19 2020

dfki-jugr added inline comments to D89688: [MLIR] Added PromoteBuffersToStackPass to convert heap-based allocations to stack-based allocations..
Oct 19 2020, 8:00 AM · Restricted Project
dfki-jugr updated the diff for D89688: [MLIR] Added PromoteBuffersToStackPass to convert heap-based allocations to stack-based allocations..

Addressed comments.

Oct 19 2020, 7:57 AM · Restricted Project
dfki-jugr added reviewers for D89688: [MLIR] Added PromoteBuffersToStackPass to convert heap-based allocations to stack-based allocations.: herhut, pifon2a.
Oct 19 2020, 4:52 AM · Restricted Project
dfki-jugr requested review of D89688: [MLIR] Added PromoteBuffersToStackPass to convert heap-based allocations to stack-based allocations..
Oct 19 2020, 4:51 AM · Restricted Project

Aug 3 2020

dfki-jugr committed rG6d47431d7eee: [mlir] Extended Buffer Assignment to support AllocaOps. (authored by dfki-jugr).
[mlir] Extended Buffer Assignment to support AllocaOps.
Aug 3 2020, 2:24 AM
dfki-jugr closed D85017: [mlir] Extended Buffer Assignment to support AllocaOps..
Aug 3 2020, 2:23 AM · Restricted Project

Jul 31 2020

dfki-jugr updated the diff for D85017: [mlir] Extended Buffer Assignment to support AllocaOps..

Changed check to exclude automatic allocation scope resources.

Jul 31 2020, 4:33 AM · Restricted Project
dfki-jugr added reviewers for D85017: [mlir] Extended Buffer Assignment to support AllocaOps.: herhut, pifon2a.
Jul 31 2020, 3:44 AM · Restricted Project
dfki-jugr requested review of D85017: [mlir] Extended Buffer Assignment to support AllocaOps..
Jul 31 2020, 3:42 AM · Restricted Project

Jul 3 2020

dfki-jugr committed rG91c320e9d852: [mlir] Add check for ViewLikeOpInterface that creates additional aliases. (authored by dfki-jugr).
[mlir] Add check for ViewLikeOpInterface that creates additional aliases.
Jul 3 2020, 8:03 AM
dfki-jugr closed D83044: [mlir] Add check for ViewLikeOpInterface that creates additional aliases..
Jul 3 2020, 8:02 AM · Restricted Project
dfki-jugr retitled D83044: [mlir] Add check for ViewLikeOpInterface that creates additional aliases. from [mlir] Add check for MemRefCastOp that creates additional aliases. to [mlir] Add check for ViewLikeOpInterface that creates additional aliases..
Jul 3 2020, 4:49 AM · Restricted Project
dfki-jugr updated the diff for D83044: [mlir] Add check for ViewLikeOpInterface that creates additional aliases..

Changed from a specialized MemRefCastOp version to a more general ViewLikeOpInterface version.
Adapt test case, since MemRefCastOp is currently not a ViewLikeOp.

Jul 3 2020, 3:44 AM · Restricted Project

Jul 2 2020

dfki-jugr added reviewers for D83044: [mlir] Add check for ViewLikeOpInterface that creates additional aliases.: herhut, pifon2a.
Jul 2 2020, 6:25 AM · Restricted Project
dfki-jugr created D83044: [mlir] Add check for ViewLikeOpInterface that creates additional aliases..
Jul 2 2020, 6:25 AM · Restricted Project

Apr 28 2020

dfki-jugr added inline comments to D78619: [mlir] Extended Alloc and Dealloc operations with memory-effect traits..
Apr 28 2020, 6:24 AM · Restricted Project, Restricted Project

Apr 27 2020

dfki-jugr committed rG262108e12ed9: [mlir] Extended Alloc and Dealloc operations with memory-effect traits. (authored by dfki-jugr).
[mlir] Extended Alloc and Dealloc operations with memory-effect traits.
Apr 27 2020, 3:43 AM
dfki-jugr closed D78619: [mlir] Extended Alloc and Dealloc operations with memory-effect traits..
Apr 27 2020, 3:43 AM · Restricted Project, Restricted Project
dfki-jugr added inline comments to D78619: [mlir] Extended Alloc and Dealloc operations with memory-effect traits..
Apr 27 2020, 2:05 AM · Restricted Project, Restricted Project

Apr 22 2020

dfki-jugr updated the diff for D78619: [mlir] Extended Alloc and Dealloc operations with memory-effect traits..

Updated commit message and added a short summary.

Apr 22 2020, 4:17 AM · Restricted Project, Restricted Project
dfki-jugr created D78619: [mlir] Extended Alloc and Dealloc operations with memory-effect traits..
Apr 22 2020, 2:40 AM · Restricted Project, Restricted Project
dfki-jugr added reviewers for D78619: [mlir] Extended Alloc and Dealloc operations with memory-effect traits.: mehdi_amini, nicolasvasilache, pifon2a.
Apr 22 2020, 2:40 AM · Restricted Project, Restricted Project

Feb 6 2020

dfki-jugr added a comment to D73713: Fixed non-deterministic GPU intrinsic lowering..

@rriddle I've tried to come up with a minimal example including a new dialect. However, the issue does not occur in simple cases on our testing machines. The easiest way to dive into this issue would be to move line 728 in LowerGPUOpsToNNVMOps.cc to 750:

Feb 6 2020, 3:36 AM · Restricted Project, Restricted Project
Herald added a reviewer for D73713: Fixed non-deterministic GPU intrinsic lowering.: mravishankar.

@mehdi_amini I fully get your point and I totally agree that we should not hide underlying bugs. However, you can argue as soon as two pattern matchers have the same benefit their ordering will be undefinied. In this case, the only possible solution you have, is to change the pattern matcher benefit.
@herhut We follow your arguments that we should unbreak the build on Windows asap. As mentioned above, this does not solve the general non-determinism issue. However, even if the ordering would be deterministic, we should not rely on intrinsic magic that might be easily broken by another commit in the future.

Feb 6 2020, 3:27 AM · Restricted Project, Restricted Project

Jan 30 2020

dfki-jugr added a comment to D73471: Add tanh lowering from Standard dialect to NVVM and ROCDL..

We built the project on a Windows machine and were able to reproduce the failed test. We figured out that the tests are right, but the error was caused by a non-deterministic pattern rewriter step. We fixed the issue in another PR: https://reviews.llvm.org/D73713.
This fix should work on all platforms (Windows/Linux).

Jan 30 2020, 8:04 AM · Restricted Project
dfki-jugr created D73713: Fixed non-deterministic GPU intrinsic lowering..
Jan 30 2020, 7:55 AM · Restricted Project, Restricted Project
dfki-jugr committed rGaddc27bc437d: Changed wrong ROCDL instructions in GPU lowering. (authored by dfki-jugr).
Changed wrong ROCDL instructions in GPU lowering.
Jan 30 2020, 6:40 AM
dfki-jugr closed D73535: Changed wrong ROCDL instructions in GPU lowering..
Jan 30 2020, 6:40 AM · Restricted Project

Jan 29 2020

dfki-jugr updated the diff for D73535: Changed wrong ROCDL instructions in GPU lowering..

Fixed test cases and format issues.

Jan 29 2020, 12:59 AM · Restricted Project

Jan 28 2020

dfki-jugr created D73535: Changed wrong ROCDL instructions in GPU lowering..
Jan 28 2020, 2:14 AM · Restricted Project
dfki-jugr committed rG88d6f18225e1: [mlir] fixed invalid LLVM intrinsics in LLVMOPs.td and llvmir-intrinsics.mlir. (authored by dfki-jugr).
[mlir] fixed invalid LLVM intrinsics in LLVMOPs.td and llvmir-intrinsics.mlir.
Jan 28 2020, 2:05 AM
dfki-jugr committed rG664d2f5bad3e: Add tanh lowering from Standard dialect to NVVM and ROCDL. (authored by dfki-jugr).
Add tanh lowering from Standard dialect to NVVM and ROCDL.
Jan 28 2020, 2:05 AM
dfki-jugr closed D73470: [mlir] fixed invalid LLVM intrinsics in LLVMOPs.td and llvmir-intrinsics.mlir..
Jan 28 2020, 2:05 AM · Restricted Project
dfki-jugr closed D73471: Add tanh lowering from Standard dialect to NVVM and ROCDL..
Jan 28 2020, 2:05 AM · Restricted Project

Jan 27 2020

dfki-jugr updated the diff for D73471: Add tanh lowering from Standard dialect to NVVM and ROCDL..

Fixed clang format issue.

Jan 27 2020, 7:46 AM · Restricted Project
dfki-jugr updated the diff for D73470: [mlir] fixed invalid LLVM intrinsics in LLVMOPs.td and llvmir-intrinsics.mlir..

Renamed BinaryIntrinsicOp to BinarySameArgsIntrinsicOp.
Renamed TernaryIntrinsicOp to TernarySameArgsIntrinsicOp.

Jan 27 2020, 7:43 AM · Restricted Project
dfki-jugr retitled D73471: Add tanh lowering from Standard dialect to NVVM and ROCDL. from Fixed tanh lowering from Standard dialect to NVVM and ROCDL. to Add tanh lowering from Standard dialect to NVVM and ROCDL..
Jan 27 2020, 7:25 AM · Restricted Project
dfki-jugr created D73471: Add tanh lowering from Standard dialect to NVVM and ROCDL..
Jan 27 2020, 6:31 AM · Restricted Project
dfki-jugr created D73470: [mlir] fixed invalid LLVM intrinsics in LLVMOPs.td and llvmir-intrinsics.mlir..
Jan 27 2020, 6:21 AM · Restricted Project

Jan 13 2020

dfki-jugr committed rG202ab273e6ec: [mlir] Added missing GPU lowering ops. (authored by dfki-jugr).
[mlir] Added missing GPU lowering ops.
Jan 13 2020, 8:13 AM
dfki-jugr closed D72439: [mlir] Added Abs, Ceil and Cos to GPU lowering conversion..
Jan 13 2020, 8:13 AM · Restricted Project, Unknown Object (Project)
dfki-jugr committed rG9b1867c17d26: Added missing GPU lowering ops. (authored by dfki-jugr).
Added missing GPU lowering ops.
Jan 13 2020, 7:35 AM
dfki-jugr updated the diff for D72439: [mlir] Added Abs, Ceil and Cos to GPU lowering conversion..

Merged template arguments in AddIllegalOP.

Jan 13 2020, 1:23 AM · Restricted Project, Unknown Object (Project)

Jan 9 2020

dfki-jugr updated the diff for D72439: [mlir] Added Abs, Ceil and Cos to GPU lowering conversion..

Removed unnecessary test cases in test files.

Jan 9 2020, 4:08 AM · Restricted Project, Unknown Object (Project)
dfki-jugr updated the diff for D72439: [mlir] Added Abs, Ceil and Cos to GPU lowering conversion..

Update clang-format issues.

Jan 9 2020, 4:04 AM · Restricted Project, Unknown Object (Project)
dfki-jugr created D72439: [mlir] Added Abs, Ceil and Cos to GPU lowering conversion..
Jan 9 2020, 2:08 AM · Restricted Project, Unknown Object (Project)