- User Since
- Jan 9 2020, 1:31 AM (30 w, 5 d)
Mon, Aug 3
Fri, Jul 31
Changed check to exclude automatic allocation scope resources.
Jul 3 2020
Changed from a specialized MemRefCastOp version to a more general ViewLikeOpInterface version.
Adapt test case, since MemRefCastOp is currently not a ViewLikeOp.
Jul 2 2020
Apr 28 2020
Apr 27 2020
Apr 22 2020
Updated commit message and added a short summary.
Feb 6 2020
@rriddle I've tried to come up with a minimal example including a new dialect. However, the issue does not occur in simple cases on our testing machines. The easiest way to dive into this issue would be to move line 728 in LowerGPUOpsToNNVMOps.cc to 750:
@mehdi_amini I fully get your point and I totally agree that we should not hide underlying bugs. However, you can argue as soon as two pattern matchers have the same benefit their ordering will be undefinied. In this case, the only possible solution you have, is to change the pattern matcher benefit.
@herhut We follow your arguments that we should unbreak the build on Windows asap. As mentioned above, this does not solve the general non-determinism issue. However, even if the ordering would be deterministic, we should not rely on intrinsic magic that might be easily broken by another commit in the future.
Jan 30 2020
We built the project on a Windows machine and were able to reproduce the failed test. We figured out that the tests are right, but the error was caused by a non-deterministic pattern rewriter step. We fixed the issue in another PR: https://reviews.llvm.org/D73713.
This fix should work on all platforms (Windows/Linux).
Jan 29 2020
Fixed test cases and format issues.
Jan 28 2020
Jan 27 2020
Fixed clang format issue.
Renamed BinaryIntrinsicOp to BinarySameArgsIntrinsicOp.
Renamed TernaryIntrinsicOp to TernarySameArgsIntrinsicOp.
Jan 13 2020
Merged template arguments in AddIllegalOP.
Jan 9 2020
Removed unnecessary test cases in test files.
Update clang-format issues.