Page MenuHomePhabricator

silvas (Sean Silva)
User

Projects

User does not belong to any projects.

User Details

User Since
Aug 20 2012, 11:51 AM (422 w, 5 d)

Recent Activity

Thu, Sep 24

silvas requested review of D88258: [mlir][shape] Make conversion passes more consistent..
Thu, Sep 24, 1:05 PM · Restricted Project
silvas committed rG9ed1e5873c19: [mlir][shape] Start a pass that lowers shape constraints. (authored by silvas).
[mlir][shape] Start a pass that lowers shape constraints.
Thu, Sep 24, 12:26 PM
silvas closed D87941: [mlir][shape] Start a pass that lowers shape constraints..
Thu, Sep 24, 12:25 PM · Restricted Project
silvas updated the diff for D87941: [mlir][shape] Start a pass that lowers shape constraints..

Remove shape.assuming canonicalization.

Thu, Sep 24, 12:19 PM · Restricted Project

Tue, Sep 22

silvas accepted D87649: [mlir][NFC] Promote memory space to BaseMemRefType.
Tue, Sep 22, 7:28 PM · Restricted Project
silvas resigned from D86363: InstCombine transform pattern "(A ^ B) | ~(A | B) -> ~(A & B)" added.
Tue, Sep 22, 7:25 PM · Restricted Project
silvas resigned from D86395: [InstCombine] transform pattern "(~A & B) ^ A -> (A | B)" added.
Tue, Sep 22, 7:25 PM · Restricted Project
silvas added inline comments to D87941: [mlir][shape] Start a pass that lowers shape constraints..
Tue, Sep 22, 11:09 AM · Restricted Project
silvas updated the diff for D87941: [mlir][shape] Start a pass that lowers shape constraints..

Address comments

Tue, Sep 22, 11:08 AM · Restricted Project
silvas requested changes to D88083: [mlir] Add file to implement bufferization for shape ops..
Tue, Sep 22, 10:53 AM · Restricted Project

Mon, Sep 21

silvas added inline comments to D87941: [mlir][shape] Start a pass that lowers shape constraints..
Mon, Sep 21, 12:24 PM · Restricted Project

Fri, Sep 18

silvas updated the diff for D87941: [mlir][shape] Start a pass that lowers shape constraints..

Fix variable name.

Fri, Sep 18, 2:00 PM · Restricted Project
silvas requested review of D87941: [mlir][shape] Start a pass that lowers shape constraints..
Fri, Sep 18, 1:58 PM · Restricted Project
silvas committed rG7c44651360dd: [mlir][shape] Extend shape.cstr_require with a message. (authored by silvas).
[mlir][shape] Extend shape.cstr_require with a message.
Fri, Sep 18, 10:22 AM
silvas closed D87875: [mlir][shape] Extend shape.cstr_require with a message..
Fri, Sep 18, 10:22 AM · Restricted Project

Thu, Sep 17

silvas updated the diff for D87875: [mlir][shape] Extend shape.cstr_require with a message..

fix typo

Thu, Sep 17, 7:40 PM · Restricted Project
silvas requested review of D87875: [mlir][shape] Extend shape.cstr_require with a message..
Thu, Sep 17, 6:35 PM · Restricted Project
silvas committed rGbae637420577: [mlir][shape] Add `shape.cstr_require %bool` (authored by silvas).
[mlir][shape] Add `shape.cstr_require %bool`
Thu, Sep 17, 4:57 PM
silvas closed D87871: [mlir][shape] Add `shape.cstr_require %bool`.
Thu, Sep 17, 4:57 PM · Restricted Project
silvas updated the diff for D87871: [mlir][shape] Add `shape.cstr_require %bool`.

+1, added some verbiage to that effect

Thu, Sep 17, 4:40 PM · Restricted Project
silvas renamed Image Macro "pictureofanit" from nit to pictureofanit.
Thu, Sep 17, 4:33 PM
silvas updated the diff for D87871: [mlir][shape] Add `shape.cstr_require %bool`.

nit

Thu, Sep 17, 4:27 PM · Restricted Project
silvas requested review of D87871: [mlir][shape] Add `shape.cstr_require %bool`.
Thu, Sep 17, 4:26 PM · Restricted Project

Fri, Sep 11

silvas committed rG84a6da67e6b2: [mlir] Fix some edge cases around 0-element TensorFromElementsOp (authored by silvas).
[mlir] Fix some edge cases around 0-element TensorFromElementsOp
Fri, Sep 11, 10:59 AM
silvas closed D87492: [mlir] Fix some edge cases around 0-element TensorFromElementsOp.
Fri, Sep 11, 10:58 AM · Restricted Project
silvas added inline comments to D87492: [mlir] Fix some edge cases around 0-element TensorFromElementsOp.
Fri, Sep 11, 10:57 AM · Restricted Project
silvas updated the diff for D87492: [mlir] Fix some edge cases around 0-element TensorFromElementsOp.

Address comments.

Fri, Sep 11, 10:56 AM · Restricted Project
silvas added a comment to D87492: [mlir] Fix some edge cases around 0-element TensorFromElementsOp.

The SameOperandsAndResultElementType is redundant with the new

TypesMatchWith and prevented having zero elements.

So is it only conceptually redudant but the verification differs or is it really redundant? And why is zero elements different?

Fri, Sep 11, 10:37 AM · Restricted Project

Thu, Sep 10

silvas requested review of D87492: [mlir] Fix some edge cases around 0-element TensorFromElementsOp.
Thu, Sep 10, 10:09 PM · Restricted Project

Wed, Sep 9

silvas committed rGbe35264ab5a3: Wordsmith RegionBranchOpInterface verification errors (authored by silvas).
Wordsmith RegionBranchOpInterface verification errors
Wed, Sep 9, 12:51 PM
silvas closed D87334: Wordsmith RegionBranchOpInterface verification errors.
Wed, Sep 9, 12:50 PM · Restricted Project

Tue, Sep 8

silvas requested review of D87334: Wordsmith RegionBranchOpInterface verification errors.
Tue, Sep 8, 3:53 PM · Restricted Project
silvas added inline comments to D86392: Implement a new kind of Pass: dynamic pass pipeline.
Tue, Sep 8, 2:45 PM · Restricted Project
silvas accepted D86392: Implement a new kind of Pass: dynamic pass pipeline.

LGTM from my side

Tue, Sep 8, 2:37 PM · Restricted Project

Wed, Sep 2

silvas added inline comments to D86392: Implement a new kind of Pass: dynamic pass pipeline.
Wed, Sep 2, 3:57 PM · Restricted Project
silvas added inline comments to D86392: Implement a new kind of Pass: dynamic pass pipeline.
Wed, Sep 2, 2:25 PM · Restricted Project
silvas added inline comments to D86904: [mlir] Support for defining Types in tblgen.
Wed, Sep 2, 1:52 PM · Restricted Project, Restricted Project
silvas added inline comments to D86904: [mlir] Support for defining Types in tblgen.
Wed, Sep 2, 1:51 PM · Restricted Project, Restricted Project
silvas added inline comments to D86392: Implement a new kind of Pass: dynamic pass pipeline.
Wed, Sep 2, 11:10 AM · Restricted Project

Tue, Sep 1

silvas added a comment to D86392: Implement a new kind of Pass: dynamic pass pipeline.

I still consider this feature naming (such as test case naming) very confusing.

But it seems like you also never encountered "pipeline" which is surprising to me as it seems like a very common terminology (and we've been using it in MLIR "forever").

Tue, Sep 1, 4:01 PM · Restricted Project
silvas added a comment to D86392: Implement a new kind of Pass: dynamic pass pipeline.

I still consider this feature naming (such as test case naming) very confusing. It's actually very simple to explain: "it allows a pass to call other passes". The name "dynamic pipeline" is very confusing -- like I'll need to re-explain to every new MLIR user that encounters the feature what the feature really is. "user: How can I call a pass from within my pass? mlir community: oh, use our dynamic pipeline feature. user: what is that? mlir community: it's a way to call a pass from within another pass; user: oh".

Tue, Sep 1, 3:31 PM · Restricted Project
silvas added a comment to D86392: Implement a new kind of Pass: dynamic pass pipeline.

Now that this functionality has evolved, is there a better name to describe this functionality than "dynamic pipeline"? It's not associated with pipelines in any specific way, and it is not associated with dynamism per se (e.g. inliner could use a statically hardcoded simplification pipeline). Perhaps "recursive pass invocation"?

I still see this as dynamic: from the pass pipeline point of view there is a "pass" which will execute "dynamically" sub-pass-pipelines. This feature enables dynamism in the pass pipeline where it does not exist today.

Tue, Sep 1, 10:47 AM · Restricted Project

Mon, Aug 31

silvas requested changes to D86392: Implement a new kind of Pass: dynamic pass pipeline.

Now that this functionality has evolved, is there a better name to describe this functionality than "dynamic pipeline"? It's not associated with pipelines in any specific way, and it is not associated with dynamism per se (e.g. inliner could use a statically hardcoded simplification pipeline). Perhaps "recursive pass invocation"?

Mon, Aug 31, 12:38 PM · Restricted Project

Fri, Aug 28

silvas added inline comments to D86392: Implement a new kind of Pass: dynamic pass pipeline.
Fri, Aug 28, 5:07 PM · Restricted Project
silvas accepted D86779: [MLIR][Shape] Merge `shape` to `std`/`scf` lowerings..
Fri, Aug 28, 11:11 AM · Restricted Project
silvas added a comment to D86770: [MLIR] Support for holistic logging of lowerings in test cases.

Using #ifdef's isn't great. Can we instead have a cl::opt and just use a regular if to control this. Then we can test it too.

Fri, Aug 28, 11:05 AM · Restricted Project

Aug 27 2020

silvas added inline comments to D86392: Implement a new kind of Pass: dynamic pass pipeline.
Aug 27 2020, 1:17 PM · Restricted Project

Aug 20 2020

silvas added a comment to D86276: [MLIR][Standard] Add `dynamic_tensor_from_elements` operation.

Also, can you update the commit description to include a description of the namespace changes?

Aug 20 2020, 11:32 AM · Restricted Project
silvas added inline comments to D86276: [MLIR][Standard] Add `dynamic_tensor_from_elements` operation.
Aug 20 2020, 11:11 AM · Restricted Project

Aug 10 2020

silvas added a comment to D85634: [MLIR][Standard] Fix cast materialization for incompatible types.

Is there anything about this specific to index type? Can this issue happen with any user-defined type?

Aug 10 2020, 11:36 AM · Restricted Project

Aug 7 2020

silvas committed rGb0d76f454daa: [mlir] Centralize handling of memref element types. (authored by silvas).
[mlir] Centralize handling of memref element types.
Aug 7 2020, 3:25 PM
silvas closed D85541: [mlir] Centralize handling of memref element types..
Aug 7 2020, 3:24 PM · Restricted Project
silvas accepted D85556: Add the inline interface to the shape dialect.
Aug 7 2020, 2:55 PM · Restricted Project
silvas requested review of D85541: [mlir] Centralize handling of memref element types..
Aug 7 2020, 11:43 AM · Restricted Project

Jul 28 2020

silvas accepted D84745: [MLIR][Shape] Add conversion for missing ops to standard.
Jul 28 2020, 3:20 PM · Restricted Project
silvas accepted D84439: [MLIR][Shape] Refactor verification.
Jul 28 2020, 9:32 AM · Restricted Project
silvas added inline comments to D84745: [MLIR][Shape] Add conversion for missing ops to standard.
Jul 28 2020, 9:18 AM · Restricted Project

Jul 27 2020

silvas requested changes to D84632: [MLIR] Add shape.extend op..

Can't we use shape.concat for this?

Jul 27 2020, 1:14 PM · Restricted Project

Jul 20 2020

silvas added inline comments to D83924: [mlir] Add update_mlir_test_checks.py.
Jul 20 2020, 9:16 PM · Restricted Project
silvas added a comment to D84157: [MLIR][Shape] Generalize `shape.const_shape` to extent tensors.

What do you think about

%1 = shape.const_shape [1, 2, 3]
%2 = shape.const_extent_tensor [4, 5, 6]

instead of

%1 = shape.const_shape [1, 2, 3] : !shape.shape
%2 = shape.const_shape [4, 5, 6] : tensor<?xindex>

?

Jul 20 2020, 9:16 PM · Restricted Project

Jul 16 2020

silvas accepted D83886: [MLIR][Standard] Add default lowering for `assert`.

Thanks for adding this!

Jul 16 2020, 10:10 PM · Restricted Project
silvas added inline comments to D83886: [MLIR][Standard] Add default lowering for `assert`.
Jul 16 2020, 10:00 PM · Restricted Project
silvas requested changes to D83886: [MLIR][Standard] Add default lowering for `assert`.
Jul 16 2020, 9:58 PM · Restricted Project
silvas added inline comments to D83924: [mlir] Add update_mlir_test_checks.py.
Jul 16 2020, 9:39 PM · Restricted Project
silvas added a comment to D83924: [mlir] Add update_mlir_test_checks.py.

It's kind of confusing that this is in llvm/utils while generate-test-checks.py is in mlir/utils. Is there a plan to reconcile this difference?

Jul 16 2020, 10:05 AM · Restricted Project

Jul 13 2020

silvas added inline comments to D83117: [MLIR][Standard] Add `assert` operation to the standard dialect.
Jul 13 2020, 11:25 AM · Restricted Project
silvas requested changes to D82528: [MLIR][Shape] Add `shape.shape_eq` operation.
Jul 13 2020, 10:12 AM · Restricted Project
silvas accepted D82533: [MLIR][Shape] Fold `shape.shape_eq`.
Jul 13 2020, 10:04 AM · Restricted Project

Jul 7 2020

silvas committed rGa084b94f1198: [mlir] Convert function signatures before converting globals (authored by silvas).
[mlir] Convert function signatures before converting globals
Jul 7 2020, 10:40 AM
silvas closed D83266: [mlir] Convert function signatures before converting globals.
Jul 7 2020, 10:40 AM · Restricted Project

Jul 6 2020

Herald added a project to D83266: [mlir] Convert function signatures before converting globals: Restricted Project.
Jul 6 2020, 4:51 PM · Restricted Project

Jun 26 2020

silvas accepted D82628: [MLIR][Shape] Add `shape.size_eq` to the shape dialect.

LGTM modulo incorporating our decision on the error case discussion from shape_eq.

Jun 26 2020, 10:55 AM · Restricted Project
silvas accepted D82528: [MLIR][Shape] Add `shape.shape_eq` operation.

LGTM modulo getting feedback for others on how to define the error cases.

Jun 26 2020, 10:55 AM · Restricted Project
silvas accepted D82666: [mlir] do not hardcode the name of the undefined function in the error message.

Thanks!

Jun 26 2020, 10:55 AM · Restricted Project
silvas accepted D82667: [mlir] LLVM dialect: use addressof instead of constant to create function pointers.

It would be good to update https://mlir.llvm.org/docs/Dialects/LLVM/

Jun 26 2020, 10:55 AM · Restricted Project

Jun 25 2020

silvas added inline comments to D82528: [MLIR][Shape] Add `shape.shape_eq` operation.
Jun 25 2020, 10:14 AM · Restricted Project
silvas accepted D82533: [MLIR][Shape] Fold `shape.shape_eq`.

LGTM, modulo splitting into two ops and a nit.

Jun 25 2020, 10:14 AM · Restricted Project
silvas added a comment to D82528: [MLIR][Shape] Add `shape.shape_eq` operation.

(we could also use shape.eq to be the one for shapes, which is a bit shorter than shape.shape_eq; I personally like being a bit more explicit but it's up to you what feels best namingwise)

Jun 25 2020, 10:13 AM · Restricted Project
silvas accepted D82531: [MLIR][Shape] Fold `shape.size_eq`.

LGTM modulo splitting into two separate ops.

Jun 25 2020, 10:13 AM · Restricted Project
silvas added inline comments to D82528: [MLIR][Shape] Add `shape.shape_eq` operation.
Jun 25 2020, 10:13 AM · Restricted Project
silvas requested changes to D82528: [MLIR][Shape] Add `shape.shape_eq` operation.
Jun 25 2020, 10:13 AM · Restricted Project
silvas added inline comments to D82528: [MLIR][Shape] Add `shape.shape_eq` operation.
Jun 25 2020, 10:13 AM · Restricted Project

Jun 22 2020

silvas accepted D81871: [MLIR][Shape] Simplify `get_extent` when dependent on `shape_of`.
Jun 22 2020, 11:49 AM · Restricted Project

Jun 19 2020

silvas added inline comments to D81871: [MLIR][Shape] Simplify `get_extent` when dependent on `shape_of`.
Jun 19 2020, 1:04 PM · Restricted Project
silvas added inline comments to D81871: [MLIR][Shape] Simplify `get_extent` when dependent on `shape_of`.
Jun 19 2020, 12:32 PM · Restricted Project
silvas accepted D82028: [MLIR][Shape] Add `shape.rank` operation.
Jun 19 2020, 12:32 PM · Restricted Project

Jun 18 2020

silvas added inline comments to D81871: [MLIR][Shape] Simplify `get_extent` when dependent on `shape_of`.
Jun 18 2020, 2:48 PM · Restricted Project
silvas accepted D82083: [MLIR][Shape] Canonicalize subsequent `size_to_index` and `index_to_size`.

Great! Thanks for these nicely factored patches!

Jun 18 2020, 9:48 AM · Restricted Project
silvas accepted D82082: [MLIR][Shape] Canonicalize subsequent `index_to_size` and `size_to_index`.

Thanks!

Jun 18 2020, 9:47 AM · Restricted Project
silvas accepted D82077: [MLIR][Shape] Add canonicalization pattern for `shape.rank`.

Awesome, thanks!

Jun 18 2020, 9:46 AM · Restricted Project
silvas added inline comments to D82076: [MLIR][Shape] Add constant folding to `shape.rank`.
Jun 18 2020, 9:45 AM · Restricted Project
silvas accepted D82076: [MLIR][Shape] Add constant folding to `shape.rank`.

LGTM modulo renaming of op (discussed in the dependent patch)

Jun 18 2020, 9:45 AM · Restricted Project
silvas requested changes to D82028: [MLIR][Shape] Add `shape.rank` operation.
Jun 18 2020, 9:45 AM · Restricted Project

Jun 17 2020

silvas requested changes to D81871: [MLIR][Shape] Simplify `get_extent` when dependent on `shape_of`.
Jun 17 2020, 11:52 AM · Restricted Project
silvas requested changes to D81560: [mlir] Add a pass to remove all shape.cstr_ and assuming_ ops..
Jun 17 2020, 11:18 AM · Restricted Project
silvas requested changes to D82028: [MLIR][Shape] Add `shape.rank` operation.
Jun 17 2020, 10:45 AM · Restricted Project

Jun 16 2020

silvas requested changes to D81871: [MLIR][Shape] Simplify `get_extent` when dependent on `shape_of`.

As per discussion today, this pattern is going to "fight" with what we are doing with IREE (and also npcomp). Can we reserve this pattern for the shape to std-with-descriptors lowering?

Jun 16 2020, 9:54 AM · Restricted Project

Jun 12 2020

silvas added inline comments to D81694: [mlir][shape] Add a pattern to rewrite `shape.reduce` as `scf.for`..
Jun 12 2020, 9:45 AM · Restricted Project

Jun 11 2020

silvas added a comment to D81551: [MLIR][Standard] Make the `dim` operation index an operand..

Can you add documentation for what happens in the case where the dimension index is out of bounds? Are we allowed to assume that doesn't happen?

Jun 11 2020, 4:00 PM · Restricted Project
silvas requested changes to D81694: [mlir][shape] Add a pattern to rewrite `shape.reduce` as `scf.for`..
Jun 11 2020, 2:53 PM · Restricted Project