User Details
- User Since
- Aug 20 2012, 11:51 AM (439 w, 6 d)
Tue, Jan 19
Use forward decl.
Address River's comments.
Fri, Jan 15
Thanks for cleaning this up!
LGTM, but ot sounds like you might want to add some more testing as well. A payload that returns an argument of the enclosing function would be enough.
Thu, Jan 14
Wed, Jan 13
Tue, Jan 12
Address Stephan's comments.
Mon, Jan 11
Fix dfki-jugr@'s comments.
Thanks! This looks great!
Fri, Jan 8
Remove old stray stuff and add a TOC
Thu, Jan 7
Wed, Jan 6
LGTM modulo Lei's comment.
Awesome! Thank you for pushing this herculean effort!
Tue, Jan 5
Dec 17 2020
I think you also should do the same for
Dec 16 2020
Address Stephan's comments.
Awesome!
Dec 15 2020
Address River's comments.
Fix a few mentions in comments.
Dec 14 2020
Did we actually get consensus around the direction here? I didn't see a clear conclusion.
Dec 11 2020
One last nit.
Touch up a few more places that mention extract_element.
Partially revert https://reviews.llvm.org/D92980
Dec 10 2020
You might want to link to the ProgrammersManual directly from here as well.
Remove some more stray copypasta.
Address River's comments.
I generally agree with @bondhugula on tensor.get_element being somewhat better. However, I think tensor.extract is the right thing for this patch because:
Would be nice to find a way to test this (Maybe a FileCheck test? not sure how to set that up though; don't worry if it is too much work.)
Dec 9 2020
Totally agreed that MLIR is in a youthful stage. I think it is a valuable discussion to be had explicitly with the community about how we approach the tradeoffs in adopting more incremental code vs more vetted designs. Getting clarity there would greatly simplify this discussion!
Dec 8 2020
Dec 7 2020
Thanks. This LGTM.
The spec link doesn't seem to support AllowNumeric. Why do we have that feature?
Dec 4 2020
Dec 3 2020
Abandoned in favor of https://reviews.llvm.org/D92522
Wow, awesome work!
Replace constexpr function with old-school class with static members.
Can we please finish the discussion in https://llvm.discourse.group/t/remove-tight-coupling-of-the-bufferdeallocation-pass-to-std-and-linalg-operations/2162/12 before moving forward with this? It's not clear to me that we all agreed that this was the right direction.
Address Chris's comments about the docs.
Dec 2 2020
Use SmallVector<T, 0> as the header size.
Created mistakenly (bad script). Abandoning.