This is an archive of the discontinued LLVM Phabricator instance.

[mlir][Python] Add Windows DLL loader to get python extensions working there.
ClosedPublic

Authored by stellaraccident on Nov 6 2020, 9:49 AM.

Diff Detail

Event Timeline

stellaraccident created this revision.Nov 6 2020, 9:49 AM
stellaraccident requested review of this revision.Nov 6 2020, 9:49 AM
mehdi_amini added inline comments.Nov 6 2020, 6:05 PM
mlir/lib/Bindings/Python/mlir/_dlloader.py
13

Isn't the .dll under lib?

stellaraccident added inline comments.Nov 6 2020, 8:29 PM
mlir/lib/Bindings/Python/mlir/_dlloader.py
13

No, on windows, dlls go under the runtime directory (bin/). Static libraries only go under lib/. I think it is because on that platform the exe and dll search path is shared.

There are special cases for this everywhere.

benvanik accepted this revision.Nov 8 2020, 10:24 AM
This revision is now accepted and ready to land.Nov 8 2020, 10:24 AM

Rebase and test on Windows.

This revision was landed with ongoing or failed builds.Nov 11 2020, 9:59 AM
This revision was automatically updated to reflect the committed changes.