Page MenuHomePhabricator

stellaraccident (Stella Laurenzo)
User

Projects

User does not belong to any projects.

User Details

User Since
Dec 20 2019, 9:16 PM (108 w, 4 d)

Recent Activity

Today

stellaraccident accepted D117658: [mlir] Better error message in PybindAdaptors.h.
Wed, Jan 19, 8:36 AM · Restricted Project
stellaraccident accepted D117646: [mlir] Rework subclass construction in PybindAdaptors.h.

This makes sense to me, and I'm trying to remember why I didn't do it originally (I remember considering the new approach but can't remember why I avoided it). I think I was aliasing the prohibition that regular pybind classes cannot further modify new with these not actually being pybind classes.

Wed, Jan 19, 8:33 AM · Restricted Project

Yesterday

stellaraccident accepted D117599: [mlir] Configure mlir so that it can be directly included in a parent cmakelists.txt.

LGTM modulo comments. I vaguely recall this kind of target sniffing having caused me problems in the past but I can't remember the details. Doing the same as llvm, sgtm.

Tue, Jan 18, 9:33 PM · Restricted Project
stellaraccident added a comment to D117325: [mlir] fix crash in PybindAdaptors.h.

I've started seeing a nondeterministic crash in the JAX test suite that I bisected to this revision.

Here's a typical failure from our CI:
https://source.cloud.google.com/results/invocations/914b1d68-3b59-401c-8417-4080cc48cc35/targets/jax%2Ftesting%2Fcpu%2Fpresubmit_github/log

If you go and look at the python source lines that pytest reports the crash at, one is a call to .verify() and another is a call to .print(). I don't have a more reduced reproduction yet: it's going to be hard to get one because it's a rare crash that I only see when running a large test suite and not when running any tests in isolation. My guess is there's some sort of memory corruption problem.

Can we revert this in the meantime?

Tue, Jan 18, 8:00 AM · Restricted Project

Mon, Jan 17

stellaraccident accepted D117325: [mlir] fix crash in PybindAdaptors.h.

Ugh, ugh. Let's definitely ask the pybind folks after landing. I'm also wondering if this part should just be implemented with the python c API. The concept is simpler than the code.

Mon, Jan 17, 7:07 AM · Restricted Project

Fri, Jan 14

stellaraccident accepted D117325: [mlir] fix crash in PybindAdaptors.h.

This is gross - I'm sorry it had caused some hard debugging for you, but thank you.

Fri, Jan 14, 8:46 AM · Restricted Project

Thu, Jan 13

stellaraccident committed rGb93eded7b945: [bazel] Separate capi_deps from deps in mlir_c_api_cc_library. (authored by stellaraccident).
[bazel] Separate capi_deps from deps in mlir_c_api_cc_library.
Thu, Jan 13, 10:08 PM
stellaraccident closed D117176: [bazel] Separate capi_deps from deps in mlir_c_api_cc_library..
Thu, Jan 13, 10:08 PM · Restricted Project

Wed, Jan 12

stellaraccident added inline comments to D117176: [bazel] Separate capi_deps from deps in mlir_c_api_cc_library..
Wed, Jan 12, 5:51 PM · Restricted Project
stellaraccident updated the diff for D117176: [bazel] Separate capi_deps from deps in mlir_c_api_cc_library..

Comment.

Wed, Jan 12, 5:51 PM · Restricted Project
stellaraccident added reviewers for D117176: [bazel] Separate capi_deps from deps in mlir_c_api_cc_library.: GMNGeoffrey, phawkins.
Wed, Jan 12, 5:38 PM · Restricted Project
stellaraccident requested review of D117176: [bazel] Separate capi_deps from deps in mlir_c_api_cc_library..
Wed, Jan 12, 5:37 PM · Restricted Project

Tue, Jan 11

stellaraccident accepted D116962: [mlir] Refactor ShapedType into an interface.

Thank you River - this is much nicer than I thought it would be.

Tue, Jan 11, 8:19 AM · Restricted Project

Sun, Jan 9

stellaraccident accepted D116905: Add a `qualified` directive to the Op, Attribute, and Type declarative assembly format.

Thanks - lg modulo comments.

Sun, Jan 9, 8:20 PM · Restricted Project

Wed, Jan 5

stellaraccident accepted D116662: [mlir] Split out Python bindings for dialects into separate libs.

Excellent!! Thanks! I think that leaves us only with a hidden dependency on all dialects registration and execution engine that, if fixed, would dramatically reduce downstream build time and distribution size.

Wed, Jan 5, 11:43 AM · Restricted Project

Tue, Jan 4

stellaraccident added a comment to D116525: [mlir] Add a parsePassPipeline overload that returns a new pass manager.

Thanks!

Tue, Jan 4, 2:05 PM · Restricted Project
stellaraccident committed rG7ee25bc56f92: [mlir][python] Add bindings for diagnostic handler. (authored by stellaraccident).
[mlir][python] Add bindings for diagnostic handler.
Tue, Jan 4, 11:12 AM
stellaraccident closed D116568: [mlir][python] Add bindings for diagnostic handler..
Tue, Jan 4, 11:12 AM · Restricted Project
stellaraccident updated the diff for D116568: [mlir][python] Add bindings for diagnostic handler..

Comment.

Tue, Jan 4, 11:03 AM · Restricted Project
stellaraccident added inline comments to D116568: [mlir][python] Add bindings for diagnostic handler..
Tue, Jan 4, 10:44 AM · Restricted Project
stellaraccident accepted D115239: [mlir][OpDSL] Add `TypeFn` class..
Tue, Jan 4, 10:15 AM · Restricted Project
stellaraccident accepted D115240: [mlir][OpDSL] Rename `PrimFn` to `ArithFn`..
Tue, Jan 4, 10:14 AM · Restricted Project
stellaraccident accepted D115241: [mlir][OpDSL] Separate `ReduceFn` and `ReduceFnUse`..

Nice improvement - thanks! (and sorry for review latency)

Tue, Jan 4, 10:13 AM · Restricted Project
stellaraccident added a comment to D116605: [mlir] Introduce Python bindings for the quantization dialect.

I believe the plan is record is to remove the ops from this dialect, so just exposing types here is preferred (as you have it).

Tue, Jan 4, 9:25 AM · Restricted Project
stellaraccident accepted D116605: [mlir] Introduce Python bindings for the quantization dialect.

I wish I could uninvent those types, but they've been stable for a long time, and there are repeated requests to have access to them - so no objection to this API surface increase.

Tue, Jan 4, 9:24 AM · Restricted Project

Mon, Jan 3

stellaraccident added a comment to D116568: [mlir][python] Add bindings for diagnostic handler..

I'd rather wait for @ftynse to have a look as well, I think I understand everything in this patch, but this in the realm of "I wouldn't be able to write this myself" ;)

Mon, Jan 3, 9:31 PM · Restricted Project
stellaraccident added inline comments to D116568: [mlir][python] Add bindings for diagnostic handler..
Mon, Jan 3, 9:01 PM · Restricted Project
stellaraccident updated the diff for D116568: [mlir][python] Add bindings for diagnostic handler..

Update type metadata.

Mon, Jan 3, 5:31 PM · Restricted Project
stellaraccident added reviewers for D116568: [mlir][python] Add bindings for diagnostic handler.: ftynse, mehdi_amini.
Mon, Jan 3, 4:46 PM · Restricted Project
stellaraccident requested review of D116568: [mlir][python] Add bindings for diagnostic handler..
Mon, Jan 3, 4:45 PM · Restricted Project

Sun, Jan 2

stellaraccident accepted D116506: Remove misused RAII gil_scoped_release/gil_scoped_acquire: without name they don't have any effect.

Good catch - and sorry: I am not sure what I was thinking with those. As-is, we hold the GIL all the time, so they are fine to remove. I think I was attempting to make it future proof for cases where we may want to release the GIL for long running operations (i.e. transforms, etc). These cases represent re-entrancy where it would need to be managed carefully. Clearly wrong as-is, though so fine to remove.

Sun, Jan 2, 5:00 PM · Restricted Project

Fri, Dec 31

stellaraccident added a comment to D116429: Do not install MLIR Object libraries used for assembling the C API (NFC).

You'll then need to enable that option when building the examples project test (which uses these and is likely why the bots are failing).

Fri, Dec 31, 7:39 AM · Restricted Project
stellaraccident added reviewers for D116429: Do not install MLIR Object libraries used for assembling the C API (NFC): bondhugula, stephenneuendorffer.
Fri, Dec 31, 7:38 AM · Restricted Project
stellaraccident added a comment to D116429: Do not install MLIR Object libraries used for assembling the C API (NFC).

There are people relying on this. Can you just disable this option by default until we find something better? That way they can still opt in.

Fri, Dec 31, 7:37 AM · Restricted Project

Thu, Dec 30

stellaraccident committed rG5cd0b817e239: [mlir] Allow IntegerAttr to parse zero width integers. (authored by stellaraccident).
[mlir] Allow IntegerAttr to parse zero width integers.
Thu, Dec 30, 8:38 PM
stellaraccident closed D116413: [mlir] Allow IntegerAttr to parse zero width integers..
Thu, Dec 30, 8:37 PM · Restricted Project
stellaraccident added a reviewer for D116413: [mlir] Allow IntegerAttr to parse zero width integers.: lattner.
Thu, Dec 30, 8:02 AM · Restricted Project
stellaraccident requested review of D116413: [mlir] Allow IntegerAttr to parse zero width integers..
Thu, Dec 30, 8:02 AM · Restricted Project

Thu, Dec 23

stellaraccident added a comment to D116257: [mlir] Use thread-pool's notion of thread count instead of requerying system..

Filed issue: https://github.com/llvm/llvm-project/issues/52862 for clarification. I don't like not understanding action-at-a-distance things like this and maybe the author can recall.

Thu, Dec 23, 5:12 PM · Restricted Project
stellaraccident added inline comments to D116257: [mlir] Use thread-pool's notion of thread count instead of requerying system..
Thu, Dec 23, 5:05 PM · Restricted Project
stellaraccident committed rG8ff42766d1ef: [mlir] Use thread-pool's notion of thread count instead of requerying system. (authored by stellaraccident).
[mlir] Use thread-pool's notion of thread count instead of requerying system.
Thu, Dec 23, 5:05 PM
stellaraccident closed D116257: [mlir] Use thread-pool's notion of thread count instead of requerying system..
Thu, Dec 23, 5:05 PM · Restricted Project
stellaraccident added inline comments to D116257: [mlir] Use thread-pool's notion of thread count instead of requerying system..
Thu, Dec 23, 5:04 PM · Restricted Project
stellaraccident updated the diff for D116257: [mlir] Use thread-pool's notion of thread count instead of requerying system..

Comment.

Thu, Dec 23, 5:03 PM · Restricted Project
stellaraccident added inline comments to D116257: [mlir] Use thread-pool's notion of thread count instead of requerying system..
Thu, Dec 23, 4:36 PM · Restricted Project
stellaraccident updated the diff for D116257: [mlir] Use thread-pool's notion of thread count instead of requerying system..

Comment.

Thu, Dec 23, 4:33 PM · Restricted Project
stellaraccident added inline comments to D116257: [mlir] Use thread-pool's notion of thread count instead of requerying system..
Thu, Dec 23, 4:33 PM · Restricted Project
stellaraccident updated the diff for D116257: [mlir] Use thread-pool's notion of thread count instead of requerying system..

Remove comment.

Thu, Dec 23, 4:31 PM · Restricted Project
stellaraccident added reviewers for D116257: [mlir] Use thread-pool's notion of thread count instead of requerying system.: mehdi_amini, Mogball, rriddle.
Thu, Dec 23, 4:20 PM · Restricted Project
stellaraccident requested review of D116257: [mlir] Use thread-pool's notion of thread count instead of requerying system..
Thu, Dec 23, 4:19 PM · Restricted Project

Dec 13 2021

stellaraccident added a reverting change for rGaa8815e42e64: Revert "[NFC] Generalize a couple of passes so they can operate on any…: rGc10995a8adce: Re-apply [NFC] Generalize a couple of passes so they can operate on any….
Dec 13 2021, 1:34 PM
stellaraccident committed rGc10995a8adce: Re-apply [NFC] Generalize a couple of passes so they can operate on any… (authored by stellaraccident).
Re-apply [NFC] Generalize a couple of passes so they can operate on any…
Dec 13 2021, 1:33 PM
stellaraccident closed D115671: Re-apply [NFC] Generalize a couple of passes so they can operate on any FunctionLike op..
Dec 13 2021, 1:33 PM · Restricted Project
stellaraccident updated the diff for D115671: Re-apply [NFC] Generalize a couple of passes so they can operate on any FunctionLike op..

Comments.

Dec 13 2021, 1:32 PM · Restricted Project
stellaraccident updated the diff for D115671: Re-apply [NFC] Generalize a couple of passes so they can operate on any FunctionLike op..

Remove restriction on DropUnitDims.

Dec 13 2021, 1:28 PM · Restricted Project
stellaraccident added a reviewer for D115671: Re-apply [NFC] Generalize a couple of passes so they can operate on any FunctionLike op.: mehdi_amini.
Dec 13 2021, 1:24 PM · Restricted Project
stellaraccident added a reverting change for rGaa8815e42e64: Revert "[NFC] Generalize a couple of passes so they can operate on any…: D115671: Re-apply [NFC] Generalize a couple of passes so they can operate on any FunctionLike op..
Dec 13 2021, 1:24 PM
stellaraccident requested review of D115671: Re-apply [NFC] Generalize a couple of passes so they can operate on any FunctionLike op..
Dec 13 2021, 1:24 PM · Restricted Project
stellaraccident added a comment to D115645: [NFC] Generalize a couple of passes so they can operate on any FunctionLike op..

The requirement on the FunctionLike trait isn't clear to me: I'm all for making things less constrained that they artificially are, I'd just like to document the remaining restriction.

LG otherwise!

Dec 13 2021, 12:04 PM · Restricted Project
stellaraccident committed rG34696e654289: [NFC] Generalize a couple of passes so they can operate on any FunctionLike op. (authored by stellaraccident).
[NFC] Generalize a couple of passes so they can operate on any FunctionLike op.
Dec 13 2021, 12:02 PM
stellaraccident closed D115645: [NFC] Generalize a couple of passes so they can operate on any FunctionLike op..
Dec 13 2021, 12:02 PM · Restricted Project
stellaraccident updated the diff for D115645: [NFC] Generalize a couple of passes so they can operate on any FunctionLike op..

Rebase.

Dec 13 2021, 11:57 AM · Restricted Project
stellaraccident added reviewers for D115645: [NFC] Generalize a couple of passes so they can operate on any FunctionLike op.: mravishankar, scotttodd.
Dec 13 2021, 9:34 AM · Restricted Project
stellaraccident requested review of D115645: [NFC] Generalize a couple of passes so they can operate on any FunctionLike op..
Dec 13 2021, 9:33 AM · Restricted Project

Nov 29 2021

stellaraccident committed rGa88bb5b9fee5: [mlir][python] Audit and fix a lot of the Python pyi stubs. (authored by stellaraccident).
[mlir][python] Audit and fix a lot of the Python pyi stubs.
Nov 29 2021, 9:43 PM
stellaraccident added a comment to D114767: [mlir][python] Audit and fix a lot of the Python pyi stubs..

Feel free to comment post-submit (and/or submit more fixes).

Nov 29 2021, 9:43 PM · Restricted Project
stellaraccident closed D114767: [mlir][python] Audit and fix a lot of the Python pyi stubs..
Nov 29 2021, 9:43 PM · Restricted Project
stellaraccident added a reviewer for D114767: [mlir][python] Audit and fix a lot of the Python pyi stubs.: ftynse.
Nov 29 2021, 9:42 PM · Restricted Project
stellaraccident requested review of D114767: [mlir][python] Audit and fix a lot of the Python pyi stubs..
Nov 29 2021, 9:40 PM · Restricted Project
stellaraccident committed rGbdc3183742f1: [mlir][python] Implement more SymbolTable methods. (authored by stellaraccident).
[mlir][python] Implement more SymbolTable methods.
Nov 29 2021, 8:33 PM
stellaraccident closed D114687: [mlir][python] Implement more SymbolTable methods..
Nov 29 2021, 8:32 PM · Restricted Project
stellaraccident updated the diff for D114687: [mlir][python] Implement more SymbolTable methods..

Add pyi bindings.

Nov 29 2021, 8:32 PM · Restricted Project
stellaraccident updated the diff for D114687: [mlir][python] Implement more SymbolTable methods..

Comments and rebase.

Nov 29 2021, 8:12 PM · Restricted Project
stellaraccident added inline comments to D114687: [mlir][python] Implement more SymbolTable methods..
Nov 29 2021, 8:11 PM · Restricted Project
stellaraccident committed rGa6e7d024a9eb: [mlir][python] Add pyi stub files to enable auto completion. (authored by stellaraccident).
[mlir][python] Add pyi stub files to enable auto completion.
Nov 29 2021, 8:00 PM
stellaraccident closed D114679: [mlir][python] Add pyi stub files to enable auto completion..
Nov 29 2021, 8:00 PM · Restricted Project
stellaraccident added inline comments to D114679: [mlir][python] Add pyi stub files to enable auto completion..
Nov 29 2021, 8:00 PM · Restricted Project
stellaraccident accepted D114731: [mlir][OpDSL] Fix OpDSL tests after https://reviews.llvm.org/D114680..

Thanks for the fix (by way of fixing the shapes so that we could remove the fallback to unverified printing). I was able to line things up on my screen to side by side review, but for the future, as Mehdi says: an NFC split followed by a fix to the few impacted test cases would be better (or the other way around).

Nov 29 2021, 1:29 PM · Restricted Project
stellaraccident added a comment to D114731: [mlir][OpDSL] Fix OpDSL tests after https://reviews.llvm.org/D114680..

Splitting and fixing at the same time kills the diff, it'd be better to have this in two steps otherwise I'm not sure how this is reviewable.

Also your revision says it is fixing the test, but the bot is passing right now: https://lab.llvm.org/buildbot/#/builders/61/builds/18113 ; are they not running in CI? What's missing?

Nov 29 2021, 1:13 PM · Restricted Project
stellaraccident added a comment to D114679: [mlir][python] Add pyi stub files to enable auto completion..

Nice! It's a shame that static methods are not handled, can we hack something in the generator?

Nov 29 2021, 8:12 AM · Restricted Project

Nov 28 2021

stellaraccident added a reviewer for D114687: [mlir][python] Implement more SymbolTable methods.: ftynse.
Nov 28 2021, 8:34 PM · Restricted Project
stellaraccident requested review of D114687: [mlir][python] Implement more SymbolTable methods..
Nov 28 2021, 8:34 PM · Restricted Project
stellaraccident committed rGace1d0ad3dc4: [mlir][python] Normalize asm-printing IR behavior. (authored by stellaraccident).
[mlir][python] Normalize asm-printing IR behavior.
Nov 28 2021, 6:03 PM
stellaraccident closed D114680: [mlir][python] Normalize asm-printing IR behavior..
Nov 28 2021, 6:03 PM · Restricted Project
stellaraccident added a reviewer for D114679: [mlir][python] Add pyi stub files to enable auto completion.: mehdi_amini.
Nov 28 2021, 5:12 PM · Restricted Project
stellaraccident added reviewers for D114680: [mlir][python] Normalize asm-printing IR behavior.: mehdi_amini, nicolasvasilache, gysit.
Nov 28 2021, 3:46 PM · Restricted Project
stellaraccident requested review of D114680: [mlir][python] Normalize asm-printing IR behavior..
Nov 28 2021, 3:45 PM · Restricted Project
stellaraccident added reviewers for D114679: [mlir][python] Add pyi stub files to enable auto completion.: ftynse, nicolasvasilache.
Nov 28 2021, 2:17 PM · Restricted Project
stellaraccident requested review of D114679: [mlir][python] Add pyi stub files to enable auto completion..
Nov 28 2021, 2:16 PM · Restricted Project

Nov 24 2021

stellaraccident accepted D114568: [MLIR] Rename test/python/dialects/math.py -> math_dialect.py.
Nov 24 2021, 7:45 PM · Restricted Project

Nov 19 2021

stellaraccident committed rG3fcdd182e978: NFC: Callout restriction on folding 0-result ops in documentation. (authored by stellaraccident).
NFC: Callout restriction on folding 0-result ops in documentation.
Nov 19 2021, 12:35 PM
stellaraccident closed D114271: NFC: Callout restriction on folding 0-result ops in documentation..
Nov 19 2021, 12:35 PM · Restricted Project
stellaraccident added a reviewer for D114271: NFC: Callout restriction on folding 0-result ops in documentation.: rriddle.
Nov 19 2021, 12:33 PM · Restricted Project
stellaraccident requested review of D114271: NFC: Callout restriction on folding 0-result ops in documentation..
Nov 19 2021, 12:32 PM · Restricted Project

Nov 14 2021

stellaraccident added a reverting change for rG1a6c26d1f529: Revert "[mlir] Allow out-of-tree python building from installed MLIR.": rG132bc6e2d481: Re-apply "[mlir] Allow out-of-tree python building from installed MLIR.".
Nov 14 2021, 8:32 PM
stellaraccident committed rG132bc6e2d481: Re-apply "[mlir] Allow out-of-tree python building from installed MLIR." (authored by stellaraccident).
Re-apply "[mlir] Allow out-of-tree python building from installed MLIR."
Nov 14 2021, 8:32 PM
stellaraccident closed D113732: Re-apply "[mlir] Allow out-of-tree python building from installed MLIR.".
Nov 14 2021, 8:32 PM · Restricted Project
stellaraccident updated the diff for D113732: Re-apply "[mlir] Allow out-of-tree python building from installed MLIR.".

Rebase.

Nov 14 2021, 2:46 PM · Restricted Project

Nov 11 2021

stellaraccident committed rGc265170110b2: [mlir] Add MLIR-C dylib. (authored by stellaraccident).
[mlir] Add MLIR-C dylib.
Nov 11 2021, 10:58 PM
stellaraccident closed D113731: [mlir] Add MLIR-C dylib..
Nov 11 2021, 10:58 PM · Restricted Project