Page MenuHomePhabricator

stellaraccident (Stella Laurenzo)
User

Projects

User does not belong to any projects.

User Details

User Since
Dec 20 2019, 9:16 PM (57 w, 2 d)

Recent Activity

Today

stellaraccident accepted D95368: [mlir] Add C API for IntegerSet.
Mon, Jan 25, 8:52 AM · Restricted Project
stellaraccident accepted D95357: [mlir] Use more C99 comments in C API header files.

Thanks. This has been annoying me for a while.

Mon, Jan 25, 8:45 AM · Restricted Project

Yesterday

stellaraccident added a comment to D94387: Add new LLVMComponents CMake module..

PTAL - I ran out of time this week to make substantive progress on this, but I took a pass through the comments and cleaned up. When I next have time, I'll work on finishing the dev work on it to get everything working, then integrate it into the existing CMAKE flags and checkpoint to see where we are.

Sun, Jan 24, 8:06 PM · Restricted Project
stellaraccident updated the diff for D94387: Add new LLVMComponents CMake module..

Address comments and rebase.

Sun, Jan 24, 8:03 PM · Restricted Project
stellaraccident committed rGfd226c9b028d: [mlir][Python] Roll up of python API fixes. (authored by stellaraccident).
[mlir][Python] Roll up of python API fixes.
Sun, Jan 24, 7:04 PM
stellaraccident closed D95320: [mlir][Python] Roll up of python API fixes..
Sun, Jan 24, 7:04 PM · Restricted Project
stellaraccident added inline comments to D95320: [mlir][Python] Roll up of python API fixes..
Sun, Jan 24, 7:02 PM · Restricted Project
stellaraccident abandoned D94810: [mlir][python] Swap operands/results order on default builder..

As discussed on discourse, we won't be going forward with this change. I've forked the things that survive in to D95320 and will do another patch to implement the "most specific builder" approach that jpienaar pointed out.

Sun, Jan 24, 3:25 PM · Restricted Project
stellaraccident added a reviewer for D95320: [mlir][Python] Roll up of python API fixes.: mehdi_amini.
Sun, Jan 24, 2:53 PM · Restricted Project
stellaraccident requested review of D95320: [mlir][Python] Roll up of python API fixes..
Sun, Jan 24, 2:52 PM · Restricted Project

Sat, Jan 23

stellaraccident committed rG52586c46b088: [mlir][CAPI] Add result type inference to the CAPI. (authored by stellaraccident).
[mlir][CAPI] Add result type inference to the CAPI.
Sat, Jan 23, 2:33 PM
stellaraccident closed D95283: [mlir][CAPI] Add result type inference to the CAPI..
Sat, Jan 23, 2:33 PM · Restricted Project
stellaraccident updated the diff for D95283: [mlir][CAPI] Add result type inference to the CAPI..

Comments

Sat, Jan 23, 2:30 PM · Restricted Project

Fri, Jan 22

stellaraccident added reviewers for D95283: [mlir][CAPI] Add result type inference to the CAPI.: jpienaar, mehdi_amini.
Fri, Jan 22, 6:50 PM · Restricted Project
stellaraccident requested review of D95283: [mlir][CAPI] Add result type inference to the CAPI..
Fri, Jan 22, 6:50 PM · Restricted Project

Tue, Jan 19

stellaraccident added inline comments to D95022: Add Python bindings for the builtin dialect.
Tue, Jan 19, 10:37 PM · Restricted Project
stellaraccident accepted D95022: Add Python bindings for the builtin dialect.

Thanks. Lg modulo comments

Tue, Jan 19, 10:09 PM · Restricted Project
stellaraccident added a comment to D94368: Enable python bindings for tensor, shape and linalg dialects..

We don't need to test completeness: i.e. no need to test every feature from ODS, just basic plumbing here (import and create / round-trip one or two ops), that's why I mentioned "smoke test".
I guess it'll be more useful with the registration aspect sorted out.

Tue, Jan 19, 8:05 PM · Restricted Project
stellaraccident added a comment to D94368: Enable python bindings for tensor, shape and linalg dialects..

I think it'd be preferable to write basic smoke tests for the bindings when adding these.

+1 especially given that it is python, having a test that it even loads adds some value. How do you square that with the general policy of not testing specific oss generated code?

Tue, Jan 19, 7:39 PM · Restricted Project
stellaraccident added a comment to D94368: Enable python bindings for tensor, shape and linalg dialects..

I think it'd be preferable to write basic smoke tests for the bindings when adding these.

Tue, Jan 19, 7:38 PM · Restricted Project
stellaraccident added inline comments to D94738: [mlir][python] Factor out standalone OpView._ods_build_default class method..
Tue, Jan 19, 7:36 PM · Restricted Project
stellaraccident added a comment to D94810: [mlir][python] Swap operands/results order on default builder..

Forked to discourse: https://llvm.discourse.group/t/finalizing-operand-result-ordering-in-python-bindings/2612

Tue, Jan 19, 5:07 PM · Restricted Project
stellaraccident updated the diff for D94810: [mlir][python] Swap operands/results order on default builder..

Rebase and fork from parents.

Tue, Jan 19, 4:17 PM · Restricted Project
stellaraccident committed rGb62c7e047420: [mlir][python] Swap shape and element_type order for MemRefType. (authored by stellaraccident).
[mlir][python] Swap shape and element_type order for MemRefType.
Tue, Jan 19, 4:05 PM
stellaraccident closed D94812: [mlir][python] Swap shape and element_type order for MemRefType..
Tue, Jan 19, 4:05 PM · Restricted Project
stellaraccident added a comment to D94812: [mlir][python] Swap shape and element_type order for MemRefType..

Hmm, this change actually makes Python API align on C++ API. I don't remember if there was a good reason to swap the order in C.

Tue, Jan 19, 4:04 PM · Restricted Project
stellaraccident updated the diff for D94812: [mlir][python] Swap shape and element_type order for MemRefType..

Rebase and split from parent.

Tue, Jan 19, 4:03 PM · Restricted Project
stellaraccident added inline comments to D94387: Add new LLVMComponents CMake module..
Tue, Jan 19, 1:25 PM · Restricted Project
stellaraccident committed rG894d88a759c9: [mlir][python] Add facility for extending generated python ODS. (authored by stellaraccident).
[mlir][python] Add facility for extending generated python ODS.
Tue, Jan 19, 1:21 PM
stellaraccident closed D94752: [mlir][python] Add facility for extending generated python ODS..
Tue, Jan 19, 1:20 PM · Restricted Project
stellaraccident updated the diff for D94752: [mlir][python] Add facility for extending generated python ODS..

Rebase

Tue, Jan 19, 1:14 PM · Restricted Project
stellaraccident accepted D94988: [mlir][OpFormatGen] Fix incorrect kind used for RegionsDirective.
Tue, Jan 19, 11:30 AM · Restricted Project
stellaraccident added inline comments to D94752: [mlir][python] Add facility for extending generated python ODS..
Tue, Jan 19, 9:35 AM · Restricted Project
stellaraccident committed rG71b6b010e6bc: [mlir][python] Factor out standalone OpView._ods_build_default class method. (authored by stellaraccident).
[mlir][python] Factor out standalone OpView._ods_build_default class method.
Tue, Jan 19, 9:34 AM
stellaraccident closed D94738: [mlir][python] Factor out standalone OpView._ods_build_default class method..
Tue, Jan 19, 9:34 AM · Restricted Project
stellaraccident added inline comments to D94738: [mlir][python] Factor out standalone OpView._ods_build_default class method..
Tue, Jan 19, 9:30 AM · Restricted Project

Mon, Jan 18

stellaraccident added a comment to D94738: [mlir][python] Factor out standalone OpView._ods_build_default class method..

PTAL

Mon, Jan 18, 4:11 PM · Restricted Project
stellaraccident updated the diff for D94738: [mlir][python] Factor out standalone OpView._ods_build_default class method..
  • Addressed comments.
  • Implemented full support for optionality in operands and results.
  • Buffed up error messages.
  • Implemented the first stage of support for default building regions.
Mon, Jan 18, 4:11 PM · Restricted Project
stellaraccident updated subscribers of rGd9b6e4d583c5: NFC: Document current MLIR Python ODS conventions..
Mon, Jan 18, 12:26 PM
stellaraccident updated subscribers of rG417f61374323: [NFC] Update some mlir python documentation..
Mon, Jan 18, 12:25 PM
stellaraccident committed rGd9b6e4d583c5: NFC: Document current MLIR Python ODS conventions. (authored by stellaraccident).
NFC: Document current MLIR Python ODS conventions.
Mon, Jan 18, 12:25 PM
stellaraccident committed rG417f61374323: [NFC] Update some mlir python documentation. (authored by stellaraccident).
[NFC] Update some mlir python documentation.
Mon, Jan 18, 11:52 AM
stellaraccident added a comment to D94810: [mlir][python] Swap operands/results order on default builder..

Not sure about this one... I can understand the rationale, but this starts to diverge from C++/ODS, which already has suboptimal documentation and I'm apprehensive of the complexity it might add. If we agree we want to put result types after operands, we should be doing so consistently and that could be a problem for generating builders automatically if we decide we want that.

Mon, Jan 18, 11:23 AM · Restricted Project

Sat, Jan 16

stellaraccident added a comment to D94387: Add new LLVMComponents CMake module..

Also added file sizes for binaries and libraries in unbundled mode to the above gist.

Sat, Jan 16, 7:18 PM · Restricted Project
stellaraccident abandoned D94000: DRAFT: Teach components to link into shared libs..
Sat, Jan 16, 7:05 PM · Restricted Project
stellaraccident added inline comments to D94000: DRAFT: Teach components to link into shared libs..
Sat, Jan 16, 7:04 PM · Restricted Project
stellaraccident added a reviewer for D94387: Add new LLVMComponents CMake module.: serge-sans-paille.
Sat, Jan 16, 7:02 PM · Restricted Project
stellaraccident added a comment to D94387: Add new LLVMComponents CMake module..

Hi serge-sans-paille, thank you for the comments! They caught me mid-cleanup so, I decided to push a revision with the further minimal changes needed to get the build mostly functional with this facility, as I think it might provide some better context. Now that I've got the tree in a non-hacky building mode and just have a handful of failing tests (around llvm-config mostly), I'll work through your comments a bit.

Sat, Jan 16, 7:01 PM · Restricted Project
stellaraccident updated the diff for D94387: Add new LLVMComponents CMake module..

Include minimal changes to the tree to build/test.

Sat, Jan 16, 6:42 PM · Restricted Project

Fri, Jan 15

stellaraccident accepted D94847: [mlir][AsmPrinter] Properly escape strings when printing locations.
Fri, Jan 15, 4:57 PM · Restricted Project
stellaraccident added reviewers for D94812: [mlir][python] Swap shape and element_type order for MemRefType.: ftynse, mehdi_amini, nicolasvasilache.
Fri, Jan 15, 11:11 AM · Restricted Project
stellaraccident requested review of D94812: [mlir][python] Swap shape and element_type order for MemRefType..
Fri, Jan 15, 11:11 AM · Restricted Project
stellaraccident added reviewers for D94810: [mlir][python] Swap operands/results order on default builder.: ftynse, mehdi_amini, nicolasvasilache.
Fri, Jan 15, 10:27 AM · Restricted Project
stellaraccident requested review of D94810: [mlir][python] Swap operands/results order on default builder..
Fri, Jan 15, 10:26 AM · Restricted Project

Thu, Jan 14

stellaraccident added reviewers for D94752: [mlir][python] Add facility for extending generated python ODS.: ftynse, mehdi_amini, nicolasvasilache.
Thu, Jan 14, 10:59 PM · Restricted Project
stellaraccident requested review of D94752: [mlir][python] Add facility for extending generated python ODS..
Thu, Jan 14, 10:59 PM · Restricted Project
stellaraccident added reviewers for D94738: [mlir][python] Factor out standalone OpView._ods_build_default class method.: ftynse, mehdi_amini, nicolasvasilache.
Thu, Jan 14, 6:33 PM · Restricted Project
stellaraccident requested review of D94738: [mlir][python] Factor out standalone OpView._ods_build_default class method..
Thu, Jan 14, 6:32 PM · Restricted Project

Mon, Jan 11

stellaraccident committed rGcceb1bfcbbc4: [mlir][CAPI] Introduce standard source layout for mlir-c dialect registration. (authored by stellaraccident).
[mlir][CAPI] Introduce standard source layout for mlir-c dialect registration.
Mon, Jan 11, 12:37 PM
stellaraccident committed rG53c866c286a7: Enable python bindings for tensor, shape and linalg dialects. (authored by stellaraccident).
Enable python bindings for tensor, shape and linalg dialects.
Mon, Jan 11, 12:37 PM
stellaraccident closed D94370: [mlir][CAPI] Introduce standard source layout for mlir-c dialect registration..
Mon, Jan 11, 12:36 PM · Restricted Project
stellaraccident closed D94368: Enable python bindings for tensor, shape and linalg dialects..
Mon, Jan 11, 12:36 PM · Restricted Project
stellaraccident updated the diff for D94368: Enable python bindings for tensor, shape and linalg dialects..

Fix dependency issue for generated Linalg ODS.

Mon, Jan 11, 12:30 PM · Restricted Project
stellaraccident added inline comments to D94387: Add new LLVMComponents CMake module..
Mon, Jan 11, 8:38 AM · Restricted Project
stellaraccident added a reviewer for D94387: Add new LLVMComponents CMake module.: tstellar.
Mon, Jan 11, 12:03 AM · Restricted Project
stellaraccident requested review of D94387: Add new LLVMComponents CMake module..
Mon, Jan 11, 12:02 AM · Restricted Project

Sat, Jan 9

stellaraccident added inline comments to D94370: [mlir][CAPI] Introduce standard source layout for mlir-c dialect registration..
Sat, Jan 9, 9:19 PM · Restricted Project
stellaraccident edited reviewers for D94370: [mlir][CAPI] Introduce standard source layout for mlir-c dialect registration., added: GeorgeLyon, mehdi_amini, ftynse; removed: silvas, nicolasvasilache.
Sat, Jan 9, 7:06 PM · Restricted Project
stellaraccident updated the diff for D94370: [mlir][CAPI] Introduce standard source layout for mlir-c dialect registration..

Fix typo.

Sat, Jan 9, 7:05 PM · Restricted Project
stellaraccident requested review of D94370: [mlir][CAPI] Introduce standard source layout for mlir-c dialect registration..
Sat, Jan 9, 7:04 PM · Restricted Project
stellaraccident added a reviewer for D94368: Enable python bindings for tensor, shape and linalg dialects.: mehdi_amini.
Sat, Jan 9, 5:17 PM · Restricted Project
stellaraccident requested review of D94368: Enable python bindings for tensor, shape and linalg dialects..
Sat, Jan 9, 5:16 PM · Restricted Project

Mon, Jan 4

stellaraccident added inline comments to D93351: [llvm-shlib] Build backend libraries as loadable modules.
Mon, Jan 4, 11:58 AM · Restricted Project
stellaraccident added inline comments to D93351: [llvm-shlib] Build backend libraries as loadable modules.
Mon, Jan 4, 10:18 AM · Restricted Project

Sun, Jan 3

stellaraccident requested review of D94000: DRAFT: Teach components to link into shared libs..
Sun, Jan 3, 1:46 PM · Restricted Project

Sat, Jan 2

stellaraccident accepted D93960: Install Numpy in the MLIR Docker image, this is required for the python bindings.
Sat, Jan 2, 12:41 AM

Fri, Jan 1

stellaraccident added inline comments to D93960: Install Numpy in the MLIR Docker image, this is required for the python bindings.
Fri, Jan 1, 8:03 PM

Thu, Dec 31

stellaraccident added inline comments to D93960: Install Numpy in the MLIR Docker image, this is required for the python bindings.
Thu, Dec 31, 7:10 PM
stellaraccident added a comment to D93960: Install Numpy in the MLIR Docker image, this is required for the python bindings.

You are going to also want the pybind11 package. That will be the next error after the numpy error :)

Thu, Dec 31, 5:59 PM
stellaraccident committed rGa16c00a7033d: [mlir][python] Fix python extension building on windows. (authored by stellaraccident).
[mlir][python] Fix python extension building on windows.
Thu, Dec 31, 12:12 AM

Wed, Dec 30

stellaraccident committed rG42c57dcc35ea: [mlir][python] Tweaks to make python extensions packagable/distributable. (authored by stellaraccident).
[mlir][python] Tweaks to make python extensions packagable/distributable.
Wed, Dec 30, 11:38 PM
stellaraccident closed D93936: [mlir][python] Tweaks to make python extensions packagable/distributable..
Wed, Dec 30, 11:38 PM · Restricted Project
stellaraccident added a comment to D93936: [mlir][python] Tweaks to make python extensions packagable/distributable..

I'm going to go ahead and submit this and get your feedback in post-review. It is blocking the ability to make functional distributable binaries.

Wed, Dec 30, 11:37 PM · Restricted Project

Tue, Dec 29

stellaraccident added a reviewer for D93936: [mlir][python] Tweaks to make python extensions packagable/distributable.: mehdi_amini.
Tue, Dec 29, 11:39 PM · Restricted Project
stellaraccident requested review of D93936: [mlir][python] Tweaks to make python extensions packagable/distributable..
Tue, Dec 29, 11:39 PM · Restricted Project
stellaraccident committed rG11f41cd44515: [mlir][python] Install generated dialect sources. (authored by stellaraccident).
[mlir][python] Install generated dialect sources.
Tue, Dec 29, 8:15 PM
stellaraccident closed D93928: [mlir][python] Install generated dialect sources..
Tue, Dec 29, 8:15 PM · Restricted Project
stellaraccident added a reviewer for D93928: [mlir][python] Install generated dialect sources.: mehdi_amini.
Tue, Dec 29, 6:07 PM · Restricted Project
stellaraccident requested review of D93928: [mlir][python] Install generated dialect sources..
Tue, Dec 29, 6:06 PM · Restricted Project
stellaraccident committed rG8a1f1a100cce: [mlir][python] Aggressively avoid name collisions in generated python ODS code. (authored by stellaraccident).
[mlir][python] Aggressively avoid name collisions in generated python ODS code.
Tue, Dec 29, 5:47 PM
stellaraccident closed D93920: [mlir][python] Aggressively avoid name collisions in generated python ODS code..
Tue, Dec 29, 5:47 PM · Restricted Project
stellaraccident committed rG14056c88d668: [mlir][Python] Add an Operation.name property (authored by siddharth-krishna).
[mlir][Python] Add an Operation.name property
Tue, Dec 29, 2:17 PM
stellaraccident closed D93474: [mlir][Python] Add an Operation.name property.
Tue, Dec 29, 2:16 PM · Restricted Project
stellaraccident updated the diff for D93474: [mlir][Python] Add an Operation.name property.

Rebase.

Tue, Dec 29, 2:16 PM · Restricted Project
stellaraccident committed rGf5665a248621: [mlir][python] Add Operation.verify(). (authored by stellaraccident).
[mlir][python] Add Operation.verify().
Tue, Dec 29, 2:12 PM
stellaraccident closed D93913: [mlir][python] Add Operation.verify()..
Tue, Dec 29, 2:12 PM · Restricted Project
stellaraccident accepted D93474: [mlir][Python] Add an Operation.name property.
Tue, Dec 29, 2:09 PM · Restricted Project
stellaraccident added a comment to D93474: [mlir][Python] Add an Operation.name property.

Thanks - I'll land the patch. (sorry for the delay - I've been offline for holidays)

Tue, Dec 29, 2:08 PM · Restricted Project
stellaraccident added reviewers for D93920: [mlir][python] Aggressively avoid name collisions in generated python ODS code.: mehdi_amini, ftynse.
Tue, Dec 29, 2:05 PM · Restricted Project
stellaraccident requested review of D93920: [mlir][python] Aggressively avoid name collisions in generated python ODS code..
Tue, Dec 29, 2:04 PM · Restricted Project