Page MenuHomePhabricator

stellaraccident (Stella Laurenzo)
User

Projects

User does not belong to any projects.

User Details

User Since
Dec 20 2019, 9:16 PM (40 w, 2 d)

Recent Activity

Wed, Sep 23

stellaraccident committed rG63998649dd48: NFC: Remove dangling dep on MLIRStandardOps. (authored by stellaraccident).
NFC: Remove dangling dep on MLIRStandardOps.
Wed, Sep 23, 9:31 AM
stellaraccident committed rGb522f09d963b: Remove MLIR C-API explicit registration of standard ops. (authored by stellaraccident).
Remove MLIR C-API explicit registration of standard ops.
Wed, Sep 23, 9:24 AM
stellaraccident closed D88155: Remove MLIR C-API explicit registration of standard ops..
Wed, Sep 23, 9:24 AM · Restricted Project
stellaraccident added a reviewer for D88155: Remove MLIR C-API explicit registration of standard ops.: ftynse.
Wed, Sep 23, 8:15 AM · Restricted Project
stellaraccident requested review of D88155: Remove MLIR C-API explicit registration of standard ops..
Wed, Sep 23, 8:14 AM · Restricted Project
stellaraccident accepted D88148: [mlir] Add insert before/after to list-like constructs in C API.
Wed, Sep 23, 8:07 AM · Restricted Project
stellaraccident committed rG8e84972ab706: NFC: Remove unused variable. (authored by stellaraccident).
NFC: Remove unused variable.
Wed, Sep 23, 8:01 AM
stellaraccident committed rGc1ded6a75991: Add mlir python APIs for creating operations, regions and blocks. (authored by stellaraccident).
Add mlir python APIs for creating operations, regions and blocks.
Wed, Sep 23, 7:59 AM
stellaraccident committed rG4cf754c4bca9: Implement python iteration over the operation/region/block hierarchy. (authored by stellaraccident).
Implement python iteration over the operation/region/block hierarchy.
Wed, Sep 23, 7:59 AM
stellaraccident added inline comments to D87996: Add mlir python APIs for creating operations, regions and blocks..
Wed, Sep 23, 7:59 AM · Restricted Project
stellaraccident committed rG7abb0ff7e041: Add Operation to python bindings. (authored by stellaraccident).
Add Operation to python bindings.
Wed, Sep 23, 7:59 AM
stellaraccident closed D87996: Add mlir python APIs for creating operations, regions and blocks..
Wed, Sep 23, 7:59 AM · Restricted Project
stellaraccident closed D87982: Implement python iteration over the operation/region/block hierarchy..
Wed, Sep 23, 7:59 AM · Restricted Project
stellaraccident closed D87958: Add Operation to python bindings..
Wed, Sep 23, 7:59 AM · Restricted Project
stellaraccident updated the diff for D87996: Add mlir python APIs for creating operations, regions and blocks..

Address comments.

Wed, Sep 23, 7:57 AM · Restricted Project
stellaraccident updated the diff for D87982: Implement python iteration over the operation/region/block hierarchy..

Push just the one change.

Wed, Sep 23, 7:44 AM · Restricted Project
stellaraccident added inline comments to D87982: Implement python iteration over the operation/region/block hierarchy..
Wed, Sep 23, 7:43 AM · Restricted Project
stellaraccident updated the diff for D87982: Implement python iteration over the operation/region/block hierarchy..

Address comments.

Wed, Sep 23, 7:43 AM · Restricted Project
stellaraccident updated the diff for D87958: Add Operation to python bindings..

Address comments

Wed, Sep 23, 7:36 AM · Restricted Project
stellaraccident added inline comments to D87958: Add Operation to python bindings..
Wed, Sep 23, 7:36 AM · Restricted Project

Sun, Sep 20

stellaraccident added inline comments to D87958: Add Operation to python bindings..
Sun, Sep 20, 9:54 PM · Restricted Project
stellaraccident added reviewers for D87996: Add mlir python APIs for creating operations, regions and blocks.: mehdi_amini, ftynse, zhanghb97.
Sun, Sep 20, 9:29 PM · Restricted Project
stellaraccident requested review of D87996: Add mlir python APIs for creating operations, regions and blocks..
Sun, Sep 20, 9:29 PM · Restricted Project

Sat, Sep 19

stellaraccident added reviewers for D87982: Implement python iteration over the operation/region/block hierarchy.: mehdi_amini, ftynse, zhanghb97.
Sat, Sep 19, 10:06 PM · Restricted Project
stellaraccident requested review of D87982: Implement python iteration over the operation/region/block hierarchy..
Sat, Sep 19, 10:05 PM · Restricted Project
stellaraccident updated the diff for D87958: Add Operation to python bindings..

Comments and rebase.

Sat, Sep 19, 7:49 PM · Restricted Project

Fri, Sep 18

stellaraccident edited reviewers for D87958: Add Operation to python bindings., added: ftynse, mehdi_amini, zhanghb97; removed: jdoerfert.
Fri, Sep 18, 6:52 PM · Restricted Project
stellaraccident updated the diff for D87958: Add Operation to python bindings..

Fix nits.

Fri, Sep 18, 6:52 PM · Restricted Project
stellaraccident requested review of D87958: Add Operation to python bindings..
Fri, Sep 18, 6:48 PM · Restricted Project
stellaraccident abandoned D87213: Preliminary python API for constructing operations..
Fri, Sep 18, 6:48 PM · Restricted Project
stellaraccident committed rG85185b61b637: First pass on MLIR python context lifetime management. (authored by stellaraccident).
First pass on MLIR python context lifetime management.
Fri, Sep 18, 12:18 PM
stellaraccident closed D87886: First pass on MLIR python context lifetime management..
Fri, Sep 18, 12:18 PM · Restricted Project
stellaraccident updated the diff for D87886: First pass on MLIR python context lifetime management..

Rebase.

Fri, Sep 18, 12:18 PM · Restricted Project
stellaraccident added a comment to D87886: First pass on MLIR python context lifetime management..

I cleaned this up further by removing the fallback through the global context table for all of the "normal" IR cases (that already have access to something they can turn into a PyMlirContextRef). Then I removed the corresponding constructors and special cased the one remaining where we don't have an explicit ref (Named Attributes - which need to be cleaned up anyway). This should degenerate to just a Python IncRef on the python object for each such case and eliminate most of the accounting.

Fri, Sep 18, 10:57 AM · Restricted Project
stellaraccident updated the diff for D87886: First pass on MLIR python context lifetime management..

Remove remaining fallback cases for the global context lookup in child object construction (and remove corresponding constructors).

Fri, Sep 18, 10:55 AM · Restricted Project
stellaraccident updated the diff for D87886: First pass on MLIR python context lifetime management..

Address comments and explicitly pass context refs to child objects where available (avoids a global table lookup in common cases).

Fri, Sep 18, 10:44 AM · Restricted Project
stellaraccident added reviewers for D87886: First pass on MLIR python context lifetime management.: mehdi_amini, ftynse, zhanghb97.
Fri, Sep 18, 12:24 AM · Restricted Project
stellaraccident requested review of D87886: First pass on MLIR python context lifetime management..
Fri, Sep 18, 12:23 AM · Restricted Project

Wed, Sep 16

stellaraccident updated subscribers of D87617: [mlir] expose affine map to C API.

I don't think that is related to you: that run was for a batch of changes
and the error is in a section of the tree in no way related to your change.
I think you're clear.

Wed, Sep 16, 9:17 PM · Restricted Project
stellaraccident accepted D87677: [mlir] Model StringRef in C API.

Thanks for the option updates. We should talk soon about enabling these by default.

Wed, Sep 16, 6:12 AM · Restricted Project

Tue, Sep 15

stellaraccident accepted D87677: [mlir] Model StringRef in C API.

Matches what was discussed on discourse. This will break the python bindings. Do you want to update those in this patch or have me do them in a follow-up? As a non-default feature still under development, either is in bounds; however, the changes should be small/mechanical and if you can include them, it will help.

Tue, Sep 15, 2:54 PM · Restricted Project

Sun, Sep 6

stellaraccident committed rG7403e3ee3240: Extend PyConcreteType to support intermediate base classes. (authored by stellaraccident).
Extend PyConcreteType to support intermediate base classes.
Sun, Sep 6, 11:41 PM
stellaraccident closed D87208: Extend PyConcreteType to support intermediate base classes..
Sun, Sep 6, 11:40 PM · Restricted Project
stellaraccident added inline comments to D87213: Preliminary python API for constructing operations..
Sun, Sep 6, 10:49 PM · Restricted Project
stellaraccident updated the diff for D87213: Preliminary python API for constructing operations..

Example changes to show how comments can be addressed.

Sun, Sep 6, 10:31 PM · Restricted Project
stellaraccident added a comment to D87208: Extend PyConcreteType to support intermediate base classes..

There are redundant init implementations for PyRankedTensorType and PyUnrankedTensorType (see inline comments).

Sun, Sep 6, 8:58 PM · Restricted Project
stellaraccident updated the diff for D87208: Extend PyConcreteType to support intermediate base classes..

Address comments and rebase.

Sun, Sep 6, 8:57 PM · Restricted Project
stellaraccident added reviewers for D87213: Preliminary python API for constructing operations.: ftynse, zhanghb97.
Sun, Sep 6, 3:53 PM · Restricted Project
stellaraccident requested review of D87213: Preliminary python API for constructing operations..
Sun, Sep 6, 3:53 PM · Restricted Project
stellaraccident added inline comments to D87091: [mlir] Add Shaped Type, Tensor Type and MemRef Type to python bindings..
Sun, Sep 6, 12:14 PM · Restricted Project
stellaraccident added a reviewer for D87208: Extend PyConcreteType to support intermediate base classes.: zhanghb97.
Sun, Sep 6, 12:10 PM · Restricted Project
stellaraccident requested review of D87208: Extend PyConcreteType to support intermediate base classes..
Sun, Sep 6, 12:09 PM · Restricted Project
stellaraccident committed rG54d432aa6b83: [mlir] Add Shaped Type, Tensor Type and MemRef Type to python bindings. (authored by zhanghb97).
[mlir] Add Shaped Type, Tensor Type and MemRef Type to python bindings.
Sun, Sep 6, 11:47 AM
stellaraccident closed D87091: [mlir] Add Shaped Type, Tensor Type and MemRef Type to python bindings..
Sun, Sep 6, 11:46 AM · Restricted Project
stellaraccident accepted D87091: [mlir] Add Shaped Type, Tensor Type and MemRef Type to python bindings..
Sun, Sep 6, 11:37 AM · Restricted Project

Fri, Sep 4

stellaraccident requested changes to D87091: [mlir] Add Shaped Type, Tensor Type and MemRef Type to python bindings..

Nice job on adding the PyShapedType intermediate base class -- there is some trickiness there. There is a cleaner way to get to the same end that I've left a comment on: feel free to leave a TODO or try to take it on in this patch.

Fri, Sep 4, 9:57 AM · Restricted Project

Thu, Sep 3

stellaraccident requested changes to D87091: [mlir] Add Shaped Type, Tensor Type and MemRef Type to python bindings..

Still just on mobile so not a comprehensive review. Thanks for working on this.

Thu, Sep 3, 8:35 AM · Restricted Project

Sat, Aug 29

stellaraccident added inline comments to D86785: [mlir] Add Complex Type, Vector Type and Tuple Type subclasses to python bindings.
Sat, Aug 29, 8:09 PM · Restricted Project
stellaraccident requested changes to D86785: [mlir] Add Complex Type, Vector Type and Tuple Type subclasses to python bindings.

I am indeed out and on mobile, so just let a couple of response comments.

Sat, Aug 29, 8:04 PM · Restricted Project

Aug 28 2020

stellaraccident committed rG2d1362e09af2: Add Location, Region and Block to MLIR Python bindings. (authored by stellaraccident).
Add Location, Region and Block to MLIR Python bindings.
Aug 28 2020, 3:30 PM
stellaraccident closed D86683: Add Location, Region and Block to MLIR Python bindings..
Aug 28 2020, 3:29 PM · Restricted Project
stellaraccident added a comment to D86683: Add Location, Region and Block to MLIR Python bindings..

Addressed comments. Thanks!

Aug 28 2020, 3:26 PM · Restricted Project
stellaraccident updated the diff for D86683: Add Location, Region and Block to MLIR Python bindings..

Comments and rebase.

Aug 28 2020, 3:26 PM · Restricted Project

Aug 26 2020

stellaraccident added reviewers for D86683: Add Location, Region and Block to MLIR Python bindings.: ftynse, jpienaar.
Aug 26 2020, 11:51 PM · Restricted Project
stellaraccident requested review of D86683: Add Location, Region and Block to MLIR Python bindings..
Aug 26 2020, 11:50 PM · Restricted Project

Aug 24 2020

stellaraccident committed rG1f6c4d829c2d: [mlir] Add Index Type, Floating Point Type and None Type subclasses to python… (authored by zhanghb97).
[mlir] Add Index Type, Floating Point Type and None Type subclasses to python…
Aug 24 2020, 12:10 PM
stellaraccident closed D86466: [mlir] Add Index Type, Floating Point Type and None Type subclasses to python bindings..
Aug 24 2020, 12:09 PM · Restricted Project
stellaraccident accepted D86466: [mlir] Add Index Type, Floating Point Type and None Type subclasses to python bindings..

Thanks!

Aug 24 2020, 11:48 AM · Restricted Project

Aug 23 2020

stellaraccident committed rG3137c299269d: Add initial python bindings for attributes. (authored by stellaraccident).
Add initial python bindings for attributes.
Aug 23 2020, 10:18 PM
stellaraccident closed D86250: Add initial python bindings for attributes..
Aug 23 2020, 10:18 PM · Restricted Project
stellaraccident added a comment to D86250: Add initial python bindings for attributes..

Thanks for the reviews. I've added a number of TODOs and it doesn't look like there is disagreement on the design points. Feel free to bring them up for further discussion if you feel otherwise.

Aug 23 2020, 10:17 PM · Restricted Project
stellaraccident updated the diff for D86250: Add initial python bindings for attributes..

Address comments.

Aug 23 2020, 10:16 PM · Restricted Project

Aug 21 2020

stellaraccident added a reviewer for D86250: Add initial python bindings for attributes.: jpienaar.
Aug 21 2020, 8:33 PM · Restricted Project

Aug 19 2020

stellaraccident edited reviewers for D86250: Add initial python bindings for attributes., added: mehdi_amini, ftynse; removed: jdoerfert.

ftynse is going offline for a time, so directing this review at Mehdi.

Aug 19 2020, 3:36 PM · Restricted Project
stellaraccident requested review of D86250: Add initial python bindings for attributes..
Aug 19 2020, 3:35 PM · Restricted Project
stellaraccident committed rGd29d1e2ffd61: Add python bindings for Type and IntegerType. (authored by stellaraccident).
Add python bindings for Type and IntegerType.
Aug 19 2020, 9:24 AM
stellaraccident closed D86179: Add python bindings for Type and IntegerType..
Aug 19 2020, 9:24 AM · Restricted Project
stellaraccident updated the diff for D86179: Add python bindings for Type and IntegerType..

Address comments.

Aug 19 2020, 9:23 AM · Restricted Project

Aug 18 2020

stellaraccident accepted D86143: [mlir] expose standard attributes to C API.

I could go either way on my comment about style for returning uniqued, backing string data. Feel free to submit as-is and possibly resolve forward if there is a further discussion to be had.

Aug 18 2020, 5:42 PM · Restricted Project
stellaraccident added a reviewer for D86179: Add python bindings for Type and IntegerType.: ftynse.
Aug 18 2020, 5:28 PM · Restricted Project
stellaraccident requested review of D86179: Add python bindings for Type and IntegerType..
Aug 18 2020, 5:27 PM · Restricted Project

Aug 17 2020

stellaraccident accepted D86094: [mlir] expose standard types to C API.
Aug 17 2020, 9:47 PM · Restricted Project
stellaraccident added a comment to D85140: [RFC] Factor out repetitive cmake patterns for llvm-style projects.

I am supportive of this cleanup (I have found this awkward in out of tree projects particularly). However, I am probably also not the right person for a detailed review compared to the existing CMake boiler-plate.

Aug 17 2020, 9:53 AM · Restricted Project, Restricted Project
stellaraccident committed rG95b77f2eac8f: Adds __str__ support to python mlir.ir.MlirModule. (authored by stellaraccident).
Adds __str__ support to python mlir.ir.MlirModule.
Aug 17 2020, 9:47 AM
stellaraccident closed D86046: Adds __str__ support to python mlir.ir.MlirModule..
Aug 17 2020, 9:47 AM · Restricted Project
stellaraccident added inline comments to D86046: Adds __str__ support to python mlir.ir.MlirModule..
Aug 17 2020, 9:45 AM · Restricted Project
stellaraccident updated the diff for D86046: Adds __str__ support to python mlir.ir.MlirModule..

Fix lint and remove lambda decay.

Aug 17 2020, 9:45 AM · Restricted Project

Aug 16 2020

stellaraccident requested review of D86046: Adds __str__ support to python mlir.ir.MlirModule..
Aug 16 2020, 8:55 PM · Restricted Project
stellaraccident committed rGfcd2969da9e0: Initial MLIR python bindings based on the C API. (authored by zhanghb97).
Initial MLIR python bindings based on the C API.
Aug 16 2020, 7:37 PM
stellaraccident closed D85481: [mlir][WIP] Initial python bindings for C API.
Aug 16 2020, 7:36 PM · Restricted Project
stellaraccident accepted D85481: [mlir][WIP] Initial python bindings for C API.

Thank you for the attempt at a move constructor, but these things need to be done a specific way and we don't want to be cloning the module. I've reverted that part of the patch and made the PyMlirModule class move-only. Also updated some comments and other non-functional things.

Aug 16 2020, 7:32 PM · Restricted Project
stellaraccident updated the diff for D85481: [mlir][WIP] Initial python bindings for C API.

Refactor to proper move constructor and update comments.

Aug 16 2020, 7:30 PM · Restricted Project

Aug 14 2020

stellaraccident added inline comments to D85481: [mlir][WIP] Initial python bindings for C API.
Aug 14 2020, 7:51 AM · Restricted Project

Aug 13 2020

stellaraccident requested changes to D85481: [mlir][WIP] Initial python bindings for C API.

Almost there. Once you resolve the above comments, let me know if you need me to land it.

Aug 13 2020, 7:19 PM · Restricted Project

Aug 11 2020

stellaraccident accepted D85751: [mlir] use intptr_t in C API.
Aug 11 2020, 6:53 PM · Restricted Project
stellaraccident accepted D85748: [mlir] Expose printing functions in C API.
Aug 11 2020, 6:52 PM · Restricted Project

Aug 9 2020

stellaraccident added inline comments to D85481: [mlir][WIP] Initial python bindings for C API.
Aug 9 2020, 12:12 PM · Restricted Project
stellaraccident requested changes to D85481: [mlir][WIP] Initial python bindings for C API.

Sorry for the delayed review (was offline for a few days). I've made some design-level comments but not done a full review. In general, I agree with Alex's comments and have added more specific feedback. It is quite hard to do a detailed review with all of the clang-format warnings: please make sure to format before sending the patch.

Aug 9 2020, 12:03 PM · Restricted Project

Aug 3 2020

stellaraccident accepted D83310: [mlir] Initial version of C APIs.

Thank you. Updates Lgtm.

Aug 3 2020, 8:33 AM · Restricted Project

Jul 23 2020

stellaraccident accepted D84459: [llvm][NFC] Don't use llvm/Config/config.h in .h files.
Jul 23 2020, 10:16 PM · Restricted Project