- User Since
- Dec 20 2019, 9:16 PM (57 w, 2 d)
Thanks. This has been annoying me for a while.
PTAL - I ran out of time this week to make substantive progress on this, but I took a pass through the comments and cleaned up. When I next have time, I'll work on finishing the dev work on it to get everything working, then integrate it into the existing CMAKE flags and checkpoint to see where we are.
Address comments and rebase.
As discussed on discourse, we won't be going forward with this change. I've forked the things that survive in to D95320 and will do another patch to implement the "most specific builder" approach that jpienaar pointed out.
Sat, Jan 23
Fri, Jan 22
Tue, Jan 19
Thanks. Lg modulo comments
Rebase and fork from parents.
Rebase and split from parent.
Mon, Jan 18
- Addressed comments.
- Implemented full support for optionality in operands and results.
- Buffed up error messages.
- Implemented the first stage of support for default building regions.
Sat, Jan 16
Also added file sizes for binaries and libraries in unbundled mode to the above gist.
Hi serge-sans-paille, thank you for the comments! They caught me mid-cleanup so, I decided to push a revision with the further minimal changes needed to get the build mostly functional with this facility, as I think it might provide some better context. Now that I've got the tree in a non-hacky building mode and just have a handful of failing tests (around llvm-config mostly), I'll work through your comments a bit.
Include minimal changes to the tree to build/test.
Fri, Jan 15
Thu, Jan 14
Mon, Jan 11
Fix dependency issue for generated Linalg ODS.
Sat, Jan 9
Mon, Jan 4
Sun, Jan 3
Sat, Jan 2
Fri, Jan 1
Thu, Dec 31
You are going to also want the pybind11 package. That will be the next error after the numpy error :)
Wed, Dec 30
I'm going to go ahead and submit this and get your feedback in post-review. It is blocking the ability to make functional distributable binaries.
Tue, Dec 29
Thanks - I'll land the patch. (sorry for the delay - I've been offline for holidays)