Page MenuHomePhabricator

benvanik (Ben Vanik)
User

Projects

User does not belong to any projects.

User Details

User Since
Jan 2 2020, 8:36 AM (107 w, 5 h)

Recent Activity

Nov 2 2021

benvanik added a comment to D111620: [mlir:DialectConversion] Restructure how argument/target materializations get invoked.

This change broke 1->N type conversion (as noted in a FIXME in here). This is really unfortunate and there doesn't seem to be any workaround now that the materialization is deferred and the casts are inserted in a way that doesn't allow for patterns to match them. Is this something that can be rolled back or fixed soon? 1->N type conversion during dialect conversion did work before this change so this is a regression.

Nov 2 2021, 3:36 PM · Restricted Project

Oct 21 2021

benvanik added inline comments to D112105: [ADT] Simplifying hex string parsing so it runs faster in debug modes..
Oct 21 2021, 7:05 PM · Restricted Project, Restricted Project
benvanik added inline comments to D112105: [ADT] Simplifying hex string parsing so it runs faster in debug modes..
Oct 21 2021, 6:30 PM · Restricted Project, Restricted Project
benvanik added inline comments to D112105: [ADT] Simplifying hex string parsing so it runs faster in debug modes..
Oct 21 2021, 9:46 AM · Restricted Project, Restricted Project
benvanik added a comment to D112105: [ADT] Simplifying hex string parsing so it runs faster in debug modes..

We don't usually optimize for debug performance - is there a particular case where this comes up that's worth prioritizing/changing code for (& is there a good heuristic we can use about which debug performance is going to matter and which isn't?)

Oct 21 2021, 9:04 AM · Restricted Project, Restricted Project

Oct 19 2021

benvanik updated the diff for D112105: [ADT] Simplifying hex string parsing so it runs faster in debug modes..

(w/ full context)

Oct 19 2021, 6:04 PM · Restricted Project, Restricted Project
benvanik requested review of D112105: [ADT] Simplifying hex string parsing so it runs faster in debug modes..
Oct 19 2021, 4:14 PM · Restricted Project, Restricted Project

Oct 8 2021

benvanik updated the diff for D111374: Fix parsing of hex-format index dense tensor attributes..

Added a test - there was nothing in this file testing the hex format at all, so I just used what I knew would trigger that path and round-trip as hex.

Oct 8 2021, 7:38 AM · Restricted Project

Oct 7 2021

benvanik requested review of D111374: Fix parsing of hex-format index dense tensor attributes..
Oct 7 2021, 6:52 PM · Restricted Project

Sep 14 2021

benvanik requested review of D109791: Fixing vector add pattern that incorrectly returns success..
Sep 14 2021, 3:42 PM · Restricted Project

Aug 25 2021

benvanik accepted D108716: [mlir][linalg] Tune hasTensorSemantics/hasBufferSemantics methods..
Aug 25 2021, 11:36 AM · Restricted Project
benvanik accepted D108715: [mlir][linalg] Tune getTiedIndexingMap method (NFC)..

awesome!

Aug 25 2021, 11:35 AM · Restricted Project

Aug 23 2021

benvanik accepted D108572: [mlir][NFC] Add inlineRegion overloads that take a block iterator insert position.
Aug 23 2021, 12:31 PM · Restricted Project

Jun 10 2021

benvanik accepted D104073: [mlir-ir-printing] Prefix the dump message with the split marker(// -----).

<3

Jun 10 2021, 4:42 PM · Restricted Project

Apr 21 2021

benvanik added a comment to D100915: [mlir] Refactor the forward dataflow propagation in SCCP into a generic framework.

This is really exciting and I'm excited to start using it - thanks River! I'll take a deeper look at the API and may ask you a question or two as I try to figure out how to hold it correctly :)

Apr 21 2021, 1:49 PM · Restricted Project

Mar 3 2021

benvanik added inline comments to D97887: [mlir] Enhance InferShapedTypeOpInterface and move LinalgOps to use them..
Mar 3 2021, 6:33 PM · Restricted Project

Mar 1 2021

benvanik added a comment to D97532: [mlir] Enhance InferShapedTypeOpInterface and move LinalgOps to use them..

Thanks for doing this Mahesh! This will really help unblock me.

Mar 1 2021, 3:14 PM · Restricted Project

Nov 8 2020

benvanik accepted D90958: [mlir][Python] Add Windows DLL loader to get python extensions working there..
Nov 8 2020, 10:24 AM · Restricted Project

Nov 5 2020

benvanik accepted D90824: [mlir][CAPI] Proposal: Always building a libMLIRPublicAPI.so..
Nov 5 2020, 4:09 PM · Restricted Project
benvanik requested changes to D90824: [mlir][CAPI] Proposal: Always building a libMLIRPublicAPI.so..

LGTM besides naming

Nov 5 2020, 1:05 PM · Restricted Project

Oct 12 2020

benvanik requested review of D89255: [mlir] fixing typo in parseAttribute that was ignoring caller-specified types.
Oct 12 2020, 10:39 AM · Restricted Project

Apr 22 2020

benvanik accepted D78690: [mlir][Standard] Allow select to use an i1 for vector and tensor values.
Apr 22 2020, 8:38 PM · Restricted Project
benvanik accepted D78682: [mlir][Standard] Add a canonicalization to simplify cond_br when the successors are identical.
Apr 22 2020, 6:31 PM · Restricted Project
benvanik accepted D78683: [mlir][Standard] Add support for canonicalizing branches to passthrough blocks.
Apr 22 2020, 6:31 PM · Restricted Project
benvanik accepted D78681: [mlir][Standard] Add canonicalization for collapsing pass through cond_br successors..
Apr 22 2020, 6:31 PM · Restricted Project
benvanik added inline comments to D78484: Providing buffer assignment for MLIR.
Apr 22 2020, 11:58 AM · Restricted Project, Restricted Project

Apr 21 2020

benvanik added inline comments to D78484: Providing buffer assignment for MLIR.
Apr 21 2020, 1:33 PM · Restricted Project, Restricted Project

Apr 7 2020

benvanik accepted D77686: [mlir][AsmFormat] Avoid invalidating the iterator when verifying attributes.
Apr 7 2020, 3:49 PM · Restricted Project

Mar 4 2020

benvanik accepted D75531: [mlir][vulkan-runner] Add basic timing for compute pipeline.
Mar 4 2020, 1:29 PM · Restricted Project
benvanik added inline comments to D75531: [mlir][vulkan-runner] Add basic timing for compute pipeline.
Mar 4 2020, 9:00 AM · Restricted Project

Mar 3 2020

benvanik added inline comments to D75531: [mlir][vulkan-runner] Add basic timing for compute pipeline.
Mar 3 2020, 2:24 PM · Restricted Project

Feb 28 2020

benvanik added inline comments to D74884: Added CallOpSignatureConversion pattern.
Feb 28 2020, 11:51 AM

Feb 16 2020

benvanik accepted D74646: [mlir] Add a TypeRange class that functions similar to ValueRange..

Perfect!

Feb 16 2020, 1:49 PM · Restricted Project

Feb 4 2020

benvanik accepted D73959: [mlir][spirv] Add dialect-specific attribute for target environment.
V_1_3, [], [Shader, GroupNonUniformArithmetic],

Beautiful!

Feb 4 2020, 6:21 PM · Restricted Project

Jan 25 2020

benvanik accepted D73415: [mlir][spirv] Relax verification to allow flexible placement.
Jan 25 2020, 4:08 PM · Restricted Project
benvanik accepted D73349: [mlir][spirv] Add spv.GroupNonUniformElect and spv.GroupNonUniformIAdd.
Jan 25 2020, 4:08 PM · Restricted Project
benvanik accepted D73379: [mlir] Add support for marking 'unknown' operations as dynamically legal..
Jan 25 2020, 4:08 PM · Restricted Project
benvanik accepted D73419: [mlir][spirv] NFC: simplify load/store builder call sites.
Jan 25 2020, 4:08 PM · Restricted Project
benvanik accepted D73421: [mlir][spirv] NFC: expose builtin func op conversion pattern.
Jan 25 2020, 4:08 PM · Restricted Project
benvanik accepted D73416: [mlir][spirv] Create builtin variable in nearest symbol table.
Jan 25 2020, 3:59 PM · Restricted Project

Jan 16 2020

benvanik accepted D72763: [mlir][spirv] Use symbolize functions in enum attribute predicates.

Awesome! I may use that predicate/class in some of my dialects too :)

Jan 16 2020, 7:30 AM · Restricted Project

Jan 15 2020

benvanik requested changes to D72763: [mlir][spirv] Use symbolize functions in enum attribute predicates.

sybmolize is a typo in the description :)

Jan 15 2020, 9:15 AM · Restricted Project
benvanik accepted D72764: [mlir][spirv] Fix SPV_MM_Vulkan extension reqirements.
Jan 15 2020, 9:15 AM · Restricted Project
benvanik accepted D72765: [mlir][spirv] Support implied extensions and capabilities.
Jan 15 2020, 9:15 AM · Restricted Project
benvanik accepted D72760: [mlir][spirv] Add implied capabilities and availability for capabilities.
Jan 15 2020, 9:15 AM · Restricted Project

Jan 14 2020

benvanik accepted D72256: [mlir][spirv] Properly support SPIR-V conversion target.
Jan 14 2020, 1:47 PM · Restricted Project