Page MenuHomePhabricator

[OPENMP][NFC]Release notes for OpenMP in clang (11.x).
AbandonedPublic

Authored by ABataev on Aug 25 2020, 11:42 AM.

Diff Detail

Event Timeline

ABataev created this revision.Aug 25 2020, 11:42 AM
Herald added a project: Restricted Project. · View Herald TranscriptAug 25 2020, 11:42 AM
ABataev requested review of this revision.Aug 25 2020, 11:42 AM
jdoerfert accepted this revision.Aug 25 2020, 1:30 PM

Nit: Maybe we should mention complex support on nvptx devices.

The rest looks good to me. Others might want to add stuff but we can merge this right away (IMHO)

This revision is now accepted and ready to land.Aug 25 2020, 1:30 PM

Nit: Maybe we should mention complex support on nvptx devices.

Ok, will add.

The rest looks good to me. Others might want to add stuff

That was the intention.

but we can merge this right away (IMHO)

It is up to Hans if he has some time. But I think I covered almost all new features (+ complex for NVPTX), so after the update it can be merged with 11.x release.

ABataev updated this revision to Diff 287776.Aug 25 2020, 2:22 PM

+ complex types for NVPTX

ABataev updated this revision to Diff 287777.Aug 25 2020, 2:25 PM

Misprint fix

Harbormaster completed remote builds in B69510: Diff 287776.

present map type and motion modifier
default(firstprivate)

present map type and motion modifier
default(firstprivate)

Present was added after 11.0 branching. Not aure about default(firstprivate)

Yest, it was before clang 11 was branched, so need to add to the list of the changes.

ABataev updated this revision to Diff 287906.Aug 26 2020, 3:44 AM

Added default(firstprivate)

hans added a comment.Aug 26 2020, 8:22 AM

but we can merge this right away (IMHO)

It is up to Hans if he has some time. But I think I covered almost all new features (+ complex for NVPTX), so after the update it can be merged with 11.x release.

It's fine by me if you want to wait a day or two for more comments, or go ahead and merge directly.

but we can merge this right away (IMHO)

It is up to Hans if he has some time. But I think I covered almost all new features (+ complex for NVPTX), so after the update it can be merged with 11.x release.

It's fine by me if you want to wait a day or two for more comments, or go ahead and merge directly.

Let's wait a day more then. Tomorrow it would be definitely ok to merge it with 11.x

hans added a comment.Tue, Sep 15, 6:52 AM

Please go ahead and commit.

Please go ahead and commit.

Hi Hans, can you commit it yourself? I have some technical issues and not able to commit it. And I don't know when it is going to be resolved. :(

hans added a comment.Tue, Sep 15, 9:40 AM

Please go ahead and commit.

Hi Hans, can you commit it yourself? I have some technical issues and not able to commit it. And I don't know when it is going to be resolved. :(

Sure! 4b23932e230dd48a7bfc6fadb461d0ef81aeba94

Please go ahead and commit.

Hi Hans, can you commit it yourself? I have some technical issues and not able to commit it. And I don't know when it is going to be resolved. :(

Sure! 4b23932e230dd48a7bfc6fadb461d0ef81aeba94

Thanks!

ABataev abandoned this revision.Wed, Sep 16, 5:13 AM