User Details
- User Since
- Jun 3 2014, 8:03 PM (357 w, 6 d)
Today
No more comments from the community. I think it is okay to accept this revision. Thanks.
Thu, Mar 18
I tried the patch in our environment and it works. LG. Thanks.
Jan 25 2021
I am seeing these errors.
Jan 22 2021
Jan 18 2021
Jan 5 2021
It looks fine. Thanks.
Jan 4 2021
Aug 25 2020
default(firstprivate) was added in https://reviews.llvm.org/rG78443666bc18a6957d279a0f58319c8a3e57771a
present map type and motion modifier
default(firstprivate)
Jun 30 2020
Mar 14 2020
Feb 25 2020
Somewhat related, that means Clang issues a warning for every compilation should there be a "unsupported" CUDA version around, even if it's not used? @tra maybe we can only issue the warning if CUDA is going to be used?
Feb 21 2020
Since it is a TR8 feature, should we have this guarded by -fopenmp-version=?
So an alternative is to:
- patch openmp/runtime/cmake/LibompCheckLinkerFlag.cmake to make the libomp_check_linker_flag function to ignore the "Unknown CUDA version" warning, AND
- ask users to build with -DCMAKE_CXX_FLAGS=-Wno-unknown-cuda-version -DCMAKE_C_FLAGS=-Wno-unknown-cuda-version to get around the C_SUPPORTS_FPIC test in cmake/modules/HandleLLVMOptions.cmake if the system has CUDA10.2 installed.
Feb 17 2020
Summary
- In order to avoid the bug in PR44587, one needs to build with >9.0.
- With CUDA toolkit 10.2, building the trunk will fail because 10.0.0 does not support it yet.
Feb 14 2020
I am not sure I understand. Do we need to modify stuff outside of /openmp? I was hoping it is our CMake that can be adjusted to make this work as described earlier. TBH, he warning is even not my biggest problem. As long as we get a libomptarget.bc we should be fine.
It turns out that having the warning message also affects the C_SUPPORTS_FPIC test in cmake/modules/HandleLLVMOptions.cmake. As a result, cmake thinks that -fPIC is not supported. Eventually, it leads to error in libclang-cpp.so.
Thanks for all the comments. It makes sense to keep the warning there before any ptx65 features are added. The warning should also apply to both the CUDA and OpenMP compile paths. As a result, I will pursue to ignore the warning in the build of libomp (i.e. libomp_check_linker_flag function in LibompCheckLinkerFlag.cmake). I think it is less pervasive and also can avoid similar occurrence when a new version of CUDA toolkit is available.
Feb 13 2020
Feb 12 2020
Feb 11 2020
Feb 3 2020
Change requires unified_address status to partial.
Ping
Jan 23 2020
Jan 22 2020
Address review comments and rebase.
Jan 17 2020
Jan 16 2020
Jan 6 2020
Jan 3 2020
Jan 2 2020
Update based on suggestion to simply the check and rebase.
Dec 30 2019
Dec 28 2019
Nov 22 2019
Nov 6 2019
Nov 5 2019
Sep 4 2019
Aug 9 2019
Aug 1 2019
Looks fine to me.
Jul 29 2019
Jul 10 2019
Jul 9 2019
May 2 2019
It looks good to me.
It looks good to me.
Feb 21 2019
Feb 19 2019
The change looks okay to me.
Feb 12 2019
Feb 7 2019
I close https://reviews.llvm.org/D57848 and consolidate the review and patch in this one.
Will consolidate the review and patch in https://reviews.llvm.org/D57851 .
Feb 6 2019
See https://reviews.llvm.org/D57848. I think we can close either one.
Feb 5 2019
Committed: r353186
Feb 4 2019
Update based on review comment.
Jan 21 2019
Jan 18 2019
Addressed reviewer's comment.
Jan 17 2019
Add changes in D56790.
Jan 15 2019
Add update in OpenMP support release note.