- User Since
- Nov 15 2019, 2:59 AM (44 w, 1 d)
Thu, Sep 17
AFAIK, all files which are required/should be available in libomptarget reside in llvm/Frontend/OpenMP/* , so may be an option can be provided for only-tarball users to get files only from this directory.
This kind of approach will also enforce people exporting stuff from clang to libomptarget, to put everything in one place.
Tue, Sep 15
Thu, Sep 10
Moved the code to load plugins to a helper function and before loop on plugins.
Wed, Sep 9
First of two patches after splitting D73657
Mon, Sep 7
Thu, Aug 27
Wed, Aug 26
- Reduced scope of specialized PrePostActionTy
Mon, Aug 24
- Moved amdgcn specific functions to CGOpenMPAMDGCN.cpp
- Removed tautology condition
- Corrected case of local variables
- Restored original formatting
- Changed back declaration of emit kernel methods as private
- Added support of amdgcn specific PrePostActionTy implementation and its corresponding test cases
- Changed static line numbers in new test cases with regex
- Other small code corrections
Aug 19 2020
Aug 18 2020
Please let me know if there are any changes/suggestions.
Aug 17 2020
Aug 13 2020
Time for check-clang has increased from ~51 sec to ~107 sec after this patch.
Putting it here before committing/closing the review.
Aug 11 2020
Aug 4 2020
Abandoning in favor of D85214
This patch updates 101 out 320 test files. Remaining will be posted as a separate patch to ease review.
Aug 3 2020
Removed redundant testing for version 5.0 with its version string.
Aug 2 2020
Jul 30 2020
Changes as requested.
Improved comment placement. Corrected check lines. Rebased.
Moved comments to header files. Used regexps for test cases.
Jul 29 2020
Jul 28 2020
Jul 27 2020
Generalized regex in one of the test to pass harbormaster build.
Jul 24 2020
Added InitTempAlloca address space cast.
LGTM. Please wait for @arsenm 's review.
Jul 21 2020
Added final to specialized classes.
Thank you. LGTM.
Jul 20 2020
Can you add test with version string 50 also?
So, tests should be there for version 45, version 50, and default version. It will ensure that this test doesn't silently stops testing for 50 when we upgrade to the next version.
Jul 17 2020
Removed getNVPTXWarpSize() changes for a separate patch and rebased.
Jul 15 2020
[Work in progress]
Among all the test files in clang/test/OpenMP which were running only for version 4.5, I am yet to fix following files (rest all are given in this patch):
Jul 14 2020
Instead of adding additional test cases without version string, removed all occurrences of -fopenmp-version=50.
I will hold committing till llvm-11 branching so it doesn't break something in any downstream dependent project at the last moment.
Removed all references to AMDGCN to make it NFC. Will introduce AMDGCN specific things separately in a followup patch.
Removed all formatting and spacing changes introduced due to clang-format.
Jul 13 2020
Jul 9 2020
Jul 6 2020
Jul 3 2020
- Removed unused functions
- Changed to INLINE
- Moved fence functions to target_impl.h
Jul 2 2020
Removed fix for OpenMPTesting.cmake bug.
Thanks @Hahnfeld. I realized that LLVM_MAJOR_VERSION was neither getting set in OpenMPTesting.cmake nor was it
inheriting it from anywhere else. So, OPENMP_TEST_COMPILER_VERSION_MAJOR was also getting set as empty, which
was getting propagated to lit by config.test_compiler_features. That is why "clang-11" was not getting recognized
as a valid target by lit-unsupported (though clang-11.0.0 would have worked). This change should fix this issue.
LGTM. Thank you!
Please link any ongoing/future effort to enable support for gcc-9/10 for the failing tests, as and when it materializes.
- Added clang version identification in openmp/runtime/test
- Marked these three tests as unsupported for clang-11
- Refactored test lines to pass clang-format
Jul 1 2020
[Work in progress] 48 files inspected/corrected. Following 35 are yet to be checked: