Page MenuHomePhabricator

luismarques (Luís Marques)
Software/hardware engineer at lowRISC

Projects

User does not belong to any projects.

User Details

User Since
Nov 2 2018, 7:48 AM (127 w, 5 d)

Mostly LLVM work.

Recent Activity

Yesterday

luismarques added a comment to D99087: [RISCV] Fix stack slot for argument types (Bug 49500).

No worries. I just noticed my latest "pref" diff mistakenly changed the initial StackAlign from max(align(ArgValueVT), align(Outs[i].ArgVT)) to max(prefalign(ArgValueVT), prefalign(ArgValueVT)). I now think that this is where the diffs came from. The align of the Outs[i].ArgVT type is often likely larger than the split type (like i128 vs. XLEN), so by removing it we reduce the stack size.

Right now I suspect I should revert this back to the preferred alignment of Outs[i].ArgVT so we're at least keeping the same alignment (or safely increasing it to the split type). Any thoughts?

Tue, Apr 13, 3:32 AM · Restricted Project
luismarques added a comment to D99087: [RISCV] Fix stack slot for argument types (Bug 49500).

Thanks. Also, it seems I was wrong, you do sometimes get smaller stack sizes despite getPrefTypeAlign >= getEVTAlign. Weird.

Yeah it's interesting. Sorry, I haven't had time to investigate yet. I'll do that today. Have you taken a look, by any chance?

Tue, Apr 13, 3:07 AM · Restricted Project

Wed, Apr 7

luismarques added a comment to D98932: [RISCV] Don't call setHasMultipleConditionRegisters(), so icmp is sunk.

Could you please clean up the test a bit? It contains references to attribute groups that don't actually exist (#0, #1). One attribute you do want to add is nounwind, to avoid the clutter caused by the CFI directives. In manually written tests we also generally don't include some of those dso_local, local_unnamed_addr, etc. In general, it would be nice to make it look less like Clang's output and more like something that can be easily read and reasoned about.

Wed, Apr 7, 2:07 PM · Restricted Project
luismarques retitled D97897: [MSan][RISCV] Add RISCV64 support for MSan from [MSan][RISCV] Add RISC-V support for MSan to [MSan][RISCV] Add RISCV64 support for MSan.
Wed, Apr 7, 6:27 AM · Restricted Project, Restricted Project
luismarques retitled D97897: [MSan][RISCV] Add RISCV64 support for MSan from [MSan][RISCV][Draft] Draft implementation of MSan RISC-V support to [MSan][RISCV] Add RISC-V support for MSan.
Wed, Apr 7, 3:23 AM · Restricted Project, Restricted Project
luismarques updated the diff for D97897: [MSan][RISCV] Add RISCV64 support for MSan.

Optimize address mappings.

Wed, Apr 7, 3:16 AM · Restricted Project, Restricted Project

Tue, Apr 6

luismarques committed rGb09df246cad9: [lit testing] Fix xfail-cl.py test worker count (authored by luismarques).
[lit testing] Fix xfail-cl.py test worker count
Tue, Apr 6, 12:48 PM
luismarques closed D99858: [lit testing] Fix xfail-cl.py test worker count.
Tue, Apr 6, 12:48 PM · Restricted Project
luismarques committed rG0c3bc1f3a477: [ASan][RISCV] Fix RISC-V memory mapping (authored by luismarques).
[ASan][RISCV] Fix RISC-V memory mapping
Tue, Apr 6, 12:46 PM
luismarques closed D97646: [ASan][RISCV] Fix RISC-V memory mapping.
Tue, Apr 6, 12:46 PM · Restricted Project, Restricted Project
luismarques added a comment to D99087: [RISCV] Fix stack slot for argument types (Bug 49500).

Yes, fair enough. I've updated the diff to use the preferred type alignment. We can always revert for whatever reason. I'll try and take a look through the diffs later.

Tue, Apr 6, 3:19 AM · Restricted Project

Mon, Apr 5

luismarques added a comment to D99087: [RISCV] Fix stack slot for argument types (Bug 49500).

Hmm good catch. Shame there's no DAG wrapper for that method; targets don't typically use it. I could look into it before merging, if you like?

Using the preferred type align does produce changes in 7 of our tests. Maybe we should leave it to a follow-up patch? We'd be best verifying that each is correct.

Mon, Apr 5, 5:07 AM · Restricted Project
luismarques accepted D95025: [RISCV] Add a test showing incorrect codegen.

Once update_mir_test_checks.py is tweaked we can start using it for this test, but let's merge it as-is for now. Thanks!

Mon, Apr 5, 1:51 AM · Restricted Project

Sun, Apr 4

luismarques abandoned D99068: [RISCV][WIP][RFC] Fix stack slot for argument type sizes not a multiple of 64 bits (Bug 49500).
Sun, Apr 4, 9:47 AM · Restricted Project
luismarques added a comment to D97514: [SystemZ] Assign the full space for promoted and split outgoing args.

Just a heads-up about a possible pitfall of this patch, though I'm not sure it actually affects SystemZ.

Sun, Apr 4, 9:45 AM · Restricted Project
luismarques updated the diff for D99068: [RISCV][WIP][RFC] Fix stack slot for argument type sizes not a multiple of 64 bits (Bug 49500).

Fixing alignment before truly abandoning, in case it's useful for D97514.

Sun, Apr 4, 9:38 AM · Restricted Project
luismarques added a comment to D99087: [RISCV] Fix stack slot for argument types (Bug 49500).

BTW, it shouldn't affect correctness but the original CreateStackTemporary would use (as part of that method's implementation) getPrefTypeAlign instead of getEVTAlign. In principle that would allow better alignment choices, although at the moment it probably would never make any difference.

Sun, Apr 4, 9:17 AM · Restricted Project
luismarques abandoned D99068: [RISCV][WIP][RFC] Fix stack slot for argument type sizes not a multiple of 64 bits (Bug 49500).

Abandoned in favor of D99087. Thanks @frasercrmck!

Sun, Apr 4, 8:33 AM · Restricted Project
luismarques requested review of D99858: [lit testing] Fix xfail-cl.py test worker count.
Sun, Apr 4, 3:06 AM · Restricted Project

Thu, Apr 1

luismarques accepted D99087: [RISCV] Fix stack slot for argument types (Bug 49500).

LGTM.

Thu, Apr 1, 10:10 AM · Restricted Project

Wed, Mar 31

luismarques committed rGa8cf32baf57d: [RISCV] Add XFAIL riscv32 for known issue with the old pass manager (authored by luismarques).
[RISCV] Add XFAIL riscv32 for known issue with the old pass manager
Wed, Mar 31, 7:19 AM
luismarques closed D99108: [RISCV] Add XFAIL riscv32 for known issue with the old pass manager.
Wed, Mar 31, 7:19 AM · Restricted Project

Tue, Mar 30

luismarques added a reviewer for D99108: [RISCV] Add XFAIL riscv32 for known issue with the old pass manager: aaronpuchert.
Tue, Mar 30, 3:12 PM · Restricted Project
luismarques committed rGeb4967c8bd34: [Sanitizer][RISCV][AArch64][Android] Adjust allocator tests (authored by luismarques).
[Sanitizer][RISCV][AArch64][Android] Adjust allocator tests
Tue, Mar 30, 1:21 PM
luismarques closed D97234: [Sanitizer][RISCV][AArch64][Android] Adjust allocator tests.
Tue, Mar 30, 1:20 PM · Restricted Project
luismarques updated the diff for D97897: [MSan][RISCV] Add RISCV64 support for MSan.

Address review feedback (thanks @MaskRay!).

Tue, Mar 30, 1:12 PM · Restricted Project, Restricted Project
luismarques updated the diff for D97234: [Sanitizer][RISCV][AArch64][Android] Adjust allocator tests.

Rebased.
Tested with the sanitizer-x86_64-linux-android and sanitizer-windows buildbots, so this time there shouldn't be buildbot failures when committing.

Tue, Mar 30, 12:55 PM · Restricted Project
luismarques updated the diff for D97897: [MSan][RISCV] Add RISCV64 support for MSan.
  • Add VarArg handling.
  • Adjust tests.
Tue, Mar 30, 8:16 AM · Restricted Project, Restricted Project

Tue, Mar 23

luismarques added a comment to D92464: [compiler-rt][builtins][RISCV] Port __clear_cache to RISC-V baremetal.

@sequencer What's the plan for this patch?

Tue, Mar 23, 7:36 AM · Restricted Project
luismarques added a comment to D99087: [RISCV] Fix stack slot for argument types (Bug 49500).

There are certainly fewer changes to existing tests, compared with

D99068. But if @luismarques is right in that there is excessive stack
alignment then this patch needs further work.

Tue, Mar 23, 5:58 AM · Restricted Project
luismarques accepted D98877: [RISCV] Use selectImm for RV32. NFC.

LGTM.

Tue, Mar 23, 3:17 AM · Restricted Project

Mon, Mar 22

luismarques updated the summary of D99108: [RISCV] Add XFAIL riscv32 for known issue with the old pass manager.
Mon, Mar 22, 2:10 PM · Restricted Project
luismarques requested review of D99108: [RISCV] Add XFAIL riscv32 for known issue with the old pass manager.
Mon, Mar 22, 2:08 PM · Restricted Project
luismarques updated the diff for D99068: [RISCV][WIP][RFC] Fix stack slot for argument type sizes not a multiple of 64 bits (Bug 49500).
  • Precommitted the original test, to better show the difference caused by of the patch.
  • Updated the existing tests. They seem to more broadly show the issue I noted about the excessive alignment/overly conservative stack size.
Mon, Mar 22, 8:24 AM · Restricted Project
luismarques committed rG20f845d7c9a6: [RISCV][NFC] Add test of stack slot sizes of large split arguments (authored by luismarques).
[RISCV][NFC] Add test of stack slot sizes of large split arguments
Mon, Mar 22, 6:41 AM
luismarques added a comment to D99068: [RISCV][WIP][RFC] Fix stack slot for argument type sizes not a multiple of 64 bits (Bug 49500).

My fix was more direct: I went over ArgValue and all of the SDValue PartValue = OutVals[i + 1]; as in the loop later in this block, and summed up all of the required getStoreSizes of their VTs, and took the maximum required alignment of each. Then created a stack temporary of that summed size and max alignment. I wasn't sufficiently happy with it and since I didn't get much indication that this was an urgent fix I didn't put it up for discussion - sorry about that. I can share my patch with you if you're interested.

Mon, Mar 22, 4:57 AM · Restricted Project
luismarques added a comment to D99068: [RISCV][WIP][RFC] Fix stack slot for argument type sizes not a multiple of 64 bits (Bug 49500).

Does this happen to fix D95025? It's certainly in a similar area as my (WIP) fix that I never got round to publishing.

Mon, Mar 22, 4:38 AM · Restricted Project
luismarques added inline comments to D99068: [RISCV][WIP][RFC] Fix stack slot for argument type sizes not a multiple of 64 bits (Bug 49500).
Mon, Mar 22, 4:18 AM · Restricted Project
luismarques updated the summary of D99068: [RISCV][WIP][RFC] Fix stack slot for argument type sizes not a multiple of 64 bits (Bug 49500).
Mon, Mar 22, 4:09 AM · Restricted Project
luismarques edited reviewers for D99068: [RISCV][WIP][RFC] Fix stack slot for argument type sizes not a multiple of 64 bits (Bug 49500), added: mundaym; removed: Michael.
Mon, Mar 22, 4:06 AM · Restricted Project
luismarques requested review of D99068: [RISCV][WIP][RFC] Fix stack slot for argument type sizes not a multiple of 64 bits (Bug 49500).
Mon, Mar 22, 4:06 AM · Restricted Project

Sat, Mar 20

luismarques abandoned D91052: [WebAssembly] Fix NaN handling when converting FP types.

Superseded by D77384 and D97490.
I can confirm that the mips* XFAIL now passes (since D77384 landed on Feb 26). If wasm contributors are still interested in reviewing this patch I can update it to include only the immediate.ll test update.

Sat, Mar 20, 4:07 AM · Restricted Project

Thu, Mar 18

luismarques added a comment to D98113: [Driver] Also search FilePaths for compiler-rt before falling back.

I just looked at this again and I don't have the full context in my mind right now but won't the test just exercise the BareMetal toolchain and not your changes?

Thu, Mar 18, 8:50 AM · Restricted Project

Wed, Mar 17

luismarques added a comment to D97646: [ASan][RISCV] Fix RISC-V memory mapping.

It's rather recommendation then requirement. Feel free to commit as is.

Wed, Mar 17, 2:15 PM · Restricted Project, Restricted Project
luismarques committed rG6b025da443a4: [Sanitizer] Fix debug builds of sanitizer_stacktrace_test.cpp (authored by luismarques).
[Sanitizer] Fix debug builds of sanitizer_stacktrace_test.cpp
Wed, Mar 17, 8:58 AM
luismarques closed D96956: [Sanitizer] Fix debug builds of sanitizer_stacktrace_test.cpp.
Wed, Mar 17, 8:58 AM · Restricted Project
luismarques added a comment to D96956: [Sanitizer] Fix debug builds of sanitizer_stacktrace_test.cpp.

That's bad, but I don't see a better easy way to fix that.
Maybe you create some separate sanitizer_common_test_runtime lib.

Wed, Mar 17, 8:55 AM · Restricted Project
luismarques updated the diff for D96956: [Sanitizer] Fix debug builds of sanitizer_stacktrace_test.cpp.

Address review feedback.

Wed, Mar 17, 8:54 AM · Restricted Project
luismarques added a comment to D97646: [ASan][RISCV] Fix RISC-V memory mapping.

LGTM, but better if someone with RISCV experience checks this too

Wed, Mar 17, 8:14 AM · Restricted Project, Restricted Project
luismarques added a comment to D95025: [RISCV] Add a test showing incorrect codegen.

Hm, I guess ideally we'd have an option for update_mir_test_checks.py to emit the stack info. I'll see if I can do that later today.

Wed, Mar 17, 7:40 AM · Restricted Project
luismarques reopened D97234: [Sanitizer][RISCV][AArch64][Android] Adjust allocator tests.

Before relanding, I need to check/fix the SizeClassAllocator64PopulateFreeListOOM test for Android x86, as the respective buildbot failed in the first landing attempt.

Wed, Mar 17, 6:49 AM · Restricted Project
luismarques updated the diff for D97234: [Sanitizer][RISCV][AArch64][Android] Adjust allocator tests.

Fix silly mistake in the last update.

Wed, Mar 17, 6:46 AM · Restricted Project

Tue, Mar 16

luismarques added a comment to D97916: [Driver][RISCV] Support parsing multi-lib config from GCC..

This still doesn't report that the multilib configuration came from GCC when it succeeds, does it? I suppose that's not a deal-breaker, but it would be nice to have. Would it be difficult to implement?

Tue, Mar 16, 2:00 PM · Restricted Project
luismarques accepted D98669: [RISCV] Make empty name symbols SF_FormatSpecific so that llvm-symbolizer ignores them for symbolization.

LGTM. Thanks!

Tue, Mar 16, 1:37 PM · Restricted Project
luismarques added a comment to D95916: DebugInfo/Symbolize: Allow STT_NOTYPE/STT_GNU_IFUNC symbols for .symtab symbolization.

Could you recheck? (I am quite certain it fixes your case)

Tue, Mar 16, 1:34 PM · Restricted Project
luismarques added inline comments to D98683: [RISCV] Improve i32 UADDSAT/USUBSAT on RV64..
Tue, Mar 16, 7:06 AM · Restricted Project
luismarques added a comment to D95916: DebugInfo/Symbolize: Allow STT_NOTYPE/STT_GNU_IFUNC symbols for .symtab symbolization.

With -g or -fasynchronous-unwind-tables, .debug_frame/.eh_frame has a label below _start. Its address is _start + 2 and its name is empty.
Neither addr2line nor llvm-symbolizer skips such a symbol with empty name.

Tue, Mar 16, 5:56 AM · Restricted Project
luismarques accepted D98683: [RISCV] Improve i32 UADDSAT/USUBSAT on RV64..
Tue, Mar 16, 5:45 AM · Restricted Project
luismarques added a comment to D98683: [RISCV] Improve i32 UADDSAT/USUBSAT on RV64..

LGTM.

Tue, Mar 16, 5:31 AM · Restricted Project

Mar 15 2021

luismarques added a comment to D95916: DebugInfo/Symbolize: Allow STT_NOTYPE/STT_GNU_IFUNC symbols for .symtab symbolization.

This broke debug info for RISC-V. Test case with broken symbolization:

Mar 15 2021, 3:23 PM · Restricted Project
luismarques added a reverting change for rGa00347b56e36: [Sanitizer][RISCV][AArch64][Android] Adjust allocator tests: rGa149812d0edf: Revert "[Sanitizer][RISCV][AArch64][Android] Adjust allocator tests".
Mar 15 2021, 6:03 AM
luismarques committed rGa149812d0edf: Revert "[Sanitizer][RISCV][AArch64][Android] Adjust allocator tests" (authored by luismarques).
Revert "[Sanitizer][RISCV][AArch64][Android] Adjust allocator tests"
Mar 15 2021, 6:03 AM
luismarques added a reverting change for D97234: [Sanitizer][RISCV][AArch64][Android] Adjust allocator tests: rGa149812d0edf: Revert "[Sanitizer][RISCV][AArch64][Android] Adjust allocator tests".
Mar 15 2021, 6:03 AM · Restricted Project
luismarques accepted D91717: [RISCV][compiler-rt] Add support for save-restore.

LGTM. Thanks!

Mar 15 2021, 5:57 AM · Restricted Project
luismarques committed rGa00347b56e36: [Sanitizer][RISCV][AArch64][Android] Adjust allocator tests (authored by luismarques).
[Sanitizer][RISCV][AArch64][Android] Adjust allocator tests
Mar 15 2021, 4:03 AM
luismarques closed D97234: [Sanitizer][RISCV][AArch64][Android] Adjust allocator tests.
Mar 15 2021, 4:03 AM · Restricted Project
luismarques added a comment to D98113: [Driver] Also search FilePaths for compiler-rt before falling back.

This makes sense to me but I'm not quite sure about the implications, especially when we consider compatibility. I think we need more eyes on this patch.

Mar 15 2021, 3:53 AM · Restricted Project
luismarques accepted D98124: [RISCV] Clean up parsing fence arguments.

LGTM.

Mar 15 2021, 3:01 AM · Restricted Project
luismarques accepted D98233: [RISCV] Improve legalization of i32 UADDO/USUBO on RV64..

LGTM.

Mar 15 2021, 2:42 AM · Restricted Project
luismarques accepted D98159: [RISCV] Add RISCVISD::BR_CC similar to RISCVISD::SELECT_CC..

(Perhaps it would have been better to have split it into the NFC patch and the rest?)

Mar 15 2021, 1:38 AM · Restricted Project
luismarques accepted D98125: [RISCV] Clean up parsing floating point rounding mode.

LGTM. Nice clean-up!

Mar 15 2021, 1:18 AM · Restricted Project

Mar 14 2021

luismarques added inline comments to D98610: [RISCV] Support clang -fpatchable-function-entry && GNU function attribute 'patchable_function_entry'.
Mar 14 2021, 7:08 PM · Restricted Project, Restricted Project
luismarques added a comment to D97916: [Driver][RISCV] Support parsing multi-lib config from GCC..

This patch seems to be in pretty good shape now.

Mar 14 2021, 5:39 PM · Restricted Project
luismarques accepted D98307: [RISCV] Remap 'generic' CPU to 'generic-rv32' or 'generic-rv64'. Validate 64Bit feature against the triple..

LGTM. Thanks!

Mar 14 2021, 4:47 PM · Restricted Project
luismarques added inline comments to D98307: [RISCV] Remap 'generic' CPU to 'generic-rv32' or 'generic-rv64'. Validate 64Bit feature against the triple..
Mar 14 2021, 4:38 PM · Restricted Project
luismarques added a comment to D98307: [RISCV] Remap 'generic' CPU to 'generic-rv32' or 'generic-rv64'. Validate 64Bit feature against the triple..

Why not just error out if passed "generic"? The error message could indicate that "generic-rv<XLEN>" should be used instead.
In other words, it's not clear to me what we're getting with the remap, particularly since it still prints a warning...?

Mar 14 2021, 3:52 PM · Restricted Project
luismarques accepted D98610: [RISCV] Support clang -fpatchable-function-entry && GNU function attribute 'patchable_function_entry'.

Overall LGTM.
I just don't understand what you mean with "1-byte NOPs" in the patchable prefix case. Regular NOPs are emitted. Please clarify the comment/patch as needed.

Mar 14 2021, 3:19 PM · Restricted Project, Restricted Project

Mar 8 2021

luismarques committed rGc5a6ad86b066: [Sanitizer][RISCV] Fix internal_clone (authored by luismarques).
[Sanitizer][RISCV] Fix internal_clone
Mar 8 2021, 2:30 PM
luismarques closed D96954: [Sanitizer][RISCV] Fix internal_clone.
Mar 8 2021, 2:30 PM · Restricted Project
luismarques updated the diff for D97234: [Sanitizer][RISCV][AArch64][Android] Adjust allocator tests.

Address review feedback.

Mar 8 2021, 7:35 AM · Restricted Project

Mar 7 2021

luismarques accepted D98132: [RISCV} Fold (select_cc (setlt X, Y), 0, ne, trueV, falseV) -> (select_cc X, Y, lt, trueV, falseV).

LGTM.

Mar 7 2021, 7:03 AM · Restricted Project
luismarques accepted D98130: [RISCV] Fold (select_cc (xor X, Y), 0, eq/ne, trueV, falseV) -> (select_cc X, Y, eq/ne, trueV, falseV).

Seems correct.

Mar 7 2021, 6:05 AM · Restricted Project

Mar 4 2021

luismarques added a comment to D97966: [compiler-rt][profile][RISCV]: Enable Compiler-RT profile build on RISC-V.
In D97966#2604312, @vsk wrote:

It's great to see this. Will these tests get picked up by an existing RISCV bot?

Mar 4 2021, 11:46 AM · Restricted Project
luismarques requested review of D97966: [compiler-rt][profile][RISCV]: Enable Compiler-RT profile build on RISC-V.
Mar 4 2021, 9:42 AM · Restricted Project

Mar 3 2021

luismarques requested review of D97897: [MSan][RISCV] Add RISCV64 support for MSan.
Mar 3 2021, 5:24 PM · Restricted Project, Restricted Project
luismarques requested review of D97896: [Clang][RISCV][RFC] Add byval parameter attribute?.
Mar 3 2021, 5:24 PM · Restricted Project

Mar 1 2021

luismarques committed rG2b5f3f446f36: [Sanitizer][NFC] Fix typo (authored by luismarques).
[Sanitizer][NFC] Fix typo
Mar 1 2021, 3:47 PM
luismarques added a comment to D91717: [RISCV][compiler-rt] Add support for save-restore.

Probably not. I wasn't sure whether the macros made it more readable.

Mar 1 2021, 8:06 AM · Restricted Project
luismarques added a comment to D91717: [RISCV][compiler-rt] Add support for save-restore.

Now that RV32 and RV64 have separate implementations, is there still a point in keeping the LOAD/STORE/STRIDE macros?

Mar 1 2021, 7:41 AM · Restricted Project

Feb 28 2021

luismarques requested review of D97646: [ASan][RISCV] Fix RISC-V memory mapping.
Feb 28 2021, 4:11 PM · Restricted Project, Restricted Project

Feb 26 2021

luismarques added inline comments to D97234: [Sanitizer][RISCV][AArch64][Android] Adjust allocator tests.
Feb 26 2021, 4:51 PM · Restricted Project

Feb 25 2021

luismarques added a comment to D97274: [RISCV] replace unuseful emergency spill slot test with a mir test.

From some quick testing, it seemed that you could trim this test down a bit.
You're also adding # REQUIRES: asserts but not actually checking for any debug output.
Also, it would be nice to add a comment documenting the logic of this test, unless new CHECKs of the debug output make it more obvious.

Feb 25 2021, 9:12 AM · Restricted Project

Feb 24 2021

luismarques accepted D97231: [RISCV] Use a ComplexPattern for zexti32 to match sexti32..

LGTM.
Thanks @jrtc27 for the sexti32 review suggestions!

Feb 24 2021, 2:31 PM · Restricted Project

Feb 23 2021

luismarques added a comment to D87997: [RISCV][crt] support building without init_array.

This does not look right to me. Newer architectures like aarch64/risc-v do not need to have .ctors/.dtors support. Can you investigate why -DCRT_HAS_INITFINI_ARRAY isn't set in your build instead?

Feb 23 2021, 7:05 AM · Restricted Project
luismarques committed rGebca13c66504: [Sanitizer][NFC] Fix typo (authored by luismarques).
[Sanitizer][NFC] Fix typo
Feb 23 2021, 1:25 AM

Feb 22 2021

luismarques updated the summary of D97234: [Sanitizer][RISCV][AArch64][Android] Adjust allocator tests.
Feb 22 2021, 3:23 PM · Restricted Project
luismarques requested review of D97234: [Sanitizer][RISCV][AArch64][Android] Adjust allocator tests.
Feb 22 2021, 3:19 PM · Restricted Project
luismarques accepted D97130: [RISCV] Have sexti32 also recognize AssertZExt from types smaller than i32..

Makes sense to me.

Feb 22 2021, 2:12 PM · Restricted Project

Feb 21 2021

luismarques added inline comments to D97133: [SelectionDAG][RISCV] Teach ComputeNumSignBits to handle SREM..
Feb 21 2021, 7:06 AM · Restricted Project
luismarques accepted D97133: [SelectionDAG][RISCV] Teach ComputeNumSignBits to handle SREM..

LGTM. Nice!

Feb 21 2021, 4:42 AM · Restricted Project