Page MenuHomePhabricator

[LV] Do not check widening decision for instrs outside of loop.
ClosedPublic

Authored by fhahn on Sun, Aug 2, 3:34 AM.

Details

Summary

No widening decisions will be computed for instructions outside the
loop. Do not try to get a widening decision. The load/store will be just
a scalar load, so treating at as normal should be fine I think.

Fixes PR46950.

Diff Detail

Event Timeline

fhahn created this revision.Sun, Aug 2, 3:34 AM
Herald added a project: Restricted Project. · View Herald TranscriptSun, Aug 2, 3:34 AM
Herald added a subscriber: hiraditya. · View Herald Transcript
fhahn requested review of this revision.Sun, Aug 2, 3:34 AM
fhahn updated this revision to Diff 282438.

Reference correct PR in test name.

fhahn edited the summary of this revision. (Show Details)Sun, Aug 2, 3:36 AM
dmgreen accepted this revision.Sun, Aug 2, 4:02 AM

Oh right. Sorry I saw that bug but didn't put two and two together somehow.

Thanks for the fix. LGTM

This revision is now accepted and ready to land.Sun, Aug 2, 4:02 AM
fhahn added a comment.Mon, Aug 3, 2:27 AM

Oh right. Sorry I saw that bug but didn't put two and two together somehow.

Thanks for the fix. LGTM

Thanks!