Page MenuHomePhabricator

dmgreen (Dave Green)
User

Projects

User does not belong to any projects.

User Details

User Since
May 24 2016, 8:35 AM (242 w, 4 d)

Recent Activity

Today

dmgreen committed rG145472421535: [ARM] Align blocks that are not fallthough targets (authored by dmgreen).
[ARM] Align blocks that are not fallthough targets
Sat, Jan 16, 2:20 PM
dmgreen committed rG2a5b576e3ea4: [ARM] Test for aligned blocks. NFC (authored by dmgreen).
[ARM] Test for aligned blocks. NFC
Sat, Jan 16, 2:20 PM
dmgreen closed D94394: [ARM] Align blocks that are not fallthough targets.
Sat, Jan 16, 2:20 PM · Restricted Project
dmgreen added reviewers for D94604: [CodeGen] Allow parallel uses of a resource: steven.zhang, atrick, evgeny777, andreadb.
Sat, Jan 16, 10:38 AM · Restricted Project
dmgreen committed rG372eb2bbb6fb: [ARM] Add low overhead loops terminators to AnalyzeBranch (authored by dmgreen).
[ARM] Add low overhead loops terminators to AnalyzeBranch
Sat, Jan 16, 10:31 AM
dmgreen committed rGc1ab698dce8d: [ARM] Remove LLC tests from transform/hardware loop tests. (authored by dmgreen).
[ARM] Remove LLC tests from transform/hardware loop tests.
Sat, Jan 16, 10:31 AM
dmgreen closed D94392: [ARM] Add low overhead loops terminators to AnalyzeBranch.
Sat, Jan 16, 10:31 AM · Restricted Project
dmgreen added inline comments to D94778: [AArch64] Further restricts when a dup(*ext) can be rearranged.
Sat, Jan 16, 10:23 AM · Restricted Project
dmgreen added a comment to D94765: [WIP]Expand masked mem intrinsics correctly wrt big-endian.

Thanks for the patch. There is a patch to make MVE consistent with the rest of MVE in D94867. This will need rebasing on top of that, with update tests to make the two consistent again.

Sat, Jan 16, 9:00 AM · Restricted Project
dmgreen requested review of D94867: [ARM] Make a BE predicate bitcast consistent with the rest of llvm.
Sat, Jan 16, 8:57 AM · Restricted Project

Yesterday

dmgreen committed rGf5abf0bd485a: [ARM] Tail predication with constant loop bounds (authored by dmgreen).
[ARM] Tail predication with constant loop bounds
Fri, Jan 15, 10:18 AM
dmgreen closed D94608: [ARM] Tail predication with constant loop bounds.
Fri, Jan 15, 10:18 AM · Restricted Project
dmgreen committed rGa0770f9e4e92: [ARM] Constant tripcount tail predication loop tests. NFC (authored by dmgreen).
[ARM] Constant tripcount tail predication loop tests. NFC
Fri, Jan 15, 10:02 AM
dmgreen accepted D94780: [ARM][Block placement] Check the predecessor exists before processing it.

Thanks. LGTM

Fri, Jan 15, 7:10 AM · Restricted Project
dmgreen accepted D94671: [DAG] visitVECTOR_SHUFFLE - MergeInnerShuffle - improve shuffle(shuffle(x,y),shuffle(x,y)) merging.

LGTM. We sometimes generate a lot of shuffles in an attempt to do lane interleaving and I know the simplification of them isn't always what it could be once all the lowering has happened. I thought more happened through simplifying buildvectors but apparently not. This looks like a good continuation to the existing code.

Fri, Jan 15, 6:09 AM · Restricted Project
dmgreen added a comment to D93476: [LV][ARM] Inloop reduction cost modelling.

Ping

Fri, Jan 15, 5:39 AM · Restricted Project

Wed, Jan 13

dmgreen accepted D94620: [NFC] Disallow unused prefixes under MC/ARM.

Yeah, LGTM

Wed, Jan 13, 11:52 PM · Restricted Project
dmgreen requested review of D94608: [ARM] Tail predication with constant loop bounds.
Wed, Jan 13, 8:43 AM · Restricted Project
dmgreen accepted D91271: [AArch64] Attempt to sink mul operands.

Thanks for the changes. LGTM

Wed, Jan 13, 6:05 AM · Restricted Project
dmgreen committed rGc29ca8551aff: [ARM] Update isVMOVNOriginalMask to handle single input shuffle vectors (authored by dmgreen).
[ARM] Update isVMOVNOriginalMask to handle single input shuffle vectors
Wed, Jan 13, 12:51 AM
dmgreen closed D94189: [ARM] Update isVMOVNOriginalMask to handle single input shuffle vectors.
Wed, Jan 13, 12:51 AM · Restricted Project
dmgreen committed rG3aeb30d1a68a: [ARM] Additional tests for different interleaving patterns. NFC (authored by dmgreen).
[ARM] Additional tests for different interleaving patterns. NFC
Wed, Jan 13, 12:32 AM

Mon, Jan 11

dmgreen updated the diff for D94034: [ARM] Flatten identity shuffles through vqdmulh nodes.

Fix typo.

Mon, Jan 11, 11:52 AM · Restricted Project
dmgreen added inline comments to D91271: [AArch64] Attempt to sink mul operands.
Mon, Jan 11, 6:11 AM · Restricted Project
dmgreen accepted D94398: [ARM] Add uses for locals introduced for debug messages. NFC..

Oh yeah. Sorry. Forgot about that.

Mon, Jan 11, 3:41 AM · Restricted Project
dmgreen added inline comments to D93629: [LV] Don't sink into replication regions.
Mon, Jan 11, 2:25 AM · Restricted Project
dmgreen committed rG8165a0342033: [ARM] Add debug messages for the load store optimizer. NFC (authored by dmgreen).
[ARM] Add debug messages for the load store optimizer. NFC
Mon, Jan 11, 1:25 AM
dmgreen requested review of D94394: [ARM] Align blocks that are not fallthough targets.
Mon, Jan 11, 1:23 AM · Restricted Project
dmgreen committed rGdcefcd51e017: [ARM] Update trunc costs (authored by dmgreen).
[ARM] Update trunc costs
Mon, Jan 11, 1:00 AM
dmgreen closed D94260: [ARM] Update trunc costs.
Mon, Jan 11, 12:59 AM · Restricted Project
dmgreen requested review of D94392: [ARM] Add low overhead loops terminators to AnalyzeBranch.
Mon, Jan 11, 12:58 AM · Restricted Project
dmgreen committed rG0c8b748f3217: [ARM] Additional trunc cost tests. NFC (authored by dmgreen).
[ARM] Additional trunc cost tests. NFC
Mon, Jan 11, 12:35 AM

Fri, Jan 8

dmgreen committed rG024af42c6010: [ARM] Custom lower i1 vector truncates (authored by dmgreen).
[ARM] Custom lower i1 vector truncates
Fri, Jan 8, 10:21 AM
dmgreen closed D94226: [ARM] Custom lower i1 vector truncates.
Fri, Jan 8, 10:21 AM · Restricted Project
dmgreen updated the diff for D93476: [LV][ARM] Inloop reduction cost modelling.

Rebase and ping. I also adjusted some code and better dealt with loop invariant operands.

Fri, Jan 8, 9:10 AM · Restricted Project
dmgreen added a comment to D94226: [ARM] Custom lower i1 vector truncates.

Thanks. I made a typo in the summary, it should have said "do not seem to be correct", not "do seem...".

Fri, Jan 8, 8:15 AM · Restricted Project
dmgreen committed rGe185b1dd7b34: [ConstProp] Constant propagation for get.active.lane.mask instrinsics (authored by dmgreen).
[ConstProp] Constant propagation for get.active.lane.mask instrinsics
Fri, Jan 8, 8:10 AM
dmgreen closed D94103: [ConstProp] Constant propagation for get.active.lane.mask instrinsics.
Fri, Jan 8, 8:10 AM · Restricted Project
dmgreen committed rGa36a2864c0d4: [ARM][LV] Additional loop invariant reduction test. NFC (authored by dmgreen).
[ARM][LV] Additional loop invariant reduction test. NFC
Fri, Jan 8, 7:15 AM
dmgreen committed rG1ae762469fd1: [ARM] Update and regenerate test checks. NFC (authored by dmgreen).
[ARM] Update and regenerate test checks. NFC
Fri, Jan 8, 6:54 AM
dmgreen committed rG72fb5ba07901: [LV] Don't sink into replication regions (authored by dmgreen).
[LV] Don't sink into replication regions
Fri, Jan 8, 1:50 AM
dmgreen closed D93629: [LV] Don't sink into replication regions.
Fri, Jan 8, 1:50 AM · Restricted Project
dmgreen added a comment to D93629: [LV] Don't sink into replication regions.

Thanks Florian.

Fri, Jan 8, 1:44 AM · Restricted Project
dmgreen added a comment to D90094: [BasicAA] Handle recursive queries more efficiently (NFCI).

Hello. I tried running our downstream benchmarks with this patch and it did not appear to have any effect, either in performance or codesize. (That doesn't mean that nothing is effected, but it's at least a good sign).

Fri, Jan 8, 1:42 AM · Restricted Project

Thu, Jan 7

dmgreen accepted D94234: [AArch64] Fix crash caused by invalid vector element type.

LGTM thanks, but please try and simplify the test case if you can.

Thu, Jan 7, 2:55 PM · Restricted Project
dmgreen requested review of D94260: [ARM] Update trunc costs.
Thu, Jan 7, 1:28 PM · Restricted Project
dmgreen requested review of D94226: [ARM] Custom lower i1 vector truncates.
Thu, Jan 7, 4:33 AM · Restricted Project
dmgreen added inline comments to D91271: [AArch64] Attempt to sink mul operands.
Thu, Jan 7, 3:06 AM · Restricted Project

Wed, Jan 6

dmgreen requested review of D94189: [ARM] Update isVMOVNOriginalMask to handle single input shuffle vectors.
Wed, Jan 6, 12:50 PM · Restricted Project
dmgreen accepted D91255: [AArch64] Rearrange mul(dup(sext/zext)) to mul(sext/zext(dup)).

Thanks. LGTM with a couple of suggestions.

Wed, Jan 6, 5:44 AM · Restricted Project
dmgreen added inline comments to D93629: [LV] Don't sink into replication regions.
Wed, Jan 6, 3:47 AM · Restricted Project
dmgreen updated the diff for D93629: [LV] Don't sink into replication regions.

Added a unit test, that caught that the Parent was not set correctly.

Wed, Jan 6, 3:47 AM · Restricted Project
dmgreen committed rG63dce70b794e: [ARM] Handle any extend whilst lowering addw/addl/subw/subl (authored by dmgreen).
[ARM] Handle any extend whilst lowering addw/addl/subw/subl
Wed, Jan 6, 3:27 AM
dmgreen closed D93835: [ARM] Handle any extend whilst lowering addw/addl/subw/subl.
Wed, Jan 6, 3:27 AM · Restricted Project
dmgreen committed rGddb82fc76ceb: [ARM] Handle any extend whilst lowering mull (authored by dmgreen).
[ARM] Handle any extend whilst lowering mull
Wed, Jan 6, 2:51 AM
dmgreen closed D93834: [ARM] Handle any extend whilst lowering mull.
Wed, Jan 6, 2:51 AM · Restricted Project
dmgreen committed rGa9b6440eddde: [AArch64] Handle any extend whilst lowering addw/addl/subw/subl (authored by dmgreen).
[AArch64] Handle any extend whilst lowering addw/addl/subw/subl
Wed, Jan 6, 2:35 AM
dmgreen closed D93833: [AArch64] Handle any extend whilst lowering addw/addl/subw/subl.
Wed, Jan 6, 2:35 AM · Restricted Project
dmgreen committed rG78d8a821e23e: [AArch64] Handle any extend whilst lowering mull (authored by dmgreen).
[AArch64] Handle any extend whilst lowering mull
Wed, Jan 6, 2:09 AM
dmgreen closed D93832: [AArch64] Handle any extend whilst lowering mull.
Wed, Jan 6, 2:09 AM · Restricted Project
dmgreen added a comment to D93833: [AArch64] Handle any extend whilst lowering addw/addl/subw/subl.

Thanks

Wed, Jan 6, 2:08 AM · Restricted Project
dmgreen added a comment to D93835: [ARM] Handle any extend whilst lowering addw/addl/subw/subl.

Thanks.

Wed, Jan 6, 2:08 AM · Restricted Project
dmgreen accepted D93791: [AArch64] Add Fujitsu A64FX scheduling model.

Thanks. I don't know any of the details of this specific core, but this LGTM in terms of a schedule.

Wed, Jan 6, 12:59 AM · Restricted Project

Tue, Jan 5

dmgreen requested review of D94103: [ConstProp] Constant propagation for get.active.lane.mask instrinsics.
Tue, Jan 5, 10:51 AM · Restricted Project
dmgreen committed rG0c59a4da59a4: [ARM][AArch64] Some extra test to show anyextend lowering. NFC (authored by dmgreen).
[ARM][AArch64] Some extra test to show anyextend lowering. NFC
Tue, Jan 5, 9:35 AM
dmgreen added inline comments to D91255: [AArch64] Rearrange mul(dup(sext/zext)) to mul(sext/zext(dup)).
Tue, Jan 5, 8:34 AM · Restricted Project

Mon, Jan 4

dmgreen requested review of D94034: [ARM] Flatten identity shuffles through vqdmulh nodes.
Mon, Jan 4, 2:51 PM · Restricted Project
dmgreen accepted D59259: [AArch64] Use faddp to implement fadd reductions..

Thanks. LGTM

Mon, Jan 4, 10:24 AM · Restricted Project
dmgreen added inline comments to D59259: [AArch64] Use faddp to implement fadd reductions..
Mon, Jan 4, 7:05 AM · Restricted Project
dmgreen committed rG901cc9b6f30f: [ARM] Extend lowering for i64 reductions (authored by dmgreen).
[ARM] Extend lowering for i64 reductions
Mon, Jan 4, 4:45 AM
dmgreen closed D93622: [ARM] Extend lowering for i64 reductions.
Mon, Jan 4, 4:45 AM · Restricted Project
dmgreen added inline comments to D93622: [ARM] Extend lowering for i64 reductions.
Mon, Jan 4, 3:51 AM · Restricted Project
dmgreen updated the diff for D93622: [ARM] Extend lowering for i64 reductions.

Updated to use is128BitVector

Mon, Jan 4, 3:51 AM · Restricted Project
dmgreen added a comment to D92296: [AARCH64] Improve accumulator forwarding for Cortex-A57 model.

OK that seems to have done better. Thanks for the report. Let us know if anything else comes up.

Mon, Jan 4, 3:48 AM · Restricted Project
dmgreen committed rG6c89f6fae491: [AArch64] Attempt to fix Mac tests with a more specific triple. NFC (authored by dmgreen).
[AArch64] Attempt to fix Mac tests with a more specific triple. NFC
Mon, Jan 4, 3:29 AM
dmgreen added a comment to D92296: [AARCH64] Improve accumulator forwarding for Cortex-A57 model.

Oh strange. Let me try with a more specific triple..

Mon, Jan 4, 3:28 AM · Restricted Project
dmgreen committed rG685c8b537af3: [AARCH64] Improve accumulator forwarding for Cortex-A57 model (authored by mnadeem).
[AARCH64] Improve accumulator forwarding for Cortex-A57 model
Mon, Jan 4, 2:59 AM
dmgreen closed D92296: [AARCH64] Improve accumulator forwarding for Cortex-A57 model.
Mon, Jan 4, 2:58 AM · Restricted Project
dmgreen added a comment to D92296: [AARCH64] Improve accumulator forwarding for Cortex-A57 model.

Can do..

Mon, Jan 4, 2:58 AM · Restricted Project

Wed, Dec 30

dmgreen accepted D92296: [AARCH64] Improve accumulator forwarding for Cortex-A57 model.

I've not ran any benchmarking, and this is touching some fairly commonly used parts of a commonly used schedule (and scheduling can be weird at times). If we do run into problems we can address them as we need, but it looks like a nice improvement and the numbers you have look good. Thanks for the patch.

Wed, Dec 30, 1:15 PM · Restricted Project
dmgreen added a comment to D93622: [ARM] Extend lowering for i64 reductions.

Ping.

Wed, Dec 30, 5:20 AM · Restricted Project
dmgreen updated the diff for D93476: [LV][ARM] Inloop reduction cost modelling.

Rebase.

Wed, Dec 30, 5:19 AM · Restricted Project
dmgreen updated the diff for D93629: [LV] Don't sink into replication regions.

Add a VPRecipeBase::moveBefore and use it and getFirstNonPhi.
Added an extra test with predicated stores and removed some undefs.

Wed, Dec 30, 3:31 AM · Restricted Project
dmgreen added a comment to D92296: [AARCH64] Improve accumulator forwarding for Cortex-A57 model.
  1. Removed forward from ASMID multiplies (mul, pmul, sqdmulh, smull, umull).
Wed, Dec 30, 2:20 AM · Restricted Project

Tue, Dec 29

dmgreen added a comment to D93835: [ARM] Handle any extend whilst lowering addw/addl/subw/subl.

Hello. Yeah those are related. I was using an AND here to get the same effect, but this is more likely to come up from the truncs in that patch in practice. D93834 is the mull part of handling any_extends. (It unfortunately doesn't entirely fix both the cases there because we end up turning one of the any_extends into a zext load, and are left with a smull of a sext load and zext load).

Tue, Dec 29, 4:17 AM · Restricted Project

Sun, Dec 27

dmgreen committed rG0c6e19b70581: [AArch64] Add some anyextend testing. NFC (authored by dmgreen).
[AArch64] Add some anyextend testing. NFC
Sun, Dec 27, 5:36 AM
dmgreen requested review of D93835: [ARM] Handle any extend whilst lowering addw/addl/subw/subl.
Sun, Dec 27, 5:34 AM · Restricted Project
dmgreen requested review of D93834: [ARM] Handle any extend whilst lowering mull.
Sun, Dec 27, 5:29 AM · Restricted Project
dmgreen requested review of D93833: [AArch64] Handle any extend whilst lowering addw/addl/subw/subl.
Sun, Dec 27, 5:24 AM · Restricted Project
dmgreen requested review of D93832: [AArch64] Handle any extend whilst lowering mull.
Sun, Dec 27, 5:19 AM · Restricted Project
dmgreen committed rG7a3e11fe96dd: [ARM] Add some NEON anyextend testing. NFC (authored by dmgreen).
[ARM] Add some NEON anyextend testing. NFC
Sun, Dec 27, 5:19 AM
dmgreen accepted D93825: [AArch64] Fix legalization of i128 ctpop without neon.

LGTM. Thanks.

Sun, Dec 27, 12:38 AM · Restricted Project

Thu, Dec 24

dmgreen accepted D93022: [ARM][AArch64] Add Cortex-A78C Support for Clang and LLVM.

Thanks. I think this LGTM now.

Thu, Dec 24, 8:37 AM · Restricted Project, Restricted Project
dmgreen added inline comments to D93022: [ARM][AArch64] Add Cortex-A78C Support for Clang and LLVM.
Thu, Dec 24, 7:38 AM · Restricted Project, Restricted Project
dmgreen added inline comments to D93022: [ARM][AArch64] Add Cortex-A78C Support for Clang and LLVM.
Thu, Dec 24, 3:05 AM · Restricted Project, Restricted Project
dmgreen added inline comments to D93791: [AArch64] Add Fujitsu A64FX scheduling model.
Thu, Dec 24, 2:08 AM · Restricted Project

Wed, Dec 23

dmgreen edited reviewers for D93762: SCCP: Refactor SCCPSolver, added: efriedma, fhahn, nikic; removed: eli.friedman.
Wed, Dec 23, 9:44 AM · Restricted Project
dmgreen committed rGa9f14cdc6203: [ARM] Add bank conflict hazarding (authored by dpenry).
[ARM] Add bank conflict hazarding
Wed, Dec 23, 6:01 AM
dmgreen closed D93054: [ARM] Add bank conflict hazarding.
Wed, Dec 23, 6:01 AM · Restricted Project

Mon, Dec 21

dmgreen requested review of D93629: [LV] Don't sink into replication regions.
Mon, Dec 21, 5:11 AM · Restricted Project