Page MenuHomePhabricator

[Flang] Checks for constraint C7110-C7115.
ClosedPublic

Authored by sameeranjoshi on Jul 31 2020, 3:14 AM.

Details

Summary

Added more tests.

	 Annotate sources and tests.
	 Improve error message.

Diff Detail

Event Timeline

sameeranjoshi created this revision.Jul 31 2020, 3:14 AM
Herald added a project: Restricted Project. · View Herald Transcript
sameeranjoshi requested review of this revision.Jul 31 2020, 3:14 AM
DavidTruby requested changes to this revision.Jul 31 2020, 6:04 AM
DavidTruby added inline comments.
flang/lib/Semantics/expression.cpp
1205

I think we usually use braces for initialization in flang, e.g.:
bool messageDisplayedOnce {true};

1271

Are these extra parentheses needed here?

This revision now requires changes to proceed.Jul 31 2020, 6:04 AM

In addition to my comment, I agree with all of @DavidTruby's comments.

Thanks for working on this! I've verified that everything builds, tests and (aside from the comments in this review) looks good.

flang/lib/Semantics/expression.cpp
1268–1271

This string can fit onto two lines.

Upstream comments addressed.

sameeranjoshi marked 3 inline comments as done.Jul 31 2020, 10:13 AM
PeteSteinfeld accepted this revision.Jul 31 2020, 10:31 AM

All builds, tests, and looks good.

Can you please move the associated cards in https://github.com/orgs/flang-compiler/projects/7 to the "Done" column after you've merged these changes?

@PeteSteinfeld I see that I have no access to move it.

This revision was not accepted when it landed; it landed in state Needs Review.Jul 31 2020, 10:58 AM
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.

I wondered about that. I'll take care of it.