Page MenuHomePhabricator

DavidTruby (David Truby)
User

Projects

User does not belong to any projects.

User Details

User Since
Oct 3 2018, 7:41 AM (121 w, 14 h)

Recent Activity

Wed, Jan 20

DavidTruby resigned from D89368: [flang][windows] Run regression tests under Windows. NFCI..
Wed, Jan 20, 12:27 PM · Restricted Project, Restricted Project
DavidTruby resigned from D94707: [Flang] Fix compilation on MinGW-w64.
Wed, Jan 20, 12:27 PM · Restricted Project, Restricted Project

Fri, Jan 15

DavidTruby resigned from D82159: Add a cmake warning when someone tries to configure clang-tools-extra without clang.
Fri, Jan 15, 6:14 AM · Restricted Project
DavidTruby resigned from D83397: [flang] Replace uses of _Complex with std::complex.
Fri, Jan 15, 6:13 AM · Restricted Project, Restricted Project
DavidTruby resigned from D92732: [Flang][OpenMP 4.5] Add semantic check for OpenMP Do Loop Constructs.
Fri, Jan 15, 6:13 AM · Restricted Project, Restricted Project, Restricted Project
DavidTruby resigned from D87056: [POC] SVE/SVE2 implementation (LLVM 9).
Fri, Jan 15, 6:12 AM · Restricted Project, Restricted Project
DavidTruby added a comment to D87672: [doc] Fix typos.

Did this change ever get committed?

Fri, Jan 15, 6:12 AM · Restricted Project

Tue, Jan 12

DavidTruby committed rGe5f51fdd650c: [clang][aarch64] Precondition isHomogeneousAggregate on isCXX14Aggregate (authored by DavidTruby).
[clang][aarch64] Precondition isHomogeneousAggregate on isCXX14Aggregate
Tue, Jan 12, 11:44 AM
DavidTruby closed D92751: [clang][aarch64] Precondition isHomogeneousAggregate on isCXX14Aggregate.
Tue, Jan 12, 11:44 AM · Restricted Project, Restricted Project

Mon, Jan 11

DavidTruby updated the diff for D92751: [clang][aarch64] Precondition isHomogeneousAggregate on isCXX14Aggregate.

Fix tests to use check-label correctly and add proper precondition on aarch64

Mon, Jan 11, 6:18 AM · Restricted Project, Restricted Project

Wed, Jan 6

DavidTruby added inline comments to D92751: [clang][aarch64] Precondition isHomogeneousAggregate on isCXX14Aggregate.
Wed, Jan 6, 8:53 PM · Restricted Project, Restricted Project
DavidTruby updated the diff for D92751: [clang][aarch64] Precondition isHomogeneousAggregate on isCXX14Aggregate.

Refactor based on review

Wed, Jan 6, 8:51 PM · Restricted Project, Restricted Project

Mon, Jan 4

DavidTruby updated the diff for D92751: [clang][aarch64] Precondition isHomogeneousAggregate on isCXX14Aggregate.

Switch from CHECK to CHECK-LABEL in tests.

Mon, Jan 4, 4:23 AM · Restricted Project, Restricted Project
DavidTruby added inline comments to D92751: [clang][aarch64] Precondition isHomogeneousAggregate on isCXX14Aggregate.
Mon, Jan 4, 4:16 AM · Restricted Project, Restricted Project
DavidTruby added inline comments to D92751: [clang][aarch64] Precondition isHomogeneousAggregate on isCXX14Aggregate.
Mon, Jan 4, 4:15 AM · Restricted Project, Restricted Project
DavidTruby updated the diff for D92751: [clang][aarch64] Precondition isHomogeneousAggregate on isCXX14Aggregate.

Refactor based on review comments

Mon, Jan 4, 4:13 AM · Restricted Project, Restricted Project

Dec 15 2020

DavidTruby updated the diff for D92751: [clang][aarch64] Precondition isHomogeneousAggregate on isCXX14Aggregate.

Add additional callee-side tests

Dec 15 2020, 9:24 AM · Restricted Project, Restricted Project
DavidTruby added reviewers for D92751: [clang][aarch64] Precondition isHomogeneousAggregate on isCXX14Aggregate: rnk, asl.
Dec 15 2020, 7:50 AM · Restricted Project, Restricted Project
DavidTruby retitled D92751: [clang][aarch64] Precondition isHomogeneousAggregate on isCXX14Aggregate from Precondition isHomogeneousAggregate on isCXX14Aggregate to [clang][aarch64] Precondition isHomogeneousAggregate on isCXX14Aggregate.
Dec 15 2020, 7:49 AM · Restricted Project, Restricted Project
DavidTruby updated the diff for D92751: [clang][aarch64] Precondition isHomogeneousAggregate on isCXX14Aggregate.

Added extra tests for additional conditions and IR -> assembly tests.

Dec 15 2020, 7:45 AM · Restricted Project, Restricted Project

Dec 7 2020

DavidTruby added reviewers for D92751: [clang][aarch64] Precondition isHomogeneousAggregate on isCXX14Aggregate: peterwaller-arm, richard.townsend.arm.
Dec 7 2020, 3:17 AM · Restricted Project, Restricted Project
DavidTruby requested review of D92751: [clang][aarch64] Precondition isHomogeneousAggregate on isCXX14Aggregate.
Dec 7 2020, 3:17 AM · Restricted Project, Restricted Project

Oct 30 2020

DavidTruby closed D90158: [Aarch64] Fix assumption that Windows implies x86.

Committed as rG81b96bb6f1caee90ad64c9c7c80b55c163b1f6a8

Oct 30 2020, 5:13 AM · Restricted Project
DavidTruby committed rG81b96bb6f1ca: [Aarch64] Fix assumption that Windows implies x86 (authored by DavidTruby).
[Aarch64] Fix assumption that Windows implies x86
Oct 30 2020, 5:12 AM

Oct 26 2020

DavidTruby added a reviewer for D90158: [Aarch64] Fix assumption that Windows implies x86: arm-chrjan01.
Oct 26 2020, 12:13 PM · Restricted Project
DavidTruby accepted D90146: [SVE] Fix TypeSize warning in llvm::getGEPInductionOperand.

LGTM!

Oct 26 2020, 8:04 AM · Restricted Project
DavidTruby requested review of D90158: [Aarch64] Fix assumption that Windows implies x86.
Oct 26 2020, 7:59 AM · Restricted Project

Oct 14 2020

DavidTruby accepted D89403: [flang] Fix CMake bug in the definition of flang-new.

LGTM

Oct 14 2020, 10:16 AM · Restricted Project

Sep 30 2020

DavidTruby added a comment to D87073: [flang]Fix for PR47339.

Ah ok, can we close this review then? Thanks!

Sep 30 2020, 6:07 AM · Restricted Project
DavidTruby resigned from D84064: [flang][openacc] OpenACC module signature.
Sep 30 2020, 5:41 AM · Restricted Project, Restricted Project
DavidTruby added a comment to D87073: [flang]Fix for PR47339.

Is something blocking this change being committed?

Sep 30 2020, 5:40 AM · Restricted Project
DavidTruby added a comment to D87672: [doc] Fix typos.

@YangZhihui if you don't have commit access I can commit this for you. Could you let me know the name and email address you'd like it committed under please? Thanks!

Sep 30 2020, 5:37 AM · Restricted Project
DavidTruby resigned from D82176: [flang][OpenMP] Added parser support for Iterators (OpenMP 5.0) and updated depend clause.
Sep 30 2020, 5:36 AM · Restricted Project, Restricted Project
DavidTruby resigned from D87499: [DebugInfo] Flang should not emit DW_AT_main_subprogram for DWARF version lower than 4.
Sep 30 2020, 5:35 AM · Restricted Project, debug-info
DavidTruby resigned from D87906: [Flang][OpenACC] Fix for branching out issue in OpenACC parallel construct..
Sep 30 2020, 5:35 AM · Restricted Project, Restricted Project
DavidTruby accepted D88109: [flang][msvc] Avoid ReferenceVariantBase ctor ambiguity. NFC..

LGTM. Not sure why msvc thinks these are ambiguous

Sep 30 2020, 5:35 AM · Restricted Project, Restricted Project
DavidTruby resigned from D88253: [flang][openacc] Update loop construct lowering.
Sep 30 2020, 5:34 AM · Restricted Project, Restricted Project
DavidTruby resigned from D88313: [flang] Failed call to CHECK() for call to ASSOCIATED(NULL()).
Sep 30 2020, 5:34 AM · Restricted Project, Restricted Project
DavidTruby accepted D88556: [Flang][OpenMP] Fix issue in only a single nowait clause can appear on a sections directive..

LGTM

Sep 30 2020, 5:34 AM · Restricted Project, Restricted Project
DavidTruby retitled D86071: [MLIR][OpenMP] Add omp.wsloop operation from [MLIR][OpenMP] Add omp.do operation to [MLIR][OpenMP] Add omp.wsloop operation.
Sep 30 2020, 5:33 AM · Restricted Project, Restricted Project
DavidTruby updated the diff for D86071: [MLIR][OpenMP] Add omp.wsloop operation.

Add indexes for loop-style implementation, and rename operation to omp.wsloop

Sep 30 2020, 5:33 AM · Restricted Project, Restricted Project
DavidTruby resigned from D88511: [flang][msvc] long double is not different from double..
Sep 30 2020, 4:14 AM · Restricted Project, Restricted Project

Sep 24 2020

DavidTruby added inline comments to D88219: [flang][driver] Remove unnecessary includes in the unittest.
Sep 24 2020, 5:19 AM · Restricted Project
DavidTruby committed rG956a84da0616: [flang] [OpenMP 4.5] Adding lit test cases for OpenMP Constructs. (authored by praveen).
[flang] [OpenMP 4.5] Adding lit test cases for OpenMP Constructs.
Sep 24 2020, 5:09 AM
DavidTruby closed D87908: [flang] [OpenMP 4.5] Adding lit test cases for OpenMP Constructs..
Sep 24 2020, 5:09 AM · Restricted Project, Restricted Project, Restricted Project
DavidTruby accepted D88219: [flang][driver] Remove unnecessary includes in the unittest.

LGTM, perhaps put NFC in the commit message?

Sep 24 2020, 5:00 AM · Restricted Project

Sep 23 2020

DavidTruby added a comment to D87908: [flang] [OpenMP 4.5] Adding lit test cases for OpenMP Constructs..

@kiranktp @DavidTruby Thanks for the review.

I do not have commit access . Can someone commit the changes on my behalf ?

Sep 23 2020, 7:07 AM · Restricted Project, Restricted Project, Restricted Project

Sep 22 2020

DavidTruby abandoned D85508: [flang] Add rudimentary empty function lowering to tco.

As discussed on flang-dev I am closing this to not block anyone else's progress on upstreaming.

Sep 22 2020, 9:53 AM · Restricted Project
DavidTruby abandoned D85509: [flang] Add rudimentary bbc tool infrastructure..

As discussed on flang-dev I am closing this to not block anyone else's progress on upstreaming.

Sep 22 2020, 9:53 AM · Restricted Project
DavidTruby abandoned D85510: [flang] Upstream lowering of empty functions and programs..

As discussed on flang-dev I am closing this to not block anyone else's progress on upstreaming.

Sep 22 2020, 9:53 AM · Restricted Project
DavidTruby added inline comments to D87684: [mlir]Add Allocate Clause to OMP Parallel Operation Definition.
Sep 22 2020, 6:47 AM · Restricted Project
DavidTruby committed rGbf202b8ce77c: [NFC][mlir] Remove llvm:: prefix from SmallVector in parallel pretty printer. (authored by DavidTruby).
[NFC][mlir] Remove llvm:: prefix from SmallVector in parallel pretty printer.
Sep 22 2020, 6:46 AM
DavidTruby closed D88025: [NFC][mlir] Remove llvm:: prefix from SmallVector in parallel pretty printer..
Sep 22 2020, 6:46 AM · Restricted Project
DavidTruby accepted D88001: [flang][msvc] Add explicit function template argument to applyLamda. NFC..

LGTM

Sep 22 2020, 6:11 AM · Restricted Project
DavidTruby accepted D88052: [flang][msvc] Explicitly reference "this" inside closure. NFC..

LGTM

Sep 22 2020, 6:11 AM · Restricted Project, Restricted Project
DavidTruby accepted D87961: [flang][msvc] Add explicit function template argument to applyFunction. NFC..

LGTM. Odd that msvc needs this clarification though.

Sep 22 2020, 6:10 AM · Restricted Project, Restricted Project
DavidTruby accepted D87908: [flang] [OpenMP 4.5] Adding lit test cases for OpenMP Constructs..

LGTM!
@kiranktp I believe most of the semantic checks are still only targeting OpenMP 4.5, at least the ones that I implemented are as that was the target spec last time I checked. If this hasn't significantly changed then upgrading the tests to OpenMP 5 will cause failures.

Sep 22 2020, 6:07 AM · Restricted Project, Restricted Project, Restricted Project

Sep 21 2020

DavidTruby added a comment to D88025: [NFC][mlir] Remove llvm:: prefix from SmallVector in parallel pretty printer..

As requested on https://reviews.llvm.org/D87684

Sep 21 2020, 8:23 AM · Restricted Project
DavidTruby requested review of D88025: [NFC][mlir] Remove llvm:: prefix from SmallVector in parallel pretty printer..
Sep 21 2020, 8:23 AM · Restricted Project

Sep 18 2020

DavidTruby added a comment to D86071: [MLIR][OpenMP] Add omp.wsloop operation.

I have submitted an RFC on the openmp do loop design here: https://llvm.discourse.group/t/openmp-worksharing-loop-rfc/1815

Sep 18 2020, 7:15 AM · Restricted Project, Restricted Project

Sep 16 2020

DavidTruby accepted D87783: [Flang] Fixed installation permission of the "binary" flang.

LGTM

Sep 16 2020, 2:55 PM · Restricted Project

Sep 15 2020

DavidTruby added inline comments to D87684: [mlir]Add Allocate Clause to OMP Parallel Operation Definition.
Sep 15 2020, 8:10 AM · Restricted Project
DavidTruby added inline comments to D87684: [mlir]Add Allocate Clause to OMP Parallel Operation Definition.
Sep 15 2020, 8:00 AM · Restricted Project

Sep 8 2020

DavidTruby accepted D87243: [cmake] Centralize LLVM_ENABLE_WARNINGS option.

LGTM and seems to work from the flang side. Wait for another review with more experience though please :)

Sep 8 2020, 6:48 AM · Restricted Project, Restricted Project, Restricted Project
DavidTruby updated the diff for D86071: [MLIR][OpenMP] Add omp.wsloop operation.

Capitalise all schedule clause values.

Sep 8 2020, 6:47 AM · Restricted Project, Restricted Project
DavidTruby added a comment to D86071: [MLIR][OpenMP] Add omp.wsloop operation.

@DavidTruby, In general, I was asking whether all clause enumeration values can begin with a Capital letter? Just the reserved keywords would look odd right?

Sep 8 2020, 4:52 AM · Restricted Project, Restricted Project

Sep 7 2020

DavidTruby accepted D87125: Update recipe for flang-aarch64 slaves.

LGTM

Sep 7 2020, 6:38 AM
DavidTruby updated the diff for D86071: [MLIR][OpenMP] Add omp.wsloop operation.

Address review comments.

Sep 7 2020, 6:29 AM · Restricted Project, Restricted Project
DavidTruby added inline comments to D86071: [MLIR][OpenMP] Add omp.wsloop operation.
Sep 7 2020, 6:09 AM · Restricted Project, Restricted Project
DavidTruby reopened D86779: [MLIR][Shape] Merge `shape` to `std`/`scf` lowerings..

I've reverted this commit for now since it broke the flang and mlir buildbots:
http://lab.llvm.org:8011/builders/flang-aarch64-ubuntu
http://lab.llvm.org:8011/builders/mlir-nvidia
http://lab.llvm.org:8011/builders/mlir-windows

Sep 7 2020, 5:38 AM · Restricted Project
DavidTruby added a reverting change for D86779: [MLIR][Shape] Merge `shape` to `std`/`scf` lowerings.: rG973800dc7cbe: Revert "[MLIR][Shape] Merge `shape` to `std`/`scf` lowerings.".
Sep 7 2020, 5:38 AM · Restricted Project
DavidTruby added a reverting change for rG15acdd75439b: [MLIR][Shape] Merge `shape` to `std`/`scf` lowerings.: rG973800dc7cbe: Revert "[MLIR][Shape] Merge `shape` to `std`/`scf` lowerings.".
Sep 7 2020, 5:38 AM
DavidTruby committed rG973800dc7cbe: Revert "[MLIR][Shape] Merge `shape` to `std`/`scf` lowerings." (authored by DavidTruby).
Revert "[MLIR][Shape] Merge `shape` to `std`/`scf` lowerings."
Sep 7 2020, 5:38 AM
DavidTruby added a comment to D86779: [MLIR][Shape] Merge `shape` to `std`/`scf` lowerings..

This commit appears to remove the ShapeToSCF folder, but not the add_directory(ShapeToSCF) in the parent folder, meaning the CMake configure step can't complete without errors.

Sep 7 2020, 5:22 AM · Restricted Project

Sep 1 2020

DavidTruby resigned from D86172: [flang] Fix assert on constant folding of extended types.
Sep 1 2020, 3:39 AM · Restricted Project, Restricted Project
DavidTruby added a comment to D86410: [flang][msvc] Avoid ambiguous overload from base class. NFC..

If this is now fixed in another way, can this review be closed?

Sep 1 2020, 3:39 AM · Restricted Project, Restricted Project
DavidTruby added a comment to D86423: [flang][openacc] Lower loop with collapse clause.

Is it possible to add lit tests based on the generated mlir?

Sep 1 2020, 3:37 AM · Restricted Project

Aug 18 2020

DavidTruby added a reviewer for D86071: [MLIR][OpenMP] Add omp.wsloop operation: clementval.
Aug 18 2020, 6:33 AM · Restricted Project, Restricted Project
DavidTruby resigned from D86121: [mlir] Remove the use of "kinds" from Attributes and Types.
Aug 18 2020, 6:18 AM · Restricted Project
DavidTruby accepted D86132: [clang][driver]Add quotation mark in test/fortran.f95 to avoid false positive.

LGTM

Aug 18 2020, 6:16 AM · Restricted Project
DavidTruby requested changes to D86132: [clang][driver]Add quotation mark in test/fortran.f95 to avoid false positive.

On my clang line, when compiling a C file, this appears as "-cc1" not "cc1". I don't see a cc1as so I can't check that one but I assume it will be the same.

Aug 18 2020, 4:10 AM · Restricted Project

Aug 17 2020

DavidTruby committed rG3b338e53e956: [flang] Add preprocessor test for defines passed on the command line (authored by DavidTruby).
[flang] Add preprocessor test for defines passed on the command line
Aug 17 2020, 6:36 AM
DavidTruby closed D85967: [flang] Add preprocessor test for defines passed on the command line.
Aug 17 2020, 6:36 AM · Restricted Project
DavidTruby added a reviewer for D86071: [MLIR][OpenMP] Add omp.wsloop operation: ftynse.
Aug 17 2020, 6:29 AM · Restricted Project, Restricted Project
DavidTruby added reviewers for D86071: [MLIR][OpenMP] Add omp.wsloop operation: kiranchandramohan, mehdi_amini.
Aug 17 2020, 6:28 AM · Restricted Project, Restricted Project
DavidTruby requested review of D86071: [MLIR][OpenMP] Add omp.wsloop operation.
Aug 17 2020, 6:25 AM · Restricted Project, Restricted Project

Aug 14 2020

DavidTruby added a comment to D85937: [flang][msvc] Split class declaration and constexpr variable definition. NFC..

You might have to use conditional preprocessing to make this workaround specific to MSVC.

The workaround is valid C++ and works fine with every compiler. So why add a #if maze?

Aug 14 2020, 2:35 PM · Restricted Project, Restricted Project
DavidTruby accepted D85646: [flang][msvc] Disambiguate injected class name..

Interesting that the compilers don't use the same lookup rule here. I wonder which is correct (my gut feeling is actually that MSVC is).

Aug 14 2020, 5:49 AM · Restricted Project, Restricted Project
DavidTruby resigned from D85622: Separate the Registration from Loading dialects in the Context.
Aug 14 2020, 5:46 AM · Restricted Project
DavidTruby abandoned D84022: [flang] Fix multi-config generator builds..

Fixed by D85078

Aug 14 2020, 5:46 AM · Restricted Project
DavidTruby accepted D85884: [Flang] Move markdown files(.MD) from documentation/ to docs/.

LGTM

Aug 14 2020, 5:45 AM · Restricted Project
DavidTruby accepted D85937: [flang][msvc] Split class declaration and constexpr variable definition. NFC..

As an aside would it be worth throwing a bug report at MSVC? I think the existing code is conformant so they might like to know about the bug.

Aug 14 2020, 5:44 AM · Restricted Project, Restricted Project
DavidTruby requested review of D85967: [flang] Add preprocessor test for defines passed on the command line.
Aug 14 2020, 5:26 AM · Restricted Project

Aug 13 2020

DavidTruby added a comment to D85862: [flang] Ensure Preprocessor::Define() saves macro names correctly.

LGTM! It would be great to have test so this doesn't regress

Aug 13 2020, 3:31 AM · Restricted Project, Restricted Project

Aug 12 2020

DavidTruby added a comment to D84334: [flang] Version information in flang/f18.

@DavidTruby so, how about replacing:

set(include ${FLANG_BINARY_DIR}/include/flang)

set(include ${FLANG_BINARY_DIR}/include/flang)
set(include ${CMAKE_CURRENT_BINARY_DIR})

with:

target_include_directories(f18
  ${CMAKE_CURRENT_BINARY_DIR}
  ${FLANG_BINARY_DIR}/include/flang 
)
Aug 12 2020, 5:13 PM · Restricted Project, Restricted Project
DavidTruby added inline comments to D84334: [flang] Version information in flang/f18.
Aug 12 2020, 5:09 PM · Restricted Project, Restricted Project
DavidTruby added a comment to D85828: [Flang] Move mark down documentation(md) files to reStructuredText(rst) file format..

I think md is the wave of the future. Other llvm subproject use md. Let's stick with what we have unless there's a compelling advantage to using rst or another format.

Aug 12 2020, 8:16 AM · Restricted Project
DavidTruby added inline comments to D85828: [Flang] Move mark down documentation(md) files to reStructuredText(rst) file format..
Aug 12 2020, 7:52 AM · Restricted Project
DavidTruby accepted D85816: Fix binaries directory for flang slaves gcc10 and clang10.

LGTM

Aug 12 2020, 6:01 AM
DavidTruby requested changes to D85816: Fix binaries directory for flang slaves gcc10 and clang10.
Aug 12 2020, 5:02 AM