User Details
- User Since
- Oct 3 2018, 7:41 AM (121 w, 14 h)
Wed, Jan 20
Fri, Jan 15
Did this change ever get committed?
Tue, Jan 12
Mon, Jan 11
Fix tests to use check-label correctly and add proper precondition on aarch64
Wed, Jan 6
Refactor based on review
Mon, Jan 4
Switch from CHECK to CHECK-LABEL in tests.
Refactor based on review comments
Dec 15 2020
Add additional callee-side tests
Added extra tests for additional conditions and IR -> assembly tests.
Dec 7 2020
Oct 30 2020
Committed as rG81b96bb6f1caee90ad64c9c7c80b55c163b1f6a8
Oct 26 2020
LGTM!
Oct 14 2020
LGTM
Sep 30 2020
Ah ok, can we close this review then? Thanks!
Is something blocking this change being committed?
@YangZhihui if you don't have commit access I can commit this for you. Could you let me know the name and email address you'd like it committed under please? Thanks!
LGTM. Not sure why msvc thinks these are ambiguous
LGTM
Add indexes for loop-style implementation, and rename operation to omp.wsloop
Sep 24 2020
LGTM, perhaps put NFC in the commit message?
Sep 23 2020
Sep 22 2020
As discussed on flang-dev I am closing this to not block anyone else's progress on upstreaming.
As discussed on flang-dev I am closing this to not block anyone else's progress on upstreaming.
As discussed on flang-dev I am closing this to not block anyone else's progress on upstreaming.
LGTM
LGTM
LGTM. Odd that msvc needs this clarification though.
LGTM!
@kiranktp I believe most of the semantic checks are still only targeting OpenMP 4.5, at least the ones that I implemented are as that was the target spec last time I checked. If this hasn't significantly changed then upgrading the tests to OpenMP 5 will cause failures.
Sep 21 2020
As requested on https://reviews.llvm.org/D87684
Sep 18 2020
I have submitted an RFC on the openmp do loop design here: https://llvm.discourse.group/t/openmp-worksharing-loop-rfc/1815
Sep 16 2020
LGTM
Sep 15 2020
Sep 8 2020
LGTM and seems to work from the flang side. Wait for another review with more experience though please :)
Capitalise all schedule clause values.
Sep 7 2020
Address review comments.
I've reverted this commit for now since it broke the flang and mlir buildbots:
http://lab.llvm.org:8011/builders/flang-aarch64-ubuntu
http://lab.llvm.org:8011/builders/mlir-nvidia
http://lab.llvm.org:8011/builders/mlir-windows
This commit appears to remove the ShapeToSCF folder, but not the add_directory(ShapeToSCF) in the parent folder, meaning the CMake configure step can't complete without errors.
Sep 1 2020
If this is now fixed in another way, can this review be closed?
Is it possible to add lit tests based on the generated mlir?
Aug 18 2020
LGTM
On my clang line, when compiling a C file, this appears as "-cc1" not "cc1". I don't see a cc1as so I can't check that one but I assume it will be the same.
Aug 17 2020
Aug 14 2020
Interesting that the compilers don't use the same lookup rule here. I wonder which is correct (my gut feeling is actually that MSVC is).
Fixed by D85078
LGTM
As an aside would it be worth throwing a bug report at MSVC? I think the existing code is conformant so they might like to know about the bug.
Aug 13 2020
LGTM! It would be great to have test so this doesn't regress
Aug 12 2020
LGTM