Page MenuHomePhabricator

PeteSteinfeld (Pete Steinfeld)
User

Projects

User does not belong to any projects.

User Details

User Since
Apr 13 2020, 9:02 AM (62 w, 3 d)

Recent Activity

Mon, Jun 21

PeteSteinfeld added a comment to D104586: [flang] Update Reshape runtime library routine and its corresponding unit test.

All builds, tests, and looks good to me. But I'm not very familiar with the front end's interface to the runtime.

Mon, Jun 21, 6:32 AM · Restricted Project

Sun, Jun 20

PeteSteinfeld committed rGe7f78fb91717: [flang] Implement constant folding for the NOT intrinsic (authored by PeteSteinfeld).
[flang] Implement constant folding for the NOT intrinsic
Sun, Jun 20, 7:28 AM
PeteSteinfeld closed D104587: [flang] Implement constant folding for the NOT intrinsic.
Sun, Jun 20, 7:28 AM · Restricted Project, Restricted Project

Fri, Jun 18

PeteSteinfeld added reviewers for D104587: [flang] Implement constant folding for the NOT intrinsic: klausler, mleair, jeanPerier.
Fri, Jun 18, 7:45 PM · Restricted Project, Restricted Project
PeteSteinfeld requested review of D104587: [flang] Implement constant folding for the NOT intrinsic.
Fri, Jun 18, 7:19 PM · Restricted Project, Restricted Project

Wed, Jun 16

PeteSteinfeld accepted D104330: [flang] Complain about more cases of calls to insufficiently defined procedures.

In my latest attempt to build and test this, .../test/Semantics/call19.f90 is failing because it's producing extra messages regarding entities that are "not a procedure". But I trust you to make sure that everything works after integration with the latest sources.

Wed, Jun 16, 2:59 PM · Restricted Project, Restricted Project
PeteSteinfeld added a comment to D104305: [flang][driver] Add `-fdebug-dump-all`.

For what it's worth, here's my cmake command that results in a successful static full build:

Wed, Jun 16, 12:06 PM · Restricted Project, Restricted Project
PeteSteinfeld added a comment to D104305: [flang][driver] Add `-fdebug-dump-all`.

The non-shared-library build of the current llvm-project/main tree fails on this new test; it looks as if gfortran is being invoked and passed an option that it does not recognize. The shared library build passes all tests.

Wed, Jun 16, 11:48 AM · Restricted Project, Restricted Project
PeteSteinfeld accepted D104385: [flang] preserve symbol in DescriptorInquiry.

All builds, tests, and looks good.

Wed, Jun 16, 8:32 AM · Restricted Project, Restricted Project

Tue, Jun 15

PeteSteinfeld committed rGbda1f2936e37: [flang] Add semantic check for the RANDOM_SEED intrinsic (authored by PeteSteinfeld).
[flang] Add semantic check for the RANDOM_SEED intrinsic
Tue, Jun 15, 9:36 PM
PeteSteinfeld closed D104318: [flang] Add semantic check for the RANDOM_SEED intrinsic.
Tue, Jun 15, 9:36 PM · Restricted Project, Restricted Project
PeteSteinfeld requested changes to D104330: [flang] Complain about more cases of calls to insufficiently defined procedures.

Things build OK, but I when I run the tests, I get failures in implicit07.f90 and resolve29.f90.

Tue, Jun 15, 9:03 PM · Restricted Project, Restricted Project
PeteSteinfeld accepted D104329: [flang] Fix crashes on calls to non-procedures.

All builds, tests, and looks good.

Tue, Jun 15, 8:27 PM · Restricted Project, Restricted Project
PeteSteinfeld accepted D104326: [flang] Don't crash on some bogus expressions.

All builds, tests, and looks good.

Tue, Jun 15, 8:13 PM · Restricted Project, Restricted Project
PeteSteinfeld accepted D104325: [flang] Correct the subscripts used for arguments to character intrinsics.

All builds, tests, and looks good.

Tue, Jun 15, 8:05 PM · Restricted Project, Restricted Project
PeteSteinfeld added reviewers for D104318: [flang] Add semantic check for the RANDOM_SEED intrinsic: klausler, jeanPerier, schweitz.
Tue, Jun 15, 1:12 PM · Restricted Project, Restricted Project
PeteSteinfeld requested review of D104318: [flang] Add semantic check for the RANDOM_SEED intrinsic.
Tue, Jun 15, 1:11 PM · Restricted Project, Restricted Project
PeteSteinfeld accepted D104305: [flang][driver] Add `-fdebug-dump-all`.

Looks great! Thanks for doing this.

Tue, Jun 15, 10:42 AM · Restricted Project, Restricted Project
PeteSteinfeld added a comment to D104305: [flang][driver] Add `-fdebug-dump-all`.

Stay tuned a little, I think I spotted the problem ...

Tue, Jun 15, 10:37 AM · Restricted Project, Restricted Project
PeteSteinfeld added a comment to D104305: [flang][driver] Add `-fdebug-dump-all`.

Thanks for doing this. These changes look good, but I can't get them to build successfully. I'm using the GNU 9.3 C++ compiler. My build fails to link the bin/flang-new executable. Here's an excerpt of the error messages:

Tue, Jun 15, 10:27 AM · Restricted Project, Restricted Project

Mon, Jun 14

PeteSteinfeld committed rGb88fa0e39fa7: [flang] Fix compilation problem with rename of "MemRefDataFlow" (authored by PeteSteinfeld).
[flang] Fix compilation problem with rename of "MemRefDataFlow"
Mon, Jun 14, 7:02 AM
PeteSteinfeld closed D104223: [flang] Fix compilation problem with rename of "MemRefDataFlow".
Mon, Jun 14, 7:01 AM · Restricted Project, Restricted Project
PeteSteinfeld added reviewers for D104223: [flang] Fix compilation problem with rename of "MemRefDataFlow": schweitz, jeanPerier, bondhugula, nicolasvasilache.
Mon, Jun 14, 6:24 AM · Restricted Project, Restricted Project
PeteSteinfeld requested review of D104223: [flang] Fix compilation problem with rename of "MemRefDataFlow".
Mon, Jun 14, 6:22 AM · Restricted Project, Restricted Project

Fri, Jun 11

PeteSteinfeld committed rG1b241b9b400b: [flang] Handle multiple USE statements for the same module (authored by PeteSteinfeld).
[flang] Handle multiple USE statements for the same module
Fri, Jun 11, 12:31 PM
PeteSteinfeld closed D104130: [flang] Handle multiple USE statements for the same module.
Fri, Jun 11, 12:31 PM · Restricted Project, Restricted Project
PeteSteinfeld updated the summary of D104130: [flang] Handle multiple USE statements for the same module.
Fri, Jun 11, 12:28 PM · Restricted Project, Restricted Project
PeteSteinfeld updated the diff for D104130: [flang] Handle multiple USE statements for the same module.

Responding to Peter's comments.

Fri, Jun 11, 12:04 PM · Restricted Project, Restricted Project
PeteSteinfeld added inline comments to D104130: [flang] Handle multiple USE statements for the same module.
Fri, Jun 11, 12:02 PM · Restricted Project, Restricted Project
PeteSteinfeld updated the summary of D104130: [flang] Handle multiple USE statements for the same module.
Fri, Jun 11, 9:55 AM · Restricted Project, Restricted Project
PeteSteinfeld requested review of D104130: [flang] Handle multiple USE statements for the same module.
Fri, Jun 11, 9:52 AM · Restricted Project, Restricted Project

Mon, Jun 7

PeteSteinfeld added inline comments to D103832: [flang] Check for calling a type parameter as a function.
Mon, Jun 7, 12:37 PM · Restricted Project, Restricted Project
PeteSteinfeld added reviewers for D103832: [flang] Check for calling a type parameter as a function: klausler, jeanPerier, schweitz.
Mon, Jun 7, 11:28 AM · Restricted Project, Restricted Project
PeteSteinfeld requested review of D103832: [flang] Check for calling a type parameter as a function.
Mon, Jun 7, 11:27 AM · Restricted Project, Restricted Project

Fri, Jun 4

PeteSteinfeld committed rG2b795ec682ff: [flang] Check for undefined derived types (authored by PeteSteinfeld).
[flang] Check for undefined derived types
Fri, Jun 4, 2:34 PM
PeteSteinfeld closed D103714: [flang] Check for undefined derived types.
Fri, Jun 4, 2:34 PM · Restricted Project, Restricted Project
PeteSteinfeld updated the diff for D103714: [flang] Check for undefined derived types.

Responding to comments from Peter.

Fri, Jun 4, 2:19 PM · Restricted Project, Restricted Project
PeteSteinfeld added inline comments to D103714: [flang] Check for undefined derived types.
Fri, Jun 4, 2:16 PM · Restricted Project, Restricted Project
PeteSteinfeld added reviewers for D103714: [flang] Check for undefined derived types: klausler, jeanPerier, schweitz.
Fri, Jun 4, 1:27 PM · Restricted Project, Restricted Project
PeteSteinfeld requested review of D103714: [flang] Check for undefined derived types.
Fri, Jun 4, 1:26 PM · Restricted Project, Restricted Project

Thu, Jun 3

PeteSteinfeld accepted D103613: [flang][driver] Add support for `-module-suffix`.

All builds, tests, and looks good.

Thu, Jun 3, 7:42 PM · Restricted Project, Restricted Project
PeteSteinfeld added a comment to D103177: [flang][driver] Extend the `flang` bash script to act as a driver.

@awarzynski, I'm not sure what a good transition period would be. Actually, I don't see the benefit of removing any functionality from f18. This might be a good topic to bring up at the Wednesday f18 meeting.

Thu, Jun 3, 6:55 PM · Restricted Project, Restricted Project
PeteSteinfeld accepted D103621: [flang] Generate type info symbols outside of derived type scopes.

All builds, tests, and looks good.

Thu, Jun 3, 9:01 AM · Restricted Project, Restricted Project
PeteSteinfeld committed rG22d7e298dc35: [flang] Check for duplicate definitions of defined input/output procedures (authored by PeteSteinfeld).
[flang] Check for duplicate definitions of defined input/output procedures
Thu, Jun 3, 7:39 AM
PeteSteinfeld closed D103560: [flang] Check for duplicate definitions of defined input/output procedures.
Thu, Jun 3, 7:39 AM · Restricted Project, Restricted Project

Wed, Jun 2

PeteSteinfeld accepted D103569: [flang] Accept BOZ in array constructors w/o types.

All builds, tests, and looks good.

Wed, Jun 2, 8:20 PM · Restricted Project, Restricted Project
PeteSteinfeld accepted D103573: [flang] Emit error about missing interface when needed.

All builds, tests, and looks goodl.

Wed, Jun 2, 8:04 PM · Restricted Project, Restricted Project
PeteSteinfeld accepted D103572: [flang] Fix crash on structure constructor as selector.

All builds, tests, and looks good.

Wed, Jun 2, 7:59 PM · Restricted Project, Restricted Project
PeteSteinfeld accepted D103580: [flang] Fix spurious "already declared" errors for interfaces.

All builds, tests, and looks good.

Wed, Jun 2, 7:55 PM · Restricted Project, Restricted Project
PeteSteinfeld accepted D103571: [flang] Support known constant lengths in DynamicType.

All builds, tests, and looks good.

Wed, Jun 2, 7:50 PM · Restricted Project, Restricted Project
PeteSteinfeld accepted D103576: [flang] Catch errors in function calls instead of crashing.

All builds, tests, and looks good.

Wed, Jun 2, 7:48 PM · Restricted Project, Restricted Project
PeteSteinfeld accepted D103570: [flang] Catch procedure pointer interface error.

All builds, tests, and looks good.

Wed, Jun 2, 7:45 PM · Restricted Project, Restricted Project
PeteSteinfeld accepted D103568: [flang] Fix folding of CMPLX.

All builds, tests, and looks good.

Wed, Jun 2, 7:42 PM · Restricted Project, Restricted Project
PeteSteinfeld accepted D103567: [flang] Fix crashes due to failure to find a subprogram.

All builds, tests, and looks good.

Wed, Jun 2, 6:58 PM · Restricted Project, Restricted Project
PeteSteinfeld added inline comments to D103560: [flang] Check for duplicate definitions of defined input/output procedures.
Wed, Jun 2, 4:57 PM · Restricted Project, Restricted Project
PeteSteinfeld added reviewers for D103560: [flang] Check for duplicate definitions of defined input/output procedures: klausler, jeanPerier, schweitz.
Wed, Jun 2, 2:59 PM · Restricted Project, Restricted Project
PeteSteinfeld requested review of D103560: [flang] Check for duplicate definitions of defined input/output procedures.
Wed, Jun 2, 2:58 PM · Restricted Project, Restricted Project

Tue, Jun 1

PeteSteinfeld added a comment to D103177: [flang][driver] Extend the `flang` bash script to act as a driver.

I'm not clear why you plan to remove code from f18.cpp.

Tue, Jun 1, 1:03 PM · Restricted Project, Restricted Project

Tue, May 25

PeteSteinfeld committed rGbc56620b8b76: [flang] Implement checks for defined input/output procedures (authored by PeteSteinfeld).
[flang] Implement checks for defined input/output procedures
Tue, May 25, 1:41 PM
PeteSteinfeld closed D103045: [flang] Implement checks for defined input/output procedures.
Tue, May 25, 1:41 PM · Restricted Project, Restricted Project
PeteSteinfeld added inline comments to D103045: [flang] Implement checks for defined input/output procedures.
Tue, May 25, 1:26 PM · Restricted Project, Restricted Project

May 24 2021

PeteSteinfeld added reviewers for D103045: [flang] Implement checks for defined input/output procedures: klausler, jeanPerier, schweitz.
May 24 2021, 1:33 PM · Restricted Project, Restricted Project
PeteSteinfeld requested review of D103045: [flang] Implement checks for defined input/output procedures.
May 24 2021, 1:32 PM · Restricted Project, Restricted Project

May 21 2021

PeteSteinfeld accepted D102948: [flang] Fix symbol table bugs with ENTRY statements.

All builds, tests, and looks good.

May 21 2021, 3:43 PM · Restricted Project

May 20 2021

PeteSteinfeld accepted D102857: [flang] Implement more transformational intrinsic functions in runtime.

All builds, tests, and looks good.

May 20 2021, 1:20 PM · Restricted Project, Restricted Project

May 19 2021

PeteSteinfeld accepted D102768: [flang] simplify derived type info table format.

All builds, tests, and looks good.

May 19 2021, 6:40 AM · Restricted Project, Restricted Project

May 17 2021

PeteSteinfeld accepted D102653: [flang] Accept OPEN(ACCESS='APPEND') legacy extension even without warnings enabled.

All builds, tests, and looks good.

May 17 2021, 2:35 PM · Restricted Project, Restricted Project
PeteSteinfeld updated the diff for D102424: [flang] Clean up file formats.

I removed changes to flang/lib/Optimizer/CodeGen/PreCGRewrite.cpp, since it looks like they will cause problems for Doxygen, and I can't currently test for them.

May 17 2021, 9:01 AM · Restricted Project, Restricted Project

May 14 2021

PeteSteinfeld added a comment to D102424: [flang] Clean up file formats.

Thanks for your comments, @awarzynski. The version of clang-format that I build from the latest sources is 13.0.0. I've been in the habit of the last many months to always use the latest version of clang-format, but I'm not sure if there's general agreement on that policy. I'll post a message on the mailing list about this.

May 14 2021, 6:27 AM · Restricted Project, Restricted Project

May 13 2021

PeteSteinfeld added a comment to D102424: [flang] Clean up file formats.
May 13 2021, 8:42 PM · Restricted Project, Restricted Project
PeteSteinfeld added a reviewer for D102424: [flang] Clean up file formats: awarzynski.
May 13 2021, 12:47 PM · Restricted Project, Restricted Project
PeteSteinfeld added inline comments to D102424: [flang] Clean up file formats.
May 13 2021, 12:39 PM · Restricted Project, Restricted Project
PeteSteinfeld added reviewers for D102424: [flang] Clean up file formats: klausler, jeanPerier, schweitz.
May 13 2021, 10:53 AM · Restricted Project, Restricted Project
PeteSteinfeld requested review of D102424: [flang] Clean up file formats.
May 13 2021, 10:52 AM · Restricted Project, Restricted Project

May 12 2021

PeteSteinfeld accepted D102352: [flang] (NFC) Expose internal idiom as utility API.

All builds, tests, and looks good.

May 12 2021, 12:41 PM · Restricted Project, Restricted Project
PeteSteinfeld added a comment to D102350: flang] Support legacy extension OPEN(ACCESS='APPEND').

Actually, I got a diff when I ran clang-format on check-io.cpp.

May 12 2021, 12:29 PM · Restricted Project, Restricted Project
PeteSteinfeld accepted D102350: flang] Support legacy extension OPEN(ACCESS='APPEND').

All builds, tests, and looks good.

May 12 2021, 12:26 PM · Restricted Project, Restricted Project
PeteSteinfeld added a comment to D102259: [flang] Limit the depth of expressions that the compiler will handle.

Instead of imposing an arbitrary limit on the size of an expression it would be better to change the algorithm to handle larger trees with more use of iteration and tail recursion, I think.

May 12 2021, 6:00 AM · Restricted Project, Restricted Project

May 11 2021

PeteSteinfeld added reviewers for D102259: [flang] Limit the depth of expressions that the compiler will handle: klausler, jeanPerier, schweitz.
May 11 2021, 10:45 AM · Restricted Project, Restricted Project
PeteSteinfeld requested review of D102259: [flang] Limit the depth of expressions that the compiler will handle.
May 11 2021, 10:44 AM · Restricted Project, Restricted Project
PeteSteinfeld added inline comments to D102210: [flang] Allow large and erroneous ac-implied-do's.
May 11 2021, 10:22 AM · Restricted Project, Restricted Project
PeteSteinfeld committed rG5a9497d68901: [flang] Allow large and erroneous ac-implied-do's (authored by PeteSteinfeld).
[flang] Allow large and erroneous ac-implied-do's
May 11 2021, 10:04 AM
PeteSteinfeld closed D102210: [flang] Allow large and erroneous ac-implied-do's.
May 11 2021, 10:04 AM · Restricted Project, Restricted Project
PeteSteinfeld added a comment to D102210: [flang] Allow large and erroneous ac-implied-do's.

Thanks for the feedback, Jean!

May 11 2021, 8:17 AM · Restricted Project, Restricted Project

May 10 2021

PeteSteinfeld added a reviewer for D102210: [flang] Allow large and erroneous ac-implied-do's: schweitz.
May 10 2021, 7:51 PM · Restricted Project, Restricted Project
PeteSteinfeld added a reviewer for D102210: [flang] Allow large and erroneous ac-implied-do's: jeanPerier.
May 10 2021, 7:51 PM · Restricted Project, Restricted Project
PeteSteinfeld requested review of D102210: [flang] Allow large and erroneous ac-implied-do's.
May 10 2021, 7:48 PM · Restricted Project, Restricted Project

May 7 2021

PeteSteinfeld accepted D102040: [flang] Enable export of FIR includes into the install tree.
May 7 2021, 10:46 AM · Restricted Project, Restricted Project
PeteSteinfeld added a comment to D102040: [flang] Enable export of FIR includes into the install tree.

I have tested full shared and non-shared builds with this change, and both look good.

May 7 2021, 7:10 AM · Restricted Project, Restricted Project
PeteSteinfeld added a comment to D102040: [flang] Enable export of FIR includes into the install tree.

@Renaud-K, I'm not sure what the use-case is that this fixes. Can you please describe it in more detail, and I'll try a build with that exact use case to verify that this fixes it.

May 7 2021, 6:49 AM · Restricted Project, Restricted Project

May 6 2021

PeteSteinfeld accepted D102024: [flang] Implement NORM2 in the runtime.

All builds, tests, and looks good.

May 6 2021, 2:21 PM · Restricted Project, Restricted Project

May 5 2021

PeteSteinfeld accepted D101931: [flang] Implement NAMELIST I/O in the runtime.

All builds, tests, and looks good to me.

May 5 2021, 12:45 PM · Restricted Project, Restricted Project

Apr 30 2021

PeteSteinfeld committed rG8989268dae30: [flang] Allow KIND type parameters to be used as LEN parameters of components (authored by PeteSteinfeld).
[flang] Allow KIND type parameters to be used as LEN parameters of components
Apr 30 2021, 9:20 AM
PeteSteinfeld closed D101482: [flang] Allow KIND type parameters to be used as LEN parameters of components.
Apr 30 2021, 9:20 AM · Restricted Project, Restricted Project

Apr 29 2021

PeteSteinfeld added a comment to D101482: [flang] Allow KIND type parameters to be used as LEN parameters of components.

Responding to Peter's comments.

Apr 29 2021, 7:15 PM · Restricted Project, Restricted Project
PeteSteinfeld updated the diff for D101482: [flang] Allow KIND type parameters to be used as LEN parameters of components.

Responding to Peter's comments.

Apr 29 2021, 7:15 PM · Restricted Project, Restricted Project
PeteSteinfeld added inline comments to D101482: [flang] Allow KIND type parameters to be used as LEN parameters of components.
Apr 29 2021, 7:11 PM · Restricted Project, Restricted Project
PeteSteinfeld updated the summary of D101482: [flang] Allow KIND type parameters to be used as LEN parameters of components.
Apr 29 2021, 3:34 PM · Restricted Project, Restricted Project
PeteSteinfeld updated the diff for D101482: [flang] Allow KIND type parameters to be used as LEN parameters of components.

Responding to Peter's comments. I totally changed my implementation to be as
described in the current commit description.

Apr 29 2021, 3:30 PM · Restricted Project, Restricted Project

Apr 28 2021

PeteSteinfeld added a project to D101482: [flang] Allow KIND type parameters to be used as LEN parameters of components: Restricted Project.
Apr 28 2021, 1:07 PM · Restricted Project, Restricted Project