Page MenuHomePhabricator

PeteSteinfeld (Pete Steinfeld)
User

Projects

User does not belong to any projects.

User Details

User Since
Apr 13 2020, 9:02 AM (33 w, 1 d)

Recent Activity

Wed, Nov 18

PeteSteinfeld committed rGea4973f2068a: [flang] Improve error message on bad LOGICAL compare operations (authored by PeteSteinfeld).
[flang] Improve error message on bad LOGICAL compare operations
Wed, Nov 18, 1:54 PM
PeteSteinfeld closed D91736: [flang] Improve error message on bad LOGICAL compare operations.
Wed, Nov 18, 1:53 PM · Restricted Project, Restricted Project
PeteSteinfeld added a project to D91736: [flang] Improve error message on bad LOGICAL compare operations: Restricted Project.
Wed, Nov 18, 12:44 PM · Restricted Project, Restricted Project
PeteSteinfeld requested review of D91736: [flang] Improve error message on bad LOGICAL compare operations.
Wed, Nov 18, 12:44 PM · Restricted Project, Restricted Project

Tue, Nov 17

PeteSteinfeld accepted D91657: [flang] Correct handling of null pointer initializers.

Aside from the noted items, all builds, tests, and looks good.

Tue, Nov 17, 8:35 PM · Restricted Project, Restricted Project
PeteSteinfeld committed rG3fd777403349: [flang] Fix FIR test failures (authored by PeteSteinfeld).
[flang] Fix FIR test failures
Tue, Nov 17, 12:30 PM
PeteSteinfeld closed D91654: [flang] Fix FIR test failures.
Tue, Nov 17, 12:29 PM · Restricted Project, Restricted Project
PeteSteinfeld added a project to D91654: [flang] Fix FIR test failures: Restricted Project.
Tue, Nov 17, 11:58 AM · Restricted Project, Restricted Project
PeteSteinfeld requested review of D91654: [flang] Fix FIR test failures.
Tue, Nov 17, 11:57 AM · Restricted Project, Restricted Project

Mon, Nov 16

PeteSteinfeld committed rG681978d3b4e8: [flang] Duplicate names for ac-implied-do variables erroneously cause errors (authored by PeteSteinfeld).
[flang] Duplicate names for ac-implied-do variables erroneously cause errors
Mon, Nov 16, 7:15 PM
PeteSteinfeld closed D91560: [flang] Duplicate names for ac-implied-do variables erroneously cause errors.
Mon, Nov 16, 7:14 PM · Restricted Project, Restricted Project
PeteSteinfeld added inline comments to D91560: [flang] Duplicate names for ac-implied-do variables erroneously cause errors.
Mon, Nov 16, 3:02 PM · Restricted Project, Restricted Project
PeteSteinfeld added inline comments to D91560: [flang] Duplicate names for ac-implied-do variables erroneously cause errors.
Mon, Nov 16, 2:14 PM · Restricted Project, Restricted Project
PeteSteinfeld updated the diff for D91560: [flang] Duplicate names for ac-implied-do variables erroneously cause errors.

I fixed some spelling errors and added a test to verify that the duplicate
ac-implied-do variable names get evaluated correctly in the presence of
constant folding.

Mon, Nov 16, 1:30 PM · Restricted Project, Restricted Project
PeteSteinfeld added inline comments to D91560: [flang] Duplicate names for ac-implied-do variables erroneously cause errors.
Mon, Nov 16, 1:27 PM · Restricted Project, Restricted Project
PeteSteinfeld added a project to D91560: [flang] Duplicate names for ac-implied-do variables erroneously cause errors: Restricted Project.
Mon, Nov 16, 12:13 PM · Restricted Project, Restricted Project
PeteSteinfeld requested review of D91560: [flang] Duplicate names for ac-implied-do variables erroneously cause errors.
Mon, Nov 16, 12:08 PM · Restricted Project, Restricted Project

Fri, Nov 13

PeteSteinfeld committed rG5795a81cbab8: [flang] Fix "EQ" comparison of arrays (authored by PeteSteinfeld).
[flang] Fix "EQ" comparison of arrays
Fri, Nov 13, 3:24 PM
PeteSteinfeld closed D91440: [flang] Fix "EQ" comparison of arrays.
Fri, Nov 13, 3:24 PM · Restricted Project, Restricted Project
PeteSteinfeld updated the diff for D91440: [flang] Fix "EQ" comparison of arrays.

Reworked the code to check array shape conformance as suggested by Peter.

Fri, Nov 13, 1:01 PM · Restricted Project, Restricted Project
PeteSteinfeld added inline comments to D91440: [flang] Fix "EQ" comparison of arrays.
Fri, Nov 13, 1:00 PM · Restricted Project, Restricted Project
PeteSteinfeld added a project to D91440: [flang] Fix "EQ" comparison of arrays: Restricted Project.
Fri, Nov 13, 9:34 AM · Restricted Project, Restricted Project
PeteSteinfeld requested review of D91440: [flang] Fix "EQ" comparison of arrays.
Fri, Nov 13, 9:33 AM · Restricted Project, Restricted Project

Thu, Nov 12

PeteSteinfeld accepted D91377: [flang] Recognize END FILE as ENDFILE in free form source.

All builds, tests, and looks good.

Thu, Nov 12, 12:43 PM · Restricted Project, Restricted Project

Tue, Nov 10

PeteSteinfeld accepted D91217: [flang] Allow labels on END statements..

All builds, tests, and looks good.

Tue, Nov 10, 7:00 PM · Restricted Project, Restricted Project
PeteSteinfeld accepted D91209: [flang] Fix CheckSpecificationExpr handling of associated names.

All builds, tests, and looks good.

Tue, Nov 10, 3:11 PM · Restricted Project, Restricted Project

Mon, Nov 9

PeteSteinfeld committed rG66a9607557a1: [flang] Avoid calling the linker when "-c" option is used (authored by PeteSteinfeld).
[flang] Avoid calling the linker when "-c" option is used
Mon, Nov 9, 10:22 AM
PeteSteinfeld added a project to D91081: [flang] Avoid calling the linker when "-c" option is used: Restricted Project.
Mon, Nov 9, 7:44 AM · Restricted Project, Restricted Project
PeteSteinfeld requested review of D91081: [flang] Avoid calling the linker when "-c" option is used.
Mon, Nov 9, 7:44 AM · Restricted Project, Restricted Project

Wed, Nov 4

PeteSteinfeld added a project to D90226: [flang] update ODS syntax to use OpBuidlerDAG instead of OpBuilder: Restricted Project.
Wed, Nov 4, 9:36 AM · Restricted Project, Restricted Project

Tue, Nov 3

PeteSteinfeld accepted D90696: [flang] Dodge gcc 8.2.0 build problem (NFC).

All of the flang front end builds without warnings, and everything tests cleanly.

Tue, Nov 3, 12:04 PM · Restricted Project, Restricted Project

Mon, Nov 2

PeteSteinfeld accepted D90636: [flang] Fix actual argument character length and length error reporting.

I'm having trouble building and running tests, but all of the changes in this update seem to build and test fine.

Mon, Nov 2, 12:59 PM · Restricted Project, Restricted Project

Oct 30 2020

PeteSteinfeld accepted D90495: [flang] Add warning for FINAL pitfall.

All builds, tests, and looks good.

Oct 30 2020, 2:25 PM · Restricted Project, Restricted Project
PeteSteinfeld accepted D90493: [flang] Detect and rewrite ambiguous READ(CVAR)[,item-list].

All builds, tests, and looks good.

Oct 30 2020, 2:13 PM · Restricted Project, Restricted Project

Oct 23 2020

PeteSteinfeld committed rGb6b589ca8484: [flang] An erroneous type bound procedure was causing a call to CHECK() (authored by PeteSteinfeld).
[flang] An erroneous type bound procedure was causing a call to CHECK()
Oct 23 2020, 2:06 PM
PeteSteinfeld closed D90074: [flang] An erroneous type bound procedure was causing a call to CHECK().
Oct 23 2020, 2:05 PM · Restricted Project, Restricted Project
PeteSteinfeld added a project to D90074: [flang] An erroneous type bound procedure was causing a call to CHECK(): Restricted Project.
Oct 23 2020, 1:53 PM · Restricted Project, Restricted Project
PeteSteinfeld requested review of D90074: [flang] An erroneous type bound procedure was causing a call to CHECK().
Oct 23 2020, 1:12 PM · Restricted Project, Restricted Project

Oct 21 2020

PeteSteinfeld committed rG6b66f1cd9ba4: [flang] Another validity of the TARGET= argument of ASSOCIATED() for objects (authored by PeteSteinfeld).
[flang] Another validity of the TARGET= argument of ASSOCIATED() for objects
Oct 21 2020, 10:20 AM
PeteSteinfeld closed D89717: [flang] Another validity of the TARGET= argument of ASSOCIATED() for objects.
Oct 21 2020, 10:20 AM · Restricted Project, Restricted Project

Oct 20 2020

PeteSteinfeld committed rG29d838310d45: [flang] Fix call to CHECK() on erroneous subroutine declaration (authored by PeteSteinfeld).
[flang] Fix call to CHECK() on erroneous subroutine declaration
Oct 20 2020, 6:12 PM
PeteSteinfeld closed D89829: [flang] Fix call to CHECK() on erroneous subroutine declaration.
Oct 20 2020, 6:12 PM · Restricted Project, Restricted Project
PeteSteinfeld added a project to D89829: [flang] Fix call to CHECK() on erroneous subroutine declaration: Restricted Project.
Oct 20 2020, 3:10 PM · Restricted Project, Restricted Project
PeteSteinfeld requested review of D89829: [flang] Fix call to CHECK() on erroneous subroutine declaration.
Oct 20 2020, 3:09 PM · Restricted Project, Restricted Project

Oct 19 2020

PeteSteinfeld added a comment to D89717: [flang] Another validity of the TARGET= argument of ASSOCIATED() for objects.

Why is this a fatal error, rather than a warning? If the TARGET= argument lacks both POINTER and TARGET attributes, the result will always be false, and we can warn about that.

Oct 19 2020, 11:53 AM · Restricted Project, Restricted Project
PeteSteinfeld added a project to D89717: [flang] Another validity of the TARGET= argument of ASSOCIATED() for objects: Restricted Project.
Oct 19 2020, 11:15 AM · Restricted Project, Restricted Project
PeteSteinfeld requested review of D89717: [flang] Another validity of the TARGET= argument of ASSOCIATED() for objects.
Oct 19 2020, 11:06 AM · Restricted Project, Restricted Project
PeteSteinfeld committed rG0047f6aed37c: [flang] Add name match checks for interface procedures (authored by PeteSteinfeld).
[flang] Add name match checks for interface procedures
Oct 19 2020, 7:56 AM
PeteSteinfeld closed D89611: [flang] Add name match checks for interface procedures.
Oct 19 2020, 7:56 AM · Restricted Project, Restricted Project
PeteSteinfeld updated the diff for D89611: [flang] Add name match checks for interface procedures.

Added the reference to the constraint in the standard for mismatched interfaces
to the code and test.

Oct 19 2020, 6:28 AM · Restricted Project, Restricted Project

Oct 18 2020

PeteSteinfeld updated the diff for D89611: [flang] Add name match checks for interface procedures.

We were reporting generic interface name mismatchess as warnings rather than as
errors. I fixed the code to report them as errors and adjusted the test.

Oct 18 2020, 11:12 AM · Restricted Project, Restricted Project
PeteSteinfeld added inline comments to D89611: [flang] Add name match checks for interface procedures.
Oct 18 2020, 11:10 AM · Restricted Project, Restricted Project

Oct 17 2020

PeteSteinfeld updated the diff for D89611: [flang] Add name match checks for interface procedures.

Added comments to label11.f90 specifying the constraints checked.

Oct 17 2020, 6:15 AM · Restricted Project, Restricted Project

Oct 16 2020

PeteSteinfeld added a project to D89611: [flang] Add name match checks for interface procedures: Restricted Project.
Oct 16 2020, 6:29 PM · Restricted Project, Restricted Project
PeteSteinfeld requested review of D89611: [flang] Add name match checks for interface procedures.
Oct 16 2020, 6:28 PM · Restricted Project, Restricted Project
PeteSteinfeld committed rGf2897b8f45c1: [flang] Disallow pointer constants (authored by PeteSteinfeld).
[flang] Disallow pointer constants
Oct 16 2020, 12:34 PM
PeteSteinfeld closed D89581: [flang] Disallow pointer constants.
Oct 16 2020, 12:34 PM · Restricted Project, Restricted Project
PeteSteinfeld added a comment to D89581: [flang] Disallow pointer constants.

Please add a comment that lays out our reasoning for the prohibition against combining PARAMETER and POINTER, since the standards do not explicitly preclude it. (The PARAMETER attribute requires a entity-decl to have an initialization that is a constant-expr, and the only form of initialization that allows a constant-expr is the one that's not a "=>" pointer initialization.) See C811, C807, & 8.5.13.

Oct 16 2020, 12:25 PM · Restricted Project, Restricted Project
PeteSteinfeld added a project to D89581: [flang] Disallow pointer constants: Restricted Project.
Oct 16 2020, 11:51 AM · Restricted Project, Restricted Project
PeteSteinfeld requested review of D89581: [flang] Disallow pointer constants.
Oct 16 2020, 11:50 AM · Restricted Project, Restricted Project
PeteSteinfeld committed rGc757418869c0: [flang] Failed call to CHECK() for call to ASSOCIATED(NULL()) (authored by PeteSteinfeld).
[flang] Failed call to CHECK() for call to ASSOCIATED(NULL())
Oct 16 2020, 7:17 AM
PeteSteinfeld closed D88313: [flang] Failed call to CHECK() for call to ASSOCIATED(NULL()).
Oct 16 2020, 7:17 AM · Restricted Project, Restricted Project

Oct 15 2020

PeteSteinfeld updated the diff for D88313: [flang] Failed call to CHECK() for call to ASSOCIATED(NULL()).

Responses to review comments.

Oct 15 2020, 1:00 PM · Restricted Project, Restricted Project
PeteSteinfeld added a comment to D88313: [flang] Failed call to CHECK() for call to ASSOCIATED(NULL()).

Thanks for the comments. New update coming.

Oct 15 2020, 12:57 PM · Restricted Project, Restricted Project
PeteSteinfeld accepted D89473: [flang] Document and use intrinsic subroutine argument intents.

All builds, tests, and looks good.

Oct 15 2020, 9:13 AM · Restricted Project, Restricted Project
PeteSteinfeld updated the summary of D88313: [flang] Failed call to CHECK() for call to ASSOCIATED(NULL()).
Oct 15 2020, 7:18 AM · Restricted Project, Restricted Project
PeteSteinfeld updated the diff for D88313: [flang] Failed call to CHECK() for call to ASSOCIATED(NULL()).

Fixed some formatting.

Oct 15 2020, 7:17 AM · Restricted Project, Restricted Project
PeteSteinfeld updated the diff for D88313: [flang] Failed call to CHECK() for call to ASSOCIATED(NULL()).

I made several changes:

  • I implemented constant folding for ASSOCIATED().
  • I fixed handling of NULL() in relational operations.
  • I implemented semantic analysis for ASSOCIATED().
  • I noticed that the semantics for ASSOCIATED() are similar to those for pointer assignment. So I extracted the code that pointer assignment uses for procedure pointer compatibility to a place where it could be used by the semantic analysis for ASSOCIATED().
  • I couldn't figure out how to make the general semantic analysis for procedure arguments work with ASSOCIATED()'s second argument, which can be either a pointer or a target. So I stopped using normal semantic analysis for arguments for ASSOCIATED().
  • I added tests for all of this.
Oct 15 2020, 7:04 AM · Restricted Project, Restricted Project

Oct 9 2020

PeteSteinfeld accepted D88981: [flang] Rework host runtime folding and enable REAL(2) folding with it..

Thanks for working on this, Jean. I have to confess that I don't understand most of the code. But it all built and tested correctly for me. It would be nice to have some constant folding tests that fold REAL(2) operands.

Oct 9 2020, 8:30 AM · Restricted Project, Restricted Project

Oct 7 2020

PeteSteinfeld accepted D89017: [flang] Allow "name: value" in compiler directives.

Builds, tests, and looks good to me.

Oct 7 2020, 6:50 PM · Restricted Project, Restricted Project

Oct 5 2020

PeteSteinfeld accepted D88610: [flang] Correct kP scaling on F output.

All builds, tests, and looks good.

Oct 5 2020, 11:59 AM · Restricted Project, Restricted Project

Oct 2 2020

PeteSteinfeld added inline comments to D88313: [flang] Failed call to CHECK() for call to ASSOCIATED(NULL()).
Oct 2 2020, 11:03 AM · Restricted Project, Restricted Project
PeteSteinfeld added inline comments to D88313: [flang] Failed call to CHECK() for call to ASSOCIATED(NULL()).
Oct 2 2020, 10:28 AM · Restricted Project, Restricted Project
PeteSteinfeld added inline comments to D88313: [flang] Failed call to CHECK() for call to ASSOCIATED(NULL()).
Oct 2 2020, 10:22 AM · Restricted Project, Restricted Project

Oct 1 2020

PeteSteinfeld accepted D88673: [flang] Fix INQUIRE of access and formatting possibilities.

All builds, tests, and looks good.

Oct 1 2020, 9:55 AM · Restricted Project, Restricted Project
PeteSteinfeld accepted D88672: [flang] Add checks for misuse of formatted I/O APIs in unformatted I/O statement.

All builds, tests, and looks good.

Oct 1 2020, 9:48 AM · Restricted Project, Restricted Project

Sep 30 2020

PeteSteinfeld accepted D88618: [flang] Fix Gw.d format output.

All builds, tests, and looks good.

Sep 30 2020, 4:27 PM · Restricted Project, Restricted Project
PeteSteinfeld accepted D88607: [flang] Allow record advancement in external formatted sequential READ.

All builds, tests, and looks good.

Sep 30 2020, 4:20 PM · Restricted Project, Restricted Project
PeteSteinfeld updated the diff for D88313: [flang] Failed call to CHECK() for call to ASSOCIATED(NULL()).

Responding to review comments.

Sep 30 2020, 11:40 AM · Restricted Project, Restricted Project
PeteSteinfeld added inline comments to D88313: [flang] Failed call to CHECK() for call to ASSOCIATED(NULL()).
Sep 30 2020, 11:38 AM · Restricted Project, Restricted Project
PeteSteinfeld updated the summary of D88313: [flang] Failed call to CHECK() for call to ASSOCIATED(NULL()).
Sep 30 2020, 10:05 AM · Restricted Project, Restricted Project
PeteSteinfeld updated the diff for D88313: [flang] Failed call to CHECK() for call to ASSOCIATED(NULL()).

I reverted the interface of the FromActual() function. This required redoing
the analysis of procedure arguments. To make sure I covered all the code in
the anslysis of procedure arguments, I added some tests that exposed another
bad call to CHECK() that I fixed. I added tests for all of this.

Sep 30 2020, 9:48 AM · Restricted Project, Restricted Project
PeteSteinfeld added inline comments to D88313: [flang] Failed call to CHECK() for call to ASSOCIATED(NULL()).
Sep 30 2020, 8:33 AM · Restricted Project, Restricted Project

Sep 25 2020

PeteSteinfeld added inline comments to D88313: [flang] Failed call to CHECK() for call to ASSOCIATED(NULL()).
Sep 25 2020, 12:03 PM · Restricted Project, Restricted Project
PeteSteinfeld added a project to D88313: [flang] Failed call to CHECK() for call to ASSOCIATED(NULL()): Restricted Project.
Sep 25 2020, 9:24 AM · Restricted Project, Restricted Project
PeteSteinfeld requested review of D88313: [flang] Failed call to CHECK() for call to ASSOCIATED(NULL()).
Sep 25 2020, 9:04 AM · Restricted Project, Restricted Project

Sep 24 2020

PeteSteinfeld abandoned D87859: [flang] Unnecessary call to CHECK() for call to NULL() as an actual argument.

I've lost the repository where I was working on this, so I'm abandoning it.

Sep 24 2020, 2:55 PM · Restricted Project, Restricted Project

Sep 17 2020

PeteSteinfeld added a comment to D87859: [flang] Unnecessary call to CHECK() for call to NULL() as an actual argument.

NULL() isn't "undefined". It's a pointer (or in some other contexts, an unallocated allocatable), and the description of ASSOCIATED() in 16.9.16 just requires that its first (POINTER=) argument be a pointer.

(Even if NULL() were undefined, it would be okay -- see paragraph (2) of 16.1, which describes general rules for inquiry functions, of which ASSOCIATED is an example.) "Unless the description of an intrinsic inquiry function states otherwise, these arguments are permitted to be unallocated allocatable variables or pointers that are undefined or disassociated."

Sep 17 2020, 6:55 PM · Restricted Project, Restricted Project
PeteSteinfeld added a project to D87859: [flang] Unnecessary call to CHECK() for call to NULL() as an actual argument: Restricted Project.
Sep 17 2020, 2:46 PM · Restricted Project, Restricted Project
PeteSteinfeld requested review of D87859: [flang] Unnecessary call to CHECK() for call to NULL() as an actual argument.
Sep 17 2020, 2:46 PM · Restricted Project, Restricted Project
PeteSteinfeld accepted D87650: [flang] Rework preprocessing of stringification.

Things still build, test, and look good.

Sep 17 2020, 1:24 PM · Restricted Project, Restricted Project

Sep 16 2020

PeteSteinfeld committed rGdd3eb3f33239: [flang] Substrings with lower bound greater than upper bound (authored by PeteSteinfeld).
[flang] Substrings with lower bound greater than upper bound
Sep 16 2020, 2:57 PM
PeteSteinfeld closed D87799: [flang] Substrings with lower bound greater than upper bound.
Sep 16 2020, 2:57 PM · Restricted Project, Restricted Project
PeteSteinfeld added a project to D87799: [flang] Substrings with lower bound greater than upper bound: Restricted Project.
Sep 16 2020, 2:50 PM · Restricted Project, Restricted Project
PeteSteinfeld requested review of D87799: [flang] Substrings with lower bound greater than upper bound.
Sep 16 2020, 2:49 PM · Restricted Project, Restricted Project

Sep 14 2020

PeteSteinfeld accepted D87650: [flang] Rework preprocessing of stringification.

All builds, tests, and looks good.

Sep 14 2020, 6:07 PM · Restricted Project, Restricted Project
PeteSteinfeld committed rGcdbfb47998cd: [flang] Fix bug for forward referenced type (authored by PeteSteinfeld).
[flang] Fix bug for forward referenced type
Sep 14 2020, 3:24 PM
PeteSteinfeld closed D87535: [flang] Fix bug for forward referenced type.
Sep 14 2020, 3:24 PM · Restricted Project, Restricted Project
PeteSteinfeld accepted D87638: [flang] Allow Fortran comments after #include path.

All builds, tests, and looks good.

Sep 14 2020, 3:16 PM · Restricted Project, Restricted Project
PeteSteinfeld accepted D87635: [flang] More clean-up of CookedSource API.

All of these changes build, test, and look good.

Sep 14 2020, 2:26 PM · Restricted Project, Restricted Project