This is an archive of the discontinued LLVM Phabricator instance.

[lldb] stop-hook ID common completion for commands `target stop-hook enable/disable/delete'
ClosedPublic

Authored by MrHate on Jul 19 2020, 2:02 AM.

Details

Summary
  1. Added a common completion StopHookIDs to provide completion with a list of stop hook ids;
  2. Applied the common completion to commands: `target stop-hook delete/enable/disable';
  3. Added an related test case.

Diff Detail

Event Timeline

teemperor accepted this revision.Aug 6 2020, 4:34 AM
teemperor added inline comments.
lldb/source/Commands/CommandCompletions.cpp
724

Where is that '11' coming from? That seems like it would deserve a comment how that got calculated.

This revision is now accepted and ready to land.Aug 6 2020, 4:34 AM
MrHate added inline comments.Aug 6 2020, 4:40 AM
lldb/source/Commands/CommandCompletions.cpp
724

That's the offset to make the descriptions of the completion result look better. The value was got after tests.

MrHate updated this revision to Diff 283570.Aug 6 2020, 4:56 AM
  • Added a comment to describe that 11 indent value.