Page MenuHomePhabricator

teemperor (Raphael Isemann)
User

Projects

User does not belong to any projects.

User Details

User Since
Mar 23 2016, 8:38 AM (265 w, 1 d)

Recent Activity

Today

teemperor committed rGf3e6f856c290: [lldb][NFC] Remove a stray unicode character in the LLDB test docs (authored by teemperor).
[lldb][NFC] Remove a stray unicode character in the LLDB test docs
Fri, Apr 23, 4:21 AM
teemperor added a comment to D101153: [lldb][NFC] Specify guidelines for API tests.

If anyone feels like any of the guidelines is actually controversial then let me know and I'll remove it from this review and split it out into its own patch.

Fri, Apr 23, 4:18 AM · Restricted Project
teemperor updated the diff for D101153: [lldb][NFC] Specify guidelines for API tests.
  • Improve some wording.
Fri, Apr 23, 4:14 AM · Restricted Project
teemperor requested review of D101153: [lldb][NFC] Specify guidelines for API tests.
Fri, Apr 23, 4:10 AM · Restricted Project
teemperor committed rGf8f3fc1fbad6: [lldb][NFC] Delete a checked-in build log in docs/testsuite (authored by teemperor).
[lldb][NFC] Delete a checked-in build log in docs/testsuite
Fri, Apr 23, 1:37 AM

Yesterday

teemperor added inline comments to D101094: lldb/Instrumentation: NFC-ish use GetFrameCodeAddressForSymbolication().
Thu, Apr 22, 1:55 PM · Restricted Project
teemperor added a comment to D100977: [lldb] Use forward type in pointer-to-member.

I assume you don't have a commit access, so I'm going to land this for you tomorrow. Thanks again for the patch!

Thu, Apr 22, 12:35 PM · Restricted Project
teemperor added inline comments to D99989: [lldb-vscode] Distinguish shadowed variables in the scopes request.
Thu, Apr 22, 12:33 PM · Restricted Project
teemperor committed rGd616a6bd107f: [lldb] Fix that the expression commands --top-level flag overwrites --allow-jit… (authored by teemperor).
[lldb] Fix that the expression commands --top-level flag overwrites --allow-jit…
Thu, Apr 22, 9:51 AM
teemperor closed D91780: [lldb] Fix that the expression commands --top-level flag overwrites --allow-jit false.
Thu, Apr 22, 9:51 AM · Restricted Project
teemperor committed rGae209aa9ecd7: Fix memory leak in MicrosoftDemangleNodes's Node::toString (authored by teemperor).
Fix memory leak in MicrosoftDemangleNodes's Node::toString
Thu, Apr 22, 9:45 AM
teemperor closed D100843: Fix memory leak in MicrosoftDemangleNodes's Node::toString.
Thu, Apr 22, 9:44 AM · Restricted Project
teemperor requested review of D101056: [lldb] Let dotest check for the `cassert` header instead of `algorithm` for libc++ check.
Thu, Apr 22, 5:34 AM · Restricted Project
teemperor committed rGe3dd82ae3c4e: [lldb] Don't leak LineSequence in PDB parsers (authored by teemperor).
[lldb] Don't leak LineSequence in PDB parsers
Thu, Apr 22, 5:11 AM
teemperor closed D100846: [lldb] Don't leak LineSequence in PDB parsers.
Thu, Apr 22, 5:11 AM · Restricted Project
teemperor requested changes to D99989: [lldb-vscode] Distinguish shadowed variables in the scopes request.
Thu, Apr 22, 4:58 AM · Restricted Project
teemperor reopened D99989: [lldb-vscode] Distinguish shadowed variables in the scopes request.
Thu, Apr 22, 4:58 AM · Restricted Project
teemperor committed rGd2223c7a4997: [lldb] XFAIL TestStoppedInStaticMemberFunction on Windows (authored by teemperor).
[lldb] XFAIL TestStoppedInStaticMemberFunction on Windows
Thu, Apr 22, 4:46 AM
teemperor accepted D100977: [lldb] Use forward type in pointer-to-member.

The test below reproduces the eager layout generation (and the resulting crashes) for me. Just apply it on top and then this is good to go. Thanks for tracking this down!

Thu, Apr 22, 4:34 AM · Restricted Project
teemperor committed rG034c73d42e46: [lldb][NFC] Fix unsigned/signed cmp warning in MainLoopTest (authored by teemperor).
[lldb][NFC] Fix unsigned/signed cmp warning in MainLoopTest
Thu, Apr 22, 3:21 AM
teemperor committed rG00764c36edf8: [lldb] Add support for evaluating expressions in static member functions (authored by teemperor).
[lldb] Add support for evaluating expressions in static member functions
Thu, Apr 22, 3:15 AM
teemperor closed D81550: [lldb] Add support for evaluating expressions in static member functions.
Thu, Apr 22, 3:14 AM · Restricted Project

Wed, Apr 21

teemperor added a comment to D100977: [lldb] Use forward type in pointer-to-member.

Were you able to reduce the reproducer you got to a test? If it's really the same bug as in D100180 then I guess a similar test case should trigger the issue (e.g., a class with a pointer-to-member member that references some type that is currently being parsed?)

Wed, Apr 21, 12:39 PM · Restricted Project
teemperor committed rGe2039142f6b1: Some FormatEntity.cpp cleanup and unit testing (authored by nealsid).
Some FormatEntity.cpp cleanup and unit testing
Wed, Apr 21, 6:14 AM
teemperor closed D98153: Some FormatEntity.cpp cleanup and unit testing.
Wed, Apr 21, 6:13 AM · Restricted Project
teemperor accepted D98153: Some FormatEntity.cpp cleanup and unit testing.

Thanks for updating and thanks for the patch! I can land it right now.

Wed, Apr 21, 6:10 AM · Restricted Project
teemperor accepted D76964: Fix an issue where the IgnoreName function was not allowing "Class" to be looked up inside a namespace or other class..

I think this review got kind of stuck. I think the only missing thing is simplifying the self.dbg.CreateTarget call in the test, but otherwise this looks good to me. I'm just going to accept this as the bit of cleanup doesn't need another revision.

Wed, Apr 21, 5:50 AM · Restricted Project

Tue, Apr 20

teemperor accepted D100795: [lldb] Fix RichManglingContext::FromCxxMethodName() leak.

LGTM, thanks for fixing this!

Tue, Apr 20, 4:05 PM · Restricted Project
teemperor requested review of D100846: [lldb] Don't leak LineSequence in PDB parsers.
Tue, Apr 20, 5:23 AM · Restricted Project
teemperor updated subscribers of D100843: Fix memory leak in MicrosoftDemangleNodes's Node::toString.
Tue, Apr 20, 5:01 AM · Restricted Project
teemperor requested review of D100843: Fix memory leak in MicrosoftDemangleNodes's Node::toString.
Tue, Apr 20, 5:01 AM · Restricted Project

Mon, Apr 19

teemperor accepted D100800: [lldb] Fix demangler leaks in the DWARF AST parser.

LGTM. I still kinda like the unique_ptr deleter but let's not block bot-fixes with refactoring requests. I'll open a review for the unique_ptr as a follow up.

Mon, Apr 19, 4:26 PM · Restricted Project
teemperor added a comment to D100800: [lldb] Fix demangler leaks in the DWARF AST parser.

Thanks for fixing this, I guess we really need a leak sanitizer/valgrind bot for LLDB...

Mon, Apr 19, 3:54 PM · Restricted Project
teemperor added inline comments to D100662: [lldb] Make the ClassTemplateDecl merging logic in TypeSystemClang respect template parameters.
Mon, Apr 19, 11:44 AM · Restricted Project
teemperor abandoned D73038: 64 bit SourceLocs.
Mon, Apr 19, 8:27 AM
teemperor added a comment to D91508: [LLDB/Lua] add support for one-liner breakpoint callback.

I think this might have broken the Windows build as it seems the LLDBSwigLuaBreakpointCallbackFunction return type is an error for MSVC (and not a warning which we seem to ignore locally).

Mon, Apr 19, 8:24 AM · Restricted Project
teemperor added a comment to D99650: Demonstrating lack of thread-safety in BackendUtil.

Sorry, my bad, I thought if I won't specify any repo/project in Phabricator it won't trigger the Herald (I was using the web interface, not arcanist).

Mon, Apr 19, 8:18 AM · Restricted Project
teemperor added a comment to D100440: [Debug-Info] DW_AT_export_symbols shouldn't be generated before version-5 of DWARF..

@aprantl @probinson @jhenderson - any of you folks want this in older versions? I think this is for C++ inline namespaces - so if you used a modern C++ standard library (that uses inline namespaces like "std::__1::basic_string", etc) users would have to use these extra qualifiers when naming types, functions, etc. Not unworkable, but a bit inconvenient.

Mon, Apr 19, 8:14 AM · debug-info, Restricted Project

Fri, Apr 16

teemperor added a reviewer for D100662: [lldb] Make the ClassTemplateDecl merging logic in TypeSystemClang respect template parameters: JDevlieghere.
Fri, Apr 16, 9:59 AM · Restricted Project
teemperor updated the diff for D100662: [lldb] Make the ClassTemplateDecl merging logic in TypeSystemClang respect template parameters.
  • Make a variable name more expressive.
Fri, Apr 16, 9:52 AM · Restricted Project
teemperor updated the summary of D100662: [lldb] Make the ClassTemplateDecl merging logic in TypeSystemClang respect template parameters.
Fri, Apr 16, 9:51 AM · Restricted Project
teemperor requested review of D100662: [lldb] Make the ClassTemplateDecl merging logic in TypeSystemClang respect template parameters.
Fri, Apr 16, 9:50 AM · Restricted Project

Thu, Apr 15

teemperor committed rG0f3ed7a48dba: [lldb] Fix incorrect test data in FileSpecTest.IsRelative (authored by teemperor).
[lldb] Fix incorrect test data in FileSpecTest.IsRelative
Thu, Apr 15, 3:43 AM

Mon, Apr 12

teemperor committed rG5a5a94ed34b0: [lldb] Delete dead StackFrameList::Merge (authored by teemperor).
[lldb] Delete dead StackFrameList::Merge
Mon, Apr 12, 5:50 AM
teemperor closed D100212: [lldb] Delete dead StackFrameList::Merge.
Mon, Apr 12, 5:49 AM · Restricted Project
teemperor committed rG34c697c85e9d: [lldb] Don't recursively load types of static member variables in the DWARF AST… (authored by teemperor).
[lldb] Don't recursively load types of static member variables in the DWARF AST…
Mon, Apr 12, 5:38 AM
teemperor closed D100180: [lldb] Don't recursively load types of static member variables in the DWARF AST parser.
Mon, Apr 12, 5:37 AM · Restricted Project

Fri, Apr 9

teemperor updated the summary of D100180: [lldb] Don't recursively load types of static member variables in the DWARF AST parser.
Fri, Apr 9, 10:16 AM · Restricted Project
teemperor requested review of D100212: [lldb] Delete dead StackFrameList::Merge.
Fri, Apr 9, 9:02 AM · Restricted Project
teemperor updated the diff for D100180: [lldb] Don't recursively load types of static member variables in the DWARF AST parser.
  • Add missing test case.
Fri, Apr 9, 5:01 AM · Restricted Project
teemperor requested review of D100180: [lldb] Don't recursively load types of static member variables in the DWARF AST parser.
Fri, Apr 9, 5:01 AM · Restricted Project

Tue, Apr 6

teemperor accepted D99890: [lldb] Fix bug where memory read --outfile is not truncating the file.

LGTM now beside the now redundant import

Tue, Apr 6, 8:36 AM · Restricted Project
teemperor requested changes to D99890: [lldb] Fix bug where memory read --outfile is not truncating the file.

Thanks for the patch! I'll be extra nit-picky about the test to make up for the great meme steal of 2021.

Tue, Apr 6, 6:18 AM · Restricted Project
teemperor accepted D99827: Clarifying the documentation for variable formatting wrt to qualifiers and adding a test that demonstrates this.

LGTM, thanks! FWIW, there are actually a lot more 'qualifiers' supported in Clang that are ignored by the formatters (restrict, Obj-C garbage collector descriptions, custom address spaces, etc.). Most of them are not even modelled in DWARF and users rarely encounter them, so I think const/volatile should cover all reasonable workflows.

Tue, Apr 6, 5:51 AM · Restricted Project
teemperor committed rGbdfee7d5e192: [lldb][NFC] Fix misleading indentation in Cocoa.cpp (authored by teemperor).
[lldb][NFC] Fix misleading indentation in Cocoa.cpp
Tue, Apr 6, 5:32 AM
teemperor requested review of D99946: [DebugInfo] Fix DWARF expressions for __block vars that are not on the heap.
Tue, Apr 6, 4:55 AM · Restricted Project

Mon, Apr 5

teemperor added inline comments to D99867: [lldb] Replace unneeded use of Foundation with ObjectiveC in tests (NFC).
Mon, Apr 5, 9:50 AM · Restricted Project

Sun, Apr 4

teemperor added inline comments to D99867: [lldb] Replace unneeded use of Foundation with ObjectiveC in tests (NFC).
Sun, Apr 4, 3:14 PM · Restricted Project
teemperor accepted D99867: [lldb] Replace unneeded use of Foundation with ObjectiveC in tests (NFC).

Thanks for cleaning this up!

Sun, Apr 4, 3:11 PM · Restricted Project
teemperor accepted D99859: [lldb] Import ObjectiveC module instead of Foundation in test (NFC).
Sun, Apr 4, 3:05 PM · Restricted Project

Thu, Apr 1

teemperor committed rG18dbe0f954a7: [lldb] Prevent that LLDB randomly crashes in CommandLineParser::addOption by… (authored by teemperor).
[lldb] Prevent that LLDB randomly crashes in CommandLineParser::addOption by…
Thu, Apr 1, 11:20 AM
teemperor closed D99652: [lldb] Prevent that LLDB randomly crashes in CommandLineParser::addOption by initializing LLVM's command line parser.
Thu, Apr 1, 11:19 AM · Restricted Project
teemperor committed rG60854c328d87: Avoid calling ParseCommandLineOptions in BackendUtil if possible (authored by teemperor).
Avoid calling ParseCommandLineOptions in BackendUtil if possible
Thu, Apr 1, 10:41 AM
teemperor closed D99740: Avoid calling ParseCommandLineOptions in BackendUtil if possible.
Thu, Apr 1, 10:41 AM · Restricted Project
teemperor requested review of D99740: Avoid calling ParseCommandLineOptions in BackendUtil if possible.
Thu, Apr 1, 9:16 AM · Restricted Project

Wed, Mar 31

teemperor abandoned D99650: Demonstrating lack of thread-safety in BackendUtil.

Not a real review, just dumping code here.

Wed, Mar 31, 4:47 AM · Restricted Project
teemperor updated the summary of D99650: Demonstrating lack of thread-safety in BackendUtil.
Wed, Mar 31, 4:46 AM · Restricted Project
teemperor requested review of D99652: [lldb] Prevent that LLDB randomly crashes in CommandLineParser::addOption by initializing LLVM's command line parser.
Wed, Mar 31, 4:44 AM · Restricted Project
teemperor requested review of D99650: Demonstrating lack of thread-safety in BackendUtil.
Wed, Mar 31, 4:34 AM · Restricted Project

Tue, Mar 30

teemperor committed rG6919c58262b0: [lldb] Add a test for Obj-C properties with conflicting names (authored by teemperor).
[lldb] Add a test for Obj-C properties with conflicting names
Tue, Mar 30, 2:08 AM
teemperor closed D99513: [lldb] Add a test for Obj-C properties with conflicting names.
Tue, Mar 30, 2:08 AM · Restricted Project
teemperor committed rG1cbba533ec93: [ObjC][CodeGen] Fix missing debug info in situations where an instance and… (authored by teemperor).
[ObjC][CodeGen] Fix missing debug info in situations where an instance and…
Tue, Mar 30, 2:08 AM
teemperor closed D99512: [ObjC][CodeGen] Fix missing debug info in situations where an instance and class property have the same identifier.
Tue, Mar 30, 2:07 AM · Restricted Project

Mon, Mar 29

teemperor committed rG10d02fb15b2d: [lldb][NFC] Fix -Wdocumentation issue in ModuleSpec.h/ThreadTrace.h (authored by teemperor).
[lldb][NFC] Fix -Wdocumentation issue in ModuleSpec.h/ThreadTrace.h
Mon, Mar 29, 10:48 AM
teemperor committed rG32f252a765d5: [lldb][NFC] Fix -Wdocumentation issue in ProcessMinidump (authored by teemperor).
[lldb][NFC] Fix -Wdocumentation issue in ProcessMinidump
Mon, Mar 29, 10:41 AM
teemperor updated the diff for D99512: [ObjC][CodeGen] Fix missing debug info in situations where an instance and class property have the same identifier.
  • Fixed formatting.
Mon, Mar 29, 8:27 AM · Restricted Project
teemperor accepted D99513: [lldb] Add a test for Obj-C properties with conflicting names.

Just queuing this up until the Clang fixes have landed.

Mon, Mar 29, 8:25 AM · Restricted Project
teemperor requested review of D99513: [lldb] Add a test for Obj-C properties with conflicting names.
Mon, Mar 29, 8:24 AM · Restricted Project
teemperor requested review of D99512: [ObjC][CodeGen] Fix missing debug info in situations where an instance and class property have the same identifier.
Mon, Mar 29, 8:23 AM · Restricted Project
teemperor added a comment to rG0c208d1f42be: [lldb] Fix flakyness in TestGdbRemote_vContThreads.

It seems Pavel already figured it out, but this is indeed randomly failing on Green Dragon (The bot is green at the moment, but the test usually randomly starts failing again). Not sure what's triggering the failure, but as it's frequently failing on my private bot (Linux) and Green Dragon (macOS), I doubt it's OS related but rather due to both bots being really resource constrained.

Mon, Mar 29, 6:27 AM
teemperor added a comment to D99331: [TESTS] Fix TestInlineStepping with ccac compiler.

So from what I understand this is resolved? If yes, can you abandon/close this revision (You can do this by selecting the "Abandon revision" action above the input field where you can comment).

Mon, Mar 29, 3:36 AM · Restricted Project
teemperor committed rG69e7b7457809: [lldb][NFC] Add a test case for Objective-C properties with conflicting names (authored by teemperor).
[lldb][NFC] Add a test case for Objective-C properties with conflicting names
Mon, Mar 29, 3:33 AM
teemperor added a comment to D99348: [ASTImporter] Add ability to convert CXXRecordDecls to RecordDecls when importing to C language TUs.

I did not mean to reuse ASTImporter, that is a possibility too. Probably it can be more easy to handle AST conversion only without importing, specially if during the conversion no kind of error can occur, so no error handling or ODR search are needed. The conversion can happen before doing the AST import (with converted AST).
I do not know how this feature will be used, is it not possible to simply set C++ mode for every used AST?

Mon, Mar 29, 2:36 AM · Restricted Project
teemperor planned changes to D99348: [ASTImporter] Add ability to convert CXXRecordDecls to RecordDecls when importing to C language TUs.

So something like an ASTConverter that just sits on top of the ASTImporter? In theory that class could implement the ImportImpl callback and do the custom imports it needs to do on its own, so I think that would work. I'm putting this in "planned changes" for now until I get around to make an ASTConverter patch..

Mon, Mar 29, 1:48 AM · Restricted Project
teemperor committed rG3c95bdf9fa35: [lldb] Don't search for system specific strings in assert.test (authored by teemperor).
[lldb] Don't search for system specific strings in assert.test
Mon, Mar 29, 1:47 AM
teemperor accepted D98153: Some FormatEntity.cpp cleanup and unit testing.

LGTM, thanks for the patch (and especially the unit test)! Some two nits left but feel free to fix those when merging. If you don't have commit access I can also do that, just let me know.

Mon, Mar 29, 1:24 AM · Restricted Project

Thu, Mar 25

teemperor added inline comments to D99348: [ASTImporter] Add ability to convert CXXRecordDecls to RecordDecls when importing to C language TUs.
Thu, Mar 25, 8:51 AM · Restricted Project
teemperor added a comment to D99348: [ASTImporter] Add ability to convert CXXRecordDecls to RecordDecls when importing to C language TUs.

This patch is also intended to get early feedback on how we should approach this. We could also discuss *if* we want to really support this whole cross-language
translation in the ASTImporter, but so far it hasn't been explicitly forbidden so people already started using it this way.

Thu, Mar 25, 8:50 AM · Restricted Project
teemperor requested review of D99348: [ASTImporter] Add ability to convert CXXRecordDecls to RecordDecls when importing to C language TUs.
Thu, Mar 25, 8:43 AM · Restricted Project
teemperor requested changes to D81810: LLDB step-instruction gets stuck on jump to self.

(Marking as requested-changes to get this out of my review queue)

Thu, Mar 25, 6:31 AM · Restricted Project
teemperor removed a project from D99331: [TESTS] Fix TestInlineStepping with ccac compiler: Restricted Project.
Thu, Mar 25, 5:53 AM · Restricted Project
teemperor edited reviewers for D99331: [TESTS] Fix TestInlineStepping with ccac compiler, added: jingham; removed: Restricted Project.

Thanks for the patch!

Thu, Mar 25, 5:53 AM · Restricted Project
teemperor removed a project from D99331: [TESTS] Fix TestInlineStepping with ccac compiler: Restricted Project.
Thu, Mar 25, 5:00 AM · Restricted Project
teemperor resigned from D82732: WIP: Use SB APIs in CommandObjects.
Thu, Mar 25, 3:56 AM · Restricted Project
teemperor committed rGd90b1230ea62: [lldb] Fix TestVSCode.test_progress_events on Linux due to vdso (authored by teemperor).
[lldb] Fix TestVSCode.test_progress_events on Linux due to vdso
Thu, Mar 25, 2:50 AM
teemperor added a comment to rG0c208d1f42be: [lldb] Fix flakyness in TestGdbRemote_vContThreads.

This still seems to be failing quite frequently on different bots (Linux and macOS):

Thu, Mar 25, 2:20 AM

Wed, Mar 24

teemperor added a comment to D95713: [lldb/Plugins] Add ScriptedProcess Process Plugin.

The tests are failing because Dave's bot is running without enabled Python. The same is true for the Windows bot. Putting the plugin behind #ifdef LLDB_ENABLE_PYTHON should fix this.

My cron job is not intentionally disabling python support. That just happened to be the fallout from the normal feature detection dance before the build starts:

  • Could NOT find SWIG (missing: SWIG_EXECUTABLE SWIG_DIR) (Required is at least version "3.0")
  • SWIG 3 or later is required for Python support in LLDB but could not be found
  • Could NOT find PythonAndSwig (missing: Python3_LIBRARIES Python3_INCLUDE_DIRS SWIG_EXECUTABLE)
  • Enable Python scripting support in LLDB: FALSE
Wed, Mar 24, 7:56 AM · Restricted Project
teemperor added a comment to D95713: [lldb/Plugins] Add ScriptedProcess Process Plugin.

The tests are failing because Dave's bot is running without enabled Python. The same is true for the Windows bot. Putting the plugin behind #ifdef LLDB_ENABLE_PYTHON should fix this.

Wed, Mar 24, 6:44 AM · Restricted Project

Mar 24 2021

teemperor added a comment to rG68bb51acd572: [lldb] Fix TestAutoInstallMainExecutable.py.

I re-added the llgs decorator in c68a645acb83 because this still seems to be a lldb-server test (which we have disabled on macOS it seems).

Mar 24 2021, 2:41 AM
teemperor committed rGc68a645acb83: [lldb] Add llgs_test decorator back to TestAutoInstallMainExecutable (authored by teemperor).
[lldb] Add llgs_test decorator back to TestAutoInstallMainExecutable
Mar 24 2021, 2:38 AM