[LLDB][Clang Integration][NFC] Remove redundant condition

[baloghadamsoftware]

Summary

Condition omit_empty_base_classes is checked both in an outer and in an inner if statement in TypeSystemClang::GetNumBaseClasses(). This patch removes the redundant inner check.

The issue was found using clang-tidy check under review misc-redundant-condition. See https://reviews.llvm.org/D81272.

[shafik]

LGTM!

lldb/source/Plugins/TypeSystem/Clang/TypeSystemClang.cpp

TypeSystemClang::GetNumBaseClasses(const CXXRecordDecl *cxx_record_decl,
   uint32_t num_bases = 0;
   if (cxx_record_decl) {
     if (omit_empty_base_classes) {
       CXXRecordDecl::base_class_const_iterator base_class, base_class_end;
       for (base_class = cxx_record_decl->bases_begin(),
           base_class_end = cxx_record_decl->bases_end();
            base_class != base_class_end; ++base_class) {
         // Skip empty base classes
-        if (omit_empty_base_classes) {
-          if (BaseSpecifierIsEmpty(base_class))
-            continue;
-        }
         ++num_bases;
       }
     } else
       num_bases = cxx_record_decl->getNumBases();
   }
   return num_bases;
 }