This is an archive of the discontinued LLVM Phabricator instance.

[globalisel] Allow backends to report an issue without triggering fallback. NFC
ClosedPublic

Authored by dsanders on Apr 15 2020, 6:22 PM.

Details

Summary

This will allow us to fix the issue where the lost locations
verifier causes CodeGen changes on lost locations because it
falls back on DAGISel

Diff Detail

Event Timeline

dsanders created this revision.Apr 15 2020, 6:22 PM
Herald added a project: Restricted Project. · View Herald TranscriptApr 15 2020, 6:23 PM
qcolombet accepted this revision.Apr 15 2020, 6:48 PM

LGTM with the bool to enum change.

llvm/lib/CodeGen/GlobalISel/Utils.cpp
201

Instead of AllowFatal could we have a severity enum?
For now, maybe just warning and failure, where failure would be equivalent to AllowFatal == true?

This revision is now accepted and ready to land.Apr 15 2020, 6:48 PM
dsanders marked 2 inline comments as done.Apr 15 2020, 7:17 PM

Thanks

llvm/lib/CodeGen/GlobalISel/Utils.cpp
201

Sure, I'll re-use DiagnosticSeverity

This revision was automatically updated to reflect the committed changes.
dsanders marked an inline comment as done.