oh boy
User Details
- User Since
- Nov 17 2016, 12:59 PM (218 w, 4 d)
Today
LGTM aside from nit
Thu, Jan 21
LGTM
Wed, Jan 20
Yeah this seems fine
LGTM, thanks!
Can you add selection tests for s32 and s64?
LGTM
LGTM
Tue, Jan 19
Hopefully should be fixed by cbf52463599c860243d29877021fcdfcd9d46553
Do you think you could split this into 3 patches, one for each commit?
Fri, Jan 15
- Add a LLT variant of allowsMemoryAccess. This is the same as the DAGCombiner check.
- Add a testcase that shows that when we have strict-align, the combine only fires when the resulting load will be aligned.
Thu, Jan 14
LGTM
LGTM
Use m_OneNonDBGUse (D94705)
A better, more general solution might be to move some of the G_FCONSTANT selection code into the legalizer or post-legalizer lowering. That might make some of the selection code which relies on seeing a G_FCONSTANT more difficult to get right though.
Wed, Jan 13
Tue, Jan 12
Fix a bug in isPredecessor exposed by this patch and add a testcase for it. It wasn't able to handle the case where DefMI is the first instruction in the block.
Here's some measurements:
Fri, Jan 8
Tue, Jan 5
LGTM
LGTM
Dec 17 2020
Dec 16 2020
Dec 9 2020
Thanks for working on this!
Dec 8 2020
Dec 7 2020
With -O0 and -Os on CTMark, there is no change in size.__text.
Dec 4 2020
Dec 3 2020
Dec 1 2020
Tidy up logic a little, improve comments, and address review comments.
Nov 30 2020
LGTM
Nov 19 2020
Nov 18 2020
Nov 16 2020
LGTM
LGTM
Nov 13 2020
Rebase + use new m_Not matcher
I think this looks reasonable.