Page MenuHomePhabricator

volkan (Volkan Keles)
User

Projects

User does not belong to any projects.

User Details

User Since
Jun 30 2015, 12:54 PM (312 w, 2 d)

Recent Activity

Thu, Jun 10

volkan committed rG119965865cc7: LoadStoreVectorizer: support different operand orders in the add sequence match (authored by wvoquine).
LoadStoreVectorizer: support different operand orders in the add sequence match
Thu, Jun 10, 4:32 PM
volkan closed D103912: LoadStoreVectorizer: support different operand orders in the add sequence match.
Thu, Jun 10, 4:32 PM · Restricted Project
volkan accepted D103912: LoadStoreVectorizer: support different operand orders in the add sequence match.

LGTM, thanks Slava.

Thu, Jun 10, 3:18 PM · Restricted Project
volkan added inline comments to D103912: LoadStoreVectorizer: support different operand orders in the add sequence match.
Thu, Jun 10, 1:35 PM · Restricted Project

Sep 15 2020

volkan committed rG79378b1b757d: GlobalISel: Fix a failing combiner test (authored by volkan).
GlobalISel: Fix a failing combiner test
Sep 15 2020, 4:43 PM
volkan closed D87050: GlobalISel: Add combines for G_TRUNC.

https://github.com/llvm/llvm-project/commit/a4e35cc2ec1036832e7626191f8b9f0e3169477c

Sep 15 2020, 3:51 PM · Restricted Project
volkan committed rGa4e35cc2ec10: GlobalISel: Add combines for G_TRUNC (authored by volkan).
GlobalISel: Add combines for G_TRUNC
Sep 15 2020, 3:51 PM

Sep 10 2020

volkan committed rGd4bf90271fa9: GlobalISel: Combine fneg(fneg x) to x (authored by volkan).
GlobalISel: Combine fneg(fneg x) to x
Sep 10 2020, 12:58 PM
volkan closed D87473: GlobalISel: Combine fneg(fneg x) to x.

https://github.com/llvm/llvm-project/commit/d4bf90271fa988101bdad4f2e78b8c3a0b85fc2d

Sep 10 2020, 12:58 PM · Restricted Project
volkan requested review of D87473: GlobalISel: Combine fneg(fneg x) to x.
Sep 10 2020, 11:21 AM · Restricted Project

Sep 8 2020

volkan committed rG1242dd330d90: GlobalISel: Combine `op undef, x` to 0 (authored by volkan).
GlobalISel: Combine `op undef, x` to 0
Sep 8 2020, 9:47 AM
volkan closed D86611: GlobalISel: Combine `op undef, x` to 0.

https://github.com/llvm/llvm-project/commit/1242dd330d9054a57c1403f16d5487f9e3a3a92f

Sep 8 2020, 9:47 AM · Restricted Project

Sep 3 2020

volkan added inline comments to D86611: GlobalISel: Combine `op undef, x` to 0.
Sep 3 2020, 9:06 AM · Restricted Project

Sep 2 2020

volkan updated the diff for D87050: GlobalISel: Add combines for G_TRUNC.

Updated the patch based on the feedback.

Sep 2 2020, 3:33 PM · Restricted Project
volkan added inline comments to D87050: GlobalISel: Add combines for G_TRUNC.
Sep 2 2020, 3:30 PM · Restricted Project
volkan requested review of D87050: GlobalISel: Add combines for G_TRUNC.
Sep 2 2020, 12:11 PM · Restricted Project

Sep 1 2020

volkan closed D86516: GlobalISel: Add combines for extend operations.

Committed in https://github.com/llvm/llvm-project/commit/061182b7baf879badc9ff82c88d383d2d9ce279b.

Sep 1 2020, 8:51 AM · Restricted Project
volkan committed rG061182b7baf8: GlobalISel: Add combines for extend operations (authored by volkan).
GlobalISel: Add combines for extend operations
Sep 1 2020, 8:51 AM

Aug 31 2020

volkan updated the diff for D86516: GlobalISel: Add combines for extend operations.
  • Use setInstrAndDebugLoc .
  • Use replaceRegWith to replace registers.
Aug 31 2020, 1:18 PM · Restricted Project
volkan updated the diff for D86516: GlobalISel: Add combines for extend operations.
  • Added vector tests.
Aug 31 2020, 11:05 AM · Restricted Project
volkan updated the diff for D86611: GlobalISel: Combine `op undef, x` to 0.
  • Fixed liveins.
Aug 31 2020, 10:29 AM · Restricted Project
volkan updated the diff for D86611: GlobalISel: Combine `op undef, x` to 0.
  • Added a test case with vector type.
Aug 31 2020, 10:19 AM · Restricted Project
volkan added inline comments to D86611: GlobalISel: Combine `op undef, x` to 0.
Aug 31 2020, 10:19 AM · Restricted Project

Aug 26 2020

volkan set the repository for D86611: GlobalISel: Combine `op undef, x` to 0 to rG LLVM Github Monorepo.
Aug 26 2020, 4:32 AM · Restricted Project
volkan requested review of D86611: GlobalISel: Combine `op undef, x` to 0.
Aug 26 2020, 4:32 AM · Restricted Project

Aug 25 2020

volkan requested review of D86516: GlobalISel: Add combines for extend operations.
Aug 25 2020, 3:22 AM · Restricted Project

May 21 2020

volkan accepted D80413: [docs][llvm-extract] Add missing alias/bb options.

LGTM except the issue above. Thanks for updating the docs.

May 21 2020, 5:53 PM · Restricted Project
volkan accepted D80346: [llvm-extract] Fix basic block extraction by delaying search until the function is materialized.

LGTM.

May 21 2020, 5:53 PM · Restricted Project

May 18 2020

volkan committed rG63081dc6f642: LoadStoreVectorizer: Match nested adds to prove vectorization is safe (authored by volkan).
LoadStoreVectorizer: Match nested adds to prove vectorization is safe
May 18 2020, 12:27 PM
volkan closed D79817: LoadStoreVectorizer: Match nested adds to prove vectorization is safe.

Committed in 63081dc6f64.

May 18 2020, 12:26 PM · Restricted Project

May 13 2020

volkan updated the diff for D79817: LoadStoreVectorizer: Match nested adds to prove vectorization is safe.
  • Removed the irrelevant changes that I accidentally added.
May 13 2020, 10:50 AM · Restricted Project
volkan updated the diff for D79817: LoadStoreVectorizer: Match nested adds to prove vectorization is safe.
  • Reduced the test and the number of check lines.
  • Added a test with nuw.
  • Added a negative test.
May 13 2020, 10:17 AM · Restricted Project

May 12 2020

volkan added inline comments to D79817: LoadStoreVectorizer: Match nested adds to prove vectorization is safe.
May 12 2020, 5:48 PM · Restricted Project
volkan created D79817: LoadStoreVectorizer: Match nested adds to prove vectorization is safe.
May 12 2020, 3:37 PM · Restricted Project

Mar 24 2020

volkan accepted D76652: [AArch64][GlobalISel] Don't localize TLS G_GLOBAL_VALUEs on Darwin..

LGTM.

Mar 24 2020, 10:11 AM · Restricted Project

Mar 2 2020

volkan committed rG4167645d1e6a: GlobalISel: Move Localizer::shouldLocalize(..) to TargetLowering (authored by volkan).
GlobalISel: Move Localizer::shouldLocalize(..) to TargetLowering
Mar 2 2020, 9:30 AM
volkan closed D75207: GlobalISel: Move Localizer::shouldLocalize(..) to TargetLowering.

Committed in 4167645d1e6a5ecc8790f0aba450799c4441882d.

Mar 2 2020, 9:30 AM · Restricted Project

Feb 27 2020

volkan added a comment to D75207: GlobalISel: Move Localizer::shouldLocalize(..) to TargetLowering.

The change itself is ok but is there any way to have more granular overriding of this behavior, instead of overriding the whole shouldLocalize()?

Feb 27 2020, 12:23 PM · Restricted Project

Feb 26 2020

volkan created D75207: GlobalISel: Move Localizer::shouldLocalize(..) to TargetLowering.
Feb 26 2020, 12:17 PM · Restricted Project

Feb 14 2020

volkan committed rG187686a22f97: [GlobalISel] LegalizationArtifactCombiner: Fix a bug in tryCombineMerges (authored by volkan).
[GlobalISel] LegalizationArtifactCombiner: Fix a bug in tryCombineMerges
Feb 14 2020, 10:49 AM
volkan closed D70564: [GlobalISel] LegalizationArtifactCombiner: Fix a bug in tryCombineMerges.

Committed in 187686a22f97662c981b9bffb998b6010ae1c401.

Feb 14 2020, 10:48 AM · Restricted Project
volkan updated the diff for D70564: [GlobalISel] LegalizationArtifactCombiner: Fix a bug in tryCombineMerges.
  • Simplified llvm::canReplaceReg(..) a bit more.
Feb 14 2020, 10:12 AM · Restricted Project
volkan added a reviewer for D73031: GlobalISel: Lower s64->s16 G_FPTRUNC: volkan.
Feb 14 2020, 10:12 AM · Restricted Project
volkan accepted D73031: GlobalISel: Lower s64->s16 G_FPTRUNC.

LGTM.

Feb 14 2020, 10:12 AM · Restricted Project

Feb 5 2020

volkan updated the diff for D70564: [GlobalISel] LegalizationArtifactCombiner: Fix a bug in tryCombineMerges.
  • Simplified llvm::canReplaceReg(..).
Feb 5 2020, 12:21 PM · Restricted Project
volkan updated the diff for D70564: [GlobalISel] LegalizationArtifactCombiner: Fix a bug in tryCombineMerges.
  • Rebased and updated based on the feedback.
Feb 5 2020, 11:12 AM · Restricted Project

Dec 18 2019

volkan accepted D69152: [gicombiner] Add GIMatchTree and use it for the code generation.

LGTM.

Dec 18 2019, 3:07 PM · Restricted Project

Dec 5 2019

volkan committed rGbfa3d260b823: [GlobalISel] Localizer: Allow targets not to run the pass conditionally (authored by volkan).
[GlobalISel] Localizer: Allow targets not to run the pass conditionally
Dec 5 2019, 11:11 AM
volkan closed D71038: [GlobalISel] Localizer: Allow targets not to run the pass conditionally.
Dec 5 2019, 11:11 AM · Restricted Project

Dec 4 2019

volkan created D71038: [GlobalISel] Localizer: Allow targets not to run the pass conditionally.
Dec 4 2019, 4:04 PM · Restricted Project

Dec 3 2019

volkan accepted D70922: [GlobalISel]: Allow targets to override how to widen constants during legalization.

LGTM with a nit.

Dec 3 2019, 9:56 AM · Restricted Project

Dec 2 2019

volkan updated the diff for D70564: [GlobalISel] LegalizationArtifactCombiner: Fix a bug in tryCombineMerges.
  • Removed XFAILs.
Dec 2 2019, 12:53 PM · Restricted Project
volkan added inline comments to D70564: [GlobalISel] LegalizationArtifactCombiner: Fix a bug in tryCombineMerges.
Dec 2 2019, 12:37 PM · Restricted Project
volkan committed rG3d02fa6da7d2: [GlobalISel] CombinerHelper: Fix a bug in matchCombineCopy (authored by volkan).
[GlobalISel] CombinerHelper: Fix a bug in matchCombineCopy
Dec 2 2019, 12:25 PM
volkan closed D70616: [GlobalISel] CombinerHelper: Fix a bug in matchCombineCopy.
Dec 2 2019, 12:25 PM · Restricted Project

Nov 22 2019

volkan added inline comments to D70564: [GlobalISel] LegalizationArtifactCombiner: Fix a bug in tryCombineMerges.
Nov 22 2019, 3:20 PM · Restricted Project
volkan updated the diff for D70564: [GlobalISel] LegalizationArtifactCombiner: Fix a bug in tryCombineMerges.
  • Notify the observer when replacing registers.
Nov 22 2019, 3:20 PM · Restricted Project
volkan updated the diff for D70564: [GlobalISel] LegalizationArtifactCombiner: Fix a bug in tryCombineMerges.
  • Added a function called canReplaceReg to share the code.
  • Added a function called replaceRegOrBuildCopy that tries to replace the registers if the constraints match, and builds a COPY otherwise.
Nov 22 2019, 2:35 PM · Restricted Project
volkan added inline comments to D70616: [GlobalISel] CombinerHelper: Fix a bug in matchCombineCopy.
Nov 22 2019, 2:25 PM · Restricted Project
volkan updated the diff for D70616: [GlobalISel] CombinerHelper: Fix a bug in matchCombineCopy.
  • Handle the cases where the registers don't have LLT.
Nov 22 2019, 2:16 PM · Restricted Project
volkan created D70616: [GlobalISel] CombinerHelper: Fix a bug in matchCombineCopy.
Nov 22 2019, 1:29 PM · Restricted Project
volkan added inline comments to D70564: [GlobalISel] LegalizationArtifactCombiner: Fix a bug in tryCombineMerges.
Nov 22 2019, 1:29 PM · Restricted Project
volkan added a comment to D70564: [GlobalISel] LegalizationArtifactCombiner: Fix a bug in tryCombineMerges.

RegbankSelect doesn't track newly created instruction and I had to set reg bank manually. Here is the patch that sets regbank for newly created COPY instructions

.

Thanks, I'll update the patch.

Nov 22 2019, 11:02 AM · Restricted Project
volkan added a comment to D70564: [GlobalISel] LegalizationArtifactCombiner: Fix a bug in tryCombineMerges.

RegbankSelect doesn't track newly created instruction and I had to set reg bank manually. Here is the patch that sets regbank for newly created COPY instructions

.

Nov 22 2019, 10:07 AM · Restricted Project

Nov 21 2019

volkan added a comment to D70564: [GlobalISel] LegalizationArtifactCombiner: Fix a bug in tryCombineMerges.

@Petar.Avramovic Could you take a look at the failing Mips tests?

Nov 21 2019, 1:35 PM · Restricted Project
volkan created D70564: [GlobalISel] LegalizationArtifactCombiner: Fix a bug in tryCombineMerges.
Nov 21 2019, 1:35 PM · Restricted Project

Nov 15 2019

volkan accepted D69147: [gicombiner] Add support for arbitrary match data being passed from match to apply.

LGTM.

Nov 15 2019, 10:50 AM · Restricted Project
volkan accepted D69117: [gicombiner] Process the MatchDag such that every node is reachable from the roots.

LGTM with a couple of nits.

Nov 15 2019, 10:41 AM · Restricted Project
volkan accepted D69077: [gicombiner] Add the MatchDag structure and parse instruction DAG's from the input.

LGTM with a few nits.

Nov 15 2019, 10:23 AM · Restricted Project

Nov 5 2019

volkan accepted D69151: [gicombiner] Import tryCombineIndexedLoadStore().

LGTM.

Nov 5 2019, 8:44 PM · Restricted Project
volkan accepted D69645: [globalisel][docs] Add a section about debugging with the block extractor.

Thanks Daniel, LGTM.

Nov 5 2019, 11:52 AM · Restricted Project

Oct 28 2019

volkan accepted D69456: [globalisel][docs] Rewrite the pipeline overview.

LGTM with a nit.

Oct 28 2019, 2:37 PM · Restricted Project

Oct 16 2019

volkan accepted D68426: [gicombiner] Hoist pure C++ combine into the tablegen definition.

Thanks for explaining, LGTM.

Oct 16 2019, 4:04 PM · Restricted Project
volkan added inline comments to D68426: [gicombiner] Hoist pure C++ combine into the tablegen definition.
Oct 16 2019, 1:27 PM · Restricted Project
volkan accepted D68628: GlobalISel: Implement lower for G_SADDO/G_SSUBO.

LGTM.

Oct 16 2019, 12:59 PM
volkan added a reviewer for D68628: GlobalISel: Implement lower for G_SADDO/G_SSUBO: volkan.
Oct 16 2019, 12:59 PM

Oct 15 2019

volkan accepted D68438: [gicombiner] Add the run-time rule disable option.

LGTM.

Oct 15 2019, 5:54 PM · Restricted Project
volkan added inline comments to D68438: [gicombiner] Add the run-time rule disable option.
Oct 15 2019, 2:14 PM · Restricted Project

Oct 8 2019

volkan added a reviewer for D68479: GlobalISel: Implement fewerElementsVector for G_BUILD_VECTOR: volkan.
Oct 8 2019, 3:02 PM
volkan accepted D68479: GlobalISel: Implement fewerElementsVector for G_BUILD_VECTOR.

LGTM.

Oct 8 2019, 3:02 PM

Oct 2 2019

volkan added inline comments to D68288: [gicombiner] Add a CodeExpander to handle C++ fragments with variable expansion.
Oct 2 2019, 12:00 PM · Restricted Project
volkan accepted D68288: [gicombiner] Add a CodeExpander to handle C++ fragments with variable expansion.

LGTM.

Oct 2 2019, 11:58 AM · Restricted Project

Oct 1 2019

volkan accepted D68286: [gicombiner] Add the boring boilerplate for the declarative combiner.

LGTM with a nit.

Oct 1 2019, 11:58 AM · Restricted Project

Sep 13 2019

volkan added a reviewer for D67570: [GlobalISel] Fix insertion point of new instructions to be after PHIs: volkan.
Sep 13 2019, 2:21 PM · Restricted Project
volkan accepted D67570: [GlobalISel] Fix insertion point of new instructions to be after PHIs.

LGTM.

Sep 13 2019, 2:21 PM · Restricted Project

Aug 30 2019

volkan committed rL370538: Request commit access for volkan.
Request commit access for volkan
Aug 30 2019, 3:00 PM

Aug 23 2019

volkan committed rG277631e3b8dd: [GlobalISel] Legalizer: Retry combining illegal artifacts as long as there new… (authored by volkan).
[GlobalISel] Legalizer: Retry combining illegal artifacts as long as there new…
Aug 23 2019, 1:31 PM
volkan committed rL369805: [GlobalISel] Legalizer: Retry combining illegal artifacts as long as there new….
[GlobalISel] Legalizer: Retry combining illegal artifacts as long as there new…
Aug 23 2019, 1:31 PM
volkan closed D65894: [GlobalISel] Legalizer: Retry combining illegal artifacts as long as there new artifacts.
Aug 23 2019, 1:31 PM · Restricted Project
volkan added a comment to D65894: [GlobalISel] Legalizer: Retry combining illegal artifacts as long as there new artifacts.

@arsenm Could you take a look at the AMDGPU tests?

Aug 23 2019, 11:19 AM · Restricted Project
volkan updated the diff for D65894: [GlobalISel] Legalizer: Retry combining illegal artifacts as long as there new artifacts.

Rebased.

Aug 23 2019, 11:19 AM · Restricted Project

Aug 20 2019

volkan added a comment to D61787: [GlobalISel Legalizer] Improve artifact combiner.

Hi Petar,

Aug 20 2019, 3:28 PM · Restricted Project

Aug 15 2019

volkan committed rG0ae6006bee0e: [GlobalISel] CSEMIRBuilder: Add support for G_GEP (authored by volkan).
[GlobalISel] CSEMIRBuilder: Add support for G_GEP
Aug 15 2019, 4:46 PM
volkan committed rL369070: [GlobalISel] CSEMIRBuilder: Add support for G_GEP.
[GlobalISel] CSEMIRBuilder: Add support for G_GEP
Aug 15 2019, 4:45 PM
volkan closed D66316: [GlobalISel] CSEMIRBuilder: Add support for G_GEP.
Aug 15 2019, 4:45 PM · Restricted Project
volkan updated the summary of D66316: [GlobalISel] CSEMIRBuilder: Add support for G_GEP.
Aug 15 2019, 3:41 PM · Restricted Project
volkan created D66316: [GlobalISel] CSEMIRBuilder: Add support for G_GEP.
Aug 15 2019, 3:15 PM · Restricted Project
volkan abandoned D66315: [GlobalISel] CSEMIRBuilder: Add support for G_GEP.
Aug 15 2019, 3:11 PM · Restricted Project
volkan created D66315: [GlobalISel] CSEMIRBuilder: Add support for G_GEP.
Aug 15 2019, 3:11 PM · Restricted Project

Aug 12 2019

volkan accepted D66039: [GlobalISel]: Fix a bug in KnownBits where we should have been using SizeInBits.

LGTM.

Aug 12 2019, 1:55 PM · Restricted Project