- User Since
- Jul 8 2015, 10:26 AM (289 w, 4 d)
Thu, Jan 21
Fri, Jan 8
Reduce the test a bit further.
Looks good to me as-is. Thanks!
Fix a typo in the test.
Add a clang driver test.
The issue is that InitLLVM initializes its private PrettyStackPrinter before installing the one-shot default SIGPIPE handler: the PrettyStackPrinter itself eventually calls RegisterHandlers(), which runs before the SIGPIPE handler is installed and therefore doesn't register a SIGPIPE handler.
Thanks, I've landed this change as bf401256edd0.
Thu, Jan 7
Unfortunately I can’t get to this right now, but will take a look first thing tomorrow morning.
Tue, Jan 5
Sun, Jan 3
In its current form, the rule for preserving debug locs doesn't seem to apply here (https://llvm.org/docs/HowToUpdateDebugInfo.html#when-to-preserve-an-instruction-location). Imho we ought to revise the guidance there before proceeding with this patch (e.g. by adding some carveout for when the destination debug loc is the same). If you can share, it might also help to have a little context - unless there's some intervening optimization, the dwarf generator's location cascade should kick in in this situation?
Dec 15 2020
Hi @xiangzhangllvm, apologies for the delay.
Dec 11 2020
Dec 3 2020
Dec 2 2020
Dec 1 2020
Nov 30 2020
The error handling additions look good to me, but I don't have the background to lgtm InstrProfWriter::validateRecord. cc @xur.
Thank you, lgtm!
Hi @OikawaKirie, thanks for the patch! Would you mind splitting up this patch? This should make each individual patch easier to review, and make it possible for changes to land incrementally (& faster). Generally we ask for patches to be split up into self-contained units: it's not an exact science, but splitting things up by directory might be a reasonable heuristic to start with.
Nov 11 2020
Nov 10 2020
Simplify, using run_to_source_breakpoint.
Nov 5 2020
Make the dummy target per-debugger.
Delete some dead code.
Nov 4 2020
Looks good to me.
Nov 3 2020
In the example, what pass/component is responsible for creating %1 = bitcast i32* %0 to i8*?
Thanks, lgtm with two comments --
Nov 2 2020
I might've missed it, but the debug location merging behavior could use a test. Here's one way to write it: https://godbolt.org/z/Yb9PY9.
Oct 30 2020
Oct 29 2020
Oct 28 2020
It looks like verifyFunction asserts that the DISubprogram attached to any function, declaration or definition, is distinct:
Jonas walked me through some of the issues here offline:
- Looks like this makes testing depend on having a configured lldb-env tool, this will make it hard to run testing against an lldb root.
- If we need to launch ./bin/lldb in some other workflow, we can consider having lldb-env derive all the info it needs from a root lit.site.cfg.py.
Re: making the lit.site.cfg self-contained, IIUC the situation is that there are a couple places where we shell out via subprocess, but that you'd like to get rid of these? I wonder whether we could bundle up the necessary scripts along with lit.site.cfg instead.
My remark was not so much about the need for another tool but rather the need to configure it. Right now I can hand-write a lit.site.cfg.py, omit a bunch of values, and point lit to it. With this tool I'd need to also configure it (i.e. replacing @LLVM_USE_SANITIZER@ and @CMAKE_CXX_COMPILER@.
Oct 27 2020
Test changes look reasonable to me!
@wallace thanks for winnowing the test objects. I left an inline suggestion about simplifying the error-handling in IntelPTInstruction. Other than that, mechanically this is looking good. Thanks!
Oct 26 2020
Friendly ping. On the assumption that the debug inst cleanup in MergeBlockIntoPredecessor was intended to be a compile-time optimization, I propose making it opt-in as the performance impact can be unexpected. I.e., I suggest that we land D88928 soon-ish (tomorrow barring any concerns/objections).
Oct 22 2020
Oct 21 2020
To my knowledge, we're not relying on the fact that branch_weights are 32-bit for bitcode compatibility purposes, or for PGO. We do support using older .profdata files with newer builds, but (afaict) this change to branch_weights does not affect that.
- Actually fix the size of the DILocalVar.
- Use DW_OP_bit_piece to implement the legacy zext.