Page MenuHomePhabricator

[mlir] Rename CMake target MLIRQuantOps to MLIRQuant
ClosedPublic

Authored by marbre on Mar 19 2020, 10:34 AM.

Details

Summary

With commit 4d60f47 VectorOps was renamed to Vector and the naming of the CMake target was adjusted. With commit 363dd3f QuantOps was renamed to Quant, but the naming of the CMake target is left untouched. This renames the CMake target.

Diff Detail

Event Timeline

marbre created this revision.Mar 19 2020, 10:34 AM
marbre edited the summary of this revision. (Show Details)Mar 19 2020, 10:34 AM
marbre added reviewers: rsuderman, rriddle.
rriddle accepted this revision.Mar 19 2020, 10:59 AM
This revision is now accepted and ready to land.Mar 19 2020, 10:59 AM
rsuderman accepted this revision.Mar 19 2020, 3:42 PM

@rriddle I would appreciate if you or someone else could commit on my behalf.

Gentle ping. I would be happy if someone could commit the patch on my behalf.

@marbre It looks like there no commit information in the revision. How do you want to be acknowledged? In the future, if you use arc to upload your commit, then this happens automatically.

@marbre It looks like there no commit information in the revision. How do you want to be acknowledged? In the future, if you use arc to upload your commit, then this happens automatically.

That's strange, I am quite sure I followed https://llvm.org/docs/Phabricator.html#requesting-a-review-via-the-web-interface and did everything like before where commit information was available. "Author: Marius Brehler <marius.brehler@iml.fraunhofer.de>" would be great!

This was committed, but I did fix up the link back to the review so it wasn't automatically closed. @marbre clearly I need to get better at this :)

@marbre It looks like there no commit information in the revision. How do you want to be acknowledged? In the future, if you use arc to upload your commit, then this happens automatically.

That's strange, I am quite sure I followed https://llvm.org/docs/Phabricator.html#requesting-a-review-via-the-web-interface

Without arc, many things aren't working as smoothly (like the CI), it would be much better if you could use it.

@marbre It looks like there no commit information in the revision. How do you want to be acknowledged? In the future, if you use arc to upload your commit, then this happens automatically.

That's strange, I am quite sure I followed https://llvm.org/docs/Phabricator.html#requesting-a-review-via-the-web-interface

Without arc, many things aren't working as smoothly (like the CI), it would be much better if you could use it.

Already installed arc and will use it for future revisions.

This was committed, but I did fix up the link back to the review so it wasn't automatically closed. @marbre clearly I need to get better at this :)

And I will use arc next time ;) Thank you very much for commiting my changes and taking care!