This is an archive of the discontinued LLVM Phabricator instance.

[clang][CGStmt] emit i constraint rather than X for asm goto indirect dests
ClosedPublic

Authored by nickdesaulniers on Dec 7 2021, 5:44 PM.

Diff Detail

Event Timeline

nickdesaulniers requested review of this revision.Dec 7 2021, 5:44 PM
nickdesaulniers created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptDec 7 2021, 5:44 PM
Herald added a subscriber: cfe-commits. · View Herald Transcript
nickdesaulniers planned changes to this revision.Dec 7 2021, 5:44 PM
Herald added a project: Restricted Project. · View Herald TranscriptDec 8 2021, 4:58 PM
nickdesaulniers retitled this revision from [WIP] alternative approach to D114895 to [clang][CGStmt] emit i constraint rather than X for asm goto indirect dests.
nickdesaulniers edited the summary of this revision. (Show Details)
  • verbatim
nickdesaulniers edited the summary of this revision. (Show Details)Dec 8 2021, 5:00 PM
nickdesaulniers planned changes to this revision.Dec 8 2021, 5:45 PM
nickdesaulniers added inline comments.
llvm/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp
8556

ugh, I didn't mean to post this hunk. I've been struggling with arc today. let me try to fix this.

  • try to update this correctly

This looks reasonable to me, but I'd like to wait for a conclusion on D115409 first. (Which probably will result in rewriting the commit message, as well).

nickdesaulniers edited the summary of this revision. (Show Details)
void accepted this revision.Dec 21 2021, 12:24 PM
This revision is now accepted and ready to land.Dec 21 2021, 12:24 PM
jyknight accepted this revision.Jan 7 2022, 12:02 PM
This revision was landed with ongoing or failed builds.Jan 11 2022, 11:49 AM
This revision was automatically updated to reflect the committed changes.