Page MenuHomePhabricator

nickdesaulniers (Nick Desaulniers)
Google

Projects

User does not belong to any projects.

User Details

User Since
Apr 13 2018, 4:23 PM (196 w, 5 d)

Recent Activity

Fri, Jan 14

nickdesaulniers added inline comments to D115419: [PowerPC] Allow absolute expressions in relocations.
Fri, Jan 14, 3:46 PM · Restricted Project

Wed, Jan 12

nickdesaulniers accepted D116939: [AArch64] clang support for Armv8.8/9.3 HBC.
Wed, Jan 12, 11:17 AM · Restricted Project, Restricted Project

Tue, Jan 11

nickdesaulniers committed rG5c562f62a4ee: [clang] number labels in asm goto strings after tied inputs (authored by nickdesaulniers).
[clang] number labels in asm goto strings after tied inputs
Tue, Jan 11, 12:10 PM
nickdesaulniers closed D115471: [clang] number labels in asm goto strings after tied inputs.
Tue, Jan 11, 12:10 PM · Restricted Project
nickdesaulniers committed rGc8463fd22b1f: [clang][CGStmt] emit i constraint rather than X for asm goto indirect dests (authored by nickdesaulniers).
[clang][CGStmt] emit i constraint rather than X for asm goto indirect dests
Tue, Jan 11, 11:49 AM
nickdesaulniers closed D115311: [clang][CGStmt] emit i constraint rather than X for asm goto indirect dests.
Tue, Jan 11, 11:49 AM · Restricted Project, Restricted Project
nickdesaulniers committed rG79ebc3b0dd13: [llvm][test] rewrite callbr to use i rather than X constraint NFC (authored by nickdesaulniers).
[llvm][test] rewrite callbr to use i rather than X constraint NFC
Tue, Jan 11, 11:31 AM
nickdesaulniers closed D115410: [llvm][test] rewrite callbr to use i rather than X constraint NFC.
Tue, Jan 11, 11:31 AM · Restricted Project, Restricted Project
nickdesaulniers committed rG4edb9983cb8c: [SelectionDAG] treat X constrained labels as i for asm (authored by nickdesaulniers).
[SelectionDAG] treat X constrained labels as i for asm
Tue, Jan 11, 10:30 AM
nickdesaulniers closed D115688: [SelectionDAG] treat X constrained labels as i for asm.
Tue, Jan 11, 10:30 AM · Restricted Project
nickdesaulniers committed rG9c4b49db1928: [ShrinkWrap] check for PPC's non-callee-saved LR (authored by nickdesaulniers).
[ShrinkWrap] check for PPC's non-callee-saved LR
Tue, Jan 11, 10:15 AM
nickdesaulniers closed D116424: [ShrinkWrap] check for PPC's non-callee-saved LR.
Tue, Jan 11, 10:15 AM · Restricted Project

Mon, Jan 10

nickdesaulniers updated the diff for D115688: [SelectionDAG] treat X constrained labels as i for asm.
  • rebase on pre-committed TargetLowering refactor
Mon, Jan 10, 6:36 PM · Restricted Project
nickdesaulniers committed rG649b11ef8bcd: git-clang-format HEAD~ (authored by nickdesaulniers).
git-clang-format HEAD~
Mon, Jan 10, 6:34 PM
nickdesaulniers committed rG301e91174002: [TargetLowering] precommit refactor from D115688 NFC (authored by nickdesaulniers).
[TargetLowering] precommit refactor from D115688 NFC
Mon, Jan 10, 6:32 PM
nickdesaulniers updated the diff for D115688: [SelectionDAG] treat X constrained labels as i for asm.
Mon, Jan 10, 5:16 PM · Restricted Project
nickdesaulniers updated the diff for D116424: [ShrinkWrap] check for PPC's non-callee-saved LR.
  • rebase
Mon, Jan 10, 4:59 PM · Restricted Project
nickdesaulniers added inline comments to D116424: [ShrinkWrap] check for PPC's non-callee-saved LR.
Mon, Jan 10, 3:00 PM · Restricted Project
nickdesaulniers updated the diff for D116424: [ShrinkWrap] check for PPC's non-callee-saved LR.
  • check for !MI.isReturn() rather than MO.isEarlyClobber
Mon, Jan 10, 2:59 PM · Restricted Project
nickdesaulniers added inline comments to D116424: [ShrinkWrap] check for PPC's non-callee-saved LR.
Mon, Jan 10, 2:13 PM · Restricted Project
nickdesaulniers added a comment to D98895: [X86][clang] Disable long double type for -mno-x87 option.

Linus Torvalds thoughts on the patches as a result of this change.

Mon, Jan 10, 11:59 AM · Restricted Project
nickdesaulniers added inline comments to D116939: [AArch64] clang support for Armv8.8/9.3 HBC.
Mon, Jan 10, 10:54 AM · Restricted Project, Restricted Project

Fri, Jan 7

nickdesaulniers added inline comments to D116424: [ShrinkWrap] check for PPC's non-callee-saved LR.
Fri, Jan 7, 2:47 PM · Restricted Project
nickdesaulniers committed rG3a604fdbcd5f: [Clang][CFG] check children statements of asm goto (authored by nickdesaulniers).
[Clang][CFG] check children statements of asm goto
Fri, Jan 7, 2:21 PM
nickdesaulniers closed D116059: [Clang][CFG] check children statements of asm goto.
Fri, Jan 7, 2:20 PM · Restricted Project

Thu, Jan 6

nickdesaulniers added inline comments to D116059: [Clang][CFG] check children statements of asm goto.
Thu, Jan 6, 4:26 PM · Restricted Project
nickdesaulniers updated subscribers of D116424: [ShrinkWrap] check for PPC's non-callee-saved LR.

Can anyone from @ppc-slack @power-llvm-team @PowerPC help review?

Thu, Jan 6, 3:55 PM · Restricted Project
nickdesaulniers updated the diff for D116059: [Clang][CFG] check children statements of asm goto.
  • MOAR TESTS RAWR!!1one
Thu, Jan 6, 2:06 PM · Restricted Project
nickdesaulniers planned changes to D116059: [Clang][CFG] check children statements of asm goto.

will add more tests

Thu, Jan 6, 12:30 PM · Restricted Project
nickdesaulniers updated the diff for D116059: [Clang][CFG] check children statements of asm goto.
  • add previously red -Warray-bounds test
Thu, Jan 6, 12:29 PM · Restricted Project
nickdesaulniers planned changes to D116059: [Clang][CFG] check children statements of asm goto.
Thu, Jan 6, 12:21 PM · Restricted Project
nickdesaulniers added a comment to D116059: [Clang][CFG] check children statements of asm goto.

Do we have testcases for how -Wuninitialized/-Wmaybe-uninitialized interact with asm goto?

Thu, Jan 6, 12:05 PM · Restricted Project
nickdesaulniers updated the diff for D116424: [ShrinkWrap] check for PPC's non-callee-saved LR.
  • revert back to Diff 397682 (trivial target-independent function)
Thu, Jan 6, 10:56 AM · Restricted Project
nickdesaulniers added inline comments to D116424: [ShrinkWrap] check for PPC's non-callee-saved LR.
Thu, Jan 6, 10:46 AM · Restricted Project

Wed, Jan 5

nickdesaulniers updated the diff for D116059: [Clang][CFG] check children statements of asm goto.
  • don't bother checking if a Val is Initialized
Wed, Jan 5, 3:30 PM · Restricted Project
nickdesaulniers added inline comments to D116424: [ShrinkWrap] check for PPC's non-callee-saved LR.
Wed, Jan 5, 3:14 PM · Restricted Project
nickdesaulniers added inline comments to D116424: [ShrinkWrap] check for PPC's non-callee-saved LR.
Wed, Jan 5, 2:43 PM · Restricted Project
nickdesaulniers updated the diff for D116424: [ShrinkWrap] check for PPC's non-callee-saved LR.
  • add some asserts, make base isNonallocatableRegisterCalleeSave actually do work.
Wed, Jan 5, 2:42 PM · Restricted Project
nickdesaulniers added a comment to D116424: [ShrinkWrap] check for PPC's non-callee-saved LR.

but I guess we can leave that for a followup, if anyone hacking on the PPC backend is interested.

Wed, Jan 5, 1:59 PM · Restricted Project
nickdesaulniers added a comment to D116424: [ShrinkWrap] check for PPC's non-callee-saved LR.

Do we need coverage for lr use and/or def, in addition to clobber?

Wed, Jan 5, 1:39 PM · Restricted Project
nickdesaulniers updated the diff for D116424: [ShrinkWrap] check for PPC's non-callee-saved LR.
  • restore previous short circuiting logic
Wed, Jan 5, 12:47 PM · Restricted Project
nickdesaulniers updated the diff for D116424: [ShrinkWrap] check for PPC's non-callee-saved LR.
  • rewrite with new TargetRegisterInfo interface
Wed, Jan 5, 12:40 PM · Restricted Project
nickdesaulniers added a comment to D116424: [ShrinkWrap] check for PPC's non-callee-saved LR.

From the test changes, it looks like the current patch completely disables shrink-wrapping in all cases? Or am I missing something?

Doesn't @loopInfoRestoreOutsideLoop in llvm/test/CodeGen/PowerPC/ppc-shrink-wrapping.ll show that that's NOT the case? The mflr/mtlr pair are sunk+raised respectively since the entry block is conditional and doesn't use the stack.

@foo in llvm/test/CodeGen/PowerPC/ppc-shrink-wrapping.ll also has an early return rather than an unconditional prolog. bgelr (branch to lr if greater than or equal to). Compared to the codegen with shrink wrap disabled, the mflr/mtlr pair is unconditional.

Though I'm less convinced about @@shrinkwrap in llvm/test/CodeGen/PowerPC/ppc64-rop-protection.ll and @test in llvm/test/CodeGen/PowerPC/pr43527.ll.

Maybe verify that llvm/test/CodeGen/PowerPC/ppc-shrink-wrapping.ll shrink-wraps in both 32-bit and 64-bit modes?

In any case, the patch is clearly having some effect beside the one you're trying for.

Wed, Jan 5, 12:24 PM · Restricted Project
nickdesaulniers added a comment to D116424: [ShrinkWrap] check for PPC's non-callee-saved LR.

From the test changes, it looks like the current patch completely disables shrink-wrapping in all cases? Or am I missing something?

Wed, Jan 5, 11:28 AM · Restricted Project

Tue, Jan 4

nickdesaulniers accepted D116589: Don't override __attribute__((no_stack_protector)) by inlining.
Tue, Jan 4, 2:58 PM · Restricted Project
nickdesaulniers updated the diff for D116424: [ShrinkWrap] check for PPC's non-callee-saved LR.
  • add LR and LR8 to a few other CallingConventions
Tue, Jan 4, 2:13 PM · Restricted Project
nickdesaulniers added a reviewer for D116424: [ShrinkWrap] check for PPC's non-callee-saved LR: Restricted Project.
Tue, Jan 4, 2:04 PM · Restricted Project
nickdesaulniers added inline comments to D116424: [ShrinkWrap] check for PPC's non-callee-saved LR.
Tue, Jan 4, 2:04 PM · Restricted Project
nickdesaulniers updated the diff for D116424: [ShrinkWrap] check for PPC's non-callee-saved LR.
  • rewrite; add LR to CalleeSavedRegs
Tue, Jan 4, 1:59 PM · Restricted Project
nickdesaulniers added inline comments to D116424: [ShrinkWrap] check for PPC's non-callee-saved LR.
Tue, Jan 4, 12:01 PM · Restricted Project
nickdesaulniers added inline comments to D116424: [ShrinkWrap] check for PPC's non-callee-saved LR.
Tue, Jan 4, 11:58 AM · Restricted Project
nickdesaulniers added inline comments to D116424: [ShrinkWrap] check for PPC's non-callee-saved LR.
Tue, Jan 4, 11:48 AM · Restricted Project
nickdesaulniers added inline comments to D116424: [ShrinkWrap] check for PPC's non-callee-saved LR.
Tue, Jan 4, 10:47 AM · Restricted Project
nickdesaulniers planned changes to D116424: [ShrinkWrap] check for PPC's non-callee-saved LR.
Tue, Jan 4, 10:33 AM · Restricted Project
nickdesaulniers added a comment to D116589: Don't override __attribute__((no_stack_protector)) by inlining.

Is there a new test case that demonstrates behavior of an always_inline callee?

Tue, Jan 4, 9:50 AM · Restricted Project
nickdesaulniers added a comment to D116589: Don't override __attribute__((no_stack_protector)) by inlining.

Please add a link to https://gcc.gnu.org/bugzilla/show_bug.cgi?id=94722 in the commit description.

Tue, Jan 4, 9:43 AM · Restricted Project

Thu, Dec 30

nickdesaulniers added inline comments to D115688: [SelectionDAG] treat X constrained labels as i for asm.
Thu, Dec 30, 2:34 PM · Restricted Project
nickdesaulniers added inline comments to D101657: [PowerPC] Handle inline assembly clobber of link regsiter.
Thu, Dec 30, 2:31 PM · Restricted Project
nickdesaulniers requested review of D116424: [ShrinkWrap] check for PPC's non-callee-saved LR.
Thu, Dec 30, 2:30 PM · Restricted Project
nickdesaulniers updated subscribers of D101657: [PowerPC] Handle inline assembly clobber of link regsiter.
Thu, Dec 30, 1:25 PM · Restricted Project
nickdesaulniers accepted D116158: [ARM][AArch64] Introduce Armv9.3-A.
Thu, Dec 30, 10:09 AM · Restricted Project
nickdesaulniers accepted D116159: [ARM][AArch64] clang support for Armv9.3-A.
Thu, Dec 30, 10:07 AM · Restricted Project
nickdesaulniers accepted D116415: [Arm] Remove duplicate CPU tests.
Thu, Dec 30, 10:06 AM · Restricted Project

Wed, Dec 29

nickdesaulniers accepted D116156: [AArch64] Adding "armv8.8-a" BC instruction..
Wed, Dec 29, 2:31 PM · Restricted Project

Tue, Dec 28

nickdesaulniers added reviewers for D116341: [Opaqueptrs][IR Serialization] Improve inlineasm [de]serialization : efriedma, jyknight.
Tue, Dec 28, 1:39 PM · Restricted Project
nickdesaulniers committed rGcd284b7ac061: [clang][ARM] re-use arm::isHardTPSupported for hardware TLS check (authored by nickdesaulniers).
[clang][ARM] re-use arm::isHardTPSupported for hardware TLS check
Tue, Dec 28, 1:29 PM
nickdesaulniers closed D116233: [clang][ARM] re-use arm::isHardTPSupported for hardware TLS check.
Tue, Dec 28, 1:29 PM · Restricted Project
nickdesaulniers updated subscribers of D92156: [PowerPC] Add support for "tlbiel" with two arguments.
Tue, Dec 28, 12:38 PM · Restricted Project
nickdesaulniers added a comment to D92156: [PowerPC] Add support for "tlbiel" with two arguments.

It looks like this was worked around in the Linux kernel.
https://lore.kernel.org/llvm/20211221055904.555763-7-aik@ozlabs.ru/
https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git/commit/?h=next&id=62479e6e26ef18f00e2e540c0e30156254533a43

Tue, Dec 28, 12:37 PM · Restricted Project
nickdesaulniers added a comment to D115419: [PowerPC] Allow absolute expressions in relocations.

Thanks for the patch!

Tue, Dec 28, 12:13 PM · Restricted Project
nickdesaulniers added a reviewer for D115419: [PowerPC] Allow absolute expressions in relocations: nickdesaulniers.
Tue, Dec 28, 11:42 AM · Restricted Project
nickdesaulniers added inline comments to D116159: [ARM][AArch64] clang support for Armv9.3-A.
Tue, Dec 28, 11:33 AM · Restricted Project
nickdesaulniers added inline comments to D116158: [ARM][AArch64] Introduce Armv9.3-A.
Tue, Dec 28, 11:24 AM · Restricted Project
nickdesaulniers added a comment to D116157: [AArch64] Adding "armv8.8-a" memcpy/memset support..

The latest publicly accessible Arm ARM doesn't yet mention the v8.8 extensions, IIUC.
https://developer.arm.com/documentation/ddi0487/gb/
Is there perhaps a draft of the next revision I can refer to to review this patch?

Tue, Dec 28, 11:19 AM · Restricted Project
nickdesaulniers added a comment to D116156: [AArch64] Adding "armv8.8-a" BC instruction..

Can you please site the relevant section of the Arm ARM for these extensions in the commit message?

Tue, Dec 28, 11:11 AM · Restricted Project
nickdesaulniers accepted D116331: Documentation for the process of adding new targets.

LGTM; thanks for adding this. Reading through https://llvm.org/docs/DeveloperPolicy.html#adding-a-new-target, consider adding these numbered points under the bulleted list of points under The basic rules for a back-end to be upstreamed in experimental mode are:.

Tue, Dec 28, 10:41 AM · Restricted Project
nickdesaulniers accepted D116003: [NFC] Specify targets for clang stack-protector-guard.c.
Tue, Dec 28, 10:05 AM · Restricted Project

Thu, Dec 23

nickdesaulniers added inline comments to D116233: [clang][ARM] re-use arm::isHardTPSupported for hardware TLS check.
Thu, Dec 23, 1:52 PM · Restricted Project
nickdesaulniers requested review of D116233: [clang][ARM] re-use arm::isHardTPSupported for hardware TLS check.
Thu, Dec 23, 1:49 PM · Restricted Project
nickdesaulniers added inline comments to D116233: [clang][ARM] re-use arm::isHardTPSupported for hardware TLS check.
Thu, Dec 23, 1:49 PM · Restricted Project
nickdesaulniers planned changes to D116233: [clang][ARM] re-use arm::isHardTPSupported for hardware TLS check.
Thu, Dec 23, 1:00 PM · Restricted Project
nickdesaulniers requested review of D116233: [clang][ARM] re-use arm::isHardTPSupported for hardware TLS check.
Thu, Dec 23, 12:15 PM · Restricted Project

Tue, Dec 21

nickdesaulniers updated subscribers of D115688: [SelectionDAG] treat X constrained labels as i for asm.
Tue, Dec 21, 3:27 PM · Restricted Project

Dec 21 2021

nickdesaulniers added inline comments to D115410: [llvm][test] rewrite callbr to use i rather than X constraint NFC.
Dec 21 2021, 3:16 PM · Restricted Project, Restricted Project
nickdesaulniers added inline comments to D115688: [SelectionDAG] treat X constrained labels as i for asm.
Dec 21 2021, 3:07 PM · Restricted Project
nickdesaulniers accepted D116128: [clang][driver] Warn when '-mno-outline-atomics' is used with a non-AArch64 triple.
Dec 21 2021, 2:49 PM · Restricted Project
nickdesaulniers added inline comments to D115688: [SelectionDAG] treat X constrained labels as i for asm.
Dec 21 2021, 2:42 PM · Restricted Project
nickdesaulniers added inline comments to D115688: [SelectionDAG] treat X constrained labels as i for asm.
Dec 21 2021, 2:30 PM · Restricted Project
nickdesaulniers added inline comments to D115688: [SelectionDAG] treat X constrained labels as i for asm.
Dec 21 2021, 2:07 PM · Restricted Project

Dec 20 2021

nickdesaulniers added a comment to D115519: [llvm][docs] Describe how to work with patch series on Phabricator.

thanks for writing this! I didn't know about Depends on D...

Dec 20 2021, 7:39 PM · Restricted Project
nickdesaulniers added inline comments to D116059: [Clang][CFG] check children statements of asm goto.
Dec 20 2021, 4:23 PM · Restricted Project
nickdesaulniers updated the diff for D116059: [Clang][CFG] check children statements of asm goto.
  • VisitChildren rather than VisitStmt
Dec 20 2021, 3:55 PM · Restricted Project
nickdesaulniers planned changes to D116059: [Clang][CFG] check children statements of asm goto.
Dec 20 2021, 3:44 PM · Restricted Project
nickdesaulniers requested review of D116059: [Clang][CFG] check children statements of asm goto.
Dec 20 2021, 3:36 PM · Restricted Project
nickdesaulniers added inline comments to D115410: [llvm][test] rewrite callbr to use i rather than X constraint NFC.
Dec 20 2021, 11:40 AM · Restricted Project, Restricted Project
nickdesaulniers updated subscribers of D115688: [SelectionDAG] treat X constrained labels as i for asm.
Dec 20 2021, 11:29 AM · Restricted Project
nickdesaulniers updated the diff for D115688: [SelectionDAG] treat X constrained labels as i for asm.
  • update aarch64 test to check branch target
Dec 20 2021, 11:28 AM · Restricted Project
nickdesaulniers added a comment to D116003: [NFC] Specify targets for clang stack-protector-guard.c.

Thanks for the patch. You're right about this change, sorry I made the mistake!

Dec 20 2021, 9:52 AM · Restricted Project

Dec 14 2021

nickdesaulniers added inline comments to D115688: [SelectionDAG] treat X constrained labels as i for asm.
Dec 14 2021, 4:58 PM · Restricted Project
nickdesaulniers updated the diff for D115471: [clang] number labels in asm goto strings after tied inputs.
Dec 14 2021, 4:53 PM · Restricted Project