User Details
- User Since
- Oct 9 2018, 11:07 PM (130 w, 4 d)
Tue, Mar 30
When I run ninja install after this commit, it errors because it is trying to install to my /lib folder, was that intentional?
Thu, Mar 25
This breaks compiling the Linux kernel for RISC-V (defconfig):
Wed, Mar 24
Drop "riscv32" and "riscv64" from list of checked triples (thanks to Fangrui for catching it with a good explanation).
Tue, Mar 23
- Hoist MCountName assignment into RISCVTargetInfo
- Prevent MCountName from getting assigned in FreeBSD and OpenBSD targets
- Add more tests
Thu, Mar 18
Such a diff does not look too bad:
Would it be better to hoist it into RISCVTargetInfo and modify the BSD switch statements to respect that in their respective TargetInfo constructors?
Tue, Mar 16
I am seeing a spew of errors after 19740652c4c4329e2b9e77f96e5e31c360b4e8bb (what appears to be the latest version of this patch):
Sun, Mar 14
I do not have commit access, I would appreciate if someone could land this for me :)
$ cmake -G Ninja -DCMAKE_CXX_COMPILER=$(command -v clang++) -DCMAKE_BUILD_TYPE=Release -DLLVM_ENABLE_PROJECTS="clang;debuginfo-tests;mlir" ../llvm ...
Mar 2 2021
This patch introduces a build error according to my bisect:
Feb 8 2021
Thanks! I can confirm that this fixes the assertion I was hitting.
Jan 26 2021
This patch causes issues with building the Linux kernel. cvise spits out:
Jan 21 2021
OpenSUSE's x86_64 config exposed an issue with this patch:
Jan 14 2021
This fixes 32r6{,el}_defconfig and does not regress any of my other MIPS kernel builds.
Jan 11 2021
Addressed Fangrui's comments. If this looks good, please commit it on my behalf: Nathan Chancellor <natechancellor@gmail.com>
Indeed, updated!
Jan 7 2021
This commit breaks my build, am I doing something wrong?
Nov 23 2020
I think that not warning upon falling through to goto or return is a mistake. We have a confirmed case of a bug where clang would catch this bug whereas gcc would not: https://lore.kernel.org/lkml/20201121124019.21116-1-ogabbay@kernel.org/. I suspect that warnings from falling through to break and ; make up the vast majority of the noise in the Linux kernel and I highly doubt that those are bugs. The other two generally have code flow implications that should be annotated. I will modify this patch tonight and see how many warnings we get from goto and return statements against mainline.
Nov 7 2020
I have not done a bisect or anything but I suspect this commit broke -DLLVM_INCLUDE_TESTS=OFF:
Thank you for the quick fix, this resolves my reported issue. I can approve if need be but it would probably be better for there to be other eyes on this :)
$ cmake \ -G Ninja \ -DCMAKE_BUILD_TYPE=Release \ -DCMAKE_C_COMPILER=$(command -v clang) \ -DCMAKE_CXX_COMPILER=$(command -v clang++) \ -DLLVM_CCACHE_BUILD=ON \ -DLLVM_ENABLE_PROJECTS="clang;polly" \ -DLLVM_TARGETS_TO_BUILD=X86 \ -DLLVM_USE_LINKER=$(command -v ld.lld) \ ../llvm
Oct 10 2020
This patch breaks building the PowerPC Linux kernel with clang.
Jul 19 2020
Please ensure that this patch gets picked up into release/11.x as the patch that introduced this failure is in there.
Jul 15 2020
With this diff applied on top of f3731d34faa7432462c877714af235e9787c9b30, this looks good to me.
I will throw this through my build tests for the Linux kernel and make sure that it passes (will probably take my machine four hours or so). I do not feel qualified enough to approve this once I get those results though.
Jul 14 2020
This commits causes a failed assertion when building the Linux kernel for arm32:
Jun 30 2020
This patch breaks compiling the Linux kernel:
Jun 29 2020
@nemanjai thanks for the fix, I can confirm all of my PowerPC builds are successful with LLVM at 4772b99dffec4f87bb7bc9273495066058ac0186!
Jun 25 2020
Gentle ping. This is still an issue at 4c6548222b3c41d024581d28f42b3f02510bcfe3 and I have not heard anything about a fix. I know I sent that message on Friday night before the weekend so I am hoping that it did not get lost. If I need to file a bug report, I am more than happy to do so.
Jun 21 2020
@void that diff on top of this revision resolves the issue I was seeing, thanks!
Jun 19 2020
Hi! This patch causes a crash when compiling the Linux kernel with certain distribution configs:
Jun 8 2020
I do not know enough about KASAN enough to review this patch but I can say that against mainline at https://git.kernel.org/linus/af7b4801030c07637840191c69eb666917e4135d, there appear to be no visible regressions with this version of the patch on top of caa2fddce72f2e8ca3d6346cc2c8fe85252b91d8.
May 29 2020
This patch causes a crash in the Linux kernel when building s390 allyesconfig:
May 1 2020
Thanks for the fix! I can confirm that a multi_v5_defconfig kernel looks normal size wise and boots in QEMU. I will do a set of kernel builds overnight to make sure that nothing else regresses.
Apr 23 2020
Thanks! I can confirm that I do not see a crash anymore with the config I used when initially reporting. I will try to run this patch through all of my kernel build tests this afternoon to make sure nothing else has regressed.
Apr 21 2020
Apr 17 2020
Just as an FYI, this fixes the issue I reported here: https://bugs.llvm.org/show_bug.cgi?id=45580
Apr 10 2020
@nemanjai thank you for that fix! Unfortunately, I am still seeing some errors with the modules target:
Apr 9 2020
For what it's worth, this patch introduces a regression when building the Linux kernel's powernv_defconfig with Clang and linking with ld.bfd (for some reason, ld.lld is fine):
Apr 7 2020
These are new tests how do you get the generic lld driver to work?
Weird -- the baseline didn't take CLANG_DEFAULT_LINKER into account either, though, right?
This does not take into account CLANG_DEFAULT_LINKER, resulting in a check-clang failure:
Mar 22 2020
I can confirm this fixes my issue, thank you for the quick fix! I can approve if need be but might be better for someone else more familiar with this area to do that :)
This change breaks -DLLVM_INCLUDE_TESTS=OFF:
Seems sane to me if I am understanding the string arithmetic correctly. I can confirm this fixes the Debian use case that we came across.
Mar 7 2020
Thanks for the review and accepting. I do not have commit rights, would you mind doing that on my behalf?
Mar 6 2020
Mar 3 2020
Feb 18 2020
Feb 16 2020
There appear to a be semantic difference between GCC and clang with the current version of this patch which results in a lot of additional warnings in the Linux kernel: https://godbolt.org/z/eHFJd8
Feb 11 2020
The Linux kernel hits the assert in markConstant on arm32 defconfig in net/mac80211/sta_info.o, as reported by Linaro's CI:
Feb 7 2020
Please revert; I am happy to test a new revision to make sure there are no warnings but I don’t want this shipped in clang-10 and a revert is something that we can easily backport unless you can come up with a fix rather quickly.
Jan 19 2020
Jan 13 2020
This fixes the error for me and looks better from a documentation perspective.
I am seeing the same failure that @leonardchan reported above. This is related to -DCLANG_DEFAULT_LINKER=lld:
Dec 21 2019
Dec 18 2019
As a follow up to my previous post, I have sent patches to clean up all of the warnings that I see in the Linux kernel. However, I found one that I do believe is a false positive:
Dec 4 2019
IMO that is misleading indentation. A single space followed by a tab? WTF
Dec 3 2019
As an FYI, this appears to cause several false positive warnings with the Linux kernel:
Oct 13 2019
Oct 10 2019
Yes, it does! I can approve this if you need it but I am not an expect in cmake so I cannot comment on how proper this is.
Oct 9 2019
Just as an FYI, this patch breaks LLVM_INCLUDE_TESTS=OFF for me:
Aug 29 2019
@NoQ thank you for the fix, I can confirm it works!
This commit causes some warnings in the Linux kernel that appear to be false positives. For example:
Aug 28 2019
LGTM.
The test case passes for me after this, thanks for the fix!
Aug 26 2019
My instrumented stage 2 build fails after this commit with this script.
Aug 23 2019
Could it be an issue with python? What is the version you are using?
Done, thanks for looking into this!
Aug 22 2019
This test case has never passed for me with check-clang, is there something environment related that is needed with this or are others experiencing this too?
Aug 12 2019
Yes, it does look like that is the case, I will abandon this. Thanks for the reply!
Aug 8 2019
Aug 4 2019
This causes a compiler hang (I assume infinite loop or deadlock somewhere) when compiling the Linux kernel.
Jul 22 2019
I tested this patch on top of r366728 and saw no regressions in my set of kernel builds.
Jul 11 2019
This change breaks building the Linux kernel for arm32 (at least):