This is an archive of the discontinued LLVM Phabricator instance.

[SparcISelLowering] avoid emitting libcalls to __muloti4 and __mulodi4
ClosedPublic

Authored by nickdesaulniers on Oct 28 2021, 1:00 PM.

Details

Summary

These compiler-rt-only symbols aren't available in libgcc. Similar to
D108842, D108844, and D108926.

Fixes: pr/52043

Diff Detail

Event Timeline

nickdesaulniers requested review of this revision.Oct 28 2021, 1:00 PM
Herald added a project: Restricted Project. · View Herald TranscriptOct 28 2021, 1:00 PM
rengolin accepted this revision.Oct 29 2021, 8:02 AM

Just like the others, LGTM. Thanks!

This revision is now accepted and ready to land.Oct 29 2021, 8:02 AM
craig.topper added inline comments.Oct 29 2021, 10:19 AM
llvm/lib/Target/Sparc/SparcISelLowering.cpp
1622

Is MULO_I64 a problem for 32-bit?

craig.topper added inline comments.Oct 29 2021, 10:20 AM
llvm/lib/Target/Sparc/SparcISelLowering.cpp
1622

Answering my own question. It is https://godbolt.org/z/bc9na1c5T

nickdesaulniers planned changes to this revision.Oct 29 2021, 10:28 AM
nickdesaulniers retitled this revision from [SparcISelLowering] avoid emitting libcalls to __muloti4() to [SparcISelLowering] avoid emitting libcalls to __muloti4 and __mulodi4.
nickdesaulniers edited the summary of this revision. (Show Details)
  • block __mulodi4 for 32b sparc, add test, rebase
This revision is now accepted and ready to land.Oct 29 2021, 12:14 PM
nickdesaulniers marked 2 inline comments as done.Oct 29 2021, 12:14 PM