- User Since
- Aug 23 2012, 7:46 PM (439 w, 6 d)
Thu, Jan 21
Dec 1 2020
Nov 3 2020
Would it be better/easier if we just change the default in the Clang driver at this point to use LLD for Android triples? I believe Dan has patches for doing that which we hadn't submitted yet (because we only recently made it the NDK default).
Oct 22 2020
Oct 21 2020
Oct 20 2020
Oct 13 2020
I think this is ok, but I'd like @eugenis to confirm that he is fine with it too. Thanks for explaining the complexity across the different API levels.
Oct 12 2020
Sep 15 2020
Sep 11 2020
Thanks for creating the new test, and for making this more flexible. Everything else looks good here.
Sep 10 2020
Sep 9 2020
Sorry, Jiyong, I had forgotten to subscribe llvm-commits when I first uploaded this (because it's part of compiler-rt and doesn't seem to have a default rule to add them). In any case, this patch LGTM, and I am going to go ahead and approve it since this only affects Android. Let's give it 24 hours for anyone else to comment before committing though (especially since I messed up with the original upload/review).
Sep 3 2020
Aug 26 2020
Aug 24 2020
Yes, let's just submit this now. If it breaks further, then we can consider other options. I'm not sure why there is a separate libc++abi reviewer listed here.
Aug 14 2020
@asmith, are you still working on this patch? The gap-fill feature is definitely needed for parity with existing objcopy implementations.
Jul 13 2020
Jun 15 2020
Jun 10 2020
Thanks, Ryan, for diagnosing and addressing this bug.
Jun 1 2020
Thanks, Nick, for cleaning this up and always striving to make things more compatible.
May 29 2020
Apr 30 2020
I'm also satisfied with this from the Android side. Thank you for discussing this with Ryan.
Apr 24 2020
LGTM on the Android side. Thanks Dan for handling this.
Apr 22 2020
Apr 16 2020
pragma clang attribute is interesting, but how do you apply that in a selective fashion to local variables (especially in a way that can be automated)? At first, I didn't think the goal for this should be to create a frequently used option for most end users, but I do think that it could be quite useful for more folks when debugging, especially if it is easy to automate (which optimization-fuel approaches are, while pragmas are not).
Apr 8 2020
Thank you for making this clear.
I agree with Ryan. Please update the Clang driver for this to pass this same flag for 32-bit ARM as we already pass for AArch64.
Apr 3 2020
I should have looked more closely at the AOSP sources, because we already hard-code the expected 4KB max-page-size. We do have some crufty flags that can be cleaned up, so I'll do that instead (https://android-review.googlesource.com/c/platform/build/soong/+/1278815). :) I'll also go ahead and create/test a CL to revert the Clang driver change forcing 4KB max-page-size next week.
So it turns out that the ld shipped in the NDK actually did have the 64KB max-page-size patch, so not taking this patch would change current user behavior. Thanks to @MaskRay for sharing the exact binutils patch we were looking for to verify that it has it. For that reason, this patch should be fine for our 32-bit ARM NDK users. For the platform, we'll see if we should just set the max-page-size back to 4KB explicitly in the build rules, but that shouldn't affect this CL.
We (Android Google folks) have an internal thread going on about what implications this might have, but I can say that I am concerned about making this kind of change for ARM Android targets. Even though we manually set a 4KB max page size in our platform builds for 32-bit, we also have to consider the needs of NDK developers (i.e. those folks making native applications/games/etc.). Some of their build configurations might behave very differently with this change, so my current thinking is that 64KB should not be the default for ARM Android targets.
Apr 1 2020
Mar 31 2020
Mar 30 2020
Mar 26 2020
Mar 20 2020
Thanks, Dan, for setting this up.
Feb 27 2020
Feb 14 2020
Dec 10 2019
Nov 6 2019
Oct 25 2019
Oct 17 2019
Oct 4 2019
Sep 9 2019
Sep 5 2019
Looks really nice. I am sure the NDK developers will be happy to see support for static OpenMP. Do you want to add the public NDK github issue link in the commit message?
Sep 4 2019
LGTM, but please wait for someone more familiar with LangRef policies to review that part.
Aug 29 2019
Aug 26 2019
Thanks for improving this for LLDB and Android.
Aug 6 2019
Jul 12 2019
You have patch.patch in the diff above. You should drop that.
s/integrates/integrated in the title, but otherwise this looks good.
Jul 3 2019
Jul 2 2019
Jun 25 2019
Craig, can you confirm that this is acceptable? I don't think there are any chips with SSE4.2 but without cx16, so this just seemed like an oversight. It might be a good idea to really audit the list of possible CPU features for other missing inclusions. Another idea would be to set a baseline minimum CPU for Android, which would cut down on having to specify so many features separately.
Jun 3 2019
FYI, https://reviews.llvm.org/D56571 is the review where this was accepted.
May 31 2019
May 30 2019
May 29 2019
Everything looks great. Thanks for adding these improvements. While it's probably safe to commit this, perhaps you should give it 24 hours in case some of the other clang-tidy folks have different style or testing concerns.
May 23 2019
May 21 2019
Thanks for picking this up and finishing it.
May 17 2019
The revert is fine with me, although I still would like Ryan to follow up on verifying that the suggested fix for Bionic will indeed work for all cases. I think it is fine for you to merge now to unbreak things for everyone else though. Thanks for working through the problem.
This LGTM if Ryan is happy with it. Thanks for taking care of getting a workaround implemented until this can be fixed.
May 16 2019
Apr 30 2019
Apr 26 2019
I had just a few small suggestions to make things more consistent. Feel free to ignore my fallthrough comment, but I feel like -Wimplicit-fallthrough has been quite valuable in Android.
Apr 20 2019
I added Peter and Oliver since they might have some suggestions here too.
Apr 17 2019
Thanks for taking a look at this.
Apr 16 2019
Thanks for finding this. Note that this is the exact code in comparesf2.c.
Apr 11 2019
Apr 4 2019
Thank you for fixing this quickly!