[lldb] Remove "0x" prefix from hex values in dirty-pages

[mgorny]

Summary

Remove the redudant "0x" prefix in the "dirty-pages" key of
qMemoryRegionInfo packet. The client accepts hex values both with
and without the prefix.

[labath]

Jason, I'm not sure how this came to be, but I think it's more common to not send the 0x for hex numbers.

[mgorny]

Gentle ping.

[jasonmolenda]

I'm fine with the change, it's true it's inconsistent but I also hate how we don't prefix base16 numbers in gdb RSP - so many bugs and mistakes are introduced because of it. So I'm always trying to sneak in some 0x prefixes when no one is looking. A fun one I saw the other day - in qHostInfo the cputype field is base16, in qProcessInfo the cputype field is base10. Sweet.

lldb/test/API/functionalities/gdb_remote_client/TestMemoryRegionDirtyPages.py

def test(self):
                 return "ptrsize:8;endian:little;vm-page-size:4096;"
 
             def qMemoryRegionInfo(self, addr):
                 if addr == 0:
                     return "start:0;size:100000000;"
                 if addr == 0x100000000:
                     return "start:100000000;size:4000;permissions:rx;dirty-pages:;"
                 if addr == 0x100004000:
-                    return "start:100004000;size:4000;permissions:r;dirty-pages:0x100004000;"
+                    return "start:100004000;size:4000;permissions:r;dirty-pages:100004000;"
                 if addr == 0x1000a2000:
-                    return "start:1000a2000;size:5000;permissions:r;dirty-pages:0x1000a2000,0x1000a3000,0x1000a4000,0x1000a5000,0x1000a6000;"
+                    return "start:1000a2000;size:5000;permissions:r;dirty-pages:1000a2000,1000a3000,1000a4000,1000a5000,1000a6000;"
 
         self.server.responder = MyResponder()
         target = self.dbg.CreateTarget('')
         if self.TraceOn():
           self.runCmd("log enable gdb-remote packets")
           self.addTearDownHook(
                 lambda: self.runCmd("log disable gdb-remote packets"))
         process = self.connect(target)

lldb/tools/debugserver/source/RNBRemote.cpp

if (region_info.permissions) {
 
     ostrm << "dirty-pages:";
     if (region_info.dirty_pages.size() > 0) {
       bool first = true;
       for (nub_addr_t addr : region_info.dirty_pages) {
         if (!first)
           ostrm << ",";
         first = false;
-        ostrm << "0x" << std::hex << addr;
+        ostrm << std::hex << addr;
       }
     }
     ostrm << ";";
     if (!region_info.vm_types.empty()) {
       ostrm << "type:";
       for (size_t i = 0; i < region_info.vm_types.size(); i++) {
         if (i)
           ostrm << ",";