Page MenuHomePhabricator

emaste (Ed Maste)
User

Projects

User does not belong to any projects.

User Details

User Since
Jul 24 2013, 5:36 AM (437 w, 13 h)

Recent Activity

Mon, Dec 6

emaste added a comment to D114186: [lld][CMake] Add LLD_DEFAULT_NOSTART_STOP_GC.

We requested an experimental ports build with the start-stop-gc behaviour reverted (i.e., with getZFlag(args, "start-stop-gc", "nostart-stop-gc", false);)

Mon, Dec 6, 8:49 AM · Restricted Project

Fri, Dec 3

emaste added inline comments to D114967: [lldb] [Process/elf-core] Disable for FreeBSD vmcores.
Fri, Dec 3, 1:59 PM · Restricted Project
emaste accepted D90876: [lldb] [test] Improve comment on expr-after-step-after-crash tests.

Fine with me, or maybe "A test for Darwin- (and prehaps Windows-)specific behavior."

Fri, Dec 3, 1:52 PM

Thu, Dec 2

emaste added a comment to D114186: [lld][CMake] Add LLD_DEFAULT_NOSTART_STOP_GC.

@jrtc27 and @emaste are both on board that the traditional GNU ld behavior / current 13.0.0 behavior is the future.

Thu, Dec 2, 12:55 PM · Restricted Project

Wed, Dec 1

emaste added a comment to D114186: [lld][CMake] Add LLD_DEFAULT_NOSTART_STOP_GC.

FreeBSD used an ancient version of GNU ld (2.17.50, from mid 2000s) until we migrated all target architectures to lld. That old ld defaults to no GC start/stop, we have been using that behaviour for decades.

Wed, Dec 1, 8:22 AM · Restricted Project
emaste added a comment to D114186: [lld][CMake] Add LLD_DEFAULT_NOSTART_STOP_GC.

compatible with GNU ld newer than 2015-10

Wed, Dec 1, 7:41 AM · Restricted Project

Mon, Nov 22

emaste updated subscribers of D114396: [Driver] Default to current FreeBSD profiling behaviour.

Similar idea to D77776 (libc++ default if major not specified)

Mon, Nov 22, 2:04 PM
emaste requested review of D114396: [Driver] Default to current FreeBSD profiling behaviour.
Mon, Nov 22, 2:02 PM
emaste committed rG2dec2aa3ad08: [Driver] Default to libc++ on FreeBSD (authored by jbeich).
[Driver] Default to libc++ on FreeBSD
Mon, Nov 22, 1:47 PM
emaste closed D77776: [Driver] Default to libc++ on FreeBSD.
Mon, Nov 22, 1:47 PM · Restricted Project
emaste committed rGa40dcd060e9d: [Driver] correct typo in FreeBSD 14 test (authored by emaste).
[Driver] correct typo in FreeBSD 14 test
Mon, Nov 22, 11:38 AM
emaste added inline comments to D77776: [Driver] Default to libc++ on FreeBSD.
Mon, Nov 22, 8:38 AM · Restricted Project
emaste updated the diff for D77776: [Driver] Default to libc++ on FreeBSD.

rebase tests

Mon, Nov 22, 8:36 AM · Restricted Project
emaste commandeered D77776: [Driver] Default to libc++ on FreeBSD.
Mon, Nov 22, 8:36 AM · Restricted Project

Nov 2 2021

emaste added a comment to D96914: [ELF] Add -z start-stop-gc to let __start_/__stop_ not retain C identifier name sections.

@emaste replied: "However, if GNU ld / gold / lld default to GCing things we could set the option to reenable it in kernel/userland Makefiles."

Nov 2 2021, 1:55 PM · Restricted Project

Nov 1 2021

emaste added a comment to D111863: [libunwind] Add an interface for dynamic .eh_frame registration.

@joerg @dim @emaste Any further comments on this?

Nov 1 2021, 5:40 PM · Restricted Project, Restricted Project

Sep 28 2021

emaste committed rG993ada05f5a0: [lldb] [unittests] Fix building the FreeBSD arm64 Register Context test (authored by andrew).
[lldb] [unittests] Fix building the FreeBSD arm64 Register Context test
Sep 28 2021, 7:55 AM
emaste closed D110545: [lldb] [unittests] Fix building the FreeBSD arm64 Register Context test.
Sep 28 2021, 7:55 AM · Restricted Project

Sep 24 2021

emaste added a comment to D108120: [lld] Add CMake options to disable individual linkers.

IMO this is worth it for the build time reduction, the size reduction is a nice bonus but not the main benefit.

Sep 24 2021, 5:46 AM · Restricted Project, Restricted Project

Sep 16 2021

emaste added a comment to D109090: [FreeBSD] avoid marking __stack_chk_guard symbol as dso_local on FreeBSD.

It looks like this worked prior to 2518433f861f because shouldAssumeDSOLocal has this case:

// PPC has no copy relocations and cannot use a plt entry as a symbol address.
llvm::Triple::ArchType Arch = TT.getArch();
if (Arch == llvm::Triple::ppc || Arch == llvm::Triple::ppc64 ||
    Arch == llvm::Triple::ppc64le)
  return false;
Sep 16 2021, 12:24 PM · Restricted Project

Sep 14 2021

emaste added a comment to D109753: [Sanitizers] intercept fparseln on FreeBSD.

Do we want to share some of these tests between NetBSD and FreeBSD?

Sep 14 2021, 10:57 AM · Restricted Project

Aug 24 2021

emaste committed rG6609892a2dcd: [clang] allow -fstack-clash-protection on FreeBSD (authored by emaste).
[clang] allow -fstack-clash-protection on FreeBSD
Aug 24 2021, 6:03 PM
emaste closed D108571: [clang] allow -fstack-clash-protection on FreeBSD.
Aug 24 2021, 6:03 PM · Restricted Project
emaste added a comment to D108630: [libc++] Remove _LIBCPP_HAS_NO_LONG_LONG in favour of using_if_exists.

Would it be possible to add build bots for FreeBSD so we can test changes like those automatically?

Aug 24 2021, 10:28 AM · Restricted Project

Aug 23 2021

emaste added a comment to D54880: Ignore gcc's stack-clash-protection flag.

Superseded by e67cbac81211d40332a79d98c9d5953624cc1202 (D68720)

Aug 23 2021, 12:06 PM · Restricted Project
emaste added a comment to D108571: [clang] allow -fstack-clash-protection on FreeBSD.

We make this change in FreeBSD's in-tree Clang about 9 months ago (https://reviews.freebsd.org/D27366)

Aug 23 2021, 11:55 AM · Restricted Project
emaste requested review of D108571: [clang] allow -fstack-clash-protection on FreeBSD.
Aug 23 2021, 11:54 AM · Restricted Project

Aug 6 2021

emaste accepted D107635: [LLD] Support compressed input sections on big-endian targets.
Aug 6 2021, 11:55 AM · Restricted Project
emaste added a comment to D107635: [LLD] Support compressed input sections on big-endian targets.

LGTM

Aug 6 2021, 11:55 AM · Restricted Project
emaste updated subscribers of D107635: [LLD] Support compressed input sections on big-endian targets.
Aug 6 2021, 7:08 AM · Restricted Project
emaste added a comment to D107635: [LLD] Support compressed input sections on big-endian targets.

With this patch applied BE mips64 FreeBSD builds successfully for me

Aug 6 2021, 7:07 AM · Restricted Project

Aug 4 2021

emaste added a comment to D107475: [lldb] [gdb-remote] Use hexadecimal numbers in vFile packets for GDB compliance.

LGTM, although in FreeBSD we don't have any backwards- or cross-compatibility issues to worry about.

Aug 4 2021, 9:48 AM · Restricted Project, Restricted Project

Jul 28 2021

emaste accepted D106964: [Security] Replace a Sony member.
Jul 28 2021, 2:12 PM · Restricted Project

Jul 27 2021

emaste accepted D106917: Security: make peoples' phab names obvious; recommend phab as the place for nominations.
Jul 27 2021, 6:06 PM · Restricted Project

Jul 7 2021

emaste added inline comments to D105563: [libc++][docs] Update documentation to reflect libc++'s compiler support policy.
Jul 7 2021, 1:01 PM · Restricted Project

Jun 26 2021

emaste committed rG699d47472c3f: [Driver] do not link _p libs for -pg on FreeBSD 14 and later (authored by emaste).
[Driver] do not link _p libs for -pg on FreeBSD 14 and later
Jun 26 2021, 3:22 PM
emaste closed D104753: [Driver] Stop linking _p libs for -pg on FreeBSD 14.
Jun 26 2021, 3:21 PM · Restricted Project

Jun 22 2021

emaste added a comment to D104753: [Driver] Stop linking _p libs for -pg on FreeBSD 14.

-pg is still supported (see the OPT_pg at line 253), gprof just won't be able to "see into" libc, libm, etc.

Jun 22 2021, 5:21 PM · Restricted Project
emaste requested review of D104753: [Driver] Stop linking _p libs for -pg on FreeBSD 14.
Jun 22 2021, 2:44 PM · Restricted Project

May 11 2021

emaste accepted D101086: [lldb] [Process/elf-core] Fix reading FPRs from FreeBSD/i386 cores.
May 11 2021, 5:57 PM · Restricted Project
emaste accepted D101893: [Process/elf-core] Read PID from FreeBSD prpsinfo.
May 11 2021, 5:57 PM · Restricted Project
emaste added a comment to D101893: [Process/elf-core] Read PID from FreeBSD prpsinfo.

LGTM

May 11 2021, 7:28 AM · Restricted Project
emaste added a comment to D101086: [lldb] [Process/elf-core] Fix reading FPRs from FreeBSD/i386 cores.

LGTM

May 11 2021, 7:25 AM · Restricted Project

May 5 2021

emaste added inline comments to D101890: [LLD] Improve --strip-all help text.
May 5 2021, 10:03 AM · Restricted Project

May 3 2021

emaste added a comment to D101773: [MC][ELF] Work around R_MIPS_LO16 relocation handling problem.

Presumably the MIPS tests changed in 72e75ca343c6f need to be changed back

May 3 2021, 3:38 PM · Restricted Project

Mar 27 2021

emaste accepted D98286: [Driver] Enable kernel address and memory sanitizers on FreeBSD.
Mar 27 2021, 6:21 PM · Restricted Project
emaste accepted D98285: [asan] Add an offset for the kernel address sanitizer on FreeBSD.
Mar 27 2021, 6:19 PM · Restricted Project

Mar 22 2021

emaste accepted D98281: [asan] Remove FreeBSD XFAIL from asan-sigbus.cpp test.

See https://svnweb.freebsd.org/base?view=revision&revision=352807

Mar 22 2021, 7:53 AM · Restricted Project

Mar 3 2021

emaste added a comment to D96626: Support: mapped_file_region: Pass MAP_NORESERVE to mmap.

So that's all the more reason to consistently use that mode everywhere, I think.

Mar 3 2021, 8:38 AM · Restricted Project

Mar 2 2021

emaste committed rG462cf39a5c18: [Driver] Fix -gz=zlib options for linker also on FreeBSD (authored by emaste).
[Driver] Fix -gz=zlib options for linker also on FreeBSD
Mar 2 2021, 5:45 AM
emaste closed D97752: Fix -gz=zlib options for linker for FreeBSD too.
Mar 2 2021, 5:45 AM · Restricted Project

Mar 1 2021

emaste added a comment to D97752: Fix -gz=zlib options for linker for FreeBSD too.

I can drop the Fixes trailer (I added it as we've adopted it in FreeBSD from Linux). That said, the referenced patch changed Gnu, AMDGPU, and HIP. My main goal here is to get the final library / executable artifacts to have compressed debug, we can look more at the intermediate bits later.

Mar 1 2021, 7:31 PM · Restricted Project
emaste retitled D97752: Fix -gz=zlib options for linker for FreeBSD too from Fix -gz=zlib options for linker to Fix -gz=zlib options for linker for FreeBSD too.
Mar 1 2021, 6:31 PM · Restricted Project
emaste requested review of D97752: Fix -gz=zlib options for linker for FreeBSD too.
Mar 1 2021, 6:30 PM · Restricted Project
emaste added a comment to D87321: Fix -gz=zlib options for linker.

I just ran into this issue on FreeBSD, bug report in https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=253942

Mar 1 2021, 10:19 AM · Restricted Project

Feb 24 2021

emaste added a comment to D97230: [lldb] [test] Workaround symlink-related test failures.

OK; I think this change is reasonable, I just want to make sure we don't completely lose the underlying issue.

Feb 24 2021, 11:22 AM · Restricted Project
emaste added a comment to D97210: [lldb] Rename NativeRegisterContext{Watchpoint => DBReg}_x86.

No objection from me

Feb 24 2021, 11:19 AM · Restricted Project
emaste added a comment to D96548: [lldb] [Process/FreeBSDRemote] Introduce aarch64 hw break/watchpoint support.

I don't think it's very likely. @emaste, any opinion on this?

Feb 24 2021, 11:17 AM · Restricted Project
emaste added a comment to D97230: [lldb] [test] Workaround symlink-related test failures.

I think it's valuable to avoid testing this (symlink issue) as a side effect of these test cases, but we should have an explicit test for this; it is an issue users could hit.

Feb 24 2021, 8:28 AM · Restricted Project

Feb 20 2021

emaste accepted D97114: [lldb] [docs] Update platform support status.

FreeBSD changes LGTM

Feb 20 2021, 8:05 AM · Restricted Project

Feb 19 2021

emaste added a comment to D96914: [ELF] Add -z start-stop-gc to let __start_/__stop_ not retain C identifier name sections.

See also https://bugs.llvm.org/show_bug.cgi?id=22906

Feb 19 2021, 6:34 PM · Restricted Project

Feb 14 2021

emaste added inline comments to D96555: [lldb] Remove the legacy FreeBSD plugin.
Feb 14 2021, 1:50 PM · Restricted Project
emaste added a comment to D96555: [lldb] Remove the legacy FreeBSD plugin.

Not sure if you're missing something, but removing the old plugin LGTM

Feb 14 2021, 1:49 PM · Restricted Project

Feb 8 2021

emaste accepted D95947: [lldb] [Process/FreeBSDRemote] Introduce powerpc support.
Feb 8 2021, 9:29 AM · Restricted Project

Feb 3 2021

emaste added inline comments to D74393: [llvm-readobj] Add support for decoding FreeBSD ELF notes.
Feb 3 2021, 1:15 PM · Restricted Project
emaste added inline comments to D74393: [llvm-readobj] Add support for decoding FreeBSD ELF notes.
Feb 3 2021, 1:12 PM · Restricted Project

Feb 1 2021

emaste added a comment to D74367: [llvm-readelf] Print raw ELF note contents if we can't parse it.

Do you expect to pick this up again?

Feb 1 2021, 5:45 PM · Restricted Project
emaste added a comment to D74393: [llvm-readobj] Add support for decoding FreeBSD ELF notes.

@arichardson do you think you'll get back to this?

Feb 1 2021, 5:26 PM · Restricted Project

Jan 30 2021

emaste added a comment to D95297: [lldb] [Process/FreeBSDRemote] Introduce arm64 support.

lldb-server. We're aiming towards removing the native plug-in soon.

Jan 30 2021, 10:10 AM · Restricted Project

Jan 4 2021

emaste added a comment to D89490: Introduce __attribute__((darwin_abi)).

For now, only Linux/ARM64 is supported/tested.

Jan 4 2021, 1:14 PM · Restricted Project, Restricted Project

Dec 31 2020

emaste added inline comments to D93495: CrashReason: Add MTE tag check faults to the list of crash reasons..
Dec 31 2020, 12:01 PM · Restricted Project

Dec 28 2020

emaste added inline comments to D93848: [sanitizer] Define SANITIZER_GLIBC to refine SANITIZER_LINUX feature detection and support musl.
Dec 28 2020, 4:27 PM · Restricted Project, Restricted Project

Dec 27 2020

emaste added inline comments to D93495: CrashReason: Add MTE tag check faults to the list of crash reasons..
Dec 27 2020, 1:35 PM · Restricted Project
emaste added inline comments to D93495: CrashReason: Add MTE tag check faults to the list of crash reasons..
Dec 27 2020, 10:33 AM · Restricted Project

Dec 16 2020

emaste added a comment to D92245: -fstack-clash-protection: Return an actual error when used on unsupported OS.

I think it's ok to only warn on Windows.

IMO that's sensible

Dec 16 2020, 7:17 PM · Restricted Project, Restricted Project

Dec 6 2020

emaste added a comment to D92264: [lldb] [POSIX-DYLD] Update the cached exe path after attach.

Seems reasonable to me

Dec 6 2020, 11:38 AM · Restricted Project

Dec 4 2020

emaste accepted D92667: [lldb] [Platform/POSIX] Use gdb-remote plugin when attaching.

Ah, of course. SGTM.

Dec 4 2020, 4:59 PM · Restricted Project
emaste added a comment to D92667: [lldb] [Platform/POSIX] Use gdb-remote plugin when attaching.

No objection here. I'm curious why the two modified tests work on Linux or NetBSD today though?

Dec 4 2020, 10:54 AM · Restricted Project

Dec 1 2020

emaste added a comment to D92245: -fstack-clash-protection: Return an actual error when used on unsupported OS.

How do things go wrong on Darwin? I was under the impression that this was implemented in LLVM as strictly inline code, no runtime support required.

Dec 1 2020, 8:45 AM · Restricted Project, Restricted Project

Nov 30 2020

emaste added a comment to D92187: [lldb] [POSIX-DYLD] Add libraries from initial rendezvous brkpt hit.

One thing that FreeBSD should do, is to upgrade to the protocol version 1 (stored in r_version), like Linux, NetBSD and OpenBSD.

Nov 30 2020, 2:43 PM · Restricted Project
emaste added a comment to D92187: [lldb] [POSIX-DYLD] Add libraries from initial rendezvous brkpt hit.
Nov 30 2020, 2:21 PM · Restricted Project
emaste added a comment to D92187: [lldb] [POSIX-DYLD] Add libraries from initial rendezvous brkpt hit.

Link to Linux info:
https://sourceware.org/gdb/wiki/LinkerInterface

Nov 30 2020, 1:52 PM · Restricted Project
emaste updated subscribers of D92187: [lldb] [POSIX-DYLD] Add libraries from initial rendezvous brkpt hit.

I'm curious how gdb handles this, and asked @bsdjhb if he knows off hand.

Nov 30 2020, 7:49 AM · Restricted Project
emaste added a comment to D92314: [lldb] [Process/FreeBSDRemote] Implement GetLoadedModuleFileSpec() and GetFileLoadAddress().

No objection, but maybe add a comment explaining the status of this implementation? Does/will NetBSD do the same?

Nov 30 2020, 7:40 AM · Restricted Project
emaste added a comment to D92245: -fstack-clash-protection: Return an actual error when used on unsupported OS.

Can we add a test that the feature can be enabled on an OS other than Linux / Windows / Darwin?

Nov 30 2020, 6:26 AM · Restricted Project, Restricted Project
emaste abandoned D92100: [clang] do not limit -fstack-clash-protection to Linux.

Abandon in favour of D92245

Nov 30 2020, 6:25 AM
emaste added a comment to D92100: [clang] do not limit -fstack-clash-protection to Linux.

Perhaps

if (EffectiveTriple.isOSWindows() || EffectiveTriple.isOSDarwin())
  return;

here too

Nov 30 2020, 6:23 AM

Nov 25 2020

emaste added inline comments to D92100: [clang] do not limit -fstack-clash-protection to Linux.
Nov 25 2020, 1:16 PM
emaste updated the diff for D92100: [clang] do not limit -fstack-clash-protection to Linux.
  • add comment suggested by @rnk
  • combine Linux and FreeBSD FileCheck
Nov 25 2020, 1:14 PM
emaste added inline comments to D92100: [clang] do not limit -fstack-clash-protection to Linux.
Nov 25 2020, 7:28 AM
emaste requested review of D92100: [clang] do not limit -fstack-clash-protection to Linux.
Nov 25 2020, 7:25 AM

Nov 24 2020

emaste added inline comments to D68720: Support -fstack-clash-protection for x86.
Nov 24 2020, 5:34 PM · Restricted Project, Restricted Project

Nov 19 2020

emaste accepted D91810: [lldb] Prevent 'process connect' from using local-only plugins.

Looks ok to me

Nov 19 2020, 11:20 AM · Restricted Project

Nov 18 2020

emaste added inline comments to D91645: [lldb] [test] Un-XFAIL tests on freebsd/i386.
Nov 18 2020, 7:56 AM · Restricted Project

Nov 17 2020

emaste added inline comments to D91645: [lldb] [test] Un-XFAIL tests on freebsd/i386.
Nov 17 2020, 8:16 PM · Restricted Project

Nov 10 2020

emaste added a comment to D91165: [libc++] Fix two fr_FR locale tests on FreeBSD.

I'm not sure if we need to add a runtime check?

Nov 10 2020, 12:15 PM · Restricted Project
emaste accepted D91165: [libc++] Fix two fr_FR locale tests on FreeBSD.

This is fine with me; have we always done that?

Nov 10 2020, 7:59 AM · Restricted Project

Nov 9 2020

emaste added a comment to D91065: [lldb] [test] Rename '.categories' to 'categories'.

No objection from me but I haven't been sufficiently involved in lldb's tests to approve.

Nov 9 2020, 7:59 AM · Restricted Project
emaste accepted D91076: [lldb] [Process/FreeBSDRemote] Correct DS/ES/FS/GS register sizes.

Agree that even if refactoring is needed correcting these makes sense.

Nov 9 2020, 7:56 AM · Restricted Project

Nov 8 2020

emaste accepted D91026: [lldb] [Host/freebsd] Set Arg0 for 'platform process list -v'.
Nov 8 2020, 6:18 AM · Restricted Project