Page MenuHomePhabricator

krytarowski (Kamil Rytarowski)
User

Projects

User does not belong to any projects.

User Details

User Since
Aug 30 2015, 11:51 AM (327 w, 3 d)

Recent Activity

Fri, Nov 26

krytarowski accepted D114635: [llvm-readobj] Add support for machine-independent NetBSD ELF core notes..
Fri, Nov 26, 9:05 AM · Restricted Project

Sep 27 2021

krytarowski accepted D110553: [lldb] Remove non-stop mode code.

NetBSD and FreeBSD do not support non-stop in the kernel.

Sep 27 2021, 12:28 PM · Restricted Project

Sep 22 2021

krytarowski added inline comments to D109843: [Sanitizers] intercept ttyent api on FreeBSD.
Sep 22 2021, 3:43 PM · Restricted Project

Sep 9 2021

krytarowski accepted D96766: [lldb] [Process/FreeBSD] Introduce mips64 FPU reg support.

Looks still fine.

Sep 9 2021, 6:48 AM · Restricted Project

Sep 8 2021

krytarowski requested changes to D101563: [lldb] [test] Extend aarch64-gp-read test to cover all registers.

There is an unhandled comment.

Sep 8 2021, 1:12 AM
krytarowski accepted D96766: [lldb] [Process/FreeBSD] Introduce mips64 FPU reg support.
Sep 8 2021, 1:11 AM · Restricted Project
krytarowski accepted D101157: [lldb] [test] Add tests for coredumps with multiple threads.
Sep 8 2021, 12:49 AM · Restricted Project
krytarowski accepted D101563: [lldb] [test] Extend aarch64-gp-read test to cover all registers.
Sep 8 2021, 12:08 AM

Sep 7 2021

krytarowski accepted D109326: [lldb] [Process/FreeBSD] Support SaveCore() using PT_COREDUMP.

Looks good

Sep 7 2021, 2:49 AM · Restricted Project

Sep 6 2021

krytarowski accepted D101329: [lldb] Support SaveCore() from gdb-remote client.

Looks correct.

Sep 6 2021, 7:51 AM · Restricted Project
krytarowski accepted D101285: [lldb] [llgs server] Support creating core dumps on NetBSD.

Looks good

Sep 6 2021, 2:11 AM · Restricted Project

Sep 2 2021

krytarowski accepted D100503: [lldb] [client] Implement follow-fork-mode.

Looks good

Sep 2 2021, 2:00 AM · Restricted Project

Aug 31 2021

krytarowski accepted D100267: [lldb] [gdb-remote client] Remove breakpoints throughout vfork.

Let's see.

Aug 31 2021, 11:58 PM · Restricted Project
krytarowski accepted D100267: [lldb] [gdb-remote client] Remove breakpoints throughout vfork.

Looks reasonable

Aug 31 2021, 10:50 PM · Restricted Project
krytarowski accepted D100263: [lldb] [gdb-remote client] Remove breakpoints in forked processes.

Looks correct.

Aug 31 2021, 4:36 AM · Restricted Project

Aug 30 2021

krytarowski accepted D100206: [lldb] [llgs client] Support minimal fork/vfork handling.

Looks good.

Aug 30 2021, 1:06 AM · Restricted Project

Jun 20 2021

krytarowski accepted D101091: [lldb] [Process/elf-core] Fix reading NetBSD/i386 core dumps.
Jun 20 2021, 9:56 AM · Restricted Project

May 11 2021

krytarowski accepted D101893: [Process/elf-core] Read PID from FreeBSD prpsinfo.
May 11 2021, 3:25 PM · Restricted Project
krytarowski accepted D101086: [lldb] [Process/elf-core] Fix reading FPRs from FreeBSD/i386 cores.
May 11 2021, 3:25 PM · Restricted Project

May 1 2021

krytarowski accepted D101521: [lldb] [Process/FreeBSD] Fix arm64 build after RegisterInfoPOSIX_arm64 changes.
May 1 2021, 1:48 PM · Restricted Project

Apr 25 2021

krytarowski accepted D100547: [lldb] [Process/FreeBSD] Report fork/vfork events to LLGS.
Apr 25 2021, 6:33 AM · Restricted Project
krytarowski accepted D100554: [lldb] [Process/NetBSD] Report fork/vfork events to LLGS.
Apr 25 2021, 6:32 AM · Restricted Project

Apr 20 2021

krytarowski added a comment to D100892: [sanitizer] Fix glibc sparc build and add GetTls support.

Sanitizers run on NetBSD/sparc64.

Apr 20 2021, 3:20 PM · Restricted Project

Mar 7 2021

krytarowski added a comment to D98121: [sanitizer] Change NanoTime to use clock_gettime on non-glibc.

Looks ok for NetBSD.

Mar 7 2021, 3:36 PM · Restricted Project

Feb 20 2021

krytarowski accepted D97114: [lldb] [docs] Update platform support status.

NetBSD OK!

Feb 20 2021, 8:53 AM · Restricted Project

Feb 13 2021

krytarowski added a comment to D96626: Support: mapped_file_region: Pass MAP_NORESERVE to mmap.

MAP_NORESERVE is dead on NetBSD as this is the default mode always.

Feb 13 2021, 12:51 AM · Restricted Project

Feb 8 2021

krytarowski accepted D95947: [lldb] [Process/FreeBSDRemote] Introduce powerpc support.
Feb 8 2021, 11:42 PM · Restricted Project
krytarowski added inline comments to D95947: [lldb] [Process/FreeBSDRemote] Introduce powerpc support.
Feb 8 2021, 12:59 PM · Restricted Project
krytarowski added inline comments to D95947: [lldb] [Process/FreeBSDRemote] Introduce powerpc support.
Feb 8 2021, 12:09 PM · Restricted Project
krytarowski added a comment to D96251: Allow TSAN to work with libc-internal locking on FreeBSD.

Would it be possible for NetBSD to also use this approach for the libc_pthread_ functions? Or is only a subset exported as libc_pthread_?

Feb 8 2021, 4:26 AM · Restricted Project
krytarowski accepted D96255: [sanitizers] Define SANITIZER_INTERCEPTOR_HOOKS on FreeBSD.
Feb 8 2021, 4:10 AM · Restricted Project
krytarowski accepted D95947: [lldb] [Process/FreeBSDRemote] Introduce powerpc support.
Feb 8 2021, 2:33 AM · Restricted Project
krytarowski added a comment to D96251: Allow TSAN to work with libc-internal locking on FreeBSD.

Can you follow the NetBSD approach and go for something like TSAN_MAYBE_INTERCEPT_NETBSD_ALIAS instead of patching shared code between all platforms?

Feb 8 2021, 2:29 AM · Restricted Project

Feb 4 2021

krytarowski added a comment to D95802: [lldb] [Process/FreeBSDRemote] Introduce mips64 support.

Merging is a good idea as NetBSD might duplicate these code chunks too.

Feb 4 2021, 5:47 AM · Restricted Project

Jan 30 2021

krytarowski added a comment to D95696: [lldb] [Process/FreeBSDRemote] Introduce arm (32-bit) support.

Oki, I see, thanks for response. Please give me a few days to analyze (and eventually to implement).

Jan 30 2021, 5:18 AM · Restricted Project

Jan 29 2021

krytarowski added a comment to D95297: [lldb] [Process/FreeBSDRemote] Introduce arm64 support.

@clayborg please have a look!

Jan 29 2021, 1:55 PM · Restricted Project

Jan 18 2021

krytarowski added a comment to D94569: [libcxx] Wipe some more macros that do not belong in C++ forwarding headers.

These symbols are usually macros + libc calls.

Jan 18 2021, 11:08 AM · Restricted Project

Jan 13 2021

krytarowski added a comment to D94569: [libcxx] Wipe some more macros that do not belong in C++ forwarding headers.

NetBSD uses macros too, but undefines them inside the header for __cplusplus. The proposed patch looks fine. This is a common source of portability issues, the stdio macros.

Jan 13 2021, 9:14 AM · Restricted Project

Jan 12 2021

krytarowski accepted D94491: [llvm] [cmake] Remove obsolete /usr/local hack for *BSD.
Jan 12 2021, 9:20 AM · Restricted Project

Dec 28 2020

krytarowski added inline comments to D93848: [sanitizer] Define SANITIZER_GLIBC to refine SANITIZER_LINUX feature detection and support musl.
Dec 28 2020, 3:42 PM · Restricted Project, Restricted Project
krytarowski added a comment to D93848: [sanitizer] Define SANITIZER_GLIBC to refine SANITIZER_LINUX feature detection and support musl.

Well... technically speaking GLIBC is at least: GNU/Linux, GNU/FreeBSD and HURD.

Hurd and GNU/kFreeBSD are not supported. Even if they do, many defined(__GLIBC__) is inside a #if SANITIZER_LINUX, so they will work automatically.

Dec 28 2020, 11:12 AM · Restricted Project, Restricted Project
krytarowski added a comment to D93848: [sanitizer] Define SANITIZER_GLIBC to refine SANITIZER_LINUX feature detection and support musl.

Well... technically speaking GLIBC is at least: GNU/Linux, GNU/FreeBSD and HURD.

Dec 28 2020, 9:16 AM · Restricted Project, Restricted Project

Dec 15 2020

krytarowski accepted D93299: [lldb] [unittests] Add tests for NetBSD register offsets/sizes.
Dec 15 2020, 9:57 AM · Restricted Project

Dec 10 2020

krytarowski added a comment to D85005: [libunwind] Support DW_CFA_remember/restore_state without heap allocation..

Please include stdlib.h for alloca, unless you target SunOS. alloca.h is unavailable on NetBSD.

Dec 10 2020, 4:29 AM · Restricted Project, Restricted Project

Dec 4 2020

krytarowski added a comment to D92667: [lldb] [Platform/POSIX] Use gdb-remote plugin when attaching.

No objection here. I'm curious why the two modified tests work on Linux or NetBSD today though?

Dec 4 2020, 12:51 PM · Restricted Project

Dec 1 2020

krytarowski added a comment to D92187: [lldb] [POSIX-DYLD] Add libraries from initial rendezvous brkpt hit.

Ideally we should iterate over the startup process and investigate the state of the r_debug structure. Once it gets initialized, set the software brakpoint to r_brk and keep track of the dynamic loading and unloading of libraries. The tricky part is to detect the right moment to plug into r_brk, early enough in the startup process before calling constructors, loading the libraries etc and late enough to become initialized.

Dec 1 2020, 6:15 AM · Restricted Project
krytarowski added a comment to D92187: [lldb] [POSIX-DYLD] Add libraries from initial rendezvous brkpt hit.

One thing that FreeBSD should do, is to upgrade to the protocol version 1 (stored in r_version), like Linux, NetBSD and OpenBSD.

It looks like Linux has always used r_version=1 (since 1995).

AFAICT we can just add r_ldbase and set version to 1.
See https://reviews.freebsd.org/D27429

Dec 1 2020, 3:27 AM · Restricted Project

Nov 30 2020

krytarowski added a comment to D92187: [lldb] [POSIX-DYLD] Add libraries from initial rendezvous brkpt hit.

I'm curious how gdb handles this, and asked @bsdjhb if he knows off hand.

Is there a brief description of how this works on Linux and/or NetBSD?

Nov 30 2020, 7:53 AM · Restricted Project

Nov 23 2020

krytarowski added a comment to D91847: [lldb] [debugserver] Add stN aliases for stmmN for compatibility.

I would mark stmmX as an alias to stX and keep stX as the default for all platforms. stmmX could be an alias for everybody for legacy reasons.

Nov 23 2020, 1:48 AM · Restricted Project
krytarowski accepted D91934: [lldb] [Process/FreeBSD] Add missing 'override' kws to POSIXStopInfo.
Nov 23 2020, 12:16 AM · Restricted Project

Nov 19 2020

krytarowski resigned from D89652: [Sanitizers] DragonFlyBSD ground work to support sanitizers.
Nov 19 2020, 3:52 PM · Restricted Project
krytarowski accepted D91810: [lldb] Prevent 'process connect' from using local-only plugins.
Nov 19 2020, 3:29 PM · Restricted Project

Nov 11 2020

krytarowski accepted D91254: [lldb] [Process/Utility] Fix DR offsets for FreeBSD.
Nov 11 2020, 6:10 AM · Restricted Project

Nov 10 2020

krytarowski accepted D91167: [lldb] [Process/NetBSD] Copy the recent improvements from FreeBSD.
Nov 10 2020, 8:39 AM · Restricted Project

Nov 9 2020

krytarowski accepted D91090: [lldb] [Process/NetBSD] Correct DS/ES/FS/GS register sizes.
Nov 9 2020, 1:00 PM · Restricted Project

Nov 8 2020

krytarowski accepted D91026: [lldb] [Host/freebsd] Set Arg0 for 'platform process list -v'.
Nov 8 2020, 5:24 AM · Restricted Project

Nov 7 2020

krytarowski accepted D91007: [lldb] [Process/FreeBSDRemote] Fix handling user-generated SIGTRAP.
Nov 7 2020, 3:41 PM · Restricted Project
krytarowski added a comment to D91007: [lldb] [Process/FreeBSDRemote] Fix handling user-generated SIGTRAP.

I propose to filter all user induced signals at once and check & 0x10000 and SI_USER.

Nov 7 2020, 1:54 PM · Restricted Project

Nov 6 2020

krytarowski accepted D90938: [lldb] [Process/FreeBSDRemote] Handle exec() from inferior.

I wonder why NetBSD fails having the same event handling.

Nov 6 2020, 7:14 AM · Restricted Project
krytarowski added a comment to D90757: [lldb] Enable FreeBSDRemote plugin by default and update test status.

Does the new plugin work with processes that are created with pdfork? The last time I tried this, it caused the old plugin to lock up the debugger entirely. Please can you ensure that there are tests that cover pdfork and cap_enter in the child? These are currently quite badly broken.

Nov 6 2020, 3:47 AM · Restricted Project

Nov 5 2020

krytarowski accepted D90863: [lldb] [Process/FreeBSDRemote] Remove thread name caching.
Nov 5 2020, 11:43 AM · Restricted Project
krytarowski accepted D90862: [lldb] [test] Fix TestGdbRemoteThreadName code on FreeBSD.
Nov 5 2020, 11:42 AM · Restricted Project

Nov 2 2020

krytarowski added a comment to D79713: [compiler-rt] [builtins] Port atomic.c to GCC.

It's relevant but I encountered issues to pass the review..

Nov 2 2020, 3:22 PM · Restricted Project
krytarowski accepted D90650: [lldb] [Plugins/FreeBSDRemote] Disable GetMemoryRegionInfo().
Nov 2 2020, 3:19 PM · Restricted Project
krytarowski accepted D90620: [lldb] [Process/FreeBSDRemote] Remove GetSharedLibraryInfoAddress override.
Nov 2 2020, 9:01 AM · Restricted Project

Oct 31 2020

krytarowski resigned from D89631: [Sanitizer] Undefined Behavior Sanitizer support proposal for DragonFlyBSD.
Oct 31 2020, 8:12 AM · Restricted Project
krytarowski accepted D90525: [lldb] [Process/FreeBSDRemote] Fix attaching via lldb-server.
Oct 31 2020, 8:12 AM · Restricted Project
krytarowski accepted D90298: [lldb] [Process/FreeBSDRemote] Implement thread GetName().
Oct 31 2020, 5:52 AM · Restricted Project

Oct 28 2020

krytarowski added inline comments to D90298: [lldb] [Process/FreeBSDRemote] Implement thread GetName().
Oct 28 2020, 5:25 AM · Restricted Project

Oct 26 2020

krytarowski accepted D90139: libcxx: Fix a few warnings.

Looks OK from the NetBSD point of view.

Oct 26 2020, 5:35 PM · Restricted Project

Oct 25 2020

krytarowski accepted D90128: [lldb] [Process/FreeBSDRemote] Fix #include for i386 compat.
Oct 25 2020, 6:45 PM · Restricted Project

Oct 24 2020

krytarowski accepted D90105: [lldb] [Process/NetBSD] Set xs_xstate_bv correctly when setting regs.
Oct 24 2020, 10:57 PM · Restricted Project

Oct 23 2020

krytarowski accepted D90034: [lldb] [Process/NetBSD] Use XStateRegSet for all FPU registers.
Oct 23 2020, 11:08 AM · Restricted Project

Oct 21 2020

krytarowski added inline comments to D89556: Avoid use of gets() in DOE-ProxyApps-C/Pathfinder.
Oct 21 2020, 10:47 AM
krytarowski added inline comments to D89874: [lldb] Split out NetBSD/x86 watchpoint impl for unification.
Oct 21 2020, 8:56 AM · Restricted Project
krytarowski added inline comments to D89556: Avoid use of gets() in DOE-ProxyApps-C/Pathfinder.
Oct 21 2020, 8:20 AM
krytarowski added inline comments to D89556: Avoid use of gets() in DOE-ProxyApps-C/Pathfinder.
Oct 21 2020, 6:44 AM

Oct 20 2020

krytarowski added inline comments to D89556: Avoid use of gets() in DOE-ProxyApps-C/Pathfinder.
Oct 20 2020, 2:57 PM
krytarowski requested changes to D89652: [Sanitizers] DragonFlyBSD ground work to support sanitizers.

Host a LLVM buildbot for DragonFly first, otherwise it will be even not ever build-tested.

Oct 20 2020, 5:20 AM · Restricted Project

Oct 19 2020

krytarowski added inline comments to D89640: [Sanitizers] Remove OpenBSD support.
Oct 19 2020, 1:24 PM · Restricted Project

Oct 18 2020

krytarowski added inline comments to D89640: [Sanitizers] Remove OpenBSD support.
Oct 18 2020, 6:53 AM · Restricted Project
krytarowski accepted D89640: [Sanitizers] Remove OpenBSD support.
Oct 18 2020, 6:46 AM · Restricted Project
krytarowski added a comment to D89640: [Sanitizers] Remove OpenBSD support.

Please leave builtins intact. ubsan might work, but removing it too is fine.

Oct 18 2020, 6:23 AM · Restricted Project

Oct 17 2020

krytarowski added a comment to D89631: [Sanitizer] Undefined Behavior Sanitizer support proposal for DragonFlyBSD.

Please, First remove unused + unusable code for already introduced OS. At most cutting it to ubsan.

Oct 17 2020, 1:25 PM · Restricted Project
krytarowski requested changes to D89631: [Sanitizer] Undefined Behavior Sanitizer support proposal for DragonFlyBSD.

This contains unrelated code to ubsan/dragonflybsd. While there can you remove unsupported code for other OSs you introduced? That was never operational?

Oct 17 2020, 1:19 PM · Restricted Project

Oct 15 2020

krytarowski accepted D89413: [lldb] [Process/FreeBSDRemote] Initial multithreading support.
Oct 15 2020, 4:57 AM · Restricted Project

Oct 14 2020

krytarowski accepted D89193: [lldb] [Process/FreeBSDRemote] Support YMM reg via PT_*XSTATE.
Oct 14 2020, 6:47 AM · Restricted Project

Oct 13 2020

krytarowski committed rGd4b040473291: [compiler-rt] [lldb] Mark syscall_acquire and syscall_release as USED (authored by krytarowski).
[compiler-rt] [lldb] Mark syscall_acquire and syscall_release as USED
Oct 13 2020, 6:57 PM
krytarowski added inline comments to D89193: [lldb] [Process/FreeBSDRemote] Support YMM reg via PT_*XSTATE.
Oct 13 2020, 11:08 AM · Restricted Project

Oct 12 2020

krytarowski added a comment to D89182: [lldb] [Process/FreeBSDRemote] Kill process via PT_KILL.

FWIW, PTHREAD_KILL is strongly discouraged on linux. But if the situation is different on freebsd, then fine.

Oct 12 2020, 3:33 AM · Restricted Project

Oct 10 2020

krytarowski added a reviewer for D89193: [lldb] [Process/FreeBSDRemote] Support YMM reg via PT_*XSTATE: bsdjhb.

+ @bsdjhb John, could you have a look?

Oct 10 2020, 12:27 PM · Restricted Project
krytarowski resigned from D63473: Support -fclang-abi-compat=8.0 to keep old ABI behavior.
Oct 10 2020, 3:17 AM · Restricted Project
krytarowski accepted D89181: [lldb] [Process/FreeBSD] Mark methods override in RegisterContext*.
Oct 10 2020, 2:40 AM · Restricted Project
krytarowski accepted D89182: [lldb] [Process/FreeBSDRemote] Kill process via PT_KILL.
Oct 10 2020, 2:40 AM · Restricted Project

Oct 6 2020

krytarowski accepted D88796: [lldb] Initial version of FreeBSD remote process plugin.
Oct 6 2020, 1:07 PM · Restricted Project

Oct 5 2020

krytarowski added inline comments to D88796: [lldb] Initial version of FreeBSD remote process plugin.
Oct 5 2020, 7:47 AM · Restricted Project

Oct 4 2020

krytarowski added a comment to D88795: [lldb] [test/Register] Attempt to fix x86-fp-read.test on Darwin.

Can we rename the register names in the darwin plugin?

Oct 4 2020, 2:54 PM · Restricted Project
krytarowski added inline comments to D88796: [lldb] Initial version of FreeBSD remote process plugin.
Oct 4 2020, 9:53 AM · Restricted Project
krytarowski added inline comments to D88796: [lldb] Initial version of FreeBSD remote process plugin.
Oct 4 2020, 7:09 AM · Restricted Project

Oct 2 2020

krytarowski accepted D88682: [lldb] [Process/NetBSD] Fix crash on unsupported i386 regs.
Oct 2 2020, 11:15 AM · Restricted Project