Page MenuHomePhabricator

krytarowski (Kamil Rytarowski)
User

Projects

User does not belong to any projects.

User Details

User Since
Aug 30 2015, 11:51 AM (263 w, 5 d)

Recent Activity

Thu, Sep 17

krytarowski committed rG7b2dd58eb09d: [compiler-rt] [scudo] Fix typo in function attribute (authored by krytarowski).
[compiler-rt] [scudo] Fix typo in function attribute
Thu, Sep 17, 7:59 AM
krytarowski committed rGe7de267910e9: [compiler-rt] [hwasan] Replace INLINE with inline (authored by krytarowski).
[compiler-rt] [hwasan] Replace INLINE with inline
Thu, Sep 17, 7:47 AM
krytarowski committed rG72c5feeed8d8: [compiler-rt] [netbsd] Include <sys/dkbad.h> (authored by krytarowski).
[compiler-rt] [netbsd] Include <sys/dkbad.h>
Thu, Sep 17, 7:36 AM
krytarowski committed rG9339f68f21fa: [compiler-rt] [tsan] [netbsd] Catch unsupported LONG_JMP_SP_ENV_SLOT (authored by krytarowski).
[compiler-rt] [tsan] [netbsd] Catch unsupported LONG_JMP_SP_ENV_SLOT
Thu, Sep 17, 7:29 AM
krytarowski closed D87602: [compiler-rt] [tsan] [netbsd] Catch unsupported LONG_JMP_SP_ENV_SLOT.
Thu, Sep 17, 7:28 AM · Restricted Project
krytarowski committed rG85e578f53ad1: [compiler-rt] Replace INLINE with inline (authored by krytarowski).
[compiler-rt] Replace INLINE with inline
Thu, Sep 17, 7:24 AM
krytarowski closed D87562: [compiler-rt] Replace INLINE with inline.
Thu, Sep 17, 7:24 AM · Restricted Project
krytarowski committed rG69516ddd028e: [compiler-rt] Avoid pulling libatomic to sanitizer tests (authored by krytarowski).
[compiler-rt] Avoid pulling libatomic to sanitizer tests
Thu, Sep 17, 7:04 AM
krytarowski closed D87568: [compiler-rt] Avoid pulling libatomic to sanitizer tests.
Thu, Sep 17, 7:04 AM · Restricted Project

Wed, Sep 16

krytarowski added a comment to D87562: [compiler-rt] Replace INLINE with inline.

Can you please clang format it as well

Wed, Sep 16, 2:25 PM · Restricted Project

Mon, Sep 14

krytarowski added a comment to D87562: [compiler-rt] Replace INLINE with inline.

I prefer we use just "inline"

Mon, Sep 14, 8:54 AM · Restricted Project
krytarowski updated the diff for D87562: [compiler-rt] Replace INLINE with inline.
Mon, Sep 14, 4:51 AM · Restricted Project
krytarowski requested review of D87602: [compiler-rt] [tsan] [netbsd] Catch unsupported LONG_JMP_SP_ENV_SLOT.
Mon, Sep 14, 1:44 AM · Restricted Project
krytarowski committed rG0008fb343704: [compiler-rt] [netbsd] Use internal_ptrace() instead of ptrace() (authored by krytarowski).
[compiler-rt] [netbsd] Use internal_ptrace() instead of ptrace()
Mon, Sep 14, 1:12 AM

Sat, Sep 12

krytarowski added a comment to D87568: [compiler-rt] Avoid pulling libatomic to sanitizer tests.

std::atomic_is_lock_free or an reimplementation of it (without pulling C++ runtime), testing a type and asserting that in runtime or build time that it is lockfree.

Sat, Sep 12, 4:28 PM · Restricted Project
krytarowski added a comment to D87562: [compiler-rt] Replace INLINE with inline.

I've verified that this symbol has unlikely any clashes with 3rd party software now. https://grep.app/search?q=ATTR_INLINE&case=true&words=true

Sat, Sep 12, 2:08 PM · Restricted Project
krytarowski requested review of D87568: [compiler-rt] Avoid pulling libatomic to sanitizer tests.
Sat, Sep 12, 1:47 PM · Restricted Project
krytarowski requested review of D87562: [compiler-rt] Replace INLINE with inline.
Sat, Sep 12, 10:02 AM · Restricted Project

Thu, Sep 10

krytarowski committed rG00460ae520e2: [compiler-rt] [netbsd] Regenerate syscall hooks (authored by krytarowski).
[compiler-rt] [netbsd] Regenerate syscall hooks
Thu, Sep 10, 11:17 AM
krytarowski committed rGbba736e5036f: [compiler-rt] [netbsd] Update generate_netbsd_syscalls.awk (authored by krytarowski).
[compiler-rt] [netbsd] Update generate_netbsd_syscalls.awk
Thu, Sep 10, 11:17 AM
krytarowski committed rGb85c085c846c: [compiler-rt] [netbsd] Improve code formatting (authored by krytarowski).
[compiler-rt] [netbsd] Improve code formatting
Thu, Sep 10, 10:39 AM
krytarowski committed rGcb8cb28ed90a: [compiler-rt] [netbsd] Add fallback definitions for MKISCSI=no (authored by krytarowski).
[compiler-rt] [netbsd] Add fallback definitions for MKISCSI=no
Thu, Sep 10, 10:39 AM
krytarowski committed rG52f42720b26a: [lldb] [netbsd] Avoid comparison of signed and unsigned integers (authored by krytarowski).
[lldb] [netbsd] Avoid comparison of signed and unsigned integers
Thu, Sep 10, 6:49 AM
krytarowski committed rGf51e55e09eef: [compiler-rt] [netbsd] Reintroduce __sanitizer_protoent (authored by krytarowski).
[compiler-rt] [netbsd] Reintroduce __sanitizer_protoent
Thu, Sep 10, 2:47 AM
krytarowski added inline comments to D82424: sanitizers: Add interceptors for getproto{ent,byname,bynumber}_r.
Thu, Sep 10, 2:43 AM · Restricted Project

Wed, Sep 9

krytarowski added a comment to D87120: [MemProf] Memory profiling runtime support.

These "linux" files will be ported to BSD so we might pick better names now.

Wed, Sep 9, 9:20 AM · Restricted Project

Tue, Sep 8

krytarowski added a comment to D85820: Use find_library for ncurses.

Please note that ncurses is not the only supported curses library. NetBSD uses its original BSD curses for LLVM projects.

Tue, Sep 8, 3:35 AM · Restricted Project, Restricted Project, Restricted Project

Sat, Sep 5

krytarowski added a comment to D76665: [asan] Stop instrumenting user-defined ELF sections.
In D76665#2140245, @kcc wrote:

Will adding attribute((no_sanitize("address"))) to your global solve the problem you are trying to solve?
(sorry for being too terse last time)

It does not work (last time I checked).

Does not work how?

Also GCC does the same thing of not instrumenting user defined sections.

Sat, Sep 5, 12:57 PM · Restricted Project, Restricted Project

Tue, Aug 25

krytarowski added a comment to D76665: [asan] Stop instrumenting user-defined ELF sections.

Ping?

Tue, Aug 25, 12:25 PM · Restricted Project, Restricted Project

Aug 6 2020

krytarowski added a comment to D76665: [asan] Stop instrumenting user-defined ELF sections.

Ping?

Aug 6 2020, 4:38 AM · Restricted Project, Restricted Project

Jul 20 2020

krytarowski added a comment to D76665: [asan] Stop instrumenting user-defined ELF sections.

@glider + @pcc please have a look!

Jul 20 2020, 9:16 PM · Restricted Project, Restricted Project
krytarowski added a comment to D76665: [asan] Stop instrumenting user-defined ELF sections.
In D76665#2140245, @kcc wrote:

Will adding attribute((no_sanitize("address"))) to your global solve the problem you are trying to solve?
(sorry for being too terse last time)

Jul 20 2020, 5:48 AM · Restricted Project, Restricted Project

Jun 3 2020

krytarowski added a comment to D81105: [compiler-rt] [builtin] Implement __atomic_fetch_nand_* builtins.
In D81105#2072158, @jfb wrote:

Please clarify what this is adding in the patch description.

Jun 3 2020, 7:17 PM · Restricted Project
krytarowski updated the diff for D81105: [compiler-rt] [builtin] Implement __atomic_fetch_nand_* builtins.
Jun 3 2020, 10:26 AM · Restricted Project
krytarowski updated the diff for D81105: [compiler-rt] [builtin] Implement __atomic_fetch_nand_* builtins.
Jun 3 2020, 9:53 AM · Restricted Project
krytarowski created D81105: [compiler-rt] [builtin] Implement __atomic_fetch_nand_* builtins.
Jun 3 2020, 8:46 AM · Restricted Project

Jun 2 2020

krytarowski added inline comments to D76665: [asan] Stop instrumenting user-defined ELF sections.
Jun 2 2020, 5:31 AM · Restricted Project, Restricted Project

May 28 2020

krytarowski added a reviewer for D80469: Add OpenBSD support in lib/tsan/go/buildgo.sh: dvyukov.

It looks fine to me, but I will defer it to @dvyukov

May 28 2020, 12:07 PM · Restricted Project

May 14 2020

krytarowski abandoned D79846: [compiler-rt] [builtin] Add public functions prototypes.

OK, we will need to live with -Wno*.

May 14 2020, 6:25 AM · Restricted Project

May 13 2020

krytarowski added a comment to D79846: [compiler-rt] [builtin] Add public functions prototypes.

Example error:

May 13 2020, 5:54 AM · Restricted Project
krytarowski added a comment to D79846: [compiler-rt] [builtin] Add public functions prototypes.

It should already be buildable out of the box. The missing prototypes warning is opt-in. I am not particularly in favour of changes motivated solely by an external build system that explicitly opts in to warnings that don't make sense for a particular compilation unit.

May 13 2020, 5:54 AM · Restricted Project
krytarowski committed rGf61f6ffe1126: [compiler-rt] [builtin] Switch the return type of __atomic_compare_exchange_##n… (authored by krytarowski).
[compiler-rt] [builtin] Switch the return type of __atomic_compare_exchange_##n…
May 13 2020, 5:22 AM
krytarowski closed D79845: [compiler-rt] [builtin] Switch the return type of __atomic_compare_exchange_##n to bool.
May 13 2020, 5:21 AM · Restricted Project
krytarowski added a comment to D79846: [compiler-rt] [builtin] Add public functions prototypes.

I'm guessing that this is explicitly enabling the missing prototypes warning. I'm not a huge fan of that for compilation units that don't have public headers, it makes the code more complex and doesn't catch any bugs. It's valuable only when you have a public header and want to ensure that it's in sync with the implementation.

May 13 2020, 5:21 AM · Restricted Project
krytarowski added a comment to D79845: [compiler-rt] [builtin] Switch the return type of __atomic_compare_exchange_##n to bool.

https://gcc.gnu.org/onlinedocs/gcc/_005f_005fatomic-Builtins.html

May 13 2020, 5:21 AM · Restricted Project
krytarowski added a comment to D79713: [compiler-rt] [builtins] Port atomic.c to GCC.

I've separated two independent changes out of this revision into a separate review.
D79845 + D79846.

May 13 2020, 3:43 AM · Restricted Project
krytarowski created D79846: [compiler-rt] [builtin] Add public functions prototypes.
May 13 2020, 3:43 AM · Restricted Project
krytarowski created D79845: [compiler-rt] [builtin] Switch the return type of __atomic_compare_exchange_##n to bool.
May 13 2020, 3:43 AM · Restricted Project

May 12 2020

krytarowski added a comment to D79713: [compiler-rt] [builtins] Port atomic.c to GCC.

will be "stuck" making sure that libatomic builds on GCC forever.

Generally... we [used to] build everything in compiler-rt with GCC except this single file.

Interesting! Where is the corresponding build system change in this patch?

May 12 2020, 3:04 PM · Restricted Project
krytarowski added a comment to D79713: [compiler-rt] [builtins] Port atomic.c to GCC.

will be "stuck" making sure that libatomic builds on GCC forever.

May 12 2020, 1:27 PM · Restricted Project
krytarowski added a comment to D79713: [compiler-rt] [builtins] Port atomic.c to GCC.

I rewrote this code again to support GCC. This time without removal of _Atomic().

May 12 2020, 11:16 AM · Restricted Project
krytarowski updated the diff for D79713: [compiler-rt] [builtins] Port atomic.c to GCC.
May 12 2020, 11:16 AM · Restricted Project
krytarowski added inline comments to D79713: [compiler-rt] [builtins] Port atomic.c to GCC.
May 12 2020, 8:01 AM · Restricted Project
krytarowski added a comment to D79713: [compiler-rt] [builtins] Port atomic.c to GCC.

it's quite easy to define a C++ template that switches from lock-free to having an inline lock

May 12 2020, 4:15 AM · Restricted Project
krytarowski added a comment to D79713: [compiler-rt] [builtins] Port atomic.c to GCC.

To give some background (please correct me if I'm wrong): This is initially motivated by having snmalloc working on NetBSD.

May 12 2020, 4:15 AM · Restricted Project
krytarowski updated the diff for D79713: [compiler-rt] [builtins] Port atomic.c to GCC.
  • drop ABI change in __atomic_compare_exchange_##n
May 12 2020, 3:43 AM · Restricted Project

May 11 2020

krytarowski added inline comments to D79713: [compiler-rt] [builtins] Port atomic.c to GCC.
May 11 2020, 12:22 PM · Restricted Project
krytarowski added inline comments to D79713: [compiler-rt] [builtins] Port atomic.c to GCC.
May 11 2020, 11:17 AM · Restricted Project
krytarowski added a comment to D79713: [compiler-rt] [builtins] Port atomic.c to GCC.
In D79713#2029514, @jfb wrote:

Without looking at the details, this generally seems fine... but why is this desirable? The commit message should have that information. If there's not really a reason then I'd rather leave it alone and not change something that's fine.

May 11 2020, 9:07 AM · Restricted Project
krytarowski updated the diff for D79713: [compiler-rt] [builtins] Port atomic.c to GCC.
May 11 2020, 8:34 AM · Restricted Project
krytarowski added a comment to D79713: [compiler-rt] [builtins] Port atomic.c to GCC.

I don't think that this should be including <stdatomic.h>. These routines are used to implement interfaces in <stdatomic.h> and it would be completely valid for a conforming implementation to use _Generic macros to directly call these functions from things in <stdatomic.h> that we then depend call, giving a circular dependency.

I don't particularly object to moving this to using the GCC builtins, since clang supports both the GCC ones and the __c11 ones, but the only two valid implementations of the routines in this file are to use compiler builtins or inline assembly.

May 11 2020, 8:34 AM · Restricted Project
krytarowski created D79713: [compiler-rt] [builtins] Port atomic.c to GCC.
May 11 2020, 5:52 AM · Restricted Project
krytarowski added inline comments to D78896: [Support] Add file lock/unlock functions.
May 11 2020, 5:19 AM · Restricted Project

Apr 4 2020

krytarowski committed rG695ca346eb0c: [compiler-rt] Fix build on NetBSD 9.99.52+ (authored by krytarowski).
[compiler-rt] Fix build on NetBSD 9.99.52+
Apr 4 2020, 4:30 PM

Mar 23 2020

krytarowski created D76665: [asan] Stop instrumenting user-defined ELF sections.
Mar 23 2020, 8:41 PM · Restricted Project, Restricted Project

Mar 17 2020

krytarowski added inline comments to D73245: Avoid using std::max_align_t in pre-C++11 mode.
Mar 17 2020, 5:06 AM · Restricted Project

Mar 15 2020

krytarowski committed rG7f6b25ad1bb3: [compiler-rt] [netbsd] Add support for the MKIPFILTER=no distribution (authored by krytarowski).
[compiler-rt] [netbsd] Add support for the MKIPFILTER=no distribution
Mar 15 2020, 5:10 PM

Feb 20 2020

krytarowski added a comment to D73067: [lldb/CMake] Auto-generate the Initialize and Terminate calls for plugin.

Autogeneration of the code puts extra burden on us for tracking what is defined where and for repackaging LLDB with custom build rules (we need plain Makefile in the distribution). I presume the same problem is for gn users, for FreeBSD etc.

Feb 20 2020, 10:38 AM · Restricted Project

Feb 11 2020

krytarowski committed rGb664321ff14f: [compiler-rt] Restrict sanitizer_linux.cpp dlinfo(3) to FreeBSD (authored by krytarowski).
[compiler-rt] Restrict sanitizer_linux.cpp dlinfo(3) to FreeBSD
Feb 11 2020, 3:16 AM

Feb 10 2020

krytarowski accepted D73990: [Sanitizers] Get link map on FreeBSD via documented API.
Feb 10 2020, 3:14 AM · Restricted Project, Restricted Project

Feb 9 2020

krytarowski committed rG273f638384d6: [LLDB] [doc] Document NetBSD status and sort OSs alphabetically (authored by krytarowski).
[LLDB] [doc] Document NetBSD status and sort OSs alphabetically
Feb 9 2020, 9:05 AM
krytarowski committed rG5a285f207e10: [LLDB] [doc] Remove note about libpanel(3) and NetBSD (authored by krytarowski).
[LLDB] [doc] Remove note about libpanel(3) and NetBSD
Feb 9 2020, 6:03 AM
krytarowski committed rG0ea4d18a288b: [LLDB] [doc] Update the current status of pkgsrc (NetBSD) building (authored by krytarowski).
[LLDB] [doc] Update the current status of pkgsrc (NetBSD) building
Feb 9 2020, 6:03 AM

Feb 7 2020

krytarowski added inline comments to D73990: [Sanitizers] Get link map on FreeBSD via documented API.
Feb 7 2020, 12:28 AM · Restricted Project, Restricted Project

Feb 6 2020

krytarowski added inline comments to D73990: [Sanitizers] Get link map on FreeBSD via documented API.
Feb 6 2020, 7:57 AM · Restricted Project, Restricted Project
krytarowski added inline comments to D73990: [Sanitizers] Get link map on FreeBSD via documented API.
Feb 6 2020, 6:17 AM · Restricted Project, Restricted Project
krytarowski added a comment to D73990: [Sanitizers] Get link map on FreeBSD via documented API.

systems were not supported by hard coding 560

Feb 6 2020, 3:10 AM · Restricted Project, Restricted Project

Feb 5 2020

krytarowski accepted D73802: [lldb] Introduce i386 support in NetBSD Process plugin.
Feb 5 2020, 12:50 AM · Restricted Project

Feb 4 2020

krytarowski resigned from D73976: [compiler-rt] fix OpenBSD and Solaris build with sigaltstack interception.

NetBSD fix landed here:

Feb 4 2020, 2:41 PM · Restricted Project, Restricted Project
krytarowski committed rGb79b7674eb47: [compiler-rt] [netbsd] Fix build after "implement sigaltstack interception" (authored by krytarowski).
[compiler-rt] [netbsd] Fix build after "implement sigaltstack interception"
Feb 4 2020, 2:33 PM
krytarowski added a comment to D73990: [Sanitizers] Get link map on FreeBSD via documented API.

I will mirror it in NetBSD whatever will be decided here.

Feb 4 2020, 2:05 PM · Restricted Project, Restricted Project
krytarowski added a comment to D73816: [compiler-rt] implement sigaltstack interception.

For fixing NetBSD, remember to go for #define sigaltstack __sigaltstack14 as the symbol is renamed.

Feb 4 2020, 6:05 AM · Restricted Project, Restricted Project

Feb 1 2020

krytarowski added inline comments to D73802: [lldb] Introduce i386 support in NetBSD Process plugin.
Feb 1 2020, 4:01 PM · Restricted Project
krytarowski added inline comments to D73802: [lldb] Introduce i386 support in NetBSD Process plugin.
Feb 1 2020, 8:47 AM · Restricted Project
krytarowski added inline comments to D73802: [lldb] Introduce i386 support in NetBSD Process plugin.
Feb 1 2020, 12:23 AM · Restricted Project

Jan 31 2020

krytarowski added inline comments to D73802: [lldb] Introduce i386 support in NetBSD Process plugin.
Jan 31 2020, 1:50 PM · Restricted Project
krytarowski committed rG3a200f3f2e52: [compiler-rt] Fix build on NetBSD 9.99.44 (authored by krytarowski).
[compiler-rt] Fix build on NetBSD 9.99.44
Jan 31 2020, 6:02 AM

Jan 23 2020

krytarowski added a comment to D63785: Add support for MUSL libc.

(!defined(__MUSL__) || !__MUSL__) is pretty ugly. There is obviously a need for SANITIZER_MUSL, but then it's up to Linux maintainers whether to accept it.

Jan 23 2020, 10:48 AM · Restricted Project, Restricted Project

Jan 13 2020

krytarowski accepted D72578: [compiler-rt] [builtins] Fix clear_cache_test to work with MPROTECT.
Jan 13 2020, 12:25 AM · Restricted Project, Restricted Project

Jan 2 2020

krytarowski added a comment to D70048: [LLD] Add NetBSD support as a new flavor of LLD (nb.lld).

LLVM Release Schedule: 10.0.0: Jan 15, 2020: branch, then rc1

Jan 2 2020, 8:16 PM · Restricted Project, Restricted Project, lld
krytarowski committed rG0da15ff31848: [compiler-rt] [netbsd] Switch to syscall for ThreadSelfTlsTcb() (authored by krytarowski).
[compiler-rt] [netbsd] Switch to syscall for ThreadSelfTlsTcb()
Jan 2 2020, 5:48 PM

Jan 1 2020

krytarowski added a comment to D70048: [LLD] Add NetBSD support as a new flavor of LLD (nb.lld).

Ping?

Jan 1 2020, 6:34 AM · Restricted Project, Restricted Project, lld

Dec 27 2019

krytarowski committed rG84afd9c5368c: [compiler-rt] [netbsd] Add support for versioned statvfs interceptors (authored by krytarowski).
[compiler-rt] [netbsd] Add support for versioned statvfs interceptors
Dec 27 2019, 9:56 AM

Dec 26 2019

krytarowski committed rG78f714f824fa: [compiler-rt] [netbsd] Add support for versioned statvfs interceptors (authored by krytarowski).
[compiler-rt] [netbsd] Add support for versioned statvfs interceptors
Dec 26 2019, 4:17 PM
krytarowski closed D71700: [compiler-rt] [netbsd] Add support for versioned statvfs interceptors.
Dec 26 2019, 4:17 PM · Restricted Project, Restricted Project
krytarowski committed rGdaa62c8ed46f: [compiler-rt] [netbsd] Add support for versioned statvfs interceptors (authored by krytarowski).
[compiler-rt] [netbsd] Add support for versioned statvfs interceptors
Dec 26 2019, 4:13 PM
krytarowski updated the diff for D71700: [compiler-rt] [netbsd] Add support for versioned statvfs interceptors.
  • rebase to HEAD
Dec 26 2019, 4:13 PM · Restricted Project, Restricted Project

Dec 25 2019

krytarowski committed rGaff6c9db9a96: [compiler-rt] [netbsd] Correct the fallback definition of PT_LWPNEXT (authored by krytarowski).
[compiler-rt] [netbsd] Correct the fallback definition of PT_LWPNEXT
Dec 25 2019, 9:24 AM

Dec 24 2019

krytarowski committed rG52b5fe5f45b1: [compiler-rt] [netbsd] Define _RTLD_SOURCE to fix build (authored by krytarowski).
[compiler-rt] [netbsd] Define _RTLD_SOURCE to fix build
Dec 24 2019, 7:14 PM
krytarowski committed rGab8a7a29bf15: [lldb] Adapt for NetBSD-9.99.30 ptrace(2) API changes (authored by krytarowski).
[lldb] Adapt for NetBSD-9.99.30 ptrace(2) API changes
Dec 24 2019, 11:42 AM